Batch DataPlane 2021-06-01.14 update #14830

paterasMSFT · 2021-06-15T19:46:41Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-06-15T19:46:43Z

Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-06-15T19:46:44Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-06-15T19:46:44Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- batch/data-plane/readme.md tag:package-2021-06.14.0
Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- batch/data-plane/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️❌Cross-Version Breaking Changes: 501 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-06-01.14.0/BatchService.json compared with base:stable/2020-09-01.12.0/BatchService.json

The following breaking changes are detected by comparison with the latest stable version:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L160:13 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L163:13
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L14759:11 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L14117:11
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L166:13 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L169:13
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L16701:9 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L15981:9
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L16707:11 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L15987:11
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L269:13 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L272:13
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L275:13 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L278:13
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L423:13 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L426:13
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L10964:11 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L10684:11
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L429:13 Old: Microsoft.Batch/stable/2020-09-01.12.0/BatchService.json#L432:13

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-09.12.0",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-09.12.0",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2021-06.14.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2021-06.14.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-09.12.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-03.11.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2020-03.11.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2019-08.10.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2019-08.10.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2019-06.9.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2019-06.9.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2018-12.8.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2018-12.8.0",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"batch/data-plane/readme.md",
"tag":"package-2018-08.7.0",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-06-15T19:46:45Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - batch/2021-06-01.14.0/batch - v55.3.0
️✔️azure-sdk-for-go - batch/2020-09-01.12.0/batch - v55.3.0
️✔️azure-sdk-for-go - batch/2020-03-01.11.0/batch - v55.3.0
️✔️azure-sdk-for-go - batch/2019-08-01.10.0/batch - v55.3.0
️✔️azure-sdk-for-go - batch/2019-06-01.9.0/batch - v55.3.0
️✔️azure-sdk-for-go - batch/2018-12-01.8.0/batch - v55.3.0
️✔️azure-sdk-for-go - batch/2018-08-01.7.0/batch - v55.3.0
️✔️azure-sdk-for-go - batch/2018-03-01.6.1/batch - v55.3.0
️✔️azure-sdk-for-go - batch/2017-05-01.5.0/batch - v55.3.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-batch - 15.0.0
️✔️azure-sdk-for-go - batch/mgmt/2021-01-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2020-09-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2020-05-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2020-03-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2019-08-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2019-04-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2018-12-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2017-09-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2017-05-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2017-01-01/batch - v55.3.0
️✔️azure-sdk-for-go - batch/mgmt/2015-12-01/batch - v55.3.0

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 18b54ea. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️batch/2021-06-01.14.0/batch [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️batch/2020-09-01.12.0/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/2020-03-01.11.0/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/2019-08-01.10.0/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/2019-06-01.9.0/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/2018-12-01.8.0/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/2018-08-01.7.0/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/2018-03-01.6.1/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/2017-05-01.5.0/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2021-01-01/batch [View full logs]
```
info	[Changelog] This is a new package
```
️✔️batch/mgmt/2020-09-01/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2020-05-01/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2020-03-01/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2019-08-01/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2019-04-01/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2018-12-01/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2017-09-01/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2017-05-01/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2017-01-01/batch [View full logs]
```
info	[Changelog] No exported changes
```
️✔️batch/mgmt/2015-12-01/batch [View full logs]
```
info	[Changelog] No exported changes
```

️❌ azure-sdk-for-js failed [Detail]

❌Failed [Logs]Release - Generate from 18b54ea. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/batch/data-plane/readme.md
cmdout	[Autorest] WARNING: HEAD 'getPropertiesFromTask' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getPropertiesFromComputeNode' method missing 404 status code section -- this might be unintentional.
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/batch/resource-manager/readme.md

️✔️@azure/arm-batch [View full logs] [Release SDK Changes]

azure-arm-batch-5.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/batchManagementClient.js → ./dist/arm-batch.js...
cmderr	[npmPack] created ./dist/arm-batch.js in 658ms

❌@azure/batch [View full logs] [Release SDK Changes]

error	Script return with result [failed] code [2] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js/sdk/batch/batch]: npm pack --silent

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 18b54ea. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
warn		specification/batch/data-plane/readme.md skipped due to azure-sdk-for-net not found in swagger-to-sdk
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/batch/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Batch [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Batch.13.0.0.nupkg
- Microsoft.Azure.Management.Batch.13.0.0.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 18b54ea. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/batch/data-plane/readme.md skipped due to azure-sdk-for-python-track2 not found in swagger-to-sdk
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-batch [View full logs] [Release SDK Changes]
- azure_mgmt_batch-14.0.0b1-py2.py3-none-any.whl
- azure-mgmt-batch-14.0.0b1.zip
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 18b54ea. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
warn		specification/batch/data-plane/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️✔️azure-resourcemanager-batch [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-07-01 00:27:09 DEBUG Got artifact_id: azure-resourcemanager-batch
cmderr	[Inst] 2021-07-01 00:27:09 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-07-01 00:27:09 DEBUG Got artifact: azure-resourcemanager-batch-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-07-01 00:27:09 DEBUG Got artifact: azure-resourcemanager-batch-1.0.0-beta.2-javadoc.jar
cmderr	[Inst] 2021-07-01 00:27:09 DEBUG Got artifact: azure-resourcemanager-batch-1.0.0-beta.2.jar
cmderr	[Inst] 2021-07-01 00:27:09 DEBUG Match jar package: azure-resourcemanager-batch-1.0.0-beta.2.jar
cmderr	[Inst] 2021-07-01 00:27:09 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14830/azure-sdk-for-java/azure-resourcemanager-batch/azure-resourcemanager-batch-1.0.0-beta.2.jar\" -o azure-resourcemanager-batch-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-batch -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-batch-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 18b54ea. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
warn		specification/batch/data-plane/readme.md skipped due to azure-resource-manager-schemas not found in swagger-to-sdk
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

️✔️batch [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-06-15T19:47:09Z

Hi, @paterasMSFT your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

chiragg4u · 2021-06-15T20:03:54Z

Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.

Please create new branch with this recommendation for the review to continue.

chiragg4u

Please go through the contribution checklist and ARM API Review Checklist added as part of the review and mark them completed. It will help you fix most of the issues and improve the quality of swagger and help close the PR faster. This is a requirement before review can be continued.

paterasMSFT · 2021-06-15T22:50:29Z

Please go through the contribution checklist and ARM API Review Checklist added as part of the review and mark them completed.

Thank you. I created the PR as a draft as I hadn't done that yet. I will complete the checklist before I mark it ready for review.

Please create new branch with this recommendation for the review to continue.

I just rebased the branch on top of a commit with the required copy. Is it still necessary for me to create a new branch?

.vscode/launch.json

specification/batch/data-plane/Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json

paterasMSFT · 2021-06-29T13:56:32Z

@tjprescott could we get a review here? There's some urgency to it. Thank you!

paterasMSFT · 2021-06-29T17:46:02Z

@chiragg4u would you mind approving your requested changes, so I can get a final approval from @tjprescott, who is assigned to the PR?

tjprescott · 2021-06-29T17:55:47Z

@chiragg4u @dpwatrous you both requested changes. Please verify those have been made and approve so we can merge this PR.

dpwatrous · 2021-06-29T19:16:12Z

@chiragg4u looks good to me. Can you approve and merge?

mikekistler

These changes look good to me. 👍

I was originally concerned about the large number of "Cross Version Breaking Changes" reported by the tooling (> 500). But upon investigation it appears that all these are caused by the addition of type: object to a schema that was already an object by virtue of having properties, but the tool still reports this as a breaking change.

revoking review

paterasMSFT · 2021-06-30T18:13:41Z

@tjprescott looks like we're ready to merge.

paterasMSFT · 2021-07-01T16:31:28Z

These changes look good to me. 👍

I was originally concerned about the large number of "Cross Version Breaking Changes" reported by the tooling (> 500). But upon investigation it appears that all these are caused by the addition of type: object to a schema that was already an object by virtue of having properties, but the tool still reports this as a breaking change.

@mikekistler or @JeffreyRichter, mind signing off on the validator "breaking changes" for the ControlPlane PR for this release as well, as they're essentially the same thing as on this one? Thanks!

* Copy of 2020-09-01 for ease of review * Azure Batch updated to 2021-06-01.14 Suppressions Fixed property name. Fixed type Fixed casing Fixed casing Spelling fix Fixed enums Fixed enum Fixed EOF and casing from PR feedback Markdown fixes Added Managed Identity and Authentication Mode APIs. Fixed example Spot cleanup Casing fix Fixed spacing Added maxParallelTasks. Formatting. Removed newline Reverted markdown change to satisfy Avocado http://azure.github.io/autorest/user/literate-file-formats/configuration.html#the-file-format

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 15, 2021

openapi-sdkautomation bot mentioned this pull request Jun 15, 2021

[AutoPR @azure/batch] Azure Batch updated to 2021-06-01.14 AzureSDKAutomation/azure-sdk-for-js#5051

Closed

Copy of 2020-09-01 for ease of review

27d93f9

chiragg4u previously requested changes Jun 15, 2021

View reviewed changes

chiragg4u added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 15, 2021

paterasMSFT force-pushed the paterasMSFT/batchdataplane20210601 branch from 83f95d5 to d4de940 Compare June 15, 2021 22:44

paterasMSFT force-pushed the paterasMSFT/batchdataplane20210601 branch 5 times, most recently from 0588942 to 9ae22aa Compare June 17, 2021 03:55

dpwatrous requested changes Jun 17, 2021

View reviewed changes

paterasMSFT force-pushed the paterasMSFT/batchdataplane20210601 branch from 7280d8c to 1af059b Compare June 18, 2021 19:55

pilor removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 28, 2021

paterasMSFT requested review from dpwatrous and chiragg4u June 29, 2021 14:48

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 29, 2021

tjprescott approved these changes Jun 29, 2021

View reviewed changes

dpwatrous approved these changes Jun 29, 2021

View reviewed changes

mikekistler approved these changes Jun 29, 2021

View reviewed changes

markweitzel added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Jun 30, 2021

tjprescott merged commit 18b54ea into master Jul 1, 2021

tjprescott deleted the paterasMSFT/batchdataplane20210601 branch July 1, 2021 00:18

mikekistler mentioned this pull request Jul 11, 2021

Breaking change false positive when adding "type: object" to schema with "properties" Azure/openapi-diff#208

Closed

This was referenced Jul 27, 2021

Fixed breaking change due to order #15371

Merged

Batch Data Plane 2021-06-01 update Azure/azure-sdk-for-net#22909

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Batch DataPlane 2021-06-01.14 update #14830

Batch DataPlane 2021-06-01.14 update #14830

paterasMSFT commented Jun 15, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jun 15, 2021

openapi-workflow-bot bot commented Jun 15, 2021

openapi-pipeline-app bot commented Jun 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 15, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 15, 2021

chiragg4u commented Jun 15, 2021

chiragg4u left a comment

paterasMSFT commented Jun 15, 2021

paterasMSFT commented Jun 29, 2021

paterasMSFT commented Jun 29, 2021

tjprescott commented Jun 29, 2021

dpwatrous commented Jun 29, 2021

mikekistler left a comment

paterasMSFT commented Jun 30, 2021

paterasMSFT commented Jul 1, 2021

Batch DataPlane 2021-06-01.14 update #14830

Batch DataPlane 2021-06-01.14 update #14830

Conversation

paterasMSFT commented Jun 15, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 15, 2021

openapi-workflow-bot bot commented Jun 15, 2021

openapi-pipeline-app bot commented Jun 15, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 15, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 15, 2021

chiragg4u commented Jun 15, 2021

chiragg4u left a comment

Choose a reason for hiding this comment

paterasMSFT commented Jun 15, 2021

paterasMSFT commented Jun 29, 2021

paterasMSFT commented Jun 29, 2021

tjprescott commented Jun 29, 2021

dpwatrous commented Jun 29, 2021

mikekistler left a comment

Choose a reason for hiding this comment

paterasMSFT commented Jun 30, 2021

paterasMSFT commented Jul 1, 2021

paterasMSFT commented Jun 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 15, 2021 •

edited

Loading