Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add all apis to 2020 readme #14870

Merged
merged 24 commits into from
Jun 30, 2021
Merged

Conversation

tofriedl
Copy link
Contributor

@tofriedl tofriedl commented Jun 17, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @tofriedl Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 17, 2021

    Swagger Validation Report

    ️❌BreakingChange: 9 Errors, 0 Warnings failed [Detail]
    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L221:7
    Old: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L222:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L221:7
    Old: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L222:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L221:7
    Old: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L222:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L221:7
    Old: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L222:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'target' renamed or removed?
    New: Microsoft.Insights/stable/2020-02-02/components_API.json#L375:11
    Old: common-types/resource-management/v2/types.json#L288:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'details' renamed or removed?
    New: Microsoft.Insights/stable/2020-02-02/components_API.json#L375:11
    Old: common-types/resource-management/v2/types.json#L288:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'additionalInfo' renamed or removed?
    New: Microsoft.Insights/stable/2020-02-02/components_API.json#L375:11
    Old: common-types/resource-management/v2/types.json#L288:7
    1041 - AddedPropertyInResponse The new version has a new property 'error' in response that was not found in the old version.
    New: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L221:7
    Old: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L222:7
    1041 - AddedPropertyInResponse The new version has a new property 'error' in response that was not found in the old version.
    New: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L221:7
    Old: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L222:7
    ️⚠️LintDiff: 3 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R4021 - DescriptionAndTitleMissing 'ErrorResponseLinkedStorage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L219
    ⚠️ R4021 - DescriptionAndTitleMissing 'ErrorResponseLinkedStorage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L219
    ⚠️ R4021 - DescriptionAndTitleMissing 'ErrorResponseComponents' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Insights/stable/2020-02-02/components_API.json#L369


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks'
    Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L37
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}'
    Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L85
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/linkedStorageAccounts/{storageType}'
    Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/providers/microsoft.insights/operations'
    Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/generatelivetoken'
    Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L77
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks'
    Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L37
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}'
    Location: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L85
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/linkedStorageAccounts/{storageType}'
    Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L50
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L50
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 3 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ Modeler/MissingType "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'ComponentPurgeBodyFilters-value' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2018-05-01-preview/components_API.json#/components/schemas/ComponentPurgeBodyFilters-value"
    ⚠️ Modeler/MissingType "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-2020-04",
    "details":"The schema 'ComponentPurgeBodyFilters-value' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2018-05-01-preview/components_API.json#/components/schemas/ComponentPurgeBodyFilters-value"
    ⚠️ Modeler/MissingType "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-2020-02-02",
    "details":"The schema 'ComponentPurgeBodyFilters-value' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json#/components/schemas/ComponentPurgeBodyFilters-value"
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-preview-2020-06-only",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-preview-2020-06-only",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"


    The following errors/warnings exist before current PR submission:

    Rule Message
    "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"Duplicate Operation 'List' detected."
    AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"Error: Plugin checker reported failure."
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-preview-2020-06-only",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-2020-04",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-2020-04",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-2020-03-01-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-2020-03-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"applicationinsights/resource-manager/readme.md",
    "tag":"package-2020-02-02",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 17, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - appinsights/mgmt/2015-05-01/insights - v55.4.0
    azure-sdk-for-python-track2 - track2_azure-mgmt-applicationinsights - 1.0.0
    +	Model ErrorResponse has a new signature
    ️✔️azure-sdk-for-go - preview/appinsights/mgmt/2020-02-02-preview/insights - v55.4.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4483c52. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.ApplicationInsights [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4483c52. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-applicationinsights [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ApplicationInsightsComponent has a new parameter disable_local_auth
      info	[Changelog]   - Model ApplicationInsightsComponent has a new parameter force_customer_storage_for_profiler
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model ErrorResponse has a new signature
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4483c52. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-30 05:45:47 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-applicationinsights;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-06-30 05:45:47 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-06-30 05:45:47 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/applicationinsights/azure-resourcemanager-applicationinsights --java.namespace=com.azure.resourcemanager.applicationinsights   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-30 05:46:24 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-applicationinsights
      cmderr	[generate.py] 2021-06-30 05:46:24 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-30 05:46:24 INFO [POM][Skip] pom already has module azure-resourcemanager-applicationinsights
      cmderr	[generate.py] 2021-06-30 05:46:24 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-30 05:46:24 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-30 05:46:24 INFO [POM][Skip] pom already has module sdk/applicationinsights
      cmderr	[generate.py] 2021-06-30 05:46:24 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-applicationinsights [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-30 05:48:04 DEBUG Got artifact_id: azure-resourcemanager-applicationinsights
      cmderr	[Inst] 2021-06-30 05:48:04 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-30 05:48:04 DEBUG Got artifact: azure-resourcemanager-applicationinsights-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2021-06-30 05:48:04 DEBUG Got artifact: azure-resourcemanager-applicationinsights-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-06-30 05:48:04 DEBUG Match jar package: azure-resourcemanager-applicationinsights-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-06-30 05:48:04 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14870/azure-sdk-for-java/azure-resourcemanager-applicationinsights/azure-resourcemanager-applicationinsights-1.0.0-beta.2.jar\" -o azure-resourcemanager-applicationinsights-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-applicationinsights -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-applicationinsights-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4483c52. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️appinsights/mgmt/2015-05-01/insights [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/appinsights/mgmt/2020-02-02-preview/insights [View full logs
      info	[Changelog] This is a new package
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4483c52. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
    • ️✔️@azure/arm-appinsights [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
      cmderr	[npmPack] created ./dist/arm-appinsights.js in 179ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4483c52. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️applicationinsights [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi, @tofriedl your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @chiragg4u
    Copy link
    Contributor

    Please go through the contribution checklist and ARM API Review Checklist added as part of the review and mark them completed. It will help you fix most of the issues and improve the quality of swagger and help close the PR faster. This is a requirement before review can be continued.

    @akning-ms akning-ms assigned ArcturusZhang and unassigned akning-ms Jun 18, 2021
    @akning-ms akning-ms removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 18, 2021
    @akning-ms
    Copy link
    Contributor

    Hi @tofriedl , As this is mainly for GO SDK, so reassign to @ArcturusZhang to review. and it is not need ARM review. for track 2 validation error, pls refer to https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#sdk-track2-validation to fix

    Copy link
    Member

    @ArcturusZhang ArcturusZhang left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 29, 2021
    @ArcturusZhang
    Copy link
    Member

    The breaking change is due to the refinement of error models

    @ArcturusZhang ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 30, 2021
    @ArcturusZhang ArcturusZhang merged commit 4483c52 into Azure:master Jun 30, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * add all apis to 2020 readme
    
    * fix
    
    * add 2020 to Go Readme
    
    * change error definitions in 2020-02-02
    
    * changes to fix issues
    
    * fix more errors
    
    * change error response to custom to fix errors
    
    * add code property to error
    
    * fix error response
    
    * change errorResponse name
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fixes
    
    * fixes
    
    * fix
    
    * fixes
    
    * fix remaining issues in readme.go.md
    
    Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants