Added default values for parameters for Import Export #14907

t-ammar · 2021-06-21T09:57:25Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-06-21T09:57:27Z

Hi, @t-ammar Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-06-21T09:57:28Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-06-21T09:57:28Z

Swagger Validation Report

️❌BreakingChange: 18 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.11)
- current:preview/2021-01-01/storageimportexport.json compared with base:preview/2021-01-01/storageimportexport.json
- current:stable/2016-11-01/storageimportexport.json compared with base:stable/2016-11-01/storageimportexport.json
- current:stable/2020-08-01/storageimportexport.json compared with base:stable/2020-08-01/storageimportexport.json

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L655:9 Old: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L655:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L660:9 Old: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L659:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L665:9 Old: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L663:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L1159:9 Old: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L1154:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L765:13 Old: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L762:13
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L790:13 Old: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L786:13
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L685:9 Old: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L685:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L690:9 Old: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L689:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L695:9 Old: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L693:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L1189:9 Old: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L1184:9

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L446
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L470
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L470
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ImportExport/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L511
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ImportExport/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L538
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ImportExport/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ImportExport/stable/2016-11-01/storageimportexport.json#L538
`❌` R4034 - AzureResourceTagsSchema	The property tags in the resource 'JobResponse' does not conform to the common type definition. Location: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L823
`❌` R4034 - AzureResourceTagsSchema	The property tags in the resource 'JobResponse' does not conform to the common type definition. Location: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L823
`❌` R4034 - AzureResourceTagsSchema	The property tags in the resource 'JobResponse' does not conform to the common type definition. Location: Microsoft.ImportExport/preview/2021-01-01/storageimportexport.json#L823
`❌` R4034 - AzureResourceTagsSchema	The property tags in the resource 'JobResponse' does not conform to the common type definition. Location: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L853

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"storageimportexport/resource-manager/readme.md",
"tag":"package-preview-2021-01",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"storageimportexport/resource-manager/readme.md",
"tag":"package-preview-2021-01",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"storageimportexport/resource-manager/readme.md",
"tag":"package-preview-2021-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"storageimportexport/resource-manager/readme.md",
"tag":"package-2016-11",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"storageimportexport/resource-manager/readme.md",
"tag":"package-2016-11",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"storageimportexport/resource-manager/readme.md",
"tag":"package-2020-08",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"storageimportexport/resource-manager/readme.md",
"tag":"package-2020-08",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2021-06-21T09:57:28Z

Thank you for your contribution t-ammar! We will review the pull request and get back to you soon.

openapi-pipeline-app · 2021-06-21T09:57:29Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-storageimportexport - 1.0.0b1
❌azure-sdk-for-go - storageimportexport/mgmt/2020-08-01/storageimportexport - Approved - v55.3.0

+	Const `CustomerManaged` type has been changed from `KekType` to `EncryptionKekType`
+	Const `MicrosoftManaged` type has been changed from `KekType` to `EncryptionKekType`
+	Const `None` type has been changed from `Type` to `IdentityType`
+	Const `SystemAssigned` type has been changed from `Type` to `IdentityType`
+	Const `UserAssigned` type has been changed from `Type` to `IdentityType`
+	Function `PossibleKekTypeValues` has been removed
+	Function `PossibleTypeValues` has been removed
+	Type of `EncryptionKeyDetails.KekType` has been changed from `KekType` to `EncryptionKekType`
+	Type of `IdentityDetails.Type` has been changed from `Type` to `IdentityType`

❌azure-sdk-for-go - storageimportexport/mgmt/2016-11-01/storageimportexport - Approved - v55.3.0

+	Field `BlobListblobPath` of struct `Export` has been removed
+	Type of `DriveStatus.PercentComplete` has been changed from `*int32` to `*int64`
+	Type of `JobDetails.DeliveryPackage` has been changed from `*PackageInfomation` to `*DeliveryPackageInformation`
+	Type of `UpdateJobParametersProperties.DeliveryPackage` has been changed from `*PackageInfomation` to `*DeliveryPackageInformation`

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 6e9525e. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
Resource not accessible by integration
HttpError: Resource not accessible by integration
    at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.6.0/node_modules/@octokit/request/dist-node/index.js:86:21
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:346:21)
    at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
    at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
    at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
    at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
    at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18

️✔️Az.StorageImportExport [View full logs]

Az.StorageImportExport.0.1.0.nupkg

error	Fatal error: Resource not accessible by integration
error	The following packages are still pending:
error		Az.StorageImportExport

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 6e9525e. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️storageimportexport/mgmt/2020-08-01/storageimportexport [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Const `MicrosoftManaged` type has been changed from `KekType` to `EncryptionKekType`
info	[Changelog] - Const `None` type has been changed from `Type` to `IdentityType`
info	[Changelog] - Const `SystemAssigned` type has been changed from `Type` to `IdentityType`
info	[Changelog] - Const `CustomerManaged` type has been changed from `KekType` to `EncryptionKekType`
info	[Changelog] - Const `UserAssigned` type has been changed from `Type` to `IdentityType`
info	[Changelog] - Type of `EncryptionKeyDetails.KekType` has been changed from `KekType` to `EncryptionKekType`
info	[Changelog] - Type of `IdentityDetails.Type` has been changed from `Type` to `IdentityType`
info	[Changelog] - Function `PossibleTypeValues` has been removed
info	[Changelog] - Function `PossibleKekTypeValues` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Application`
info	[Changelog] - New const `Key`
info	[Changelog] - New const `ManagedIdentity`
info	[Changelog] - New const `User`
info	[Changelog] - New function `PossibleIdentityTypeValues() []IdentityType`
info	[Changelog] - New function `PossibleEncryptionKekTypeValues() []EncryptionKekType`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `AdditionalShippingInformation` in struct `LocationProperties`
info	[Changelog] - New field `SystemData` in struct `JobResponse`
info	[Changelog]
info	[Changelog] Total 9 breaking change(s), 11 additive change(s).
info	[Changelog]

️✔️storageimportexport/mgmt/2016-11-01/storageimportexport [View full logs] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `UpdateJobParametersProperties.DeliveryPackage` has been changed from `*PackageInfomation` to `*DeliveryPackageInformation`
info	[Changelog] - Type of `JobDetails.DeliveryPackage` has been changed from `*PackageInfomation` to `*DeliveryPackageInformation`
info	[Changelog] - Type of `DriveStatus.PercentComplete` has been changed from `*int32` to `*int64`
info	[Changelog] - Field `BlobListblobPath` of struct `Export` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Key`
info	[Changelog] - New const `User`
info	[Changelog] - New const `ManagedIdentity`
info	[Changelog] - New const `UserAssigned`
info	[Changelog] - New const `MicrosoftManaged`
info	[Changelog] - New const `SystemAssigned`
info	[Changelog] - New const `None`
info	[Changelog] - New const `Application`
info	[Changelog] - New const `CustomerManaged`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New function `PossibleEncryptionKekTypeValues() []EncryptionKekType`
info	[Changelog] - New function `ShippingInformation.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `IdentityDetails.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleIdentityTypeValues() []IdentityType`
info	[Changelog] - New struct `DeliveryPackageInformation`
info	[Changelog] - New struct `EncryptionKeyDetails`
info	[Changelog] - New struct `IdentityDetails`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `Identity` in struct `JobResponse`
info	[Changelog] - New field `SystemData` in struct `JobResponse`
info	[Changelog] - New field `AdditionalShippingInformation` in struct `LocationProperties`
info	[Changelog] - New field `AdditionalInformation` in struct `ShippingInformation`
info	[Changelog] - New field `BlobListBlobPath` in struct `Export`
info	[Changelog] - New field `EncryptionKey` in struct `JobDetails`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 27 additive change(s).
info	[Changelog]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 6e9525e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-storageimportexport [View full logs] [Release SDK Changes]
- azure-mgmt-storageimportexport-1.0.0b1.zip
- azure_mgmt_storageimportexport-1.0.0b1-py2.py3-none-any.whl
```
info	[Changelog]
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 6e9525e. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/storageimportexport/resource-manager/readme.md

️✔️@azure/arm-storageimportexport [View full logs] [Release SDK Changes]

azure-arm-storageimportexport-1.3.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/storageImportExportManagementClient.js → ./dist/arm-storageimportexport.js...
cmderr	[npmPack] created ./dist/arm-storageimportexport.js in 233ms

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 6e9525e. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/storageimportexport/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse-error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse-error-detailsItem' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PutJobParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'JobDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'EncryptionKeyDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IdentityDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateJobParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateJobParameters-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ListJobsResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'JobResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Location' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Location-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ReturnAddress' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ReturnShipping' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ShippingInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PackageInfomation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DeliveryPackageInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DriveStatus' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Export' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Export-blobList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'LocationsResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'GetBitLockerKeysResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DriveBitLockerKey' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ListOperationsResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Jobs/put/Create export job
cmderr	[Autorest]     - name: /Jobs/put/Create import job
cmderr	[Autorest]     - name: /Jobs/get/Get export job
cmderr	[Autorest]     - name: /Jobs/get/Get import job
cmderr	[Autorest]     - name: /Jobs/get/List jobs in a resource group
cmderr	[Autorest]     - name: /Jobs/get/List jobs in a subscription
cmderr	[Autorest]     - name: /Jobs/patch/Update export job
cmderr	[Autorest]     - name: /Jobs/patch/Update import job
cmderr	[Autorest]     - name: /BitLockerKeys/post/List BitLocker Keys for drives in a job
cmderr	[Autorest]     - name: /Jobs/delete/Delete job
cmderr	[Autorest]     - name: /Locations/get/Get locations
cmderr	[Autorest]     - name: /Locations/get/List locations
cmderr	[Autorest] --------------------------------------------------------

️✔️storageimportexport [View full logs] [Release Azure CLI Changes]
- storageimportexport-0.1.0-py3-none-any.whl
- storageimportexport-0.1.0.zip

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 6e9525e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️storageimportexport [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2021-06-21T09:57:37Z

All CLA requirements met.

openapi-workflow-bot · 2021-06-21T09:59:27Z

Hi @t-ammar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

t-ammar · 2021-06-22T12:27:40Z

@weidongxu-microsoft
Just wanted to confirm that this is to address a Swagger correctness S360 issue and there’s no changes on the service side

weidongxu-microsoft · 2021-06-24T01:40:10Z

@t-ammar

Please fix the CI.

Same procedure for S360 or not. If breaking changes reported, you need approval from the board.

t-ammar · 2021-06-24T09:57:18Z

@weidongxu-microsoft
The CI has been fixed, can you please do the review?

weidongxu-microsoft

@ArcturusZhang @msyyc Does change on "default" affect your SDK?

weidongxu-microsoft · 2021-06-25T01:28:22Z

@t-ammar
I am OK with it.

You would need breaking changes board review as well.

parvezah · 2021-07-09T05:21:18Z

@weidongxu-microsoft @ArcturusZhang , We have created the Breaking Change template ticket. We joined the office hours, but no one attended it, maybe because of US holiday. We will try to follow up in the next Office Hours.

Meanwhile wanted to understand the failures on the Go Language SDK. We would like to pursue to get that to closure. Any guidance on what we need to resolve the same? @ArcturusZhang

weidongxu-microsoft · 2021-07-09T05:30:16Z

@jianyexi Hi Jianye, does change on default value considered as breaking changes (as it reflex service behavior, which does not affect SDK, and likely not affect user if service behavior is not changed)?

weidongxu-microsoft · 2021-07-09T05:31:57Z

Go SDK build is good. I guess the breaking changes reported by golang is caused by some previous changes on the PR. @ArcturusZhang

parvezah · 2021-07-12T17:08:41Z

Hi @weidongxu-microsoft, The PR is approved now. I am not able to Merge it. It is a PR raised by one of our Interns in our team who is not available right now, so not able to check if he has permissions to do the same.
Will you be able to help with merging the change?

…or Import Export (#1796) Create to sync Azure/azure-rest-api-specs#14907 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/storageimportexport?expand=1)

* Added default values for parameters * added single multipath for go

Added default values for parameters

43f8ad6

openapi-assignment-bot bot assigned weidongxu-microsoft Jun 21, 2021

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jun 21, 2021

openapi-workflow-bot bot added the FixS360 label Jun 21, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jun 21, 2021

added single multipath for go

18d3cc6

t-ammar requested a review from ArcturusZhang as a code owner June 24, 2021 08:12

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jun 24, 2021

weidongxu-microsoft approved these changes Jun 25, 2021

View reviewed changes

ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jul 10, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 12, 2021

weidongxu-microsoft merged commit 6e9525e into Azure:master Jul 13, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Added default values for parameters for Import Export (Azure#14907)

ef7145c

* Added default values for parameters * added single multipath for go

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added default values for parameters for Import Export #14907

Added default values for parameters for Import Export #14907

t-ammar commented Jun 21, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jun 21, 2021

openapi-workflow-bot bot commented Jun 21, 2021

openapi-pipeline-app bot commented Jun 21, 2021 •

edited

Loading

ghost commented Jun 21, 2021

openapi-pipeline-app bot commented Jun 21, 2021 •

edited

Loading

Breaking Changes Tracking

ghost commented Jun 21, 2021 •

edited by ghost

Loading

openapi-workflow-bot bot commented Jun 21, 2021

t-ammar commented Jun 22, 2021

weidongxu-microsoft commented Jun 24, 2021

t-ammar commented Jun 24, 2021

weidongxu-microsoft left a comment

weidongxu-microsoft commented Jun 25, 2021

parvezah commented Jul 9, 2021

weidongxu-microsoft commented Jul 9, 2021 •

edited

Loading

weidongxu-microsoft commented Jul 9, 2021

parvezah commented Jul 12, 2021

Added default values for parameters for Import Export #14907

Added default values for parameters for Import Export #14907

Conversation

t-ammar commented Jun 21, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 21, 2021

openapi-workflow-bot bot commented Jun 21, 2021

openapi-pipeline-app bot commented Jun 21, 2021 • edited Loading

Swagger Validation Report

ghost commented Jun 21, 2021

openapi-pipeline-app bot commented Jun 21, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

ghost commented Jun 21, 2021 • edited by ghost Loading

openapi-workflow-bot bot commented Jun 21, 2021

t-ammar commented Jun 22, 2021

weidongxu-microsoft commented Jun 24, 2021

t-ammar commented Jun 24, 2021

weidongxu-microsoft left a comment

Choose a reason for hiding this comment

weidongxu-microsoft commented Jun 25, 2021

parvezah commented Jul 9, 2021

weidongxu-microsoft commented Jul 9, 2021 • edited Loading

weidongxu-microsoft commented Jul 9, 2021

parvezah commented Jul 12, 2021

t-ammar commented Jun 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 21, 2021 •

edited

Loading

ghost commented Jun 21, 2021 •

edited by ghost

Loading

weidongxu-microsoft commented Jul 9, 2021 •

edited

Loading