[DataBox] Bump the api version to add new values for enums for JobStageStatus #14909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @raviten Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The property systemData in the response of operation:'Jobs_Get' is not read only. Please add the readonly for the systemData. Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L448 |
|
The property systemData in the response of operation:'Jobs_Create' is not read only. Please add the readonly for the systemData. Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L513 |
|
The property systemData in the response of operation:'Jobs_Update' is not read only. Please add the readonly for the systemData. Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L634 |
| Sku Model definition 'Sku' is not valid. A Sku model must have 'name' property. It can also have 'tier', 'size', 'family', 'capacity' as optional properties. Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L3952 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnumerationInProgress Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L1542 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isPasskeyUserDefined Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L1909 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isCancellable Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L2701 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDeletable Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L2706 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isShippingAddressEditable Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L2711 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isPrepareToShipEnabled Location: Microsoft.DataBox/stable/2021-05-01/databox.json#L2716 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-05-01/databox.json compared with base:stable/2021-03-01/databox.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"databox/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"databox/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"databox/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
Hi, @raviten your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Generation Artifacts
|
This was referenced Jun 21, 2021
This was referenced Jun 21, 2021
…h Tera as acceptable word
raviten
requested review from
00Kai0,
ArcturusZhang,
jsntcy,
msyyc,
qiaozha and
RAY-316
as code owners
26 tasks
|
@PhoenixHe-msft help with .net Sdk failure |
|
@jianyexi @PhoenixHe-msft .net sdk is failing in recent PRs as well. I hope this is not blocker for merging |
filizt
added
ARMSignedOff
|
LGTM. You still need to resolve SDK breaking changes task failures. |
|
@ArcturusZhang @msyyc SDK breaking change reviewer |
ArcturusZhang
added
the
Approved-SdkBreakingChange-Go
|
@raviten could you fix the branch conflict ? |
jianyexi
approved these changes
Jun 28, 2021
This was referenced Jun 28, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…geStatus (Azure#14909) * copy of 2021-03-01, first commit * adding new api version and its example * updating readme files with 2021-05-01 version and cSpell.json too with Tera as acceptable word * updating 2021-readme files * adding reference to the file * removing track1 changes for python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.