New api version support to include disable local auth for service bus #14952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @SayanMS09 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth Location: Microsoft.ServiceBus/preview/2021-06-01-preview/namespace-preview.json#L731 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: requireInfrastructureEncryption Location: Microsoft.ServiceBus/preview/2021-06-01-preview/namespace-preview.json#L856 |
|
| 'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ServiceBus/preview/2021-06-01-preview/namespace-preview.json#L877 |
|
| 'userAssignedIdentityProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ServiceBus/preview/2021-06-01-preview/namespace-preview.json#L1040 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfigs/CheckNameAvailability' Location: Microsoft.ServiceBus/preview/2021-06-01-preview/DisasterRecoveryConfig.json#L37 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules' Location: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L37 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules/{authorizationRuleName}' Location: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L85 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules/{authorizationRuleName}/listKeys' Location: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L234 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules/{authorizationRuleName}/regenerateKeys' Location: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L282 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/queues/{queueName}/authorizationRules/{authorizationRuleName}/ListKeys' Location: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L545 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/topics/{topicName}/authorizationRules/{authorizationRuleName}/ListKeys' Location: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L865 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.ServiceBus/CheckNameAvailability' Location: Microsoft.ServiceBus/preview/2021-06-01-preview/CheckNameAvailability.json#L37 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ServiceBus/preview/2021-06-01-preview/DisasterRecoveryConfig.json#L217 |
|
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L363 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 2 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:preview/2021-06-01-preview/AuthorizationRules.json compared with base:preview/2021-01-01-preview/AuthorizationRules.json
- current:preview/2021-06-01-preview/CheckNameAvailability.json compared with base:preview/2021-01-01-preview/CheckNameAvailability.json
- current:preview/2021-06-01-preview/DisasterRecoveryConfig.json compared with base:preview/2021-01-01-preview/DisasterRecoveryConfig.json
- current:preview/2021-06-01-preview/Queue.json compared with base:preview/2021-01-01-preview/Queue.json
- current:preview/2021-06-01-preview/Rules.json compared with base:preview/2021-01-01-preview/Rules.json
- current:preview/2021-06-01-preview/migrationconfigs.json compared with base:preview/2021-01-01-preview/migrationconfigs.json
- current:preview/2021-06-01-preview/namespace-preview.json compared with base:preview/2021-01-01-preview/namespace-preview.json
- current:preview/2021-06-01-preview/networksets.json compared with base:preview/2021-01-01-preview/networksets.json
- current:preview/2021-06-01-preview/operations.json compared with base:preview/2021-01-01-preview/operations.json
- current:preview/2021-06-01-preview/subscriptions.json compared with base:preview/2021-01-01-preview/subscriptions.json
- current:preview/2021-06-01-preview/topics.json compared with base:preview/2021-01-01-preview/topics.json
| Rule | Message |
|---|---|
| The new version has a different type 'object' than the previous one ''. New: Microsoft.ServiceBus/preview/2021-06-01-preview/namespace-preview.json#L877:9 Old: Microsoft.ServiceBus/preview/2021-01-01-preview/namespace-preview.json#L873:9 |
|
| The new version has a different type 'object' than the previous one ''. New: Microsoft.ServiceBus/preview/2021-06-01-preview/namespace-preview.json#L1040:5 Old: Microsoft.ServiceBus/preview/2021-01-01-preview/namespace-preview.json#L1036:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 3 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-06-preview", "details":"Schema 'SqlRuleAction' has a property 'sqlExpression' that is already declared the parent schema 'Action' but isn't significantly different. The property has been removed from SqlRuleAction" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-06-preview", "details":"Schema 'SqlRuleAction' has a property 'compatibilityLevel' that is already declared the parent schema 'Action' but isn't significantly different. The property has been removed from SqlRuleAction" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-06-preview", "details":"Schema 'SqlRuleAction' has a property 'requiresPreprocessing' that is already declared the parent schema 'Action' but isn't significantly different. The property has been removed from SqlRuleAction" |
|
| 💬 AutorestCore/Exception | "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-06-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-06-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-06-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=229426&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-go - servicebus/mgmt/2017-04-01/servicebus - v55.5.0️✔️azure-sdk-for-go - servicebus/mgmt/2015-08-01/servicebus - v55.5.0️✔️azure-sdk-for-go - preview/servicebus/mgmt/2018-01-01-preview/servicebus - v55.5.0❌azure-sdk-for-python-track2 - track2_azure-mgmt-servicebus - 6.0.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.ServiceBus [View full logs] [Release SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-servicebus [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model SBNamespace has a new parameter status info [Changelog] - Model SBNamespace has a new parameter system_data info [Changelog] - Model SBNamespace has a new parameter private_endpoint_connections info [Changelog] - Model Identity has a new parameter user_assigned_identities info [Changelog] - Model KeyVaultProperties has a new parameter key_version info [Changelog] - Model KeyVaultProperties has a new parameter identity info [Changelog] - Model SBAuthorizationRule has a new parameter system_data info [Changelog] - Model Encryption has a new parameter require_infrastructure_encryption info [Changelog] - Model PrivateEndpointConnection has a new parameter system_data info [Changelog] - Model NetworkRuleSet has a new parameter system_data info [Changelog] - Model SBTopic has a new parameter system_data info [Changelog] - Model ArmDisasterRecovery has a new parameter system_data info [Changelog] - Model SBNamespaceUpdateParameters has a new parameter status info [Changelog] - Model SBNamespaceUpdateParameters has a new parameter private_endpoint_connections info [Changelog] - Model SBQueue has a new parameter system_data info [Changelog] - Model SBSubscription has a new parameter system_data info [Changelog] - Model MigrationConfigProperties has a new parameter system_data info [Changelog] - Model Rule has a new parameter system_data info [Changelog] - Added operation NamespacesOperations.list_network_rule_sets info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Parameter id of model Subnet is now required info [Changelog] - Removed operation NamespacesOperations.list_ip_filter_rules info [Changelog] - Removed operation NamespacesOperations.create_or_update_virtual_network_rule info [Changelog] - Removed operation NamespacesOperations.delete_ip_filter_rule info [Changelog] - Removed operation NamespacesOperations.create_or_update_ip_filter_rule info [Changelog] - Removed operation NamespacesOperations.list_virtual_network_rules info [Changelog] - Removed operation NamespacesOperations.delete_virtual_network_rule info [Changelog] - Removed operation NamespacesOperations.migrate info [Changelog] - Removed operation NamespacesOperations.get_ip_filter_rule info [Changelog] - Removed operation NamespacesOperations.get_virtual_network_rule
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-07-07 05:54:19 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-servicebus-generated" cmderr [generate.py] 2021-07-07 05:54:19 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-07-07 05:54:19 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.31 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/servicebus/azure-resourcemanager-servicebus-generated --java.namespace=com.azure.resourcemanager.servicebus.generated --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md cmderr [generate.py] 2021-07-07 05:55:07 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-07-07 05:55:07 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-07-07 05:55:07 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-07-07 05:55:07 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-07-07 05:55:07 INFO [POM][Skip] pom already has module sdk/servicebus cmderr [generate.py] 2021-07-07 05:55:07 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-servicebus-generated [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar
- azure-resourcemanager-servicebus-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-servicebus-generated-1.0.0-beta.1-javadoc.jar
cmderr [Inst] 2021-07-07 05:57:51 DEBUG Got artifact_id: azure-resourcemanager-servicebus-generated cmderr [Inst] 2021-07-07 05:57:51 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-07-07 05:57:51 DEBUG Got artifact: azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-07-07 05:57:51 DEBUG Match jar package: azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-07-07 05:57:51 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14952/azure-sdk-for-java/azure-resourcemanager-servicebus-generated/azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-servicebus-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️servicebus/mgmt/2017-04-01/servicebus [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️servicebus/mgmt/2015-08-01/servicebus [View full logs]info [Changelog] No exported changes
️✔️preview/servicebus/mgmt/2018-01-01-preview/servicebus [View full logs]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New function `NetworkRuleSetListResultIterator.Value() NetworkRuleSet` info [Changelog] - New function `NamespacesClient.ListNetworkRuleSetsPreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `*NetworkRuleSetListResultPage.NextWithContext(context.Context) error` info [Changelog] - New function `NetworkRuleSetListResult.IsEmpty() bool` info [Changelog] - New function `NewNetworkRuleSetListResultPage(NetworkRuleSetListResult, func(context.Context, NetworkRuleSetListResult) (NetworkRuleSetListResult, error)) NetworkRuleSetListResultPage` info [Changelog] - New function `NamespacesClient.ListNetworkRuleSetsSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `NamespacesClient.ListNetworkRuleSets(context.Context, string, string) (NetworkRuleSetListResultPage, error)` info [Changelog] - New function `*NetworkRuleSetListResultIterator.NextWithContext(context.Context) error` info [Changelog] - New function `NetworkRuleSetListResultIterator.Response() NetworkRuleSetListResult` info [Changelog] - New function `NewNetworkRuleSetListResultIterator(NetworkRuleSetListResultPage) NetworkRuleSetListResultIterator` info [Changelog] - New function `NetworkRuleSetListResultIterator.NotDone() bool` info [Changelog] - New function `*NetworkRuleSetListResultPage.Next() error` info [Changelog] - New function `*NetworkRuleSetListResultIterator.Next() error` info [Changelog] - New function `NetworkRuleSetListResultPage.NotDone() bool` info [Changelog] - New function `NetworkRuleSetListResultPage.Response() NetworkRuleSetListResult` info [Changelog] - New function `NamespacesClient.ListNetworkRuleSetsComplete(context.Context, string, string) (NetworkRuleSetListResultIterator, error)` info [Changelog] - New function `NamespacesClient.ListNetworkRuleSetsResponder(*http.Response) (NetworkRuleSetListResult, error)` info [Changelog] - New function `NetworkRuleSetListResultPage.Values() []NetworkRuleSet` info [Changelog] - New struct `NetworkRuleSetListResult` info [Changelog] - New struct `NetworkRuleSetListResultIterator` info [Changelog] - New struct `NetworkRuleSetListResultPage` info [Changelog] - New field `Status` in struct `SBNamespaceProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 25 additive change(s). info [Changelog]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md
️✔️@azure/arm-servicebus [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/serviceBusManagementClient.js → ./dist/arm-servicebus.js... cmderr [npmPack] created ./dist/arm-servicebus.js in 588ms
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️servicebus [View full logs] [Release Schema Changes]
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @SayanMS09 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
This was referenced Jun 23, 2021
added 2 commits
June 23, 2021 13:55
lirenhe
added
the
Approved-BreakingChange
|
Adding 'type:object' is not considered as breaking change. |
|
Please copy the existing API version into the new paths in your first commit in future PRs before making changes |
pilor
added
ARMSignedOff
|
@apraovjr , can you please review |
apraovjr
reviewed
Jul 1, 2021
| "$ref": "#/definitions/DictionaryValue" | ||
| }, | ||
| "description": "Properties for User Assigned Identities" | ||
| } |
There was a problem hiding this comment.
@SayanMS09 Refer to this PR for the user-managed identity contract.
https://github.com/v-Ajnava/azure-rest-api-specs/blob/47ed0cebba65cb950843a6c2d52f6b537823b34f/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2021-01-01-preview/namespaces-preview.json
apraovjr
approved these changes
Jul 2, 2021
lirenhe
approved these changes
Jul 5, 2021
|
For python, the breaking change is permitted. |
This was referenced Jul 7, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…Azure#14952) * New api version support to include disable local auth for service bus * Added Auth examples * Fixing LintDiff error * Fixing spell check * Changed propery name to UserAssignedIdentity * Reverted last change and changed property to UserAssignedIdentity Co-authored-by: Sayan Ghosh <sayanghosh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.