Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Api 2021-06-22 #14956

Merged
merged 15 commits into from
Aug 26, 2021
Merged

Conversation

Bhargava-Chary-Chollaty
Copy link
Member

@Bhargava-Chary-Chollaty Bhargava-Chary-Chollaty commented Jun 23, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @Bhargava-Chary-Chollaty Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 23, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 6 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'HybridRunbookWorkers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Automation/stable/2021-06-22/hybridRunbookWorker.json#L291
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'HybridRunbookWorkers_Create' Request Model: 'HybridRunbookWorkerCreateParameters' Response Model: 'HybridRunbookWorker'
    Location: Microsoft.Automation/stable/2021-06-22/hybridRunbookWorker.json#L154
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'HybridRunbookWorkerGroup_Create' Request Model: 'HybridRunbookWorkerGroupCreateOrUpdateParameters' Response Model: 'HybridRunbookWorkerGroup'
    Location: Microsoft.Automation/stable/2021-06-22/hybridRunbookWorkerGroup.json#L137
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HybridRunbookWorkerGroupModel'. Consider using the plural form of 'HybridRunbookWorkerGroup' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Automation/stable/2021-06-22/hybridRunbookWorkerGroup.json#L141
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L552
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L819


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L886
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L84
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L142
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L185
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L228
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L270
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L310
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L365
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L413
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L458
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Automation/stable/2021-06-22/hybridRunbookWorkerGroup.json#L75
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Automation/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Automation/stable/2021-06-22/operations.json#L39
    R4037 - MissingTypeObject The schema 'AutomationAccount' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L469
    R4037 - MissingTypeObject The schema 'AutomationAccountProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L495
    R4037 - MissingTypeObject The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L563
    R4037 - MissingTypeObject The schema 'AutomationAccountCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L592
    R4037 - MissingTypeObject The schema 'AutomationAccountCreateOrUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L622
    R4037 - MissingTypeObject The schema 'AutomationAccountListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L639
    R4037 - MissingTypeObject The schema 'Statistics' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L655
    R4037 - MissingTypeObject The schema 'StatisticsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L690
    R4037 - MissingTypeObject The schema 'Usage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L702
    R4037 - MissingTypeObject The schema 'UsageCounterName' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L733
    R4037 - MissingTypeObject The schema 'UsageListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L746
    R4037 - MissingTypeObject The schema 'Key' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L758
    R4037 - MissingTypeObject The schema 'KeyListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L794
    R4037 - MissingTypeObject The schema 'AutomationAccountUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L805
    R4037 - MissingTypeObject The schema 'AutomationAccountUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L826
    R4037 - MissingTypeObject The schema 'Identity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L856
    R4037 - MissingTypeObject The schema 'EncryptionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L904
    R4037 - MissingTypeObject The schema 'identity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Automation/stable/2021-06-22/account.json#L923
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/automation/resource-manager/readme.md
    tag: specification/automation/resource-manager/readme.md#tag-package-2020-01-13-preview
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 4 Warnings warning [Detail]
    The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Automation/stable/2021-06-22/hybridRunbookWorkerGroup.json#L367:11
    Old: Microsoft.Automation/stable/2019-06-01/hybridRunbookWorkerGroup.json#L301:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Automation/stable/2021-06-22/hybridRunbookWorkerGroup.json#L228:13
    Old: Microsoft.Automation/stable/2019-06-01/hybridRunbookWorkerGroup.json#L169:13


    The following breaking changes are detected by comparison with latest preview version:

    Rule Message
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Automation/stable/2021-06-22/hybridRunbookWorkerGroup.json#L367:11
    Old: Microsoft.Automation/preview/2020-01-13-preview/hybridRunbookWorkerGroup.json#L301:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Automation/stable/2021-06-22/hybridRunbookWorkerGroup.json#L228:13
    Old: Microsoft.Automation/preview/2020-01-13-preview/hybridRunbookWorkerGroup.json#L169:13
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 6 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ Modeler/MissingType "readme":"automation/resource-manager/readme.md",
    "tag":"package-2015-10",
    "details":"The schema 'ScheduleCreateOrUpdateProperties-interval' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/schedule.json#/components/schemas/ScheduleCreateOrUpdateProperties-interval"
    ⚠️ Modeler/MissingType "readme":"automation/resource-manager/readme.md",
    "tag":"package-2015-10",
    "details":"The schema 'ScheduleProperties-interval' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/schedule.json#/components/schemas/ScheduleProperties-interval"
    ⚠️ Modeler/MissingType "readme":"automation/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"The schema 'ScheduleCreateOrUpdateProperties-interval' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/automation/resource-manager/Microsoft.Automation/stable/2019-06-01/schedule.json#/components/schemas/ScheduleCreateOrUpdateProperties-interval"
    ⚠️ Modeler/MissingType "readme":"automation/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"The schema 'ScheduleProperties-interval' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/automation/resource-manager/Microsoft.Automation/stable/2019-06-01/schedule.json#/components/schemas/ScheduleProperties-interval"
    ⚠️ Modeler/MissingType "readme":"automation/resource-manager/readme.md",
    "tag":"package-2020-01-13-preview",
    "details":"The schema 'ScheduleCreateOrUpdateProperties-interval' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/schedule.json#/components/schemas/ScheduleCreateOrUpdateProperties-interval"
    ⚠️ Modeler/MissingType "readme":"automation/resource-manager/readme.md",
    "tag":"package-2020-01-13-preview",
    "details":"The schema 'ScheduleProperties-interval' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/schedule.json#/components/schemas/ScheduleProperties-interval"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2015-10",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2015-10",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2021-06-22",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2021-06-22",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"


    The following errors/warnings exist before current PR submission:

    Rule Message
    PreCheck/DuplicateSchema "readme":"automation/resource-manager/readme.md",
    "tag":"package-2017-05-preview",
    "details":"Duplicate Schema named ScheduleProperties -- properties.interval.$ref: undefined => "#/components/schemas/schemas:756" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2017-05-preview",
    "details":"Error: Plugin prechecker reported failure."
    PreCheck/DuplicateSchema "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-01-preview",
    "details":"Duplicate Schema named ScheduleProperties -- properties.interval.$ref: undefined => "#/components/schemas/schemas:605" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-01-preview",
    "details":"Error: Plugin prechecker reported failure."
    PreCheck/DuplicateSchema "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-06-preview",
    "details":"Duplicate Schema named ScheduleProperties -- properties.interval.$ref: undefined => "#/components/schemas/schemas:503" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-06-preview",
    "details":"Error: Plugin prechecker reported failure."
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2015-10",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2017-05-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2017-05-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-01-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-06-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-06-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2020-01-13-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"automation/resource-manager/readme.md",
    "tag":"package-2020-01-13-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 23, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-automation - 1.1.0b1
    ️✔️azure-sdk-for-go - automation/mgmt/2019-06-01/automation - v56.3.0
    ️✔️azure-sdk-for-go - automation/mgmt/2015-10-31/automation - v56.3.0
    ️✔️azure-sdk-for-go - preview/automation/mgmt/2020-01-13-preview/automation - v56.3.0
    ️✔️azure-sdk-for-go - preview/automation/mgmt/2018-06-30-preview/automation - v56.3.0
    ️✔️azure-sdk-for-go - preview/automation/mgmt/2018-01-15-preview/automation - v56.3.0
    ️✔️azure-sdk-for-go - preview/automation/mgmt/2017-05-15-preview/automation - v56.3.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 10cdea5. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/automation/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Automation [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10cdea5. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-automation [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter public_network_access
      info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter identity
      info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter encryption
      info	[Changelog]   - Model AutomationAccount has a new parameter public_network_access
      info	[Changelog]   - Model AutomationAccount has a new parameter private_endpoint_connections
      info	[Changelog]   - Model AutomationAccount has a new parameter identity
      info	[Changelog]   - Model AutomationAccount has a new parameter encryption
      info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter public_network_access
      info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter identity
      info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter encryption
      info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
      info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 10cdea5. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️automation/mgmt/2019-06-01/automation [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️automation/mgmt/2015-10-31/automation [View full logs
      Only show 20 items here, please refer to log for details.
      info	[Changelog] - New function `WatcherClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
      info	[Changelog] - New function `PrivateEndpointConnection.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `WatcherClient.GetSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `WatcherClient.ListByAutomationAccount(context.Context, string, string, string) (WatcherListResultPage, error)`
      info	[Changelog] - New function `WatcherClient.StopSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New struct `PrivateEndpointConnection`
      info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `PrivateEndpointProperty`
      info	[Changelog] - New struct `PrivateLinkServiceConnectionStateProperty`
      info	[Changelog] - New struct `Watcher`
      info	[Changelog] - New struct `WatcherClient`
      info	[Changelog] - New struct `WatcherListResult`
      info	[Changelog] - New struct `WatcherListResultIterator`
      info	[Changelog] - New struct `WatcherListResultPage`
      info	[Changelog] - New struct `WatcherProperties`
      info	[Changelog] - New struct `WatcherUpdateParameters`
      info	[Changelog] - New struct `WatcherUpdateProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 76 additive change(s).
      info	[Changelog]
    • ️✔️preview/automation/mgmt/2020-01-13-preview/automation [View full logs
      info	[Changelog] This is a new package
    • ️✔️preview/automation/mgmt/2018-06-30-preview/automation [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `*PrivateEndpointConnection.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `PrivateEndpointConnection.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PrivateLinkServiceConnectionStateProperty.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `PrivateEndpointConnection`
      info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `PrivateEndpointProperty`
      info	[Changelog] - New struct `PrivateLinkServiceConnectionStateProperty`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 11 additive change(s).
      info	[Changelog]
    • ️✔️preview/automation/mgmt/2018-01-15-preview/automation [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `PrivateLinkServiceConnectionStateProperty.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*PrivateEndpointConnection.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `PrivateEndpointConnection.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `PrivateEndpointConnection`
      info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `PrivateEndpointProperty`
      info	[Changelog] - New struct `PrivateLinkServiceConnectionStateProperty`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 11 additive change(s).
      info	[Changelog]
    • ️✔️preview/automation/mgmt/2017-05-15-preview/automation [View full logs
      Only show 20 items here, please refer to log for details.
      info	[Changelog] - New function `WatcherClient.CreateOrUpdateResponder(*http.Response) (Watcher, error)`
      info	[Changelog] - New function `WatcherUpdateParameters.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `WatcherClient.StartSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `*WatcherListResultIterator.NextWithContext(context.Context) error`
      info	[Changelog] - New function `WatcherClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New struct `PrivateEndpointConnection`
      info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `PrivateEndpointProperty`
      info	[Changelog] - New struct `PrivateLinkServiceConnectionStateProperty`
      info	[Changelog] - New struct `Watcher`
      info	[Changelog] - New struct `WatcherClient`
      info	[Changelog] - New struct `WatcherListResult`
      info	[Changelog] - New struct `WatcherListResultIterator`
      info	[Changelog] - New struct `WatcherListResultPage`
      info	[Changelog] - New struct `WatcherProperties`
      info	[Changelog] - New struct `WatcherUpdateParameters`
      info	[Changelog] - New struct `WatcherUpdateProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 76 additive change(s).
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 10cdea5. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/automation/resource-manager/readme.md
    • ️✔️@azure/arm-automation [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/automationClient.js → ./dist/arm-automation.js...
      cmderr	[npmPack] created ./dist/arm-automation.js in 1.1s
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10cdea5. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2539) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
      cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
      cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
      cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
      cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2539) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2539) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      cmderr	[generateScript.sh] (node:2539) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
      cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
      cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
      cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
      cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
      cmderr	[generateScript.sh] (node:2539) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
    • ️✔️automation [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi, @Bhargava-Chary-Chollaty your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    "description": "Gets or sets hybrid runbook worker group create or update properties."
    },
    "name": {
    "type": "string",
    Copy link
    Member

    @RamyasreeChakka RamyasreeChakka Jun 24, 2021

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    name should be marked as readOnly. #Resolved

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Made the change

    Copy link
    Member

    @RamyasreeChakka RamyasreeChakka left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @RamyasreeChakka RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 24, 2021
    @leni-msft leni-msft assigned jianyexi and unassigned leni-msft Jun 28, 2021
    @jianyexi
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @jianyexi jianyexi assigned ruowan and unassigned jianyexi Jun 28, 2021
    @jianyexi
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @RamyasreeChakka RamyasreeChakka added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 29, 2021
    @RamyasreeChakka RamyasreeChakka dismissed their stale review June 29, 2021 17:57

    revoking review

    Copy link
    Member

    @RamyasreeChakka RamyasreeChakka left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @RamyasreeChakka RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 29, 2021
    @ruowan ruowan assigned zhenglaizhang and unassigned ruowan Jul 5, 2021
    @zhenglaizhang
    Copy link
    Contributor

    @Bhargava-Chary-Chollaty it's suggested to fix warnings for new api version in #14956 (comment)

    @zhenglaizhang
    Copy link
    Contributor

    @Bhargava-Chary-Chollaty it's suggested to fix warnings for new api version in #14956 (comment)

    ping @Bhargava-Chary-Chollaty

    @ghost
    Copy link

    ghost commented Aug 22, 2021

    Hi, @Bhargava-Chary-Chollaty. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants