Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change profile to profile-content in readme.typescript.md #15034

Merged

Conversation

dw511214992
Copy link
Member

profile is a reserved word in autorest v3. see the disscussion in Azure/autorest#4013

we need to change it to make sure track2 js sdk can generate codes.

@dw511214992 dw511214992 requested a review from lirenhe June 30, 2021 09:19
@dw511214992 dw511214992 requested a review from qiaozha as a code owner June 30, 2021 09:19
@openapi-workflow-bot
Copy link

Hi, @dw511214992 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @lirenhe
    Copy link
    Member

    lirenhe commented Jun 30, 2021

    /azp run

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 30, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 30, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    This was referenced Jun 30, 2021
    This was referenced Jul 2, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @msyyc
    Copy link
    Member

    msyyc commented Jan 5, 2022

    /azp run

    @JackTn JackTn deleted the change-profile-to-profilecontent-in-readme-typescript-md branch June 16, 2022 00:48
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants