Revert "Added GA API version (2021-07-01)" #15129

jianyexi · 2021-07-09T01:06:40Z

This reverts commit d1bf50c.

openapi-workflow-bot · 2021-07-09T01:06:41Z

Hi, @jianyexi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-07-09T01:06:42Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-07-09T01:06:42Z

Swagger Validation Report

️❌BreakingChange: 33 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.11)
- current:Microsoft.Purview/stable/2021-07-01 compared with base:Microsoft.Purview/stable/2021-07-01
- current:preview/2020-12-01-preview/purview.json compared with base:preview/2020-12-01-preview/purview.json

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Purview/accounts' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L19:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Purview/accounts' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L69:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Purview/accounts/{accountName}' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L116:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Purview/accounts/{accountName}/listkeys' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L318:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Purview/accounts/{accountName}/addRootCollectionAdmin' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L361:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Purview/getDefaultAccount' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L410:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Purview/setDefaultAccount' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L474:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Purview/removeDefaultAccount' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L517:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Purview/operations' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L581:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Purview/accounts/{accountName}/privateEndpointConnections' removed or restructured? Old: Microsoft.Purview/stable/2021-07-01/purview.json#L618:5

Rule	Message
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Canceled' from the old version. New: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1063:9 Old: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1064:9
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L671:7 Old: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L671:7

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- purview/resource-manager/readme.md tag:package-2020-12-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- purview/resource-manager/readme.md tag:package-2020-12-01-preview

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Accounts_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L117
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L623
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Accounts_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L158
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L671
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Accounts_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L260
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1367
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1707
⚠️ R2023 - SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L426
⚠️ R2023 - SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L469
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'setdefaultaccount' in:'DefaultAccounts_Set'. Consider updating the operationId Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L432

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

purview/resource-manager/readme.md#package-2020-12-01-preview

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"purview/resource-manager/readme.md",
"tag":"package-2020-12-01-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"purview/resource-manager/readme.md",
"tag":"package-2020-12-01-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"purview/resource-manager/readme.md",
"tag":"package-2020-12-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-07-09T01:06:43Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - preview/purview/mgmt/2020-12-01-preview/purview - v55.5.0

-	Function `PrivateEndpointConnectionsClient.CreateOrUpdateSender` return value(s) have been changed from `(*http.Response, error)` to `(PrivateEndpointConnectionsCreateOrUpdateFuture, error)`
-	Function `PrivateEndpointConnectionsClient.CreateOrUpdate` return value(s) have been changed from `(PrivateEndpointConnection, error)` to `(PrivateEndpointConnectionsCreateOrUpdateFuture, error)`

❌azure-sdk-for-python-track2 - track2_azure-mgmt-purview - 1.0.0b1

-	Removed operation PrivateEndpointConnectionsOperations.create_or_update

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 654c237. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-purview [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Account has a new parameter managed_resource_group_name
info	[Changelog]   - Model Account has a new parameter system_data
info	[Changelog]   - Model PrivateLinkResource has a new parameter properties
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model PrivateLinkResource no longer has parameter required_zone_names
info	[Changelog]   - Model PrivateLinkResource no longer has parameter required_members
info	[Changelog]   - Model PrivateLinkResource no longer has parameter group_id
info	[Changelog]   - Model AccountUpdateParameters has a new signature

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 654c237. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/purview/mgmt/2020-12-01-preview/purview [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*DeletedAccount.UnmarshalJSON` has been removed
info	[Changelog] - Function `*PrivateLinkResource.UnmarshalJSON` has been removed
info	[Changelog] - Function `DeletedAccount.MarshalJSON` has been removed
info	[Changelog] - Function `DeletedAccountProperties.MarshalJSON` has been removed
info	[Changelog] - Function `DeletedAccountPropertiesModel.MarshalJSON` has been removed
info	[Changelog] - Function `*AccountUpdateParameters.UnmarshalJSON` has been removed
info	[Changelog] - Struct `DeletedAccount` has been removed
info	[Changelog] - Struct `DeletedAccountList` has been removed
info	[Changelog] - Struct `DeletedAccountProperties` has been removed
info	[Changelog] - Struct `DeletedAccountPropertiesModel` has been removed
info	[Changelog] - Field `*PrivateLinkResourceProperties` of struct `PrivateLinkResource` has been removed
info	[Changelog] - Field `*AccountProperties` of struct `AccountUpdateParameters` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `LastModifiedByTypeApplication`
info	[Changelog] - New const `User`
info	[Changelog] - New const `ManagedIdentity`
info	[Changelog] - New const `LastModifiedByTypeManagedIdentity`
info	[Changelog] - New const `Application`
info	[Changelog] - New const `LastModifiedByTypeUser`
info	[Changelog] - New const `Key`
info	[Changelog] - New const `LastModifiedByTypeKey`
info	[Changelog] - New function `AccountPropertiesSystemData.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `SystemData.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleLastModifiedByTypeValues() []LastModifiedByType`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New struct `AccountPropertiesSystemData`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `Properties` in struct `PrivateLinkResource`
info	[Changelog] - New field `SystemData` in struct `AccountProperties`
info	[Changelog] - New field `ManagedResourceGroupName` in struct `AccountProperties`
info	[Changelog] - New field `Properties` in struct `AccountUpdateParameters`
info	[Changelog]
info	[Changelog] Total 16 breaking change(s), 19 additive change(s).
info	[Changelog]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 654c237. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	Skip detect changed packages

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-07-09T01:08:46Z

Hi @jianyexi, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

jianyexi · 2021-07-09T01:15:37Z

The previous PR are not ready for public, so revert it .

This reverts commit 654c237.

…#15245) This reverts commit 654c237. Co-authored-by: Shailesh Kelkar <shkelkar@microsoft.com>

This reverts commit d1bf50c.

Revert "Added GA API version (2021-07-01) (#14937)"

da9a6ae

This reverts commit d1bf50c.

jianyexi requested a review from ArcturusZhang as a code owner July 9, 2021 01:06

openapi-assignment-bot bot assigned raych1 Jul 9, 2021

jianyexi assigned jianyexi and unassigned raych1 Jul 9, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jul 9, 2021

openapi-sdkautomation bot mentioned this pull request Jul 9, 2021

[AutoPR track2_azure-mgmt-purview] Revert "Added GA API version (2021-07-01)" AzureSDKAutomation/azure-sdk-for-python#6445

Closed

openapi-pipeline-app bot added CI-BreakingChange-Go CI-BreakingChange-Python-Track2 labels Jul 9, 2021

jianyexi added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed CI-BreakingChange-Go CI-BreakingChange-Python-Track2 labels Jul 9, 2021

openapi-pipeline-app bot added CI-BreakingChange-Python-Track2 CI-BreakingChange-Go labels Jul 9, 2021

leni-msft approved these changes Jul 9, 2021

View reviewed changes

jianyexi merged commit 654c237 into master Jul 9, 2021

This was referenced Jul 9, 2021

[ReleasePR preview/purview/mgmt/2020-12-01-preview/purview] Update readme.python.md Azure/azure-sdk-for-go#15023

Closed

[ReleasePR track2_azure-mgmt-purview] Update readme.python.md Azure/azure-sdk-for-python#19734

Closed

jianyexi added a commit that referenced this pull request Jul 18, 2021

Revert "Revert "Added GA API version (2021-07-01) (#14937)" (#15129)"

f95110f

This reverts commit 654c237.

jianyexi pushed a commit that referenced this pull request Jul 18, 2021

Revert "Revert "Added GA API version (2021-07-01) (#14937)" (#15129)" (…

ebe90b1

…#15245) This reverts commit 654c237. Co-authored-by: Shailesh Kelkar <shkelkar@microsoft.com>

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Revert "Added GA API version (2021-07-01) (Azure#14937)" (Azure#15129)

2e47a94

This reverts commit d1bf50c.

jianyexi deleted the revert-14937-shkelkar-add-GA-api-version branch July 22, 2021 05:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Added GA API version (2021-07-01)" #15129

Revert "Added GA API version (2021-07-01)" #15129

jianyexi commented Jul 9, 2021

openapi-workflow-bot bot commented Jul 9, 2021

openapi-workflow-bot bot commented Jul 9, 2021

openapi-pipeline-app bot commented Jul 9, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jul 9, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jul 9, 2021

jianyexi commented Jul 9, 2021

Revert "Added GA API version (2021-07-01)" #15129

Revert "Added GA API version (2021-07-01)" #15129

Conversation

jianyexi commented Jul 9, 2021

openapi-workflow-bot bot commented Jul 9, 2021

openapi-workflow-bot bot commented Jul 9, 2021

openapi-pipeline-app bot commented Jul 9, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jul 9, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jul 9, 2021

jianyexi commented Jul 9, 2021

openapi-pipeline-app bot commented Jul 9, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jul 9, 2021 •

edited

Loading