[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview #15144

bwamie · 2021-07-09T21:33:00Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-07-09T21:33:02Z

Hi, @bwamie Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-07-09T21:33:02Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.11)
- current:preview/2021-05-01-preview/botservice.json compared with base:preview/2021-05-01-preview/botservice.json

Rule	Message
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'disableLocalAuth' that was not found in the old version. New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1535:7 Old: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1535:7

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- botservice/resource-manager/readme.md tag:package-preview-2021-05
Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- botservice/resource-manager/readme.md tag:package-preview-2021-05

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.BotService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L742
`❌` R4037 - MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1423
`❌` R4037 - MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1467
`❌` R4037 - MissingTypeObject	The schema 'BotProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1534
`❌` R4037 - MissingTypeObject	The schema 'BotResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1628
`❌` R4037 - MissingTypeObject	The schema 'AlexaChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1690
`❌` R4037 - MissingTypeObject	The schema 'FacebookChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1733
`❌` R4037 - MissingTypeObject	The schema 'FacebookPage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1773
`❌` R4037 - MissingTypeObject	The schema 'EmailChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1806
`❌` R4037 - MissingTypeObject	The schema 'MsTeamsChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1843

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

botservice/resource-manager/readme.md#package-preview-2021-05

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"botservice/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"botservice/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"botservice/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-07-09T21:33:03Z

Swagger Generation Artifacts

️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=232814&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go - botservice/mgmt/2021-03-01/botservice - v55.7.0
️✔️azure-sdk-for-go - preview/botservice/mgmt/2018-07-12/botservice - v55.7.0
️✔️azure-sdk-for-go - preview/botservice/mgmt/2017-12-01/botservice - v55.7.0
❌azure-sdk-for-python-track2 - track2_azure-mgmt-botservice - 1.0.0

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 761b197. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/botservice/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.BotService [View full logs] [Release SDK Changes]

cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 761b197. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-botservice [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model SlackChannelProperties has a new parameter scopes
info	[Changelog]   - Model BotProperties has a new parameter disable_local_auth
info	[Changelog]   - Model BotProperties has a new parameter is_isolated
info	[Changelog]   - Model BotProperties has a new parameter schema_transformation_version
info	[Changelog]   - Added operation group HostSettingsOperations
info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
info	[Changelog]   - Added operation group OperationResultsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model DirectLineSpeechChannelProperties no longer has parameter cognitive_services_subscription_id
info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_region
info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_subscription_key

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 761b197. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-botservice [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model BotProperties has a new parameter disable_local_auth
info	[Changelog]   - Model SlackChannelProperties has a new parameter scopes
info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
info	[Changelog]   - Added operation group OperationResultsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model DirectLineSpeechChannelProperties no longer has parameter cognitive_services_subscription_id
info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_subscription_key
info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_region

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 761b197. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️botservice/mgmt/2021-03-01/botservice [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/botservice/mgmt/2018-07-12/botservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/botservice/mgmt/2017-12-01/botservice [View full logs]
```
info	[Changelog] No exported changes
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 761b197. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️botservice [View full logs] [Release Schema Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 761b197. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/botservice/resource-manager/readme.md

️✔️@azure/arm-botservice [View full logs] [Release SDK Changes]

azure-arm-botservice-2.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/azureBotService.js → ./dist/arm-botservice.js...
cmderr	[npmPack] created ./dist/arm-botservice.js in 445ms

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-07-09T21:33:03Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-workflow-bot · 2021-07-09T21:35:09Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

.../botservice/resource-manager/Microsoft.BotService/preview/2021-05-01-preview/botservice.json

swagatmishra2007 · 2021-07-12T18:47:46Z

Hello ARM team, this review adds an optional property to a preview api version , that does not have any customers yet (we have only enabled it behind subscription level feature flags which are enabled on subscriptions owned by our team). So it should not be classified as a breaking change. Can you please take a look?

mentat9 · 2021-07-13T00:04:14Z

Please complete the checklist.

add slack permission scopes field

mentat9 · 2021-07-14T17:26:47Z

Please fill out (completely) the submission checklist. This is required before ARM review.

bwamie · 2021-07-15T18:39:22Z

Please fill out (completely) the submission checklist. This is required before ARM review.

@mentat9 checklist completed. Thanks.

mentat9 · 2021-07-15T19:29:30Z

.../botservice/resource-manager/Microsoft.BotService/preview/2021-05-01-preview/botservice.json

@@ -1609,6 +1609,10 @@
          "type": "boolean",
          "description": "Whether the bot is in an isolated network"
        },
+        "disableLocalAuth": {
+          "type": "boolean",


boolean

ARM guidance is to discourage booleans in favor of string enums, e.g. localAuthType { Required, NotRequired }. These are usually easier for customers to understand and use, are extensible to more than two values, and can save complexity by eliminating invalid combinations of multiple booleans. This isn't a requirement, but you should consider it. #Resolved

That is the type expected of that property. Just reusing as is per the guiding doc.

mentat9 · 2021-07-15T19:31:48Z

.../botservice/resource-manager/Microsoft.BotService/preview/2021-05-01-preview/botservice.json

@@ -2137,6 +2141,10 @@
          "type": "string",
          "description": "The Slack verification token. Value only returned through POST to the action Channel List API, otherwise empty."
        },
+        "scopes": {


scopes

How are multiple values separated? Generally collections should not be encoded in strings if their members need to be consumed indvidually.

@youyu16 can you respond to this?

it will separated by ",", example, "channels:history,channels:read", this is an URL parameter.

OK, I'd recommend updating the description to explain the format, but won't block ARM signoff.

mentat9 · 2021-07-15T19:34:37Z

Hello ARM team, this review adds an optional property to a preview api version , that does not have any customers yet (we have only enabled it behind subscription level feature flags which are enabled on subscriptions owned by our team). So it should not be classified as a breaking change. Can you please take a look?

Agree it should not be an ARM breaking change. I have removed the NewApiVersionRequired label based on this.

mentat9 · 2021-07-15T19:36:33Z

@bwamie, you can clear the ARMChangesRequested label when you are finished responding.

PhoenixHe-NV · 2021-07-20T09:07:34Z

/azp run

azure-pipelines · 2021-07-20T09:07:44Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2021-07-20T09:23:33Z

@bwamie Please fix prettier issue

…w' of https://github.com/bwamie/azure-rest-api-specs into edwin-botservice-Microsoft.BotService-2021-05-01-preview

bwamie · 2021-07-20T22:26:18Z

@bwamie Please fix prettier issue

@PhoenixHe-msft fixed.

commit 3ba8d02621be2a4ff7b89bcb740e1bead312aef3 Author: Shuo LI <surezeroleo@gmail.com> Date: Mon Aug 9 11:41:29 2021 -0700 Fixing readme commit 96bcf4a430c048211ffb098111956b1c27145a9a Merge: 57dfa48342 7384176da4 Author: Shuo LI <surezeroleo@gmail.com> Date: Mon Aug 9 11:36:05 2021 -0700 Merge branch 'master' of github.com:Azure/azure-rest-api-specs into dev/shul/add-07-01-to-master commit 57dfa48342d0f5f354a0817871bb9fed4c697a99 Author: Shuo LI <surezeroleo@gmail.com> Date: Mon Aug 9 11:29:51 2021 -0700 Adding 07-01 to master from private repo commit 7384176da46425e7899708f263e0598b851358c2 Author: Hari Prasad Perabattula <harics24@users.noreply.github.com> Date: Sat Aug 7 14:21:16 2021 +0530 Adding NSP resource in the Network Manager preview version (#15553) * Defining the APIs for the new NSP resource * Adding the perimeter associable resources in 02-01-preview * Removing the etags to be same with the 03-01-pre version * Update networkSecurityPerimeter.json Fixing a lint error. Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> commit dba6ed1f03bda88ac6884c0a883246446cc72495 Author: Tom Harvey <tombuildsstuff@users.noreply.github.com> Date: Fri Aug 6 21:34:08 2021 +0200 appconfiguration: adding the autorest config needed for a Go Data Plane SDK (#15317) commit 301de051cd0e618222e7c1bb58c2a430828b9374 Author: Carey Halton <chalton@microsoft.com> Date: Fri Aug 6 12:09:29 2021 -0700 Add TAv3 skills to latest GA swagger spec (#15536) commit 37dbd30ec2e8ba2afe6a4ad1a9f8b14538d6e461 Author: Adam Dobrawy <ad-m@users.noreply.github.com> Date: Fri Aug 6 20:51:18 2021 +0200 Fix audience in AzureMetrics IngestMetrics (#15436) * Fix audience in AzureMetrics metrics * remove Go from auto codegen Co-authored-by: Joel Hendrix <jhendrix@microsoft.com> commit 4d61f9054ca7678ebf596e66c4f6300a21043970 Author: Taras Vozniuk <primary.taras.vozniuk@gmail.com> Date: Fri Aug 6 23:01:11 2021 +0800 [Hub Generated] Review request for Render to add version preview/2.1 (#15411) * render updates based on https://github.com/Azure/azure-rest-api-specs/pull/14625 * GetAttribution response codes * remove common error responses * go multiapi batch should include 2.0 * fix openapi 3.0 definition of file response, keep content-type * keep operationId between 2.0 and 2.1 * update samples and header response * exclude 2.0 from 2.1-preview tag, refs in 2.1 params, remove used Text param * refrain from changing 2.0 timestamp format * remove default in tileSize * remove redundant required: false * bump python package version * make sure there is no cross-client parameter references - move all shared into Common * remove non-supported application/xml MIME * use local apiversion param def commit 633cc8d82699e4fab31892d7c2e7ef5f7a131219 Author: Alan Po-Ching Yang <alankashiwa@gmail.com> Date: Fri Aug 6 22:57:58 2021 +0800 [Hub Generated] Review request for description changes under maps/data-plane/Route & Search (#15429) * Merge changes in PR:14813 * Merge changes in PR:14829 * Merge changes in PR:14965 Co-authored-by: Alan Yang <pochingyang@microsoft.com> commit 486665ff6938e2ada5af0f774711fa1b1ea41655 Author: nick-ms-ts <69840069+nick-ms-ts@users.noreply.github.com> Date: Fri Aug 6 15:33:31 2021 +0800 add outbound swagger change to synapse preview 2021-06-01 (#15549) commit dec9c6c39c2c24aa51a3f70c0b1133912653b180 Author: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com> Date: Fri Aug 6 12:56:15 2021 +0530 Updated documentation for 2021-04-01-preview version. (#15512) Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com> commit 5b09fc0fd671d7758c4581e330f7bb4d23aee6d4 Author: JiahuiPeng <46921893+804873052@users.noreply.github.com> Date: Fri Aug 6 15:11:23 2021 +0800 track2 add PostgreSQL in readme.go.md (#15552) * track2 add PostgreSQL in readme.go.md * fix * fix commit 9161ee6b26ff405ad94c150216615983a5327e53 Author: Bharath Kumar <85932838+Bharath550-ms@users.noreply.github.com> Date: Fri Aug 6 12:29:11 2021 +0530 Updated new Property for SparkConfig Properties in Spark Compute (#15474) * Updated new Property for SparkConfig Properties in Spark Compute Updated new Property for SparkConfig Properties in Spark Compute * Updated property name commit 987157f087b9dba696c53425e956ec61a9a48ea3 Author: Dongwei Wang <bean0idear@163.com> Date: Fri Aug 6 14:56:39 2021 +0800 [Synapse] - Update management Swagger spec config file (#15407) * [Synapse] - Update mgmt Swagger spec config file * Add an empty line Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> commit 129f4e52415548422041c42888c0f29037e0b275 Author: yanfa317 <53584318+yanfa317@users.noreply.github.com> Date: Thu Aug 5 23:49:08 2021 -0700 Remove discriminator from ActiveConfiguration and split activeconfiguraiton APIs to config level (#15282) * Add ResourceGuid to NetworkManager * add list by config * Revert "Add ResourceGuid to NetworkManager" This reverts commit 4e07577882e630ccbb5820bb2c397c5860394b65. * resourceGuid * [NetworkManager] Remove discriminator from ActiveConfiguration * revert change * fix format * Fix as commnets * fix test * Update Example * Split current APIs * Fix lintdiff * fix as commnets commit 8570821f7bf880af7132da01e881eb7ae98c2239 Author: JiahuiPeng <46921893+804873052@users.noreply.github.com> Date: Fri Aug 6 14:46:48 2021 +0800 track2 add azure cosmos db in readme.go.md (#15551) * track2 add azure cosmos db in readme.go.md * fix commit e05e9e32311195cec57f788ed21fa181b31f19c7 Author: Tim Nguyễn <33771623+tim-nguyen-cs@users.noreply.github.com> Date: Thu Aug 5 20:14:40 2021 -0700 removed un-servied top parameter (#15445) Co-authored-by: Tim Nguyen <you@example.com> commit 1ff7765fa023026eb615dc8fca74f7ebdc7cf23a Author: Peter Socha <psocha@users.noreply.github.com> Date: Thu Aug 5 19:06:54 2021 -0700 Improve Batch Account ListOutboundNetworkDependenciesEndpoints Swagger example (#15537) commit a331a455fd31e022f8df07105058ae586a02ab03 Author: orkayam <68549999+orkayam@users.noreply.github.com> Date: Thu Aug 5 10:10:00 2021 +0300 Microsoft.IoTSecurity: 2021-09-01-preview (#15491) * Initial Commit for Old Version * Add new API version * Update Operation Ids * Update tags * Update example names Co-authored-by: Orel Kayam <orkayam@microsoft.com> commit 102f4f621fcf4fdde8b6f3e0d5bddafb68cbe5a4 Author: Micah McKittrick <32313503+mimckitt@users.noreply.github.com> Date: Wed Aug 4 23:52:57 2021 -0700 Add Key Vault Extension changes (#15176) * Add Key Vault Extension changes * Update compute.json commit db37dbb98e65cafab6397ff3a33e5df3599bfbfe Author: alkigel <77278418+alkigel@users.noreply.github.com> Date: Thu Aug 5 04:24:32 2021 +0300 solving s360 issues in MarketplaceOrdering swagger (#15335) * solving s360 issues in MarketplaceOrdering swagger * Update Agreements.json * Update Agreements.json * Update Agreements.json * Update Agreements.json * Update Agreements.json * Update Agreements.json * Update Agreements.json * Update CancelMarketplaceTerms.json * Update GetAgreementMarketplaceTerms.json * Update GetMarketplaceTerms.json * Update SetMarketplaceTerms.json * Update SignMarketplaceTerms.json * Update SignMarketplaceTerms.json * Update SetMarketplaceTerms.json * Update GetMarketplaceTerms.json * Update GetAgreementMarketplaceTerms.json * Update ListMarketplaceTerms.json * Update Agreements.json * Update Agreements.json * Update readme.md * Update readme.md * Update readme.md commit 111fbceeeb7c2c4905b80fe2ab760e5564b3458a Author: kryalama <66494519+kryalama@users.noreply.github.com> Date: Wed Aug 4 16:37:16 2021 -0700 add aad authentication support (#14461) * update endpoint to v2.1 which supports AAD * add v2.1 changes under new folder v2.1 * CI issues * update swagger version commit 3d6211cf28f83236cdf78e7cfc50efd3fb7cba72 Author: Dongwei Wang <bean0idear@163.com> Date: Wed Aug 4 23:59:13 2021 +0800 [Synapse] - Exclude KQL Scripts APIs for August release (#15511) * [Synapse] - split kqlScripts * Run code style checker * Update artifacts * remove ksqlscriptname Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> commit e77ce605fc14239b071218d52a75e7c3fafee58e Author: srkakuru <50426366+srkakuru@users.noreply.github.com> Date: Tue Aug 3 22:51:33 2021 -0700 Add userAssignedIdentities property to the Identity section in 2021-05-01 and 2021-06-01-preview (#15296) commit e0a8cac0a598a364ce155d47065567dd020b1244 Author: Laura Galbraith <lagalbra@microsoft.com> Date: Tue Aug 3 22:14:43 2021 -0700 Microsoft.BareMetalInfrastructure: correctly annotate read-only properties with readOnly (#15255) * Microsoft.BareMetalInfrastructure: correctly annotate read-only properties with readOnly * Use multi-api and namespace formats for Go SDK like hanaonazure does commit 3bae02c450bf1ee6350a0c24d81923387bdafe57 Author: Amit Elran <amitelran2110@gmail.com> Date: Wed Aug 4 05:28:44 2021 +0300 KustoPool PATCH: Change async response from 201 to 202 according to ARM RPC (#15410) * Change PATCH async response from 201 to 202 according to ARM RPC * Add schema Co-authored-by: Amit Elran <amelran@microsoft.com> commit ee5b85ababb7053ec56da4062fa6a7977016fee6 Author: xunsun-commits <84804232+xunsun-commits@users.noreply.github.com> Date: Tue Aug 3 19:17:23 2021 -0700 Fix S360 bugs for swagger FSPG 2020-02-14-preview API (#15459) * added properties.minorVersion for 2020-02-14-preview API swagger and examples * add geoRedundantBackup and earliestRestoreDate * add geoRedundantBackup and earliestRestoreDate 2 * Updated MaintenanceWindow standbyCount logBackupStorageSku availabilityZone commit 709c6356bb862bbfbe887a57c8756453893f0256 Author: rewongmicrosoft <57964114+rewongmicrosoft@users.noreply.github.com> Date: Tue Aug 3 19:12:59 2021 -0700 updating error responses, adding x-ms-long-running-operation (#15368) commit c9795c7a0a21f3fecba2729a28f67fd5e3b2329e Author: hunngu-ms <63322431+hunngu-ms@users.noreply.github.com> Date: Tue Aug 3 18:47:16 2021 -0700 Add Threat Intellingence to Stable swagger (#14832) * Add Threat Intellingence to Stable swagger * Fix validation error for sharing parameters * Fix validation * Fix Validation * Fix CloudError in ThreatIntelligence to fix linted error * Resolve Conflict commit c981b81aa26ad4d0d156e034e6782853b4e747a1 Author: James Park <japark@microsoft.com> Date: Tue Aug 3 14:56:57 2021 -0700 [Maps] Update the Creator V1 API deprecation notice URL's title (#15480) * [Maps] Add Creator v1 deprecation notice. * [Maps] 'dataSharingLevel' is not available - remove text reference for UDI * Add missing notices * [Maps] Update the v1 creator service deprecation notice link * [Maps] Update Creator v1 deprecation notice's hyperlink title. commit a8719243647b7c6d06ed287483d788808de7ecab Author: orkayam <68549999+orkayam@users.noreply.github.com> Date: Tue Aug 3 11:26:31 2021 +0300 Deprecate API (#15434) Co-authored-by: Orel Kayam <orkayam@microsoft.com> commit cc4fb04edaf01ab0f44ac7a498bdd75a5f3f0627 Author: Kevin Mao <88005524+kevinmaoo@users.noreply.github.com> Date: Tue Aug 3 00:21:46 2021 -0700 Added defaults to EventGrid.json (#15395) commit bc4218cfb4178d8af43046080c0c86402d182c3f Author: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com> Date: Tue Aug 3 13:24:38 2021 +0800 Update web readme and readme.python (#15488) * Update web readme and readme.python * Update readme commit dce5e8df0b08c663487e038a9f585b41ddcecca5 Author: JiahuiPeng <46921893+804873052@users.noreply.github.com> Date: Tue Aug 3 12:32:25 2021 +0800 track2 modify redis readme.go.md (#15356) commit 3e2652d7b354690f729da56306e410b7179e683c Author: Guosen Wang <guoswang@microsoft.com> Date: Tue Aug 3 12:05:52 2021 +0800 Add isServerVersionAbove32 in CosmosDbMongoDbApi linked service (#15250) commit 5a26835f26fdb1ef29b1d1da6c51b10500f9de46 Author: navysingla <47647464+navysingla@users.noreply.github.com> Date: Mon Aug 2 20:36:29 2021 -0700 Alias description change (#15461) commit 6763962fa8ab3c7e1d73b5800cc0b45f35e4ef6a Author: moranraz <59017169+moranraz@users.noreply.github.com> Date: Tue Aug 3 05:31:47 2021 +0300 Feature/morazmiz/swagger separation fixes (#15295) * add missing types * change reference to resource and resourceWithEtag * extract userInfo to common file * . * add composite tag * add missing dataConnectorsCheckRequirements * add dataConnectorsCheckRequirements to readme * fix readme * . * fix errors in readme * add missing type * add missing types * . * . * remove changes with resource, resourceWithEtag, new tag * . * remove object * revert userInfo changes * fix true commit ca664ca4304f85d900dccba84195889b3db16fee Author: Phoenix He <tih@microsoft.com> Date: Tue Aug 3 10:22:07 2021 +0800 sync (#15470) commit 1ce325fa9c75897227a4dff2d3e016f1a9952802 Author: Teddy Todorov <thtodoro@microsoft.com> Date: Mon Aug 2 22:19:33 2021 -0400 add descriptions (#15487) commit c5b1c5bae99ce14287f5a4ff46e4cfefd490a512 Author: diwudd <wud@microsoft.com> Date: Mon Aug 2 18:42:37 2021 -0700 Microsoft.ProviderHub : Update 2021-06-01-preview (#15268) * adding 05-preview for diff * adding 06 preview * Add SystemData support in ProviderHub 2021-06-01-preview version * Tab to spaces + address comment * fixing validation errors * add properties back * Fix readme * Fix swagger * prettier check * Fix json Co-authored-by: Sanjai Ganesh Jeenagiri <sanjaiganesh@users.noreply.github.com> Co-authored-by: REDMOND\lakshv <lakshv@microsoft.com> Co-authored-by: shenshengkafei <wudiadi1111@gmail.com> commit 444ccbf2899c3f68b94d4300b2ec44bc82404e31 Author: Jorge Herrera <69991673+herreraj-ms@users.noreply.github.com> Date: Mon Aug 2 18:38:18 2021 -0700 Fix Microsoft.Insights go/terraform 'full' package (update activityLogAlerts_API.json) (#15163) * Fix go/terraform package * remove incompatible definitions * Force trigger checks * fix on go package-2021-07 * fix condition commit b186a5fcc952cf5e0a543554627b89f646d6c63c Author: travist13 <travist@microsoft.com> Date: Mon Aug 2 17:14:09 2021 -0700 AzsAdmin Compute: Fixing powershell generation errors (#15059) * Update to use unique resource names to avoid collisions; Add SubscriptionId to ScaleUnits route * Reverting use of common type apiversion to avoid breaking changes. * Moving ApiVersion back to use common type commit c25e3a8c81feb4e965d65e8584262fea42b5da0a Author: Tom Harvey <tombuildsstuff@users.noreply.github.com> Date: Tue Aug 3 01:54:13 2021 +0200 synapse: adding the configuration for the Go Data Plane SDK (#15263) commit 7a42f16c75e5005c59b75fe7f0888c1103294d43 Author: David Desberg <david.desberg@microsoft.com> Date: Mon Aug 2 16:43:44 2021 -0700 Fix missing data actions in 7.2-stable, 7.3-preview (#15254) commit 29ca2b61aeb5cb9d49218a412cb4e06a5243c749 Author: Maor Leger <maorleger@users.noreply.github.com> Date: Mon Aug 2 16:36:30 2021 -0700 KeyVault - /rng response should always return a value on success (#14982) * Make value required for RandomBytes response * format commit f5c2fa587b55809ff1b8f0633666638547c784dc Author: Taras Vozniuk <primary.taras.vozniuk@gmail.com> Date: Tue Aug 3 07:36:01 2021 +0800 [Hub Generated] add missing date-time format specifier across map clients for cleaner codegen with datetime types (#15454) * add missing format date-time across map clients * drop date-time format from quarter forecast date which comes with time but doesn't supply timezone info commit d638e0b8fccb54556796954c43ed2d8ddd192e28 Author: Sandip-Raiyani <sandipraiyani1993@gmail.com> Date: Mon Aug 2 16:31:08 2021 -0700 Delete specification/timeseriesinsights/data-plane/Microsoft.TimeSeriesInsights/preview directory (#15394) - Removing Azure Time Series Insights Preview API from docs as we have GA API since July 2021 and preview API will be depreciated. commit 37fabde7d6f545f2258df22b34f99941520403da Author: Heath Stewart <heaths@microsoft.com> Date: Mon Aug 2 14:22:00 2021 -0700 Remove heaths from Search codeowners (#15477) commit 14d41c657c0d2afe5646662579d31ab882443479 Author: ankanjan <58195759+ankanjan@users.noreply.github.com> Date: Mon Aug 2 11:04:46 2021 -0700 removing business rules(a feature for the future) which was added by … (#15399) * removing business rules(a feature for the future) which was added by mistake. * fixing style issues and a typo commit f528ab6315c8d4dd4c36f363851d491798a78146 Author: Kaiqi Zhang <kaiqzhan@gmail.com> Date: Mon Aug 2 04:40:52 2021 -0700 [AKS] Merge dev-containerservice-Microsoft.ContainerService-2021-07-01 to master (#15370) * Adds base for updating Microsoft.ContainerService from version stable/2021-05-01 to version 2021-07-01 * Updates readme * Updates API version in new specs and examples * Modify Swagger to fix the problem of automatically generating ugly names in track 2 (#14758) * update swagger to fix track 2 autogenerated naming issue * fix * update readme for sdk generation * fix lint error * Trigger Build * update readme * Improve AKS Swagger documentation (#14957) * Improve AKS Swagger documentation - This change has already been merged in master for the 2021-05-01 API version. * Fix up custom words * aks: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec (#15033) * fix: decouple pod identity provisioning error from cloud error * drop extra external mark * fix linting issue * fix reference * Dev containerservice microsoft.container service 2021 07 01: add SecurityProfile (#15035) * Add SecurityProfile to ManagedClusters * spaces * Space * spaces * json formatting * move from params to defs * :) * just another * now with npm * Descriptions update for AKS July API (#15074) * allow disabling of runcommand (#15092) * allow disabling of runcommand * format error * format with example * change enable to disable * Revert "allow disabling of runcommand (#15092)" (#15147) This reverts commit ec3e241a564d21f5ec914f4aa0b59a96ac7ec0d9. * [AKS] Add NATGatewayProfile to 2021-07-01 API (#15154) * [AKS] Add NATGatewayProfile to 2021-07-01 API * Fix linter errors Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> * Add scaleDownMode to agent pool properties (#15124) * add scale down mode * address comments * fix markdown link * update proper api version * Resolve python markdown conflict & fix typo (#15402) * resolve python conflict & fix typo * resolve conflict Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com> Co-authored-by: hbc <bcxxxxxx@gmail.com> Co-authored-by: Or Parnes <orparnes@gmail.com> Co-authored-by: Haitao Chen <haitch@users.noreply.github.com> Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> Co-authored-by: Marwan Ahmed <marwanad@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com> commit 7a2f1670064f9a293a758d24ca37353cabc2faf7 Author: Arcturus <dapzhang@microsoft.com> Date: Mon Aug 2 19:17:32 2021 +0800 Fix readme.go.md in compute RP (#14631) * add the missing $ * remove one useless directive * fix * remove the hack for track 2 and add comments for reasons * add one of the directive back to readme.go.md * add some comment to explain this more * fix commit 749d2b5158cfd186e6719a13c614e1993cccbf95 Author: Tom Harvey <tombuildsstuff@users.noreply.github.com> Date: Mon Aug 2 09:54:26 2021 +0200 signalr: adding the missing `Trace` value (#15455) Fixes #14923 commit 84d82e9a8f422a930f4e0ffbe037ae9dce5fce3f Author: Zed Lei <59104634+RAY-316@users.noreply.github.com> Date: Mon Aug 2 15:17:02 2021 +0800 Update readme.md (#15381) commit 1aabb7fe65620f03641e38e4ee832c154b1de92a Author: Zhenglai Zhang <darinzh@microsoft.com> Date: Mon Aug 2 14:52:01 2021 +0800 set default branch as main for pipeline (#15465) * set default branch as main * block pr to public spec repo commit 88e7838a09868a51de3894114355c75929847a46 Author: Arcturus <dapzhang@microsoft.com> Date: Mon Aug 2 12:00:38 2021 +0800 enable sdk automation (#15467) commit ecf0d999c9128ddfc1cac5ba52f57a5b00f94000 Author: Zed Lei <59104634+RAY-316@users.noreply.github.com> Date: Mon Aug 2 11:45:07 2021 +0800 Update readme.md (#15384) commit ade87243daf2fd3512875e4fb2dd2ebba0b1198c Author: TJ Egbejimba <toegbeji@microsoft.com> Date: Sun Aug 1 19:39:05 2021 -0700 Remove duplicate Operations API from subscriptions to prevent generation issues (#14853) * remove name validation from client side * remove name check from deploymentScripts swagger * remove name check from previous swagger versions * remove pattern from resourcegroupname parameter * add subscriptions directive * remove list operation from subscriptions API * Update readme.python.md * add suppresion for operations implementation Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> commit 81bfcf207b34d16da84547803cc8c06bce5f3f5f Author: JianyeXi <59603451+jianyexi@users.noreply.github.com> Date: Mon Aug 2 10:32:57 2021 +0800 update ci-fix (#14887) * update how to fix * fix comment * fix * up * fix typo * fix typo * modified: documentation/ci-fix.md Co-authored-by: jianyexi <jianyxi@microsoft.com> commit edf2ce9083c5f8337af2fcdc729c4b3ba84d2026 Author: Alfredo Santamaria <chino.sebastian@gmail.com> Date: Sun Aug 1 19:23:41 2021 -0700 Service Fabric Managed Clusters - API version 2021-07-01-preview (#15378) * initial commit - copy from 2021-05-01 * update to version 2021-07-01-preview * update examples * change node type sku list example name * missing type objects * more missing type objects * make skus path pagable Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com> commit d0924f1c217762779545299998e6d48a81715213 Author: andrew <69653137+greenms@users.noreply.github.com> Date: Sun Aug 1 18:52:58 2021 -0700 [Hub Generated] Review request for Microsoft.Cache to add version stable/2021-08-01 (#15417) * Adds base for updating Microsoft.Cache from version stable/2021-03-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * Breaking Change: Replaced 'sasUri' import parameter with 'sasUris' to enable importing from multiple files * Fix ModelValidation errors and some existing Linter errors commit 8f9abea46b6eb4e0d8f278bf9a6990a913a9934e Author: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com> Date: Mon Aug 2 04:25:20 2021 +0300 Extract OData parameters to Common types and use in newest versions (#15463) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> commit d2183715d380084ff04313a73c8803d042fe91b9 Author: Bertrand Le Roy <bertrandleroy@gmail.com> Date: Fri Jul 30 09:09:16 2021 -0700 Add annotation cache support (#15397) * Add annotation cache support * CR fixes commit 7360a2dd210efe1cd3351960e7a5ca391b702783 Author: nick-ms-ts <69840069+nick-ms-ts@users.noreply.github.com> Date: Fri Jul 30 15:52:04 2021 +0800 [DataFactory] Unify IR vNet injection experience (#14925) * add swagger change * cache change * update description * undo change on readme * add subnetId * add outbound * update description * style correction * fix example * Update int format * fix name unique issue * fix operation id name issue * fix underscore issue * fix example * rename * add change to preview versions * add subnetID * remove unnecessary change commit 70675cff9d38634512852106484d28b55c2a7432 Author: Daeun Yim <69321306+DaeunYim@users.noreply.github.com> Date: Fri Jul 30 00:50:29 2021 -0700 [PostgreSQL] Update Readme File to Support Non-Multi API (#15420) * fix readme file for multi api not supporting SDKs * fix typo commit cc8bda00a78706bb1007fa0044dd84d94d4ef3d7 Author: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com> Date: Fri Jul 30 15:07:56 2021 +0800 Update readme.python.md (#15449) * Update readme.python.md * Create readme.python.md commit 1d28da6ddb09d18ef055e36f57c781e0f76eb3ed Author: shahafal <darklos@gmail.com> Date: Fri Jul 30 07:47:08 2021 +0300 Add Security Settings new API version (#15093) * add settings for version 2021-07-01 * add tag package-2021-06-only Co-authored-by: Shahaf Alkaslassy <shahafal@microsoft.com> commit af06ae68df826e3d72da765366492b0ee6630dd0 Author: jimmyshie123 <xiezj123@outlook.com> Date: Thu Jul 29 22:49:36 2021 -0400 Emerging swagger kpi fix (#15270) * new coming swagger kpi * hierarchicalQueue fix * lint fix * remove hierarchical queue, add new object missing items * hierarchical queues Co-authored-by: Jimmy Xie <jimmyxie@microsoft.com> commit 5910fcb4cdda744e96b2cd357f29dbdaf71db849 Author: Zhenglai Zhang <darinzh@microsoft.com> Date: Fri Jul 30 10:49:26 2021 +0800 remove old spellcheck, prettier and networkvalidation pipeline tasks (#15404) commit 0c76462d6a083f2cb6484ae45696392e3eedec7d Author: aegal <aegal@outlook.com> Date: Thu Jul 29 19:37:27 2021 -0700 add back flatten flag for delegated subnet because its parameters are nested (#15262) * adding az cli command generation * reverting x-ms-client-flatten for delegated subnet * address feedback from cli team * pushing another change * remove readonly flag * remove flatten flag * remove list commands and correct extension mode * add back x-ms-client-flatten Co-authored-by: Ali Egal <alegal@microsoft.com> commit 12b33700f28ad519c3004ddbc7f29c16ef7aeb3c Author: Zed Lei <59104634+RAY-316@users.noreply.github.com> Date: Fri Jul 30 09:51:20 2021 +0800 Sql t1 del (#15431) * sql t2 readme config * readme config * Update readme.python.md * conflient resolve * del t1 Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> commit d81e31601e4bcc061ac6436de40d97b7db5e4dd3 Author: David Watrous <509299+dpwatrous@users.noreply.github.com> Date: Thu Jul 29 21:06:54 2021 -0400 [Batch] Make readme.md and swagger titles consistent (#15424) * [Batch] Changed "title" from BatchManagement to BatchManagementClient Autorest is using this to generate the name of the client class. Changing this will avoid a breaking change in the Java SDK that is about to be released. * Make readme.md titles consistent with swagger commit 74dbcfee45a6634d0043e478aba324796d98940c Author: Shubham Gupta <shugup@microsoft.com> Date: Thu Jul 29 01:50:48 2021 -0700 Exposing reviewers property on accessReviewInstance model (#14560) * Cloning version 2021-07-01-preview from version 2021-03-01-preview * Exposing reviewers properties on accessReviewInstance model * Fixing SDK validation warnings * Prettier check fixes commit b47572ab2069865484c493a4f679d4e72f8b303d Author: JiahuiPeng <46921893+804873052@users.noreply.github.com> Date: Thu Jul 29 16:45:52 2021 +0800 track1 add batch tag machine learning services in readme.go.md (#15432) * track1 add batch tag machine learning services in readme.go.md * fix commit 1267076f6a49f9eea0860e70e79f523d1085ed14 Author: zhaomuzhi <zhaoweixiong521@gmail.com> Date: Wed Jul 28 22:57:50 2021 -0700 [Ready for Review]New Azure Machine Learning api version 2021-07-01 (#15141) * Add Identity to createWorkpace example * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * revert change on transitivePE and notebookKeys * revert change on transitivePE and notebookKeys * add new stable version 2021-01-01 * add ListNotebookAccessToken * add primaryUserAssignedIdentity * fix missing properties and apis * fix one more missing property * 202 status for start and stop CI * make resync keys long runnin operation in version Jan2021 * resync keys 204 * update resync keys example * Dont throw 204 for resync * update resync keys * Formatting * revert Jan2021changes and add new version * start apr2021 version for azure ml rp * undo remove new line in jan2021 * use systemData definition in common * removed old files * fix small swagger bugs * run prettier * remove reference to sku * update readme * minimum agentCount should be 0 * add createdOn and ModifiedOn to compute properties * add LoadBalancerType to aks compute * add isNotebookInstanceCompute to virtualMachine * add leafDomainLabel to SslConfiguration * add overwriteExistingDomain to SslConfiguration * add synapseSpark as supported compute-type * update patch compute response to 202 * remove location from example responses * Revert "remove location from example responses" This reverts commit 048bf2551513afae842a9c4fbb5861aeddc6c33a. * MachineLearningCompute_Update should have a 200 response * sys data to use local def due to naming conflicts. * Fix enum casing * Fix operationId PR comment. * Change opId in apr version * remove 20210401 for easy review * only change api version * merge changes for 20210401 version * Add x-ms-discriminator-value for Synapse spark * camelcase loadbalancer properties * add createdOn and Modified on to examples * address AvoidAnonymousTypes error for SynapseSpark * Minor fixes + new property * Remove subscription state. * copy over from baseline api version 2021-03-01-preview * removed preview features from 2021-03-01-preview and added more apis and properties in 2021-07-01 * remove more preview features and examples * delete more examples of preview features * do some fixes * add a new enum value in DiagnoseResult * fix bug * update example * add x-ms-secret to some fields of KubernetesProperties * fix example * fix build error * add one new diagnosis category * fix swagger example * address comments on ListNodes api Co-authored-by: Vinay Rajmal Soni <vison@microsoft.com> Co-authored-by: Suba <sukaruna@microsoft.com> Co-authored-by: jopet@microsoft.com <jopet@microsoft.com> Co-authored-by: Josh Peterson <15050193+joshanator@users.noreply.github.com> Co-authored-by: Suba <sk.suba1@gmail.com> Co-authored-by: RichardZhaoW <39205025+RichardZhaoW@users.noreply.github.com> Co-authored-by: Richard Zhao <zhwei@microsoft.com> commit 038eccb4096daa059b0afa3f3cce301afe3fb776 Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Wed Jul 28 22:08:22 2021 -0700 Update PULL_REQUEST_TEMPLATE.md (#15267) Clean up grammar and clarify the ARM review process. commit 0eeefb8349b4faccd3ad2bf4a2ea50660eb38158 Author: Jack Ma <jackmagic313@gmail.com> Date: Wed Jul 28 21:49:20 2021 -0700 [DataFactory] Support cleanup property for integration runtime resource from DataFactory. (#15276) * add cleanup property on IR * revert synapse * fix description commit 444d527ca9ba163e65ad4ce9fc888a6f69940a4c Author: rickysun93 <rickysun93@outlook.com> Date: Thu Jul 29 11:44:57 2021 +0800 [Data Factory]Change additionalColumns/compressionType to type of object in ADF/Synapse public swagger (#15264) * Change additionalColumns/compressionType to type of object in ADF public swagger * upgrade synapse public swagger * upgrade synapse preview swagger Co-authored-by: Haoran Sun <haorsun@microsoft.com> commit 6db379d3aa60503efb5ff7670974d00db8c03ca2 Author: jmcallister-msft <77418352+jmcallister-msft@users.noreply.github.com> Date: Wed Jul 28 19:50:34 2021 -0700 [DataFactory] GitHub bring your own app swagger update for ADF/Synapse ARM only (#14690) * consolidate github byoa changes to one commit * consolidate BYOA commits to one * Revert "consolidate BYOA commits to one" This reverts commit 43cbce4deefa1aa11f86d052debdf615553f7a66. * remove duplicate client secret commit e27a46d0ab6a480f75da21d8d4fc99bf240b0755 Author: Arvind Krishnaa J <arv100.kri@gmail.com> Date: Thu Jul 29 02:35:20 2021 +0000 Fix typo for property name (#15380) Co-authored-by: Arvind Krishnaa Jagannathan <arjagann@microsoft.com> commit 4220a6a8e5ef756eedd095faaf133e7454bbb20e Author: JiahuiPeng <46921893+804873052@users.noreply.github.com> Date: Thu Jul 29 10:27:50 2021 +0800 track1 add batch tag to cost-management and storagecache in readme.go.md (#15430) commit a33fb4495e4c51cff80c76432bd5ea88e8088de9 Author: osmuller <61298360+osmuller@users.noreply.github.com> Date: Wed Jul 28 19:12:56 2021 -0700 [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#14945) * Adds base for updating Microsoft.KeyVault from version preview/2021-04-01-preview to version 2021-06-01-preview * Updates readme * Updates API version in new specs and examples * KeyVault - Add PublicNetworkAccess property to Vault resource KeyVault - Add PublicNetworkAccess property to Vault resource * Re add 'all' permissions * Revert the int64 change back to unixtime * Change * Fix lint * Add missing tag commit 002ad52075e725708deabf842a736c98751b8566 Author: mitagarg <mita.garg@hotmail.com> Date: Wed Jul 28 17:00:07 2021 -0700 [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 (#15325) * Adding payGPrice in Legacy and pricingModel in Modern * Modified the text for pricingModel Co-authored-by: Mita Garg <v-migarg@microsoft.com> commit 4345abfa4c9f4ea4b354b5ee0b0652150e6301e3 Author: smore <simore@microsoft.com> Date: Wed Jul 28 16:58:58 2021 -0700 add cname path and create new api version (#14409) * add cname path and create new api version * fix PR comment * remove storage account * use common types for Check Name Availability * Fix PR comment commit 7cc0a47e7808f3247c71cda25b7c1da8503272ba Author: Priyanka Jayaswal <priyankajayaswal025@gmail.com> Date: Thu Jul 29 00:06:07 2021 +0530 Updating extension id regex (#15152) commit 2b4fc08199d3789162b806c70eb25f09a40fc55c Author: rebecca337 <80353400+rebecca337@users.noreply.github.com> Date: Wed Jul 28 09:27:55 2021 -0400 [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2021-05-01 (#14545) * Adds base for updating Microsoft.StorageCache from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * 2021-05-01 API Changes * prettier fix * Lintdiff fix * Add create only fields * Create only tag for CacheIdentity * Create only tag for CacheIdentity * Remove create only for key rotation * Fix s360 errors * Fix read only * Revert package-lock.json * Revert package-lock.json commit eaae6d973b6d3bf57fc3228ad8f8a59ddebaec08 Author: Weidong Xu <weidxu@microsoft.com> Date: Wed Jul 28 15:23:06 2021 +0800 [ADF] Java Mgmt, discriminator property must be required (#15405) commit 70de9e4a7769183153878d38c89648b8f89be978 Author: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com> Date: Wed Jul 28 14:19:40 2021 +0800 Update pull_request_assignment.yml (#15403) commit 0b8ad3639180cfd04c880544275f18a6601c2226 Author: Alan Feng <DreamlessA@users.noreply.github.com> Date: Tue Jul 27 22:13:55 2021 -0700 Added and modified readme files for autorest.az to use for codegen (#14856) * added and modified readme files for autorest.az * removed autogen command groups * addressed PR comments commit 83c0c488dfe3f49d7c666511d5d6714ec6b4502f Author: agalerrotaru <86316103+agalerrotaru@users.noreply.github.com> Date: Tue Jul 27 22:31:06 2021 -0400 adding the changes again; trying to fix prettier errors (#15322) * adding the changes again; trying to fix prettier errors * fixing model validation errors * prettier error fix * fixed the last prettier errors: * reverted to original package-lock.json commit de77aca543997da8e6916681c9cf55d3a509f45e Author: Mike Pateras <35780775+paterasMSFT@users.noreply.github.com> Date: Tue Jul 27 22:18:18 2021 -0400 Fixed order (#15367) C# needs required fields to be before any optional fields. Because username and password are no longer required, autorest is ordering these parameters alphabetically. commit 0d5cc910289f3657c021c26db3de2b5c24cd3935 Author: Tim Nguyễn <33771623+tim-nguyen-cs@users.noreply.github.com> Date: Tue Jul 27 18:41:18 2021 -0700 fixed resources-list description typo (#15392) Co-authored-by: Tim Nguyen <you@example.com> commit 472ed65c628500835be420732be07728118d3563 Author: Mike Pateras <35780775+paterasMSFT@users.noreply.github.com> Date: Tue Jul 27 14:42:18 2021 -0400 Fixed breaking change due to order (#15371) commit 552b277f9f8d2057a94dfc9c3e09c0d877c0ea30 Author: tofriedl <50571149+tofriedl@users.noreply.github.com> Date: Tue Jul 27 11:44:33 2021 +0300 remove wrong read-only from RetentionInDays property (#15247) * remove readonly from RetentionInDays * fix * fix * fix commit 4cec1770664631fced06a1d83d79ebc3d2ca74db Author: Shashwat Aggarwal <shashwat.aggarwal@microsoft.com> Date: Tue Jul 27 13:44:16 2021 +0530 Adding readme.python.md configuration for Recovery Services - Site Recovery (#15383) * Add python sdk config * Python sdk generation readme commit 3efd9a9b9e3e829bb98e946816f71aec737287b6 Author: Xi Yang <81410773+yxi339@users.noreply.github.com> Date: Tue Jul 27 13:28:48 2021 +0800 [datafactory] add table lock and upsert properties (#14975) * add table lock and upsert properties * update naming * add description and properties for sqlSink commit e79143f9db659c61aa8be2099688ee9e285acd2e Author: MorBrisker <morbrisker@gmail.com> Date: Tue Jul 27 05:19:48 2021 +0300 Revert "Add assesments & assessment metadata new API versions (#15196)" (#15362) This reverts commit 44c5162667da54ee7bcaf3bd5beef9a9cc9ca198. commit ce0105332301d7eeee795634901bb62fc7f6903b Author: Zhenglai Zhang <darinzh@microsoft.com> Date: Tue Jul 27 10:15:14 2021 +0800 Revert "chore: Add dependabot for NPM dependency updates (#12602)" (#15359) This reverts commit 78ca03c592dd8beb3063de254c407cdf0751fbec. commit bea659d448f0195819a326dfefa5a2364ac0171b Author: Abigail Hartman <Abigail.Hahn@microsoft.com> Date: Mon Jul 26 12:09:31 2021 -0700 Text Analytics v3.2 preview.1 (#15159) * Moved files from another branch * Responding to PR comments from an old PR * Updated version in example files * Added v3.2-preview.1 to releases in readme.md * Fixed enum mismatch in model validation' * Ran prettier on all json files * Updated case of rank and offset enum values * Updated case of rank and offset enum values * PR comments * Added another missing type * Reverted an unintentional change Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com> commit e3dbb827d99eaadf132075707373f6b4bda08fd9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jul 26 15:07:55 2021 +0800 Bump @types/mocha from 5.2.7 to 9.0.0 (#15342) Bumps [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mocha) from 5.2.7 to 9.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mocha) --- updated-dependencies: - dependency-name: "@types/mocha" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 8d2e8837bf8d9e0b86ceb5faa5bba09ffbdda595 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jul 26 15:06:48 2021 +0800 Bump ts-node from 8.3.0 to 10.1.0 (#15341) Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 8.3.0 to 10.1.0. - [Release notes](https://github.com/TypeStrong/ts-node/releases) - [Commits](https://github.com/TypeStrong/ts-node/compare/v8.3.0...v10.1.0) --- updated-dependencies: - dependency-name: ts-node dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 69c20e89a4f94f99cdbc627f5c33812732b2fa32 Author: Pratima Upadhyay <pratima.upadhyay02@gmail.com> Date: Mon Jul 26 11:18:49 2021 +0530 Changing version back to 2021-06 (#15305) * Updating version in readme * Updating swagger version commit 78ca03c592dd8beb3063de254c407cdf0751fbec Author: Nick Schonning <nschonni@gmail.com> Date: Mon Jul 26 01:25:32 2021 -0400 chore: Add dependabot for NPM dependency updates (#12602) commit 949ff43c349ae94aec6cd972eb005ab3f65e6ffc Author: Jie Shen <drfish.me@gmail.com> Date: Mon Jul 26 12:28:21 2021 +0800 Fix swagger correctness for appplatform 2021-06-01-preview (#15031) commit 8c8839fc9905c2e9f31f55a7a13ca0594c16af7b Author: Zed Lei <59104634+RAY-316@users.noreply.github.com> Date: Mon Jul 26 12:10:24 2021 +0800 redis t1 del (#15340) commit cc5b287c6aa04ffc5e27f994c2371b9df1d0c257 Author: Kyle Rush <kyrush@microsoft.com> Date: Sun Jul 25 19:59:36 2021 -0700 Time Series Insights - add 2021-06-30-preview API version, and supportsCustomerManagedKey output property (#15274) * Adds base for updating Microsoft.TimeSeriesInsights from version stable/2020-05-15 to version 2021-06-30-preview * Updates readme * Updates API version in new specs and examples * Add supportsCustomerManagedKey to env response definition, examples commit 61d502e5e4c1c3d592f85afffe637f11204a778a Author: tim-nguyen-cs <33771623+tim-nguyen-cs@users.noreply.github.com> Date: Sun Jul 25 19:58:32 2021 -0700 [Hub Generated] Review request for Microsoft.Resources to add version stable/2021-04-01 (#15297) * updated list-resources description * published validation changes Co-authored-by: Tim Nguyen <you@example.com> commit 44c5162667da54ee7bcaf3bd5beef9a9cc9ca198 Author: MorBrisker <morbrisker@gmail.com> Date: Mon Jul 26 05:02:17 2021 +0300 Add assesments & assessment metadata new API versions (#15196) * DuplicateAssessmentsFiles * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Update assessmentMetadata.json * Update CreateAssessmentsMetadata_subscription_example.json * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion * Add2021-06-01AsessmentsAPIVersion Co-authored-by: MIDDLEEAST\morbrisker <morbrisker@microsoft.com> commit 1a70101c76b8491d840ea8d7712a477b819bb0f9 Author: PingZhu2232 <36140352+PingZhu2232@users.noreply.github.com> Date: Sun Jul 25 18:59:32 2021 -0700 Adding 06-15 version (#15320) * copy latest version * change versions * identity changes related MSI * readme changes * readme go changes * sdk fix * changed modelAsString to true, supported identity in PATCH Co-authored-by: Ping Zhu <pizh@Pings-MacBook-Pro.local> commit cb405da5485f0d0f78ee27339722d5faca39f637 Author: Tom Harvey <tombuildsstuff@users.noreply.github.com> Date: Fri Jul 23 18:36:59 2021 +0200 search: adding the autorest files necessary to generate a Data Plane SDK (#15316) commit 7b8b9ebbf8593580ed710329c61dee1936062cbb Author: JiahuiPeng <46921893+804873052@users.noreply.github.com> Date: Fri Jul 23 16:33:42 2021 +0800 Track2 modify sql readme.go.md (#15314) * servicebus readme.go.md * track2 modify sql readme.go.md commit 45080747a094f6a64968b6f93aa1f9a7233a63ae Author: vipinhas <82088177+vipinhas@users.noreply.github.com> Date: Fri Jul 23 10:04:29 2021 +0300 Vipinhas/add min capacity clusters (#15290) * removing read only property, no longer in use - NOT a breaking change * add min value for LA cluster capacity reservation commit 9e9017617ee84fd46b0be3fe6a431e13bde18bd2 Author: Prachetos Sadhukhan <Prachetos.Sadhukhan@microsoft.com> Date: Fri Jul 23 11:37:40 2021 +0530 Added custom resource naming changes for HyperV, InMageAzureV2 providers (#15199) commit fafa5991a1727ab399bdf4cd349d53443486778e Author: David Watrous <509299+dpwatrous@users.noreply.github.com> Date: Fri Jul 23 01:42:06 2021 -0400 Update CODEOWNERS (#15244) commit b20011746ef065a8ab6572045de9578c192f2ffd Author: Shashwat Aggarwal <shashwat.aggarwal@microsoft.com> Date: Fri Jul 23 07:12:28 2021 +0530 New Version 2021-06-01 for Azure Site Recovery. (#14794) * New Api Version 2021-06-01 for ASR * V2A RCM new API version changes * SDK2Track fix * few contracts for rcm failback * Update service.json Fixed index * Prettier-fix Co-authored-by: prmyaka <prmyaka@microsoft.com> commit 87e2c65e4133115b0207a4f0d023acfb87ca5e95 Author: basharg <basharg@microsoft.com> Date: Thu Jul 22 17:55:28 2021 -0700 Update documentation text for the zoneBalance property (#15231) * Fix public IP sku name and Tier property names * remove required property to match NRP swagger spec * update example file * update zoneBalance help message Co-authored-by: Bashar Gharaibeh <basharghar@live.com> commit a9c6da300bd6f71155fcd724a8d238ea84a118d1 Author: LU WU <laurawu19@gmail.com> Date: Thu Jul 22 17:55:01 2021 -0700 Add missing examples for disk.json (#15309) * Add missing examples for disk.json * Update UpdateASnapshot.json commit 23ff943dbe3b5ccdc63a6195daa0f30b17ed9d88 Author: James Park <japark@microsoft.com> Date: Thu Jul 22 09:34:38 2021 -0700 [Maps] Update the Creator V1 API deprecation notice URL (#15302) * [Maps] Add Creator v1 deprecation notice. * [Maps] 'dataSharingLevel' is not available - remove text reference for UDI * Add missing notices * [Maps] Update the v1 creator service deprecation notice link commit ed3fcfb33e8ecae0717bee53046677bd2f3c16ad Author: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com> Date: Thu Jul 22 19:45:14 2021 +0800 Revert "[Hub Generated] Review request for Microsoft.Security to add version preview/2021-07-01-preview (#15212)" (#15303) This reverts commit 463d63186066d7faeb1f74eda7fd380fa3cf9cf8. commit 463d63186066d7faeb1f74eda7fd380fa3cf9cf8 Author: Sapir Elmakayes <32778998+SapirElmakayes@users.noreply.github.com> Date: Thu Jul 22 11:33:39 2021 +0300 [Hub Generated] Review request for Microsoft.Security to add version preview/2021-07-01-preview (#15212) * Adds base for updating Microsoft.Security from version preview/2021-05-01-preview to version 2021-07-01-preview * Updates readme * Updates API version in new specs and examples * Create Multi cloud API * Minor typo fix * Schema change (offering type) * Change array to object in the examples * Rename to Security Connector * Fix files name errors * Remove softwareInventories (auto generated) * Update examples and naming * Update the enum type to string * Adds suppression to readme * Rever the readme.md basic information * Fix SecurityConnetor defenition link * Policy description update * Prettier file * Rename the minitor offering type * Fix typo in the put example * Fix conflict * Add CSPM as custom word * prettier files * Fix lint error - adding 200OK for delete * Update readme.md Add JAVA to swagger-to-sdk * Update the preview tag location * Rename the resource to SecurityConnectors Co-authored-by: Sapir Elmakayes <saelmaka@microsoft.com> commit 4272591f9214235c325d8e49ff3eedc7cd022f6a Author: Alfredo Santamaria <chino.sebastian@gmail.com> Date: Wed Jul 21 21:52:55 2021 -0700 Service Fabric - Add missing property recreateApplication to ApplicationUpgradePolicy (#15128) * add missing property recreateApplication * add recreateApplication to all missing api versions * fix issue with cluster difinition AvoidAnonymousTypes * ClusterVersions add default response * add integer format * more integer formats * add type object * more type object * more type object * more type object * more type object 3 Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com> commit 05f0decc3a8562377693501fed5310aad2a55e74 Author: swagat mishra <swagatmishra2007@gmail.com> Date: Wed Jul 21 21:47:35 2021 -0700 [Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview (#15182) * initial actual changes * added example * corrected mistake in previous contract * fix prettier changes * fix model validation errors * fix readonly * fix prettier issue Co-authored-by: Swagat Mishra <swagatm@microsoft.com> commit e9a6009d8f1a98656cf5b6f1fe5809251bfa0085 Author: 804873052 <46921893+804873052@users.noreply.github.com> Date: Thu Jul 22 11:23:30 2021 +0800 Add batch tag to compute and containerinstance in readme.go.md (#15299) * servicebus readme.go.md * Go SDK Release Request,compute and containerinstance the readme.go.md add batch tag commit 2a6c840524573116aa549a3733fa2243baa4da3f Author: Dustin Burson <47367432+dustinburson@users.noreply.github.com> Date: Wed Jul 21 20:00:25 2021 -0700 Dev healthcareapis microsoft.healthcare apis 2021 06 01 preview changes (#15166) * Adds base for updating Microsoft.HealthcareApis from version stable/2021-01-11 to version 2021-06-01-preview * Updates readme * Updates API version in new specs and examples * Initial 2021-06-01-preview API * Address linter and avocado errors * Add DICOM to custom words list. * Add additional missing custom words * Fix prettier errors * Address additional linter error Address incorrect param name on FHIR Destination examples * Add missing fhirdestination to custom words list * Fix invalid parameter name * Fix IoT FHIR Destination examples * Fix incorrect path variable in swagger * Fix missing iotFhirDestination in Create example * Fix prettier errors * Update readme default version back to GAed version * Remove body from delete methods of all new resource types per PR feedback * * Remove 202's from PUTs on new resource types * Add missing resource states * Replace ACR with Azure container repository in property descriptions for clarity * Fix model as string being false for fhirServiceKind. * Fix prettier error commit 56444d66e9733afaabc00d5f979dce1c837a61cd Author: tezhangmsvan <51929944+tezhangmsvan@users.noreply.github.com> Date: Wed Jul 21 19:09:19 2021 -0700 [Hub Generated] Review request for Microsoft.DBforPostgreSQL to add version preview/2020-11-05-preview (#13555) * Add files via upload * Update Migrations.json * 2 files * to json * Json resolved. Fixed most issues aware to be ARM conformant * Delete Migrations_openapi.json * Delete Migrations.json * Add files via upload * Update readme.md * Update readme.md * Update readme.md * Create custom-words.txt * Update Migrations.json * Add DMSDB in custom-words.txt * Delete custom-words.txt * Update custom-words.txt * remove sku * Update custom-words.txt * add DMSDB * Update Migrations.json * Update Migrations.json * Update Migrations.json * Add clouderror * Update Migrations.json * Update Migrations.json * Update Migrations.json * Update Migrations.json * Update Migrations.json * Update Migrations.json * Update Migrations.json * Update Migrations.json * Update Migrations.json * Update Migrations.json * Update Migrations.json * remove sku * use same sku from postgresql.json * Put target state -> Post * revert to put * refactor * Dummy example and typo * remame typo * examples and summarylistresult * Update Migrations.json * Update Migrations.json * x-ms-client-flatten * x-ms-enum modelasstring * properties * array * array prettier * password null * array in create * Add description to all * MigrationCreateFullRequest allof MigrationCreateRequest * Update Migrations.json * Update Migrations.json * allof * flatten * validate examples * misc * gen examples * https://github.com/Azure/azure-rest-api-specs/pull/13555/checks?check_run_id=2506679669 * update read -> get * 201 created * Unify three resources * for credscan * newline at end of file * prettier playground * npx prettier --write "specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2020-11-05-preview/Migrations.json" * array format * update examples * partial resolve * partial resolve * readonly and x-ms-mutability * add new version json files * Update readme.md * update * v2 * Update Migrations.json * api version and operations * Update Migrations.json * pretty * properties for patch * nameavialability * migration name availability * reason * add migration name * , * merge * update * merge * change version * autorest --validation --azure-validator --use=@microsoft.azure/classic-openapi-validator@latest --use=@microsoft.azure/openapi-validator@latest --tag=package-2021-06-15-privatepreview * merge * update * update * update * new version postgresql.json * update * prettier * systemdata * update * type object * update remove locatiion from rg update error response * unify error response version * Cloud error already confroms. API update remove location move targetDBServerSubnetResourceId add userAssignedIdentityResourceId * update properties for patch and fix prettier * update * Service error * type; object, duplicate version * pretty and unused example * remove privatezone * remvoe db * Sql -> SQL * casing Co-authored-by: tezhang <tezhang@microsoft.com> commit 8eb10b6052b7073e9c56f7707772e3e01c9d9a8d Author: Pratima Upadhyay <pratima.upadhyay02@gmail.com> Date: Thu Jul 22 07:31:07 2021 +0530 Updating version in readme (#15285) commit 74efe54fbc55c91a1d9213afbb2723747acfddf9 Author: jochav <75458295+jochav@users.noreply.github.com> Date: Wed Jul 21 21:19:25 2021 -0400 Updating Query filter description (#15291) Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com> commit c671429a9d07e6c74ea0bf11adc3cc544964a358 Author: Raj Shah <rajmshah93@gmail.com> Date: Wed Jul 21 18:15:32 2021 -0700 Fix Swagger Correctness Issues (#15185) commit 7a4a64310bec1f7f59bbdd8e8ab04ca938cbc3e6 Author: annoakes <45375852+annoakes@users.noreply.github.com> Date: Wed Jul 21 09:33:40 2021 -0700 Purview Account data-plane Swagger (#15216) * Bootstrap Purview Account data-plane Swagger * Update most recent swagger * Fix spelling and examples that got dropped * Update readme * Fix swagger validation errors commit f2553893baa03c3db9a9b7974e1845908805bd5f Author: msyyc <70930885+msyyc@users.noreply.github.com> Date: Wed Jul 21 19:41:26 2021 +0800 Update readme.python.md (#15288) commit 81c815da8d9d4689ffcc8b411548432c42eaea2b Author: 804873052 <46921893+804873052@users.noreply.github.com> Date: Wed Jul 21 17:26:47 2021 +0800 servicebus readme.go.md (#15287) commit 2a8442856438f3c78b7150f4a32270c03fc99d43 Author: Zed Lei <59104634+RAY-316@users.noreply.github.com> Date: Wed Jul 21 15:14:35 2021 +0800 Containerregistry maps datamigration t1 del (#15284) * sql t2 readme config * readme config * Update readme.python.md * conflient resolve * t1 del Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> commit 31788d78903023976ef843501761ede7d74493d2 Author: Kiran Kulkarni <kirankulkarni747@users.noreply.github.com> Date: Wed Jul 21 00:04:56 2021 -0700 [Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview (#15239) * Add "msaAppTenantId", "msaAppType" and "msaAppMSIResourceId" properties. * Address ARM feedback to set modelAsString as true. commit 761b1977490402b15062af591dfe4dbb3c0bfb76 Author: Edwin Bwambale <12407430+bwamie@users.noreply.github.com> Date: Wed Jul 21 00:02:26 2021 -0700 [Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview (#15144) * Add disable/enable local authentication ARM property * Update property description * add slack permission scopes * Prettify JSON * Make File Pretty Co-authored-by: Edwin Bwambale <edwinb@microsoft.com> Co-authored-by: Tianyu You <youtianyu2010@gmail.com> commit c2ec03e5faa411e9a6785c15c3ddbd812e67ba7b Author: giakas <giakas@microsoft.com> Date: Tue Jul 20 23:11:36 2021 -0700 Fix descriptions for encoding types (#15281) commit dc90355ba177c3412bdb5b5569595834e1da33a4 Author: msyyc <70930885+msyyc@users.noreply.github.com> Date: Wed Jul 21 10:30:27 2021 +0800 [blueprint]python track2 configuration (#15278) * Update readme.python.md * Update readme.md * Update readme.python.md commit 528e36c9d7e23151db99188cac5df7fed19705a6 Author: shdesmu <56369302+shdesmu@users.noreply.github.com> Date: Tue Jul 20 18:31:14 2021 -0700 [Hub Generated] Public private branch 'shdeshmu/updateExistingAPIVersion' (#15261) * Updated existing properties in current APIVersions * pretier check commit 84daa99e7c8aca2ebb535d84700a0e61a3aca05f Author: Teddy Todorov <thtodoro@microsoft.com> Date: Tue Jul 20 20:54:42 2021 -0400 Add Good/Bad edge case examples to R3016 (#15043) From https://docs.microsoft.com/en-us/previous-versions/dotnet/netframework-1.1/141e06ef(v=vs.71)?redirectedfrom=MSDN: > When using acronyms, use Pascal case or camel case for acronyms more than two characters long and > However, you should capitalize acronyms that consist of only two characters, such as System.IO instead of System.Io. commit 2fb369beac2e348015d01d702215c0f07e9b442c Author: xunsun-commits <84804232+xunsun-commits@users.noreply.github.com> Date: Tue Jul 20 17:43:34 2021 -0700 Remove Server.identity from FSPG GA API (#15204) commit 63f4a94d3996dbe1911d7de70a004be7ff4dc169 Author: Michael Greene <mgreenegit@users.noreply.github.com> Date: Tue Jul 20 19:17:42 2021 -0500 remove properties that are not writeable from examples (#15241) commit d241e05b224891ddc0147544213d8edccf53f7d9 Author: Terence Fan <stdrickforce@gmail.com> Date: Wed Jul 21 00:38:04 2021 +0800 [WebPubSub] New api for generating token (#15137) * init * update commit f0cf72baa1627bddf8583d5d08e02ccb8319cfb0 Author: Karthik RG <karrg@microsoft.com> Date: Tue Jul 20 22:04:11 2021 +0530 Updating swagger for June (#14821) * v1 of updated swagger * Adding examples for farm operations * Spell check + prettier check * Spelling fix * Fixing model validation * Model validation fix * Removing additional propoerties * Removing additional propoerties * Prettier fix * Doc bash bgs v1 * Adding updated examples * Prettier fix * Prettier fix * Fixing model validation errors * Fixing examples formodel validation * Fixing Lintdiff errors * agfood to agrifood * Agfood to agrifood * Reverting change from agrifood to agfood * Udpates * Updates * Update package.json commit 2a89fd49dfef5f02b83fe5018e87bd9ebe195c8e Author: Filip Proborszcz <v-filipp@microsoft.com> Date: Tue Jul 20 17:55:10 2021 +0200 [Maps] Add separate Swagger definitions for Maps client libraries (#14871) * Make maps data-plane swagger files compile when taken from api to sdk. * Update correctly the search api * Update common.js and add swagger codegen to maps dataplane. * Fix path issue * fix prettifier error. * Replace mistyped extension. * Fix common type version. * Fix errors for alias.json * run prettier * fix security def and parameters. * Revert "fix security def and parameters." This reverts commit 85370d9b6b3ad0ae615d1931aa7a5eec39957b30. * Revert "run prettier" This reverts commit be16d4423be319cc4b7a957abe977aced26e0fa5. * Revert "Fix errors for alias.json" This reverts commit 0458cbc9489ba8cc05a575517b35001fa4c4a7e8. * fix extension issue * comment out all other errors. * revert changes to package.json files * update files. remove common response as it isn't supported. * update readonly problem * Update error correctly to not be a breaking change * Remove unused definition. * Fix GeoJSONGeometryCollection * Fix naming scheme * fix coord abb * fix geometryCollection error by using a more generic type for inheritance. * update anon def * try without schema * fix naming issue. * add schema * try again * update common file * update route.json file * Revert "update route.json file" This reverts commit 2858248ea19ece1998617afbb83c1b6633487834. * Update geometry collection. * fix go modeler error * remove type * - fix ModelValidation * - enable Java and Python generation * try with new errorDetail. * correct paths * revert changes to odataerror. update python sdk. * fix typo * update error and readonly CoordinateAbbreviated to reuse more. * - try to build Python SDK * - try to forcefully build Python SDK * Add top level java. * update warnings from lint diff * try java generation with the inline file. * update Java compilation with right tags. * Fix compilation warnings * Update readme namespace names * Make enums be modelAsString: true * Add x-ms-error-response to error responses * Remove feedback.json and feedback reference from readme.md. * Fix "security" requirement object to have valid scope for OAuth2 security scheme type * Fix "security" requirement object to have valid scope for OAuth2 security scheme type - add missing file * Use common client parameters - part 1 * Use common client parameters - part 2 * Fix lint errors * update go namespace to the correct one. * Use common response objects to fix duplicate schemas * Fix semantic & model validation W/A for OAV as it is not able to parse Swagger file without "responses" object. * Fix autorest duplicate schema warnings Use common schema for Language, View, xTileIndex & yTileIndex between Render 1.0, Render 2.0, Search 1.0 and Traffic 1.0. * Fix C# generation of StyleRuleBaseType enum type * Fix license header for GO lang * Fix inheritance of the StyleRuleBase type in the Featu…

Add disable/enable local authentication ARM property

c965d58

openapi-pipeline-app bot added the NewApiVersionRequired label Jul 9, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Jul 9, 2021

bwamie marked this pull request as ready for review July 9, 2021 21:39

openapi-assignment-bot bot assigned PhoenixHe-NV Jul 9, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Jul 9, 2021

bwamie requested a review from swagatmishra2007 July 9, 2021 21:40

swagatmishra2007 reviewed Jul 12, 2021

View reviewed changes

.../botservice/resource-manager/Microsoft.BotService/preview/2021-05-01-preview/botservice.json Outdated Show resolved Hide resolved

swagatmishra2007 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 12, 2021

Update property description

a5a2dd8

mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 13, 2021

youyu16 and others added 2 commits July 13, 2021 17:57

add slack permission scopes

570cc18

Merge pull request #1 from youyu16/youyu16-slack-permissionscopes

5dec1be

add slack permission scopes field

bwamie added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jul 15, 2021

bwamie added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 15, 2021

mentat9 reviewed Jul 15, 2021

View reviewed changes

mentat9 removed the NewApiVersionRequired label Jul 15, 2021

openapi-pipeline-app bot added the NewApiVersionRequired label Jul 15, 2021

PhoenixHe-NV added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 20, 2021

edwin4microsoft added 3 commits July 20, 2021 14:21

Prettify JSON

a0f43e4

Merge branch 'edwin-botservice-Microsoft.BotService-2021-05-01-previe…

b0369c2

…w' of https://github.com/bwamie/azure-rest-api-specs into edwin-botservice-Microsoft.BotService-2021-05-01-preview

Make File Pretty

652439e

PhoenixHe-NV approved these changes Jul 21, 2021

View reviewed changes

PhoenixHe-NV merged commit 761b197 into Azure:master Jul 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview #15144

[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview #15144

bwamie commented Jul 9, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jul 9, 2021

openapi-pipeline-app bot commented Jul 9, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jul 9, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jul 9, 2021

openapi-workflow-bot bot commented Jul 9, 2021

swagatmishra2007 commented Jul 12, 2021

mentat9 commented Jul 13, 2021

mentat9 commented Jul 14, 2021 •

edited

Loading

bwamie commented Jul 15, 2021

mentat9 Jul 15, 2021 •

edited

Loading

bwamie Jul 15, 2021

bwamie Jul 15, 2021

mentat9 Jul 15, 2021

bwamie Jul 15, 2021

youyu16 Jul 15, 2021 •

edited

Loading

mentat9 Jul 16, 2021

mentat9 commented Jul 15, 2021

mentat9 commented Jul 15, 2021 •

edited

Loading

PhoenixHe-NV commented Jul 20, 2021

azure-pipelines bot commented Jul 20, 2021

PhoenixHe-NV commented Jul 20, 2021

bwamie commented Jul 20, 2021

[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview #15144

[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview #15144

Conversation

bwamie commented Jul 9, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jul 9, 2021

openapi-pipeline-app bot commented Jul 9, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jul 9, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jul 9, 2021

openapi-workflow-bot bot commented Jul 9, 2021

swagatmishra2007 commented Jul 12, 2021

mentat9 commented Jul 13, 2021

mentat9 commented Jul 14, 2021 • edited Loading

bwamie commented Jul 15, 2021

mentat9 Jul 15, 2021 • edited Loading

Choose a reason for hiding this comment

bwamie Jul 15, 2021

Choose a reason for hiding this comment

bwamie Jul 15, 2021

Choose a reason for hiding this comment

mentat9 Jul 15, 2021

Choose a reason for hiding this comment

bwamie Jul 15, 2021

Choose a reason for hiding this comment

youyu16 Jul 15, 2021 • edited Loading

Choose a reason for hiding this comment

mentat9 Jul 16, 2021

Choose a reason for hiding this comment

mentat9 commented Jul 15, 2021

mentat9 commented Jul 15, 2021 • edited Loading

PhoenixHe-NV commented Jul 20, 2021

azure-pipelines bot commented Jul 20, 2021

PhoenixHe-NV commented Jul 20, 2021

bwamie commented Jul 20, 2021

bwamie commented Jul 9, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jul 9, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jul 9, 2021 •

edited

Loading

mentat9 commented Jul 14, 2021 •

edited

Loading

mentat9 Jul 15, 2021 •

edited

Loading

youyu16 Jul 15, 2021 •

edited

Loading

mentat9 commented Jul 15, 2021 •

edited

Loading