HanaOnAzure: correctly annotate read-only properties with readOnly #15205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @lagalbra Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The integer type does not have a format, please add it. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L934 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L490 |
|
The schema 'HanaInstancesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L522 |
|
The schema 'HanaInstance' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L538 |
|
The schema 'HanaInstanceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L553 |
|
The schema 'HardwareProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L628 |
|
The schema 'Disk' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L700 |
|
The schema 'StorageProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L747 |
|
The schema 'OSProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L771 |
|
The schema 'NetworkProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L794 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"hanaonazure/resource-manager/readme.md",
"tag":"package-2017-11",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"hanaonazure/resource-manager/readme.md",
"tag":"package-2017-11",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"hanaonazure/resource-manager/readme.md",
"tag":"package-2017-11",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @lagalbra, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @lagalbra, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jul 14, 2021
This was referenced Jul 14, 2021
Swagger Generation Artifacts
|
|
@chunyu3 This is being done to satisfy a GA requirement: https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi019-annotate-read-only-properties-with-readonly-true - see https://msazure.visualstudio.com/One/_workitems/edit/10364134 |
|
Looks Good. |
octavianhornoiu
approved these changes
Jul 15, 2021
JeffreyRichter
added
the
Approved-BreakingChange
|
@ArcturusZhang would you please take a look at the go-sdk breaking change? thanks |
ArcturusZhang
added
the
Approved-SdkBreakingChange-Go
This was referenced Jul 20, 2021
This was referenced Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Change: This is being done to satisfy a GA requirement: https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi019-annotate-read-only-properties-with-readonly-true
Changelog
Please ensure to add changelog with this PR by answering the following questions.
N/A - the behavior is already running
ASAP, because the service is already running as such
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.