Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isServerVersionAbove32 in CosmosDbMongoDbApi linked service #15250

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Add isServerVersionAbove32 in CosmosDbMongoDbApi linked service #15250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...y/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2303,6 +2303,10 @@
"CosmosDbMongoDbApiLinkedServiceTypeProperties": {
"description": "CosmosDB (MongoDB API) linked service properties.",
"properties": {
"isServerVersionAbove32": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isServerVersionAbove32

Can we have a property like serviceVersion instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j5lim In our scenario, only version 3.2 is special, we no need to know the exact server version. If we change it to serverVersion, customer need to select one from a list, which is a more complicated user experience.
And the property name is already used in our backend and UI, I cannot change it easily.

"type": "object",
leni-msft marked this conversation as resolved.
Show resolved Hide resolved
"description": "Whether the CosmosDB (MongoDB API) server version is higher than 3.2. The default value is false. Type: boolean (or Expression with resultType boolean)."
},
"connectionString": {
"description": "The CosmosDB (MongoDB API) connection string. Type: string, SecureString or AzureKeyVaultSecretReference. Type: string, SecureString or AzureKeyVaultSecretReference.",
"type": "object"
Expand Down