-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synapse workspace]Support cleanup property for integration runtime resource of Synapse workspace. #15279
Conversation
Hi, @jackmagic313 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: synapse/common/v1/privateEndpointConnection.json#L326 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: synapse/common/v1/privateEndpointConnection.json#L326 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'BigDataPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L25 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'IpFirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/firewallRule.json#L203 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'IntegrationRuntimes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L85 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'Keys_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/keys.json#L75 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'Library_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/library.json#L25 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privateEndpointConnections.json#L46 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privateLinkResources.json#L75 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'PrivateLinkHubPrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privateLinkResources.json#L175 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'PrivateLinkHubs_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privatelinkhub.json#L86 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L25 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolMetadataSyncConfigs_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L520 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolGeoBackupPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L851 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolDataWarehouseUserActivities_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L921 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolReplicationLinks_GetByName' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1172 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolMaintenanceWindows_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1233 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolMaintenanceWindowOptions_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1356 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolTransparentDataEncryptions_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1414 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1619 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolSensitivityLabels_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L2290 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolConnectionPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L2739 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolSecurityAlertPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3130 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolVulnerabilityAssessmentRuleBaselines_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3449 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolVulnerabilityAssessments_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3535 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'ExtendedSqlPoolBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3747 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'DataMaskingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4007 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'DataMaskingRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4148 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolSchemas_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4323 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'SqlPoolTables_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4380 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"The schema 'KekIdentityProperties-useSystemAssignedIdentity' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json#/components/schemas/KekIdentityProperties-useSystemAssignedIdentity" |
|
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.$ref: undefined => "#/components/schemas/schemas:1325", properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => " |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:872" " |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:876" " |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.$ref: undefined => "#/components/schemas/schemas:1175", properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => " |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'" |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Deduplicating schema name: 'CloudError' -> 'CloudErrorAutoGenerated'" |
|
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
@idear1203 could you help to take a look when you have time? The related PR on Data Factory service is: #15276 |
This PR will cover latest API version as well since the resource contract is referred by specs of all API versions. For example, Line 83 in 70de9e4
|
Sorry for the misleading. Please update the Swagger spec here: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L1394 . In the next management SDK release, we will use this Swagger spec as input file. |
Hi, @jackmagic313. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
…into jikma/addcleanupsynapse
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.