Add snapshot related new APIs and properties to AKS 2021-08-01 swagger #15586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @chengliangli0918 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2785 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2878 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L3988 |
|
The response of operation:'ManagedClusters_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L420 |
|
The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L907 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L1466 |
|
The response of operation:'ManagedClusters_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L460 |
|
The response of operation:'AgentPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L954 |
|
The response of operation:'PrivateEndpointConnections_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L1514 |
|
The response of operation:'ManagedClusters_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L570 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L1170 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L640 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L1077 |
|
The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L37 |
|
The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L4790 |
|
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2193 |
|
The schema 'OperationValue' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2206 |
|
The schema 'OperationValueDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2226 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2251 |
|
The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2290 |
|
The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2311 |
|
The schema 'ManagedClusterServicePrincipalProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2530 |
|
The schema 'ContainerServiceMasterProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2546 |
|
The schema 'ManagedClusterAgentPoolProfileProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2600 |
|
The schema '1' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2785 |
|
The schema 'AgentPoolListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2846 |
|
The schema 'AgentPoolUpgradeSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2863 |
|
The schema '1' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2878 |
|
The schema 'ManagedClusterWindowsProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2890 |
|
The schema 'ContainerServiceLinuxProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerService/stable/2021-08-01/managedClusters.json#L2933 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-08",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-08",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-08",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-08-01-only",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"containerservice/resource-manager/readme.md",
"tag":"package-2021-08-01-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi, @chengliangli0918 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi @chengliangli0918, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Aug 9, 2021
|
@chengliangli0918, you checked this box: To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits., but didn't do it. Please submit a new PR with the first commit made by copying the unchanged files from the previous API version to the new API version folder. Then apply subsequent changes (including API version changes) to that base commit. This is required so reviewers can handle more PRs per week. |
mentat9
added
ARMChangesRequested
|
@mentat9, I should checked this box by mistake *To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.**. 2021-08-01 is a new API version, copied over from 2021-07-01 API version in a few previous PRs. This PR is just Adding new API(s)
|
chengliangli0918
added
WaitForARMFeedback
|
Checking the box was correct, but you need to create the PR correctly for ARM API review. When adding an API version, always make the first commit a copy of the unchanged files from the previous API version into the new folder. Then apply your changes in subsequent commits, including updating the API versions. |
mentat9
added
ARMChangesRequested
|
We followed the process to add new 2021-08-01 API version in the dev branch dev-containerservice-Microsoft.ContainerService-2021-08-01 1st commit: 00040b9 (copy 2021-07-01 to the new folder 2021-08-01 subsequent commits: different feature owners add new properties/APIs to 2021-08-01 API by different PRs. This PR is one of them
|
matthchr
reviewed
Aug 10, 2021
...ager/Microsoft.ContainerService/stable/2021-08-01/examples/SnapshotsListByResourceGroup.json
Outdated
Show resolved
Hide resolved
...erservice/resource-manager/Microsoft.ContainerService/stable/2021-08-01/managedClusters.json
Outdated
Show resolved
Hide resolved
...erservice/resource-manager/Microsoft.ContainerService/stable/2021-08-01/managedClusters.json
Outdated
Show resolved
Hide resolved
...erservice/resource-manager/Microsoft.ContainerService/stable/2021-08-01/managedClusters.json
Outdated
Show resolved
Hide resolved
…-01' of github.com:Azure/azure-rest-api-specs into charlili/snapshotswagger
matthchr
approved these changes
Aug 11, 2021
|
@mentat9 Thanks for your time to chat about this PR on Teams. I also updated "What's the purpose of the update" of this PR to 'Other' to make the scope of this PR smaller. I'll update the PR label. |
chengliangli0918
added
WaitForARMFeedback
mentat9
reviewed
Aug 11, 2021
...erservice/resource-manager/Microsoft.ContainerService/stable/2021-08-01/managedClusters.json
Outdated
Show resolved
Hide resolved
mentat9
reviewed
Aug 11, 2021
...erservice/resource-manager/Microsoft.ContainerService/stable/2021-08-01/managedClusters.json
Outdated
Show resolved
Hide resolved
mentat9
reviewed
Aug 11, 2021
...erservice/resource-manager/Microsoft.ContainerService/stable/2021-08-01/managedClusters.json
Outdated
Show resolved
Hide resolved
mentat9
reviewed
Aug 11, 2021
...erservice/resource-manager/Microsoft.ContainerService/stable/2021-08-01/managedClusters.json
Show resolved
Hide resolved
|
I left some non-blocking comments for consideration. Signing off from ARM side. |
mentat9
added
ARMSignedOff
|
@mentat9 Thank you for reviewing this PR from ARM side in your busy week as ARM reviewer. We really appreciate it. Also I push a new iteration to resolve your comments. Thank you again.
|
ruowan
merged commit 5219b6b
into
Azure:dev-containerservice-Microsoft.ContainerService-2021-08-01
qwordy
pushed a commit
that referenced
this pull request
Sep 9, 2021
…ch to main (#15954) * Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * add publicNetworkAccess property per network platform's request (#15489) * add publicNetworkAccess per network platform's request * fix quota Co-authored-by: Li Ma <lima2@microsoft.com> * update readme for 2021-08-01 sdk generation (#15476) * update readme for sdk generation * update readme for sdk generation Co-authored-by: Charlie Li <charlili@microsoft.com> * allow disabling of runcommand (#15481) * allow disabling of runcommand * rename file * another rename * fix prittier check * fix stupid prettier check * change publicNetworkAccess to enum (#15564) Co-authored-by: Li Ma <lima2@microsoft.com> * Add CreationData property to Agentpool level in 2021-08-01 API (#15563) * Add CreationData property to Agentpool level in 2021-08-01 API * fix json format * fix swagger spell check Co-authored-by: Charlie Li <charlili@microsoft.com> * chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (#15579) * Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (#15586) * Add CreationData property to Agentpool level in 2021-08-01 API * Add snapshot related APIs and properties to AKS 2021-08-01 swagger * fix lint and spell checks * fix lint and spell checks * fix PrettierCheck * Change some Nodepool to NodePool * some changes according to ARM team's review comments Co-authored-by: Charlie Li <charlili@microsoft.com> * fix tag typo to match tag convention (#15683) * add workload runtime to agent pool api (#15726) * add workload runtime to agent pool api * reference example * add custom words * fix: workload runtime description (#15782) * fix: workload runtime description * add wasmtime to custom words * clarify single workload type per node Co-authored-by: Matthew Christopher <matthchr@microsoft.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com> * fix typo in readme.python.md (#15903) * Add CreationData property to Agentpool level in 2021-08-01 API * fix typos in readme.python.md Co-authored-by: Charlie Li <charlili@microsoft.com> * merge recent custom-words.txt changes from main branch to resolve conflicts (#15938) * Add CreationData property to Agentpool level in 2021-08-01 API * merge recent custom-words.txt changes from main branch to resolve conflicts Co-authored-by: Charlie Li <charlili@microsoft.com> * pull custom-words.txt from main * add a new word - NodePool * add two more words Co-authored-by: Super <mali_no2@hotmail.com> Co-authored-by: Li Ma <lima2@microsoft.com> Co-authored-by: Charlie Li <charlili@microsoft.com> Co-authored-by: Haitao Chen <haitch@users.noreply.github.com> Co-authored-by: Qi Ni <pomelonicky@gmail.com> Co-authored-by: Ariel Silverman <asilverman@users.noreply.github.com> Co-authored-by: Ace Eldeib <alexeldeib@gmail.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.