Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Add data plane Queues Storage swagger #15791

Merged
merged 166 commits into from
Aug 30, 2021
Merged

[Storage] Add data plane Queues Storage swagger #15791

merged 166 commits into from
Aug 30, 2021

Conversation

tasherif-msft
Copy link
Contributor

Queues 2018-03-28 swagger

tg-msft and others added 30 commits August 26, 2019 15:14
@tg-msft
Storage Dataplane Preview (#7027)
b23bd37 
* Adding Azure Storage Dataplane REST API Specs

These are all Preview swagger specs and we do expect to make changes.

- Add readme.md files to suppress --azure-validator rules
- Fix trivial error about an x-ms-client-name mathing a name that won't change the
code generation
- We'll need to fix the semantic/avocado pipeline issues and get this properly reviewed before merging from the `storage-dataplane-preview` fork into `master`.
@seanmcc-msft
Fixed blob swagger for CPK (#7045)
325e210 
* Fixed blob swagger for CPK
@jianghaolu
Add share permission body to storage files (#7081)
4ecb28a 
* Add share permission body to storage files

* Add produces to getPermission

* Move response body from create to get
@amnguye
Adding SAS Error Codes (#7322)
ab914bf
@xiafu-msft
[Fix]Addressing the Things Below (#7304)
ccf01ab 
1.	create of Page Blob is missing tier parameter.
2.	For upload_pages_from_url of Page Blob, the generated code doesn’t extract header encryption-key-sha256 from raw response, which resulted in the response to client doesn’t have encryption-key-sha256 info.
3.	For append_block_from_url of Append Blob, currently the generated code is not extracting the response header request-server-encrypted from raw response(server returned response) which resulted in client doesn’t have request-server-encrypted info.
4.	get_permission of Storage File has file_permission_key parameter which should be required instead of optional
@jeremymeng
Remove delimiter from list blob flat segment response (#7376)
d7cbda6 
Resolves #7350
@seanmcc-msft
Updated DataLake swagger (#7408)
cd1d536
@seanmcc-msft
Additional DataLake swagger updates (#7445)
8e3a78a 
* Additional DataLake swagger updates
@gapra-msft
refactored fileSystemResource param and added md5 to pathHttpHeaders (#…
4174e38 
…7525)
@seanmcc-msft
Updated ContentMD5 parameter in DataLake swagger (#7534)
d8b94a0 
* Updated ContentMD5 parameter in DataLake swagger

* separated contentMD5 from transactionalContentMD5
@rickle-msft
Add transactional md5 support for blockBlobUpload (#7553)
507724d
@seanmcc-msft
Added File Storage 2019-07-07 service version (#7825)
5122cb1
@seanmcc-msft
Added premium share properties to File Shares (#7826)
a2141f3
@seanmcc-msft
Added x-ms-number-of-handles-failed to File and Directory ForceCloseH…
7fd37fc 
…andles (#7833)
@seanmcc-msft
Added new FileCopy() headers (#7837)
e20a954
@seanmcc-msft
Added File Lease (#7845)
75ca3f6
@zezha-msft
[Blob] Added missing headers for copy blob from URL (#7820)
5151dfe
@seanmcc-msft
Added 2019-07-07 Blobs Swagger (#7849)
942b1fb
@seanmcc-msft
Added additional FileLease parameters (#7892)
10fa1f6
@seanmcc-msft
Added additional File Lease request and response headers (#7910)
7e1b820
@seanmcc-msft
Added encryption scopes to Blob Storage (#7929)
ec5b478
@seanmcc-msft
Storage/features/more cpk n (#7940)
6e2997a
@seanmcc-msft
Added previous snapshot url header to PageBlob.GetPageRangeDiff (#7951)
b11a654
@seanmcc-msft
Made LeaseId optional on File Break Lease (#7952)
db33535
@seanmcc-msft
Added EncryptionScope and DenyDefaultEncryptionScopeOverride to Conta…
c0529f2 
…inerProperties (#8001)
@gapra-msft
Added rest parity attributes to start copy response (#8009)
9469f79
@gapra-msft @seanmcc-msft
Modified swagger to fix some descriptions (#8014)
d12ba55
@gapra-msft
undid rest parity start copy response (#8016)
08e1db0
@seanmcc-msft
Added new ErrorCode (#8071)
cd7a122
@seanmcc-msft
Added FileSystem Get/SetAccessControl and SetPermissions (#8081)
855877c
@openapi-workflow-bot
Copy link

Hi, @tasherif-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 25, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'Service_SetProperties' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.QueueStorage/preview/2018-03-28/queue.json#L40
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.QueueStorage/readme.md",
    "tag":"package-2018-03",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.QueueStorage/readme.md",
    "tag":"package-2018-03",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.QueueStorage/readme.md",
    "tag":"package-2018-03",
    "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"storage/data-plane/Microsoft.QueueStorage/readme.md",
    "tag":"package-2018-03",
    "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 25, 2021 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @tasherif-msft tasherif-msft requested a review from tg-msft August 25, 2021 18:52
    tg-msft
    tg-msft approved these changes Aug 26, 2021
    View reviewed changes
    Copy link
    Member

    @tg-msft tg-msft left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks great

    @anuchandy anuchandy merged commit aa4b90d into main Aug 30, 2021
    @JackTn JackTn deleted the queue-swagger branch June 16, 2022 00:51
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @anuchandy anuchandy anuchandy approved these changes

    @tg-msft tg-msft tg-msft approved these changes

    @kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

    @seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

    @tjprescott tjprescott Awaiting requested review from tjprescott

    Assignees

    @anuchandy anuchandy

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.