-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 202 Accepted for deletion call #15874
Conversation
Hi, @sureleo Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L733 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L796 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L844 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L888 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1029 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1092 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1140 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1184 |
|
'PUT' operation 'DataControllers_PutDataController' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L733 |
|
'PUT' operation 'DataControllers_PutDataController' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1029 |
|
'PATCH' operation 'DataControllers_PatchDataController' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L888 |
|
'PATCH' operation 'DataControllers_PatchDataController' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1184 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1837 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Property name: name Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L975 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Property name: name Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1271 |
|
Guid used in model definition 'OnPremiseProperty' for property 'id'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1437 |
|
Guid used in model definition 'LogAnalyticsWorkspaceConfig' for property 'workspaceId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1936 |
|
Guid used in model definition 'UploadServicePrincipal' for property 'clientId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1956 |
|
Guid used in model definition 'OnPremiseProperty' for property 'id'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1748 |
|
Guid used in model definition 'LogAnalyticsWorkspaceConfig' for property 'workspaceId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L2208 |
|
Guid used in model definition 'UploadServicePrincipal' for property 'clientId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L2228 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: dev Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L948 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: dev Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L995 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1118 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: dev Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1244 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: dev Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1291 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1437 |
|
The tracked resource, 'DataControllerResource', must have a list by resource group operation.(This rule does not apply for tenant level resources.) Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1249 |
|
The tracked resource, 'DataControllerResource', must have a list by resource group operation.(This rule does not apply for tenant level resources.) Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1568 |
|
The tracked resource, 'DataControllerResource', must have a list by subscriptions operation. Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1249 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
"tag":"package-2021-08-01",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
"tag":"package-2021-08-01",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
"tag":"package-2021-08-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
"tag":"package-preview-2021-07-01",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"azurearcdata/resource-manager/readme.md",
"tag":"package-preview-2021-07-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @sureleo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
https://msazure.visualstudio.com/One/_workitems/edit/10744495 Breaking change review intake created. |
Also adding email from @sanjaiganesh
Thanks |
@sureleo, as your PR contains breaking change, please follow http://aka.ms/bcforapi to get it reviewed. |
Thanks. I have already created breaking change intake. |
* Adding 202 for deletion call * Adding headers to suppress warnings
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.