-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 #15881
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 #15881
Conversation
…/2021-07-01 to version 2021-08-01
Hi, @ayfathim Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Hi @ayfathim, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @ayfathim . Please modify the readme to include 2018-12-20 version in the latest package like below. These settings apply only when input-file:
- Microsoft.RecoveryServices/stable/2021-07-01/bms.json
- Microsoft.RecoveryServices/stable/2018-12-20/bms.json |
/azp run unifiedPipeline |
1 similar comment
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
1 similar comment
No pipelines are associated with this pull request. |
Hi, @ayfathim your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Reviewed from RecoveryServices-backup end |
Please fill the changelog section above. Also, add the summary of the changes in this PR (e.g.: adding a new route or a new resource type, etc). |
@filizt : I have added a summary above. Basically there is no change, except new version being introduced, to make it s360 compliant. Summary: |
No API changes review from 2021-07-01 version. |
Hi, @ayfathim. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ARM Manifest deployment for the new-version will complete this week. Post that we will merge this PR |
… Microsoft.RecoveryServices to add version stable/2021-08-01 (#1931) Create to sync Azure/azure-rest-api-specs#15881 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/recoveryservicesbackup?expand=1)
…version stable/2021-08-01 (Azure#15881) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * Fixing readme file
/azp run |
…version stable/2021-08-01 (Azure#15881) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * Fixing readme file
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Summary:
We are adding new API version( 2021-08-01) in recoveryservices, recoveryservicesbackup folder, since this version is added recently in recoveryservicessiterecovery folder.
This API version change is being made, to make it S360 Compliant.
There is no additional change in this PR.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.