Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GA version changes - 2021-10-01 #15956

Merged
merged 25 commits into from
Sep 11, 2021
Merged

New GA version changes - 2021-10-01 #15956

merged 25 commits into from
Sep 11, 2021

Conversation

sirireddy12
Copy link
Contributor

@sirireddy12 sirireddy12 commented Sep 8, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new API version - 2021-10-01
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. - October
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. - September 9th
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @sirireddy12 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 8, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 4 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L241
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: clientProxy
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L746
    ⚠️ R4020 - DescriptiveDescriptionRequired The value provided for description is not descriptive enough. Accurate and descriptive description is essential for maintaining reference documentation.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L751
    ⚠️ R4021 - DescriptionAndTitleMissing 'ListClusterUserCredentialProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L727


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L563
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L576
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Kubernetes/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L382
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Kubernetes/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L395
    R4037 - MissingTypeObject The schema 'OperationList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L420
    R4037 - MissingTypeObject The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L446
    R4037 - MissingTypeObject The schema 'CredentialResults' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L626
    R4037 - MissingTypeObject The schema 'HybridConnectionConfig' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L701
    R4037 - MissingTypeObject The schema 'OperationList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L433
    R4037 - MissingTypeObject The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L459
    R4037 - MissingTypeObject The schema 'CredentialResults' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L656
    R4037 - MissingTypeObject The schema 'HybridConnectionConfig' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L748
    ⚠️ R1003 - ListInOperationName Since operation 'Operations_Get' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L385
    ⚠️ R1003 - ListInOperationName Since operation 'Operations_Get' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L398
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L34
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L97
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L150
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L191
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L302
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L345
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L34
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L100
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L163
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L204
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L254
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L315
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L358
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: clientProxy
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L846
    ⚠️ R4020 - DescriptiveDescriptionRequired The value provided for description is not descriptive enough. Accurate and descriptive description is essential for maintaining reference documentation.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L851
    ⚠️ R4021 - DescriptionAndTitleMissing 'ListClusterUserCredentialsProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L827
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 7 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:
    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Kubernetes/connectedClusters/{clusterName}/listClusterUserCredentials' removed or restructured?
    Old: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L251:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ListClusterUserCredentialsProperties' removed or renamed?
    New: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L419:3
    Old: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L426:3
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'privateLinkState' renamed or removed?
    New: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L553:7
    Old: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L560:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'privateLinkScopeResourceId' renamed or removed?
    New: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L553:7
    Old: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L560:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'privateLinkState' renamed or removed?
    New: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L698:7
    Old: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L722:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'privateLinkScopeResourceId' renamed or removed?
    New: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L698:7
    Old: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L722:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Kubernetes/stable/2021-10-01/connectedClusters.json#L95:7
    Old: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json#L98:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 8, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - hybridkubernetes/mgmt/2021-03-01/hybridkubernetes - v57.2.0
    ️✔️azure-sdk-for-go - preview/hybridkubernetes/mgmt/2021-04-01-preview/hybridkubernetes - v57.2.0
    ️✔️azure-sdk-for-go - preview/hybridkubernetes/mgmt/2020-01-01-preview/hybridkubernetes - v57.2.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-hybridkubernetes - Approved - 1.0.0
    -	Model ConnectedClusterPatch has a new signature
    -	Removed operation ConnectedClusterOperations.update
    ️✔️azure-sdk-for-go - hybridkubernetes/mgmt/2021-10-01/hybridkubernetes - v57.2.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9a19506. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-hybridkubernetes [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation ConnectedClusterOperations.list_cluster_user_credential
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9a19506. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-11 05:35:10 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-hybridkubernetes;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-09-11 05:35:10 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-09-11 05:35:10 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hybridkubernetes/azure-resourcemanager-hybridkubernetes --java.namespace=com.azure.resourcemanager.hybridkubernetes   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/hybridkubernetes/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-11 05:35:41 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-hybridkubernetes
      cmderr	[generate.py] 2021-09-11 05:35:41 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-11 05:35:41 INFO [POM][Skip] pom already has module azure-resourcemanager-hybridkubernetes
      cmderr	[generate.py] 2021-09-11 05:35:41 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-11 05:35:41 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-11 05:35:41 INFO [POM][Skip] pom already has module sdk/hybridkubernetes
      cmderr	[generate.py] 2021-09-11 05:35:41 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-hybridkubernetes [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-09-11 05:37:16 DEBUG Got artifact_id: azure-resourcemanager-hybridkubernetes
      cmderr	[Inst] 2021-09-11 05:37:16 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-11 05:37:16 DEBUG Got artifact: azure-resourcemanager-hybridkubernetes-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2021-09-11 05:37:16 DEBUG Got artifact: azure-resourcemanager-hybridkubernetes-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-09-11 05:37:16 DEBUG Match jar package: azure-resourcemanager-hybridkubernetes-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-09-11 05:37:16 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15956/azure-sdk-for-java/azure-resourcemanager-hybridkubernetes/azure-resourcemanager-hybridkubernetes-1.0.0-beta.2.jar\" -o azure-resourcemanager-hybridkubernetes-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hybridkubernetes -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hybridkubernetes-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9a19506. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️hybridkubernetes/mgmt/2021-10-01/hybridkubernetes [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️hybridkubernetes/mgmt/2021-03-01/hybridkubernetes [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/hybridkubernetes/mgmt/2021-04-01-preview/hybridkubernetes [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/hybridkubernetes/mgmt/2020-01-01-preview/hybridkubernetes [View full logs
      info	[Changelog] No exported changes
    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9a19506. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2381) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
      cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
      cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
      cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
      cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2381) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2381) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    • ️✔️hybridkubernetes [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @sirireddy12, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    Copy link

    @krdhruva krdhruva left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🕐

    @rapatchi
    Copy link
    Contributor

    rapatchi commented Sep 9, 2021

      "clientProxy": true
    

    this should be false


    Refers to: specification/hybridkubernetes/resource-manager/Microsoft.Kubernetes/preview/2021-04-01-preview/examples/ConnectedClustersListClusterCredentialsResult.json:9 in 3c5ef91. [](commit_id = 3c5ef91, deletion_comment = True)

    @rapatchi
    Copy link
    Contributor

    rapatchi commented Sep 9, 2021

    {

    The file names are little confusing.
    Could you rename them to some consistent format?.

    1. ....CSPAAD.json
    2. ....CSPToken.json
    3. .....HPAAD.json
    4. .....HPToken.json ?.

    Refers to: specification/hybridkubernetes/resource-manager/Microsoft.Kubernetes/preview/2021-04-01-preview/examples/ConnectedClustersListClusterCredentialsResult.json:1 in 3c5ef91. [](commit_id = 3c5ef91, deletion_comment = True)

    @openapi-workflow-bot
    Copy link

    Hi, @sirireddy12 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 10, 2021
    @majastrz
    Copy link
    Member

    It doesn't look like you structured your history to make it easy to review the delta for us. These were the instructions in the PR title:
    image

    Can you also link to the previously approved API so I can review the delta?

    @rapatchi
    Copy link
    Contributor

    rapatchi commented Sep 11, 2021

    It doesn't look like you structured your history to make it easy to review the delta for us. These were the instructions in the PR title:
    image

    Can you also link to the previously approved API so I can review the delta?

    We have taken the current GA api-version as base with no change from here.
    And as we want to take “listClusterUserCredentials” defined here to GA.
    The only change which we did while taking this API to GA is rename it from “listClusterUserCredentials” to “listClusterUserCredential”. As it should have been that in the first place.

    Hope this helps.

    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 11, 2021
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @majastrz
    Copy link
    Member

    Hope this helps.

    Yes, it does. Thanks!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-SdkBreakingChange-Python ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants