Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Cache to add version stable/2020-12-01 #16132

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

gorandom
Copy link
Contributor

@gorandom gorandom commented Sep 23, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @gorandom Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 23, 2021

    Swagger Validation Report

    ️❌BreakingChange: 16 Errors, 0 Warnings failed [Detail]
    Rule Message
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-06-01/redis.json#L1874:9
    Old: Microsoft.Cache/stable/2020-06-01/redis.json#L1874:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-06-01/redis.json#L1909:9
    Old: Microsoft.Cache/stable/2020-06-01/redis.json#L1908:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-06-01/redis.json#L1874:9
    Old: Microsoft.Cache/stable/2020-06-01/redis.json#L1874:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-06-01/redis.json#L1909:9
    Old: Microsoft.Cache/stable/2020-06-01/redis.json#L1908:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-06-01/redis.json#L1874:9
    Old: Microsoft.Cache/stable/2020-06-01/redis.json#L1874:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-06-01/redis.json#L1909:9
    Old: Microsoft.Cache/stable/2020-06-01/redis.json#L1908:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-06-01/redis.json#L1874:9
    Old: Microsoft.Cache/stable/2020-06-01/redis.json#L1874:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-06-01/redis.json#L1909:9
    Old: Microsoft.Cache/stable/2020-06-01/redis.json#L1908:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1881:9
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1881:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1921:9
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1920:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1881:9
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1881:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1921:9
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1920:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1881:9
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1881:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1921:9
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1920:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1881:9
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1881:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1921:9
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1920:9
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L68
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L68
    R4009 - RequiredReadOnlySystemData The response of operation:'Redis_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L345
    R4009 - RequiredReadOnlySystemData The response of operation:'FirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L899
    R4009 - RequiredReadOnlySystemData The response of operation:'PatchSchedules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1208
    R4009 - RequiredReadOnlySystemData The response of operation:'LinkedServer_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1399
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1562
    R4009 - RequiredReadOnlySystemData The response of operation:'Redis_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L172
    R4009 - RequiredReadOnlySystemData The response of operation:'FirewallRules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L828
    R4009 - RequiredReadOnlySystemData The response of operation:'PatchSchedules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1067
    R4009 - RequiredReadOnlySystemData The response of operation:'LinkedServer_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1273
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Put' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1613
    R4009 - RequiredReadOnlySystemData The response of operation:'Redis_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L236
    R4009 - RequiredReadOnlySystemData The response of operation:'Redis_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L342
    R4009 - RequiredReadOnlySystemData The response of operation:'FirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L896
    R4009 - RequiredReadOnlySystemData The response of operation:'PatchSchedules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1205
    R4009 - RequiredReadOnlySystemData The response of operation:'LinkedServer_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1396
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1559
    R4009 - RequiredReadOnlySystemData The response of operation:'Redis_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L169
    R4009 - RequiredReadOnlySystemData The response of operation:'FirewallRules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L825
    R4009 - RequiredReadOnlySystemData The response of operation:'PatchSchedules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1064
    R4009 - RequiredReadOnlySystemData The response of operation:'LinkedServer_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1270
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Put' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1610
    R4009 - RequiredReadOnlySystemData The response of operation:'Redis_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L233
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2315
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2370
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L37
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L37
    R4037 - MissingTypeObject The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1781
    R4037 - MissingTypeObject The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1821
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    AutorestCore/Exception "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-06",
    "details":"Error: Plugin prechecker reported failure."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 23, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-redis - 13.0.0
    azure-sdk-for-go - redis/mgmt/2020-12-01/redis - v58.0.0
    +	Type of `CommonProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `CreateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `Properties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `UpdateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    azure-sdk-for-go - redis/mgmt/2020-06-01/redis - v58.0.0
    +	Type of `CommonProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `CreateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `Properties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `UpdateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    ️✔️azure-sdk-for-go - redis/mgmt/2018-03-01/redis - v58.0.0
    ️✔️azure-sdk-for-go - redis/mgmt/2017-10-01/redis - v58.0.0
    ️✔️azure-sdk-for-go - redis/mgmt/2017-02-01/redis - v58.0.0
    ️✔️azure-sdk-for-go - redis/mgmt/2016-04-01/redis - v58.0.0
    ️✔️azure-sdk-for-go - redis/mgmt/2015-08-01/redis - v58.0.0
    ️✔️azure-sdk-for-go - preview/redis/mgmt/2019-07-01-preview/redis - v58.0.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from d07fa4a. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/redis/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.Redis [View full logs]  [Release SDK Changes]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/ScenarioTests/CreateUpdateDeleteFunctionalTests.cs(79,66): error CS0029: Cannot implicitly convert type 'System.Collections.Generic.Dictionary<string, string>' to 'Microsoft.Azure.Management.Redis.Models.RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/ScenarioTests/CreateUpdateDeleteFunctionalTests.cs(93,45): error CS0021: Cannot apply indexing with [] to an expression of type 'RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/InMemoryTests/GetTests.cs(63,41): error CS0021: Cannot apply indexing with [] to an expression of type 'RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/InMemoryTests/CreateOrUpdateTests.cs(282,102): error CS0029: Cannot implicitly convert type 'System.Collections.Generic.Dictionary<string, string>' to 'Microsoft.Azure.Management.Redis.Models.RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/InMemoryTests/CreateOrUpdateTests.cs(299,41): error CS0021: Cannot apply indexing with [] to an expression of type 'RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/ScenarioTests/CreateUpdateDeleteFunctionalTests.cs(79,66): error CS0029: Cannot implicitly convert type 'System.Collections.Generic.Dictionary<string, string>' to 'Microsoft.Azure.Management.Redis.Models.RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/ScenarioTests/CreateUpdateDeleteFunctionalTests.cs(93,45): error CS0021: Cannot apply indexing with [] to an expression of type 'RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/InMemoryTests/GetTests.cs(63,41): error CS0021: Cannot apply indexing with [] to an expression of type 'RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/InMemoryTests/CreateOrUpdateTests.cs(282,102): error CS0029: Cannot implicitly convert type 'System.Collections.Generic.Dictionary<string, string>' to 'Microsoft.Azure.Management.Redis.Models.RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/InMemoryTests/CreateOrUpdateTests.cs(299,41): error CS0021: Cannot apply indexing with [] to an expression of type 'RedisCommonPropertiesRedisConfiguration' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/tests/Microsoft.Azure.Management.RedisCache.Tests.csproj]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d07fa4a. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-10-04 16:12:35 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-redis-generated"
      cmderr	[generate.py] 2021-10-04 16:12:35 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-10-04 16:12:35 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/redis/azure-resourcemanager-redis-generated --java.namespace=com.azure.resourcemanager.redis.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/redis/resource-manager/readme.md
      cmderr	[generate.py] 2021-10-04 16:13:06 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-10-04 16:13:06 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-10-04 16:13:06 INFO [POM][Skip] pom already has module azure-resourcemanager-redis-generated
      cmderr	[generate.py] 2021-10-04 16:13:06 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-10-04 16:13:06 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-10-04 16:13:06 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-redis-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-10-04 16:15:06 DEBUG Got artifact_id: azure-resourcemanager-redis-generated
      cmderr	[Inst] 2021-10-04 16:15:06 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-10-04 16:15:06 DEBUG Got artifact: azure-resourcemanager-redis-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-10-04 16:15:06 DEBUG Match jar package: azure-resourcemanager-redis-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-10-04 16:15:06 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16132/azure-sdk-for-java/azure-resourcemanager-redis-generated/azure-resourcemanager-redis-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-redis-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-redis-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-redis-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d07fa4a. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️redis/mgmt/2020-12-01/redis [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `UpdateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `CommonProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `CreateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `Properties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `*CommonPropertiesRedisConfiguration.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `CommonPropertiesRedisConfiguration.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `CommonPropertiesRedisConfiguration`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️redis/mgmt/2020-06-01/redis [View full logsBreaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `CommonProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `Properties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `CreateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `UpdateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `CommonPropertiesRedisConfiguration.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*CommonPropertiesRedisConfiguration.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `CommonPropertiesRedisConfiguration`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️redis/mgmt/2018-03-01/redis [View full logs
      info	[Changelog] No exported changes
    • ️✔️redis/mgmt/2017-10-01/redis [View full logs
      info	[Changelog] No exported changes
    • ️✔️redis/mgmt/2017-02-01/redis [View full logs
      info	[Changelog] No exported changes
    • ️✔️redis/mgmt/2016-04-01/redis [View full logs
      info	[Changelog] No exported changes
    • ️✔️redis/mgmt/2015-08-01/redis [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/redis/mgmt/2019-07-01-preview/redis [View full logs
      info	[Changelog] No exported changes
    ️❌ azure-sdk-for-go-track2 failed [Detail]
    • Failed [Logs]Release - Generate from d07fa4a. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] cannot get rp and namespaces from readme 'specification/redis/resource-manager/readme.md': cannot parse module name from `track2` section
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d07fa4a. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/redis/resource-manager/readme.md
    • ️✔️@azure/arm-rediscache [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/redisManagementClient.js → ./dist/arm-rediscache.js...
      cmderr	[npmPack] created ./dist/arm-rediscache.js in 436ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d07fa4a. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot
    Copy link

    Hi @gorandom, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @gorandom
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @gorandom gorandom marked this pull request as ready for review September 28, 2021 11:35
    @qwordy
    Copy link
    Member

    qwordy commented Sep 30, 2021

    Some checks were not successful

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 1, 2021
    @gorandom
    Copy link
    Contributor Author

    gorandom commented Oct 4, 2021

    @qwordy The breaking change is approved. shall we merge this PR?

    jovannikolov-msft pushed a commit to jovannikolov-msft/azure-rest-api-specs that referenced this pull request Dec 1, 2021
    Co-authored-by: Praveenkumar Ravikumar <prravikumar@microsoft.com>
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    Co-authored-by: Praveenkumar Ravikumar <prravikumar@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants