Added CVM settings for version 2021-11-01 #16622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-saypaul
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
|
Hi, @ms-saypaul Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
ghost
added
the
|
Hi @ms-saypaul, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Nov 1, 2021
RunCai
approved these changes
Nov 10, 2021
|
/azp rerun |
|
Command 'rerun' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
Swagger Generation Artifacts
|
… feature/cplat-2021-11-01
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Model definition 'SubResourceWithColocationStatus' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Compute/stable/2021-11-01/compute.json#L9359 |
|
Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'SubResourceWithColocationStatus' has extra properties ['colocationStatus']. Location: Microsoft.Compute/stable/2021-11-01/compute.json#L9365 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L49 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L108 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L159 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L204 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L249 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L289 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L329 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L379 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L438 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L495 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L537 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L583 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L613 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L653 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L709 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L766 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L811 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L871 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L908 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L944 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L1010 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L1075 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L1128 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L1199 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L1243 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L1279 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L1322 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-11-01/compute.json#L1381 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-11-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 5 Errors, 13 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2021-11-01/compute.json compared with base:stable/2021-07-01/compute.json
- current:stable/2021-11-01/compute.json compared with base:preview/2016-04-30-preview/compute.json
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/reimage' removed or restructured? Old: Microsoft.Compute/stable/2021-07-01/compute.json#L7200:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/reimageall' removed or restructured? Old: Microsoft.Compute/stable/2021-07-01/compute.json#L7256:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/deallocate' removed or restructured? Old: Microsoft.Compute/stable/2021-07-01/compute.json#L7303:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}' removed or restructured? Old: Microsoft.Compute/stable/2021-07-01/compute.json#L7350:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/instanceView' removed or restructured? Old: Microsoft.Compute/stable/2021-07-01/compute.json#L7536:5 |
The following breaking changes are detected by comparison with latest preview version:
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/reimage' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L2597:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/reimageall' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L2650:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/deallocate' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L2703:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L2756:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/instanceView' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L2853:5 |
|
| The operation id has been changed from 'VirtualMachines_GetExtensions' to 'VirtualMachineExtensions_List'. This will impact generated code. New: Microsoft.Compute/stable/2021-11-01/compute.json#L2015:7 Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L646:7 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.Compute/stable/2021-11-01/compute.json#L13181:9 Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L4702:9 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.Compute/stable/2021-11-01/compute.json#L13187:11 Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L4708:11 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.Compute/stable/2021-11-01/compute.json#L13070:5 Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L4594:5 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.Compute/stable/2021-11-01/compute.json#L13118:5 Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L4657:5 |
|
| The new version is missing a property found in the old version. Was 'managed' renamed or removed? New: Microsoft.Compute/stable/2021-11-01/compute.json#L9259:7 Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L3160:7 |
|
| The new version is missing a property found in the old version. Was 'properties' renamed or removed? New: Microsoft.Compute/stable/2021-11-01/compute.json#L11054:7 Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L3687:7 |
|
| The new version is missing a property found in the old version. Was 'overProvision' renamed or removed? New: Microsoft.Compute/stable/2021-11-01/compute.json#L14320:7 Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L5144:7 |
️🔄SDK Track2 Validation inProgress [Detail]
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
@ArcturusZhang could you provide any advice on why the SDK Azure-sdk-for-net CI is failing? Is it a CI issue? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grizzlytheodore
added
the
DoNotMerge
grizzlytheodore
pushed a commit
that referenced
this pull request
Jan 3, 2022
* Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object
ArcturusZhang
added a commit
that referenced
this pull request
Jan 19, 2022
* compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (#16570)" (#16663) This reverts commit 70a8729. * sync with last version * add missing examples * suppress bodyTopLevelProperties * Add VMSS filter to List VMs (#16813) * change1 for change file * change description * change description * add suppression for required properties * Revert "Add VMSS filter to List VMs (#16813)" (#16956) This reverts commit 231fd22. * Remove impossible state from example (#16544) * Downmerging change from Azure:main (#16654) Co-authored-by: Avinash Akka <avakka@microsoft.com> * Added CVM settings for version 2021-11-01 (#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <thchan@microsoft.com> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> * DedicatedHost Reboot Feature (#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (#17041) * save (#17091) Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json (#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - #10190 * add vmss filter to list (#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <lexiexie@microsoft.com> * move Kashif's change to 2021-11-01 * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)" (#17121) This reverts commit 220cfd0. * fix CI failures, and run prettier on added examples * for credscan. change password example * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * make new api call long-running-operation * compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (#16570)" (#16663) This reverts commit 70a8729. * sync with last version * add missing examples * Add VMSS filter to List VMs (#16813) * change1 for change file * change description * change description * Revert "Add VMSS filter to List VMs (#16813)" (#16956) This reverts commit 231fd22. * Remove impossible state from example (#16544) * Added CVM settings for version 2021-11-01 (#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <thchan@microsoft.com> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> * DedicatedHost Reboot Feature (#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (#17041) * save (#17091) Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json (#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - #10190 * add vmss filter to list (#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <lexiexie@microsoft.com> * move Kashif's change to 2021-11-01 * fix CI failures, and run prettier on added examples * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)" (#17121) This reverts commit 220cfd0. * for credscan. change password example * make new api call long-running-operation * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * update Repair action to enum and update readme * rebase to main since 2021-08-01 merged. update readme * update x-ms-enum name for RepairType * add default response to operations * update * put back 'required' tag for Resource.Location property and use a new object for VM_LIST return object * fix json format * update examples * run prettier on updated examples * update example for credScan * add VirtualMachineResource for toplevel property suppression. * lint diff errors * lint diff fix update * remove change for VMextensions.location bug * return readme file and examples before vm.vmextension.location change Co-authored-by: sukodava <78733210+sukodava@users.noreply.github.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: xielexie <94083876+xielexie@users.noreply.github.com> Co-authored-by: Mike Richmond <mirichmo@microsoft.com> Co-authored-by: Avinash <akka@usc.edu> Co-authored-by: Avinash Akka <avakka@microsoft.com> Co-authored-by: ms-saypaul <67093296+ms-saypaul@users.noreply.github.com> Co-authored-by: Raktima Das <raktdas@microsoft.com> Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com> Co-authored-by: frank-pang-msft <92764154+frank-pang-msft@users.noreply.github.com> Co-authored-by: Chase VanBuskirk <chasevanb@gmail.com> Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> Co-authored-by: vbhasker-msft <93355049+vbhasker-msft@users.noreply.github.com> Co-authored-by: avjai <34567499+avjai@users.noreply.github.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: karthikka4820 <88366202+karthikka4820@users.noreply.github.com> Co-authored-by: LexieXie <lexiexie@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
mstrisoline
pushed a commit
to mstrisoline/azure-rest-api-specs
that referenced
this pull request
Feb 1, 2022
* compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663) This reverts commit 70a8729. * sync with last version * add missing examples * suppress bodyTopLevelProperties * Add VMSS filter to List VMs (Azure#16813) * change1 for change file * change description * change description * add suppression for required properties * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956) This reverts commit 231fd22. * Remove impossible state from example (Azure#16544) * Downmerging change from Azure:main (Azure#16654) Co-authored-by: Avinash Akka <avakka@microsoft.com> * Added CVM settings for version 2021-11-01 (Azure#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (Azure#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <thchan@microsoft.com> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> * DedicatedHost Reboot Feature (Azure#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041) * save (Azure#17091) Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json (Azure#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - Azure#10190 * add vmss filter to list (Azure#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <lexiexie@microsoft.com> * move Kashif's change to 2021-11-01 * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121) This reverts commit 220cfd0. * fix CI failures, and run prettier on added examples * for credscan. change password example * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * make new api call long-running-operation * compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663) This reverts commit 70a8729. * sync with last version * add missing examples * Add VMSS filter to List VMs (Azure#16813) * change1 for change file * change description * change description * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956) This reverts commit 231fd22. * Remove impossible state from example (Azure#16544) * Added CVM settings for version 2021-11-01 (Azure#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (Azure#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <thchan@microsoft.com> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> * DedicatedHost Reboot Feature (Azure#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041) * save (Azure#17091) Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json (Azure#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - Azure#10190 * add vmss filter to list (Azure#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <lexiexie@microsoft.com> * move Kashif's change to 2021-11-01 * fix CI failures, and run prettier on added examples * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121) This reverts commit 220cfd0. * for credscan. change password example * make new api call long-running-operation * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * update Repair action to enum and update readme * rebase to main since 2021-08-01 merged. update readme * update x-ms-enum name for RepairType * add default response to operations * update * put back 'required' tag for Resource.Location property and use a new object for VM_LIST return object * fix json format * update examples * run prettier on updated examples * update example for credScan * add VirtualMachineResource for toplevel property suppression. * lint diff errors * lint diff fix update * remove change for VMextensions.location bug * return readme file and examples before vm.vmextension.location change Co-authored-by: sukodava <78733210+sukodava@users.noreply.github.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: xielexie <94083876+xielexie@users.noreply.github.com> Co-authored-by: Mike Richmond <mirichmo@microsoft.com> Co-authored-by: Avinash <akka@usc.edu> Co-authored-by: Avinash Akka <avakka@microsoft.com> Co-authored-by: ms-saypaul <67093296+ms-saypaul@users.noreply.github.com> Co-authored-by: Raktima Das <raktdas@microsoft.com> Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com> Co-authored-by: frank-pang-msft <92764154+frank-pang-msft@users.noreply.github.com> Co-authored-by: Chase VanBuskirk <chasevanb@gmail.com> Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> Co-authored-by: vbhasker-msft <93355049+vbhasker-msft@users.noreply.github.com> Co-authored-by: avjai <34567499+avjai@users.noreply.github.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: karthikka4820 <88366202+karthikka4820@users.noreply.github.com> Co-authored-by: LexieXie <lexiexie@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663) This reverts commit 70a8729. * sync with last version * add missing examples * suppress bodyTopLevelProperties * Add VMSS filter to List VMs (Azure#16813) * change1 for change file * change description * change description * add suppression for required properties * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956) This reverts commit 231fd22. * Remove impossible state from example (Azure#16544) * Downmerging change from Azure:main (Azure#16654) Co-authored-by: Avinash Akka <avakka@microsoft.com> * Added CVM settings for version 2021-11-01 (Azure#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (Azure#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <thchan@microsoft.com> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> * DedicatedHost Reboot Feature (Azure#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041) * save (Azure#17091) Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json (Azure#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - Azure#10190 * add vmss filter to list (Azure#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <lexiexie@microsoft.com> * move Kashif's change to 2021-11-01 * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121) This reverts commit 220cfd0. * fix CI failures, and run prettier on added examples * for credscan. change password example * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * make new api call long-running-operation * compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663) This reverts commit 70a8729. * sync with last version * add missing examples * Add VMSS filter to List VMs (Azure#16813) * change1 for change file * change description * change description * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956) This reverts commit 231fd22. * Remove impossible state from example (Azure#16544) * Added CVM settings for version 2021-11-01 (Azure#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (Azure#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <thchan@microsoft.com> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> * DedicatedHost Reboot Feature (Azure#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041) * save (Azure#17091) Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json (Azure#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - Azure#10190 * add vmss filter to list (Azure#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <lexiexie@microsoft.com> * move Kashif's change to 2021-11-01 * fix CI failures, and run prettier on added examples * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121) This reverts commit 220cfd0. * for credscan. change password example * make new api call long-running-operation * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * update Repair action to enum and update readme * rebase to main since 2021-08-01 merged. update readme * update x-ms-enum name for RepairType * add default response to operations * update * put back 'required' tag for Resource.Location property and use a new object for VM_LIST return object * fix json format * update examples * run prettier on updated examples * update example for credScan * add VirtualMachineResource for toplevel property suppression. * lint diff errors * lint diff fix update * remove change for VMextensions.location bug * return readme file and examples before vm.vmextension.location change Co-authored-by: sukodava <78733210+sukodava@users.noreply.github.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: xielexie <94083876+xielexie@users.noreply.github.com> Co-authored-by: Mike Richmond <mirichmo@microsoft.com> Co-authored-by: Avinash <akka@usc.edu> Co-authored-by: Avinash Akka <avakka@microsoft.com> Co-authored-by: ms-saypaul <67093296+ms-saypaul@users.noreply.github.com> Co-authored-by: Raktima Das <raktdas@microsoft.com> Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com> Co-authored-by: frank-pang-msft <92764154+frank-pang-msft@users.noreply.github.com> Co-authored-by: Chase VanBuskirk <chasevanb@gmail.com> Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> Co-authored-by: vbhasker-msft <93355049+vbhasker-msft@users.noreply.github.com> Co-authored-by: avjai <34567499+avjai@users.noreply.github.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: karthikka4820 <88366202+karthikka4820@users.noreply.github.com> Co-authored-by: LexieXie <lexiexie@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.