Add TotalCount property to ListInvoices #16623

bradenwatkins · 2021-11-01T18:35:33Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-11-01T18:35:36Z

Hi, @bradenwatkins Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-11-01T18:35:37Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.1)
- current:preview/2019-10-01-preview/billing.json compared with base:preview/2019-10-01-preview/billing.json
- current:stable/2020-05-01/billing.json compared with base:stable/2020-05-01/billing.json

Rule	Message
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'totalCount' in response that was not found in the old version. New: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7310:7 Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7310:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'totalCount' in response that was not found in the old version. New: Microsoft.Billing/stable/2020-05-01/billing.json#L5027:7 Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5027:7

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R3015 - EnumMustHaveType	Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it. Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6459
`❌` R3015 - EnumMustHaveType	Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it. Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6472
`❌` R3015 - EnumMustHaveType	Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it. Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6912
`❌` R3015 - EnumMustHaveType	Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it. Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7135
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3140
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3231
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3316
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3140
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3231
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3316
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3140
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3231
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3316
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L3538
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L3710
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L4673
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L4807
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L4889
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L4971
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L5102
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Billing/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L3949
`❌` R4037 - MissingTypeObject	The schema 'CustomerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3704
`❌` R4037 - MissingTypeObject	The schema 'CustomerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3744
`❌` R4037 - MissingTypeObject	The schema 'TransferProductRequestProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3810
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3895
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3929
`❌` R4037 - MissingTypeObject	The schema 'BillingProfilesOnExpand' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L4021
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountUpdateRequest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L4038
`❌` R4037 - MissingTypeObject	The schema 'BillingPropertyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L4064
`❌` R4037 - MissingTypeObject	The schema 'Enrollment' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L4179

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/billing/resource-manager/readme.md tag: specification/billing/resource-manager/readme.md#tag-package-2020-05

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-11-01T18:35:37Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-11-01T18:35:38Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-billing - 6.0.0
️✔️azure-sdk-for-go - billing/mgmt/2021-10-01/billing - v59.0.0
❌azure-sdk-for-go - preview/billing/mgmt/2020-05-01-preview/billing - v59.0.0

+	Const `All` has been removed
+	Const `Reservation` has been removed
+	Field `MarketplacesEnabled` of struct `EnrollmentPolicies` has been removed

️✔️azure-sdk-for-go - preview/billing/mgmt/2018-11-01-preview/billing - v59.0.0
️✔️azure-sdk-for-go - preview/billing/mgmt/2018-03-01-preview/billing - v59.0.0
️✔️azure-sdk-for-go - preview/billing/mgmt/2017-04-24-preview/billing - v59.0.0
❌azure-sdk-for-go - preview/billing/mgmt/2017-02-27-preview/billing - v59.0.0

+	Package was removed

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0c48f2a. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/billing/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Billing [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Billing.4.1.0.nupkg
- Microsoft.Azure.Management.Billing.4.1.0.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 0c48f2a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-billing [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model InvoiceSection has a new parameter tags
info	[Changelog]   - Model ProductsListResult has a new parameter total_count
info	[Changelog]   - Model InvoiceListResult has a new parameter total_count
info	[Changelog]   - Model TransactionListResult has a new parameter total_count
info	[Changelog]   - Model BillingSubscription has a new parameter suspension_reasons

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 0c48f2a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-11-09 07:50:22 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-billing;1.0.0-beta.2;1.0.0-beta.3"
cmderr	[generate.py] 2021-11-09 07:50:22 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
cmderr	[generate.py] 2021-11-09 07:50:22 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.39 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/billing/azure-resourcemanager-billing --java.namespace=com.azure.resourcemanager.billing   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/billing/resource-manager/readme.md
cmderr	[generate.py] 2021-11-09 07:51:16 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-billing
cmderr	[generate.py] 2021-11-09 07:51:16 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-11-09 07:51:16 INFO [POM][Skip] pom already has module azure-resourcemanager-billing
cmderr	[generate.py] 2021-11-09 07:51:16 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-11-09 07:51:16 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-11-09 07:51:16 INFO [POM][Skip] pom already has module sdk/billing
cmderr	[generate.py] 2021-11-09 07:51:16 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-billing [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-11-09 07:53:53 DEBUG Got artifact_id: azure-resourcemanager-billing
cmderr	[Inst] 2021-11-09 07:53:53 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-11-09 07:53:53 DEBUG Got artifact: azure-resourcemanager-billing-1.0.0-beta.3.jar
cmderr	[Inst] 2021-11-09 07:53:53 DEBUG Match jar package: azure-resourcemanager-billing-1.0.0-beta.3.jar
cmderr	[Inst] 2021-11-09 07:53:53 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16623/azure-sdk-for-java/azure-resourcemanager-billing/azure-resourcemanager-billing-1.0.0-beta.3.jar\" -o azure-resourcemanager-billing-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-billing -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-billing-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0c48f2a. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️billing/mgmt/2021-10-01/billing [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```

️✔️preview/billing/mgmt/2020-05-01-preview/billing [View full logs] Breaking Change Detected

Only show 20 items here, please refer to log for details.

info	[Changelog] - New struct `ReservationsListResultIterator`
info	[Changelog] - New struct `ReservationsListResultPage`
info	[Changelog] - New field `MarketplaceEnabled` in struct `EnrollmentPolicies`
info	[Changelog] - New field `NotificationEmailAddress` in struct `AccountProperties`
info	[Changelog] - New field `TotalCount` in struct `ProductsListResult`
info	[Changelog] - New field `TotalCount` in struct `InvoiceSectionListResult`
info	[Changelog] - New field `TotalCount` in struct `CustomerListResult`
info	[Changelog] - New field `SuspensionReasons` in struct `SubscriptionProperties`
info	[Changelog] - New field `TotalCount` in struct `TransactionListResult`
info	[Changelog] - New field `Tags` in struct `ProfileProperties`
info	[Changelog] - New field `MiddleName` in struct `AddressDetails`
info	[Changelog] - New field `TotalCount` in struct `SubscriptionsListResult`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog] - New field `Tags` in struct `InvoiceSectionProperties`
info	[Changelog] - New field `TotalCount` in struct `InvoiceListResult`
info	[Changelog] - New field `AccountOwnerEmail` in struct `EnrollmentAccountProperties`
info	[Changelog] - New field `Description` in struct `OperationDisplay`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 82 additive change(s).
info	[Changelog]

️✔️preview/billing/mgmt/2018-11-01-preview/billing [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/billing/mgmt/2018-03-01-preview/billing [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/billing/mgmt/2017-04-24-preview/billing [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/billing/mgmt/2017-02-27-preview/billing [View full logs] Breaking Change Detected
```
info	[Changelog] This package was removed
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0c48f2a. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/billing/resource-manager/readme.md

️✔️@azure/arm-billing [View full logs] [Release SDK Changes]

azure-arm-billing-3.1.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
cmderr	[npmPack] created ./dist/arm-billing.js in 655ms

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 0c48f2a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:3047) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2018-11-01-preview/Microsoft.Billing.json'
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:3047) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:3047) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
cmderr	[generateScript.sh] (node:3047) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:176:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:293:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:300:29
cmderr	[generateScript.sh] (node:3047) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
warn	No file changes detected after generation

️✔️billing [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-11-01T18:41:03Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

bradenwatkins · 2021-11-01T18:54:24Z

PR to fix: https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=A9734F54-1226-4C78-88F8-8D352B8F88B4

bradenwatkins · 2021-11-08T18:35:24Z

@akning-ms can you merge this now that the breaking change is approved?

Co-authored-by: Braden Watkins <brwatkin@microsoft.com>

Add TotalCount property to ListInvoices

9589987

bradenwatkins requested review from asarkar84 and wilcobmsft as code owners November 1, 2021 18:35

openapi-assignment-bot bot assigned akning-ms Nov 1, 2021

openapi-workflow-bot bot added the FixS360 label Nov 1, 2021

openapi-sdkautomation bot mentioned this pull request Nov 1, 2021

[AutoPR @azure/arm-billing] Add TotalCount property to ListInvoices AzureSDKAutomation/azure-sdk-for-js#6552

Closed

openapi-pipeline-app bot added the NewApiVersionRequired label Nov 1, 2021

openapi-sdkautomation bot mentioned this pull request Nov 1, 2021

[AutoPR track2_azure-mgmt-billing] Add TotalCount property to ListInvoices AzureSDKAutomation/azure-sdk-for-python#7974

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 1, 2021

This was referenced Nov 1, 2021

[AutoPR Microsoft.Azure.Management.Billing] Add TotalCount property to ListInvoices AzureSDKAutomation/azure-sdk-for-net#6497

Closed

[AutoPR azure-resourcemanager-billing] Add TotalCount property to ListInvoices AzureSDKAutomation/azure-sdk-for-java#11326

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 8, 2021

akning-ms approved these changes Nov 9, 2021

View reviewed changes

akning-ms merged commit 0c48f2a into Azure:main Nov 9, 2021

LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022

Add TotalCount property to ListInvoices (Azure#16623)

b3fc170

Co-authored-by: Braden Watkins <brwatkin@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add TotalCount property to ListInvoices #16623

Add TotalCount property to ListInvoices #16623

bradenwatkins commented Nov 1, 2021 •

edited

Loading

openapi-workflow-bot bot commented Nov 1, 2021

openapi-pipeline-app bot commented Nov 1, 2021 •

edited

Loading

openapi-workflow-bot bot commented Nov 1, 2021

openapi-pipeline-app bot commented Nov 1, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Nov 1, 2021

bradenwatkins commented Nov 1, 2021

bradenwatkins commented Nov 8, 2021

Add TotalCount property to ListInvoices #16623

Add TotalCount property to ListInvoices #16623

Conversation

bradenwatkins commented Nov 1, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Nov 1, 2021

openapi-pipeline-app bot commented Nov 1, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Nov 1, 2021

openapi-pipeline-app bot commented Nov 1, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Nov 1, 2021

bradenwatkins commented Nov 1, 2021

bradenwatkins commented Nov 8, 2021

bradenwatkins commented Nov 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 1, 2021 •

edited

Loading