[SRP] Add "2021-08-01" API version #16659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfchen95
requested review from
JasonYang-MSFT and
kasobol-msft
as code owners
|
Hi, @zfchen95 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=271541&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-go-track2 - armstorage - 0.3.0️✔️azure-sdk-for-go - storage/mgmt/2021-06-01/storage - v61.1.0❌azure-sdk-for-go - storage/mgmt/2021-04-01/storage - v61.1.0+ Field `Expiry` of struct `AccessPolicy` has been removed + Field `Start` of struct `AccessPolicy` has been removed
️✔️azure-sdk-for-go - storage/mgmt/2021-02-01/storage - v61.1.0️✔️azure-sdk-for-go - storage/mgmt/2021-01-01/storage - v61.1.0❌azure-sdk-for-go - storage/mgmt/2019-06-01/storage - v61.1.0+ Field `Code` of struct `ErrorResponse` has been removed + Field `Message` of struct `ErrorResponse` has been removed
️✔️azure-sdk-for-go - storage/mgmt/2019-04-01/storage - v61.1.0️✔️azure-sdk-for-go - storage/mgmt/2018-11-01/storage - v61.1.0️✔️azure-sdk-for-go - storage/mgmt/2018-02-01/storage - v61.1.0️✔️azure-sdk-for-go - storage/mgmt/2017-10-01/storage - v61.1.0️✔️azure-sdk-for-go - storage/mgmt/2017-06-01/storage - v61.1.0️✔️azure-sdk-for-go - storage/mgmt/2016-12-01/storage - v61.1.0️✔️azure-sdk-for-go - storage/mgmt/2016-05-01/storage - v61.1.0️✔️azure-sdk-for-go - storage/mgmt/2016-01-01/storage - v61.1.0️✔️azure-sdk-for-go - storage/mgmt/2015-06-15/storage - v61.1.0️✔️azure-sdk-for-go - preview/storage/mgmt/2020-08-01-preview/storage - v61.1.0️✔️azure-sdk-for-go - preview/storage/mgmt/2018-07-01-preview/storage - v61.1.0️✔️azure-sdk-for-go - preview/storage/mgmt/2018-03-01-preview/storage - v61.1.0️✔️azure-sdk-for-go - preview/storage/mgmt/2015-05-01-preview/storage - v61.1.0️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-storage - 19.0.0️❌ azure-sdk-for-net failed [Detail]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-6.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/storage/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-pageable cmderr [Autorest] - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2021-08-01/storage.json:1683:4 ($.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/localUsers"]) cmderr [Autorest] FATAL: swagger-document/individual/schema-validator - FAILED cmderr [Autorest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting. cmderr [Autorest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting. error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest warn Skip package processing as generation is failed
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@8.3.0` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-storage [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group LocalUsersOperations info [Changelog] - Model ActiveDirectoryProperties has a new parameter account_type info [Changelog] - Model ActiveDirectoryProperties has a new parameter sam_account_name info [Changelog] - Model EncryptionIdentity has a new parameter encryption_federated_identity_client_id info [Changelog] - Model StorageAccount has a new parameter allowed_copy_scope info [Changelog] - Model StorageAccount has a new parameter is_local_user_enabled info [Changelog] - Model StorageAccount has a new parameter is_sftp_enabled info [Changelog] - Model StorageAccountCreateParameters has a new parameter allowed_copy_scope info [Changelog] - Model StorageAccountCreateParameters has a new parameter is_local_user_enabled info [Changelog] - Model StorageAccountCreateParameters has a new parameter is_sftp_enabled info [Changelog] - Model StorageAccountUpdateParameters has a new parameter allowed_copy_scope info [Changelog] - Model StorageAccountUpdateParameters has a new parameter is_local_user_enabled info [Changelog] - Model StorageAccountUpdateParameters has a new parameter is_sftp_enabled
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2022-01-07 14:17:19 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-storage-generated" cmderr [generate.py] 2022-01-07 14:17:19 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2022-01-07 14:17:19 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.44 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/storage/azure-resourcemanager-storage-generated --java.namespace=com.azure.resourcemanager.storage.generated --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/storage/resource-manager/readme.md cmderr [generate.py] 2022-01-07 14:18:08 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2022-01-07 14:18:08 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2022-01-07 14:18:08 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2022-01-07 14:18:08 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2022-01-07 14:18:08 INFO [POM][Skip] pom already has module sdk/storage cmderr [generate.py] 2022-01-07 14:18:08 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-storage-generated [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-storage-generated-1.0.0-beta.1.jar
- azure-resourcemanager-storage-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-storage-generated-1.0.0-beta.1-javadoc.jar
cmderr [Inst] 2022-01-07 14:20:56 DEBUG Got artifact_id: azure-resourcemanager-storage-generated cmderr [Inst] 2022-01-07 14:20:56 DEBUG Got artifact: pom.xml cmderr [Inst] 2022-01-07 14:20:56 DEBUG Got artifact: azure-resourcemanager-storage-generated-1.0.0-beta.1.jar cmderr [Inst] 2022-01-07 14:20:56 DEBUG Match jar package: azure-resourcemanager-storage-generated-1.0.0-beta.1.jar cmderr [Inst] 2022-01-07 14:20:56 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16659/azure-sdk-for-java/azure-resourcemanager-storage-generated/azure-resourcemanager-storage-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-storage-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-storage-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-storage-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️storage/mgmt/2021-06-01/storage [View full logs] [Release SDK Changes]info [Changelog] This is a new package info [Changelog]
- Only show 7 items here, please refer to log for details.
️✔️storage/mgmt/2021-04-01/storage [View full logs]info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New field `StartTime` in struct `AccessPolicy` info [Changelog] - New field `ExpiryTime` in struct `AccessPolicy` info [Changelog] info [Changelog] Total 1 breaking change(s), 1 additive change(s).
️✔️storage/mgmt/2021-02-01/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️storage/mgmt/2021-01-01/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
- Only show 7 items here, please refer to log for details.
️✔️storage/mgmt/2019-06-01/storage [View full logs]info [Changelog] - New field `EnableAutoTierToHotFromCool` in struct `ManagementPolicyBaseBlob` info [Changelog] - New field `AllowSharedKeyAccess` in struct `AccountPropertiesCreateParameters` info [Changelog] - New field `AllowSharedKeyAccess` in struct `AccountProperties` info [Changelog] - New field `AllowSharedKeyAccess` in struct `AccountPropertiesUpdateParameters` info [Changelog] - New field `RetentionInDays` in struct `ChangeFeed` info [Changelog] info [Changelog] Total 1 breaking change(s), 63 additive change(s).
- Only show 7 items here, please refer to log for details.
️✔️storage/mgmt/2019-04-01/storage [View full logs]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New field `AllowSharedKeyAccess` in struct `AccountProperties` info [Changelog] - New field `AllowSharedKeyAccess` in struct `AccountPropertiesUpdateParameters` info [Changelog] - New field `AllowSharedKeyAccess` in struct `AccountPropertiesCreateParameters` info [Changelog] info [Changelog] Total 0 breaking change(s), 3 additive change(s).
️✔️storage/mgmt/2018-11-01/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️storage/mgmt/2018-02-01/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️storage/mgmt/2017-10-01/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️storage/mgmt/2017-06-01/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️storage/mgmt/2016-12-01/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️storage/mgmt/2016-05-01/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️storage/mgmt/2016-01-01/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️storage/mgmt/2015-06-15/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/storage/mgmt/2020-08-01-preview/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/storage/mgmt/2018-07-01-preview/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/storage/mgmt/2018-03-01-preview/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/storage/mgmt/2015-05-01-preview/storage [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️armstorage [View full logs] [Release SDK Changes]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `ActiveDirectoryPropertiesAccountTypeComputer` info [Changelog] - New const `AllowedCopyScopePrivateLink` info [Changelog] - New const `ActiveDirectoryPropertiesAccountTypeUser` info [Changelog] - New const `AllowedCopyScopeAAD` info [Changelog] - New function `PossibleActiveDirectoryPropertiesAccountTypeValues() []ActiveDirectoryPropertiesAccountType` info [Changelog] - New function `*LocalUsersClient.CreateOrUpdate(context.Context, string, string, string, LocalUser, *LocalUsersCreateOrUpdateOptions) (LocalUsersCreateOrUpdateResponse, error)` info [Changelog] - New function `NewLocalUsersClient(string, azcore.TokenCredential, *arm.ClientOptions) *LocalUsersClient` info [Changelog] - New function `PossibleAllowedCopyScopeValues() []AllowedCopyScope` info [Changelog] - New function `LocalUsers.MarshalJSON() ([]byte, error)` info [Changelog] - New function `LocalUserKeys.MarshalJSON() ([]byte, error)` info [Changelog] - New function `LocalUser.MarshalJSON() ([]byte, error)` info [Changelog] - New function `*LocalUsersClient.ListKeys(context.Context, string, string, string, *LocalUsersListKeysOptions) (LocalUsersListKeysResponse, error)` info [Changelog] - New function `*LocalUsersClient.List(context.Context, string, string, *LocalUsersListOptions) (LocalUsersListResponse, error)` info [Changelog] - New function `*LocalUsersClient.RegeneratePassword(context.Context, string, string, string, *LocalUsersRegeneratePasswordOptions) (LocalUsersRegeneratePasswordResponse, error)` info [Changelog] - New function `AllowedCopyScope.ToPtr() *AllowedCopyScope` info [Changelog] - New function `LocalUserProperties.MarshalJSON() ([]byte, error)` info [Changelog] - New function `*LocalUsersClient.Get(context.Context, string, string, string, *LocalUsersGetOptions) (LocalUsersGetResponse, error)` info [Changelog] - New function `ActiveDirectoryPropertiesAccountType.ToPtr() *ActiveDirectoryPropertiesAccountType` info [Changelog] - New function `*LocalUsersClient.Delete(context.Context, string, string, string, *LocalUsersDeleteOptions) (LocalUsersDeleteResponse, error)` info [Changelog] - New struct `LocalUser` info [Changelog] - New struct `LocalUserKeys` info [Changelog] - New struct `LocalUserProperties` info [Changelog] - New struct `LocalUserRegeneratePasswordResult` info [Changelog] - New struct `LocalUsers` info [Changelog] - New struct `LocalUsersClient` info [Changelog] - New struct `LocalUsersCreateOrUpdateOptions` info [Changelog] - New struct `LocalUsersCreateOrUpdateResponse` info [Changelog] - New struct `LocalUsersCreateOrUpdateResult` info [Changelog] - New struct `LocalUsersDeleteOptions` info [Changelog] - New struct `LocalUsersDeleteResponse` info [Changelog] - New struct `LocalUsersGetOptions` info [Changelog] - New struct `LocalUsersGetResponse` info [Changelog] - New struct `LocalUsersGetResult` info [Changelog] - New struct `LocalUsersListKeysOptions` info [Changelog] - New struct `LocalUsersListKeysResponse` info [Changelog] - New struct `LocalUsersListKeysResult` info [Changelog] - New struct `LocalUsersListOptions` info [Changelog] - New struct `LocalUsersListResponse` info [Changelog] - New struct `LocalUsersListResult` info [Changelog] - New struct `LocalUsersRegeneratePasswordOptions` info [Changelog] - New struct `LocalUsersRegeneratePasswordResponse` info [Changelog] - New struct `LocalUsersRegeneratePasswordResult` info [Changelog] - New struct `PermissionScope` info [Changelog] - New struct `SSHPublicKey` info [Changelog] - New field `EncryptionFederatedIdentityClientID` in struct `EncryptionIdentity` info [Changelog] - New field `AllowedCopyScope` in struct `StorageAccountProperties` info [Changelog] - New field `IsSftpEnabled` in struct `StorageAccountProperties` info [Changelog] - New field `IsLocalUserEnabled` in struct `StorageAccountProperties` info [Changelog] - New field `AllowedCopyScope` in struct `StorageAccountPropertiesCreateParameters` info [Changelog] - New field `IsLocalUserEnabled` in struct `StorageAccountPropertiesCreateParameters` info [Changelog] - New field `IsSftpEnabled` in struct `StorageAccountPropertiesCreateParameters` info [Changelog] - New field `AccountType` in struct `ActiveDirectoryProperties` info [Changelog] - New field `SamAccountName` in struct `ActiveDirectoryProperties` info [Changelog] - New field `IsLocalUserEnabled` in struct `StorageAccountPropertiesUpdateParameters` info [Changelog] - New field `IsSftpEnabled` in struct `StorageAccountPropertiesUpdateParameters` info [Changelog] - New field `AllowedCopyScope` in struct `StorageAccountPropertiesUpdateParameters` info [Changelog] info [Changelog] Total 0 breaking change(s), 74 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json cmderr [automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist cmderr [automation_init.sh] uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. cmderr [automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js cmderr [automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file. cmderr [automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself. warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json warn No file changes detected after generation warn No package detected after generation
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️storage [View full logs] [Release Schema Changes]
ghost
added
the
|
Hi @zfchen95, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Nov 4, 2021
blueww
reviewed
Nov 4, 2021
specification/storage/resource-manager/Microsoft.Storage/stable/2021-08-01/storage.json
Show resolved
Hide resolved
blueww
reviewed
Nov 5, 2021
specification/storage/resource-manager/Microsoft.Storage/stable/2021-08-01/storage.json
Show resolved
Hide resolved
|
May I know why the python track2 SDK from CI pipeline doesn't contain the new api version? Where can I find the private Python SDK for CLI prototype? |
|
@zfchen95 |
Done |
|
@zfchen95 could you fix the https://github.com/Azure/azure-rest-api-specs/pull/16659/checks?check_run_id=4412720413 , other s look fine |
|
Hi, @zfchen95. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
11 tasks
|
@weidongxu-microsoft @qiaozha @msyyc could you help confirm the SDK generation failures @zhenglaizhang could you help confirm ApiDocPreview failure |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jianyexi Java failed when generating SDK examples, so code is likely good. I will check this later. This should not block the PR. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ArcturusZhang
requested changes
Jan 5, 2022
There was a problem hiding this comment.
Please make sure to apply the same changes from #17027 to your new api-version. This is important to keep our SDKs stable.
specification/storage/resource-manager/Microsoft.Storage/stable/2021-08-01/blob.json
Show resolved
Hide resolved
ArcturusZhang
approved these changes
Jan 7, 2022
This was referenced Jan 7, 2022
Merged
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jan 7, 2022
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* Copy the spec from 2021-06-01 to 2021-08-01 * Apply the API and property changes in 2021-08-01 * Fix format * Update readme and add tag 2021-08 * Add isLocalUserEnabled and isSftpEnabled properties; add examples for ActiveDirectoryProperties * Fix missing bracket and format issue; add required properties for permissionScopes * Create readme.python.md * Remove unreferenced file * Add explicit type:object * Add default responses and system data field * Fix example of Create Local User * Update descriptions * Remove secret tag * Revert "Remove secret tag" This reverts commit 45b1c7b. * Update LocalUserCreate.json * Update the local user properties definition * fix readme * apply Azure#17027 to this PR Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Arcturus Zhang <dapzhang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.