Zone mappings fix #16667
Merged
Zone mappings fix #16667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @tjegbejimba Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a new property 'zoneMappings' in response that was not found in the old version. New: Microsoft.Resources/stable/2021-01-01/resources.json#L4941:7 Old: Microsoft.Resources/stable/2021-01-01/resources.json#L4941:7 |
|
The new version has a new property 'zoneMappings' in response that was not found in the old version. New: Microsoft.Resources/stable/2021-04-01/resources.json#L4977:7 Old: Microsoft.Resources/stable/2021-04-01/resources.json#L4977:7 |
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
|
Hi @tjegbejimba, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Nov 4, 2021
Closed
|
Hi @tjegbejimba, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@tjegbejimba , please follow above action to get breaking change approved. |
JeffreyRichter
added
the
Approved-BreakingChange
|
@raych1 The breaking changes have been approved |
@tjegbejimba , |
|
Hi, @tjegbejimba. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
raych1
approved these changes
Dec 6, 2021
This was referenced Dec 6, 2021
Closed
akning-ms
added a commit
that referenced
this pull request
Jan 20, 2022
…est main branch (#17414) * containerservice-multiapi-config (#16837) * update * Update readme.python.md * Update readme.md Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * add type to enums to fix Linter error R3015 (#16775) * Add Track2 release go tag (#16847) * Add Track2 release go tag * recover * Added billing subscription APIs in new 2021-10-01 version (#16653) * Ported Microsoft.Billing 20211001 to main * Prettier fixes for Microsoft.Billing 20211001 * Updated readme.cmd package-2021-10 * Deleted old replaced example * Fix quotas in PR template (#16866) * directive (#16869) * fixing typo in closing param tag (#16873) * Published/azure/azure rest api specs pr/dev orbital microsoft.orbital 2021 04 04 preview (#16877) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * Orbital sdk 2021 04 04 preview (#5253) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Added orbital.json file * Passed linting using AutoRest for 2020-09-01 Azure Orbital Private Privew * Updated Operation object under Azure Orbital 2020-09-01 preview. * Updated Operation object under Azure Orbital 2020-09-01 preview. * Updated Satellites object for Azure Orbital 2020-09-01 preview * Updated examples for Azure Orbital Private Preview 2020-09-01 * Updated examples for Azure Orbital Private Preview 2020-09-01 * Updated examples for Azure Orbital Private Preview 2020-09-01 * Addressed feedback from ARMChangesRequested * Updated the GetAvailableContacts api to add long running operation * Updated the api version * Updated the objects based on discussion with PM. * list available ground station made a POST request (#2521) * list available ground station made a POST request * Swagger LintDiff fix Co-authored-by: Devanshu Singh <devasingh@microsoft.com> * swagger specs for version-20210404-preview * removed cross version references. Copied over unchanged examples from the previous API version 2021-09-01-preview * removed availableGroundStations API * New Readme Config File New Go Language Readme Config File New Typescript Language Readme Config File New Python Language Readme Config File New C# Language Readme Config File New Ruby Language Readme Config File New Swagger Spec File New Swagger Example Spec File Added orbital.json file Passed linting using AutoRest for 2020-09-01 Azure Orbital Private Privew Updated Operation object under Azure Orbital 2020-09-01 preview. Updated Operation object under Azure Orbital 2020-09-01 preview. Updated Satellites object for Azure Orbital 2020-09-01 preview Updated examples for Azure Orbital Private Preview 2020-09-01 Updated examples for Azure Orbital Private Preview 2020-09-01 Updated examples for Azure Orbital Private Preview 2020-09-01 Addressed feedback from ARMChangesRequested Updated the GetAvailableContacts api to add long running operation Updated the api version Updated the objects based on discussion with PM. list available ground station made a POST request (#2521) * list available ground station made a POST request * Swagger LintDiff fix Co-authored-by: Devanshu Singh <devasingh@microsoft.com> * validation check changes. Avocado, SpellCheck and prettier * validation checks changes * Modify readme.md for sdk generation * added system data * sdk pre namer validation changes * lintdiff warning changes * add comms scenario swagger (#3794) * add comms scenario swagger * remove unused example * fix some validation errors * fix style issues * update spec based on feedback * add updated example files * fix CI errors * change endpoints/connections list APIs to posts from gets * connections lists from endpoints return resource IDs rather than full objects. * update examples files for endpoints connections list APIs * fix operationIds and add descriptions * fix more op ids and add descriptions for real * fix typos, add constraints, and remove kbps/gbps from bandwidth (#4023) * Updates to Resource Types (Modifications and Renames) (#4294) * update orbital.json * update examples * prettier fix * unfix old api version * fix ci issues * make more fields immutable * update provisioning states * swagger specs for Available groundstation APIs, version 2021-preview (#4920) * swagger specs for Available groundstation APIs, version 2021-preview * npm prettier check * added type object * removed capability and global comms info from responses * prettier fix * changed AP id response * changes to schema to follow ARM format, resource id update * Spelling check fix * Ground Station spell check * added groundstation to custom words * Revert "added groundstation to custom words" This reverts commit 0d7e18217de98836dcb8ba991685e15436004836. * Revert "Ground Station spell check" This reverts commit ef85b3b26f9ddf81dc1f50a9b677f9d8f115c4cf. * Revert "Spelling check fix" This reverts commit 6bd95c6e013889b6d488703846bbe87bbbb9c494. * word addition * type in response * type definition in swagger * readonly add Co-authored-by: Akanksha Bhattacharyya <akankshab@microsoft.com> * removed comms APIs * readme updated * fixed Swagger Avocado errors * swagger lintDiff fix 1 * swagger lintDiff fix 2 * swagger lintDiff fix 3 Co-authored-by: Sunny Patel <sunny27710@gmail.com> Co-authored-by: Sunny Patel <sunpatel@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com> Co-authored-by: Devanshu Singh <devasingh@microsoft.com> Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com> Co-authored-by: Jim Harris <72156062+MicrosoftJim@users.noreply.github.com> Co-authored-by: Akanksha Bhattacharyya <akanksha.nb@gmail.com> Co-authored-by: Akanksha Bhattacharyya <akankshab@microsoft.com> * operation IDs updated (#5461) Co-authored-by: Devanshu Singh <devasingh@microsoft.com> * Dev orbital microsoft.orbital 2021 04 04 preview (#5491) * operation IDs updated * updated OperationListResult definition * review points implemented Co-authored-by: Devanshu Singh <devasingh@microsoft.com> * Azure Orbital - Review points implemented (#5507) * operation IDs updated * updated OperationListResult definition * review points implemented * referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types * reverting cloudError refs * prettify json * reorder some parameters Co-authored-by: Devanshu Singh <devasingh@microsoft.com> Co-authored-by: ArcturusZhang <dapzhang@microsoft.com> * Removed Empty allOf (#5510) * operation IDs updated * updated OperationListResult definition * review points implemented * referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types * reverting cloudError refs * prettify json * removed empty allOf * validation checks Co-authored-by: Devanshu Singh <devasingh@microsoft.com> * readme.go.md fixed (#5512) * operation IDs updated * updated OperationListResult definition * review points implemented * referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types * reverting cloudError refs * prettify json * removed empty allOf * validation checks * readme.go.md fixed Co-authored-by: Devanshu Singh <devasingh@microsoft.com> * Remove last empty allOf (#5513) * operation IDs updated * updated OperationListResult definition * review points implemented * referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types * reverting cloudError refs * prettify json * removed empty allOf * validation checks * readme.go.md fixed * remove one last empty allOf Co-authored-by: Devanshu Singh <devasingh@microsoft.com> * Add EventHubUri field to Contact Profile Co-authored-by: Devanshu Singh <8132290+thisisdevanshu@users.noreply.github.com> Co-authored-by: Sunny Patel <sunny27710@gmail.com> Co-authored-by: Sunny Patel <sunpatel@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com> Co-authored-by: Devanshu Singh <devasingh@microsoft.com> Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com> Co-authored-by: Jim Harris <72156062+MicrosoftJim@users.noreply.github.com> Co-authored-by: Akanksha Bhattacharyya <akanksha.nb@gmail.com> Co-authored-by: Akanksha Bhattacharyya <akankshab@microsoft.com> Co-authored-by: ArcturusZhang <dapzhang@microsoft.com> * add 2021-10-01-only tag (#16857) * add 2021-10-01-only tag * updating go java python readmes * Modify readme.go.md 11/25/2021 (#16879) * Track2 modify readme.go.md (#16870) * Dev loadtestservice microsoft.load test service 2021 11 01 preview pubpr (#16831) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * Added loadtestservice swagger spec * CI failure fix * Review comments fix * CI failure fix * Updated api version * Added x-ms-long-running-operation header for async delete * Update readme.md for python config * update readme.python for python config Co-authored-by: Yiming Lei <59104634+RAY-316@users.noreply.github.com> * [NetAppFiles] Anf 16015 net app files 2021-08-01 (#16381) * Add 2021-08-01 folder * Bump to api-version 2021-08 * Apply cahnges to api-version 2021-08 * Apply changes to api-version 2021-08 * Add VolumeGroups API * prettier * Add VolumeGroups API * Update volumeType desciption * Remove Name from backupPolicyPropertyBag * Remove Name from backupPolicy Examples * Recovery services backup october release (#16865) * RecoveryServicesBackup: Added ValidateOperationAsync APIs to new API version 2021-10-01 (#16291) * Added base for new API version 2021-10-01 from previous 2021-08-01 * Updates Readme * Updates API version in new specs and examples * Updated CRR related API in readme * Added PreCheckAsync new APIs * Removed incorrect long-running-operation tag * Renamed API as per PR review * RecoveryServicesBackup: Minor update to new ValidateOperation async API (#16402) * Added long running operation tag to async API * Updated examples with renamed tracking API * Recovery services backup october release (#16303) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-08-01 to 2021-10-01 * Update Swagger spec and examples * Update readme * Resolve Avocado and PrettierCheck issues * Resolve Model Validation issues * Adding package for active and passive stamp (#16695) * Updating readme to split active and passive stamp * Update * Updating readme.go * Fixing model validation errors * Fixing model validation * Adding enums for protectionIntent * Adding identity based restore details Co-authored-by: abhishek-goyal1 <70324004+abhishek-goyal1@users.noreply.github.com> Co-authored-by: Abhinit Kumar <89906029+abhinitkumar01@users.noreply.github.com> * typescript.md-update (#16863) * add new lint rules doc (#16712) * add two rules * add index * fix typo * add a new rule * update category * fix comments * fix comments Co-authored-by: jianye xi <jianyxi@microsoft.com> Co-authored-by: Tianxiang Chen <tianxchen@microsoft.com> * loadtestservice-typescript.md-update (#16892) * Update confluent.json (#16885) * Track2 modify readme.go.md 3 (#16886) * Track2 modify readme.go.md * directive modelerfour.lenient-model-deduplication=true * update comments (#16770) * update comments * update comments * update comments * [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-10-01 (#16853) * Updating readme.go * Adds base for updating Microsoft.RecoveryServices from version stable/2021-08-01 to version 2021-10-01 * Updates readme * Updates API version in new specs and examples * Revert "Updating readme.go" This reverts commit 4a49dbce02bebaaa8c0c62c7744b256444127a71. * Updating readme.go * Update specification/recoveryservicessiterecovery/resource-manager/readme.go.md Co-authored-by: Dapeng Zhang <ufo54153@gmail.com> Co-authored-by: Dapeng Zhang <ufo54153@gmail.com> * add deployment script and rename armTemplateDeployment to armTemplate (#16894) * add deployment script and rename armTemplateDeployment to armTemplate * fix comments Co-authored-by: Tianxiang Chen <tianxchen@microsoft.com> * eventgrid: fixing the identity type (#16844) The documentation states this supports `SystemAssigned, UserAssigned` however this value isn't specified * Update EventGrid Schema for Azure Container Registry (#16776) * Update EventGrid Schema for Azure Container Registry * prettier fix * Remove unused api (#16720) * Remove unused api * Remove unused example files * Updating k8s version in dualstack to valid version (#16874) Dualstack is only for >= 1.21 in AKS * [CosmosDB] Remove additional resources from Graph Resources (#16841) * test * try1 * fixing services discriminator * prettier and readme * revert additional changes * fixing model validation errors * model validation fix * nit * remove additional properties from Graph resources Co-authored-by: Meha Kaushik <mekaushi@microsoft.com> * Track2 modify readme.go.md 4 (#16902) * Track2 modify readme.go.md 4 * devops * portal-typescript.md-update (#16904) * Update README files to generate sdk in azure-sdk-for-net repo. (#16855) * Update README files to generate sdk in azure-sdk-for-net repo. * Changed namespace name. Co-authored-by: Santosh Mishra <sanmishra@microsoft.com> * Add Semantic configuration to Azure Search specs (#16777) * Add semantic skeleton * Add query time semantic configuration parameter * Add example for semantic configuration * Update descriptions * Fix syntax issue * IoT Central Public API 1.1-preview Oct Release (#16514) * Add new 2.0-preview.1 version for IoT Central * fix typo on enum value * rollback 1.0 changes, applied 2.0-preview.1 * fix typo * remove non-used examples * fix style * update version from 2.0-preview.1 to 1.1-preview * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload * add nextLink to collection of orgs * fix typo * fix wrong position of paging * fix the paging * add . to description * update default to use enum for api-version * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching * update examples * fix lint error, model validation * fix missing type in examples, remove url format * fix ID case * fix id case * fix ID case * add iotc query language reference * fix typo * Update descriptions + add newly supported languages * Add enum descriptions for languages * Fix syntax and spelling * Fix semantic configuration name * Run prettier * Add sdk naming for semantic * Rename internal semantic object * Add language names * Add MA-in * Add farsi * Fix country name typoes and add spelling entries Co-authored-by: Raouf Merouche <ramero@microsoft.com> Co-authored-by: Johnson Yang <hayang@microsoft.com> Co-authored-by: Wenyang Fu <wefu@microsoft.com> * Update examples and description for Catalog (#16761) * IoT Central Public API 1.1-preview Oct Release (#16514) * Add new 2.0-preview.1 version for IoT Central * fix typo on enum value * rollback 1.0 changes, applied 2.0-preview.1 * fix typo * remove non-used examples * fix style * update version from 2.0-preview.1 to 1.1-preview * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload * add nextLink to collection of orgs * fix typo * fix wrong position of paging * fix the paging * add . to description * update default to use enum for api-version * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching * update examples * fix lint error, model validation * fix missing type in examples, remove url format * fix ID case * fix id case * fix ID case * add iotc query language reference * fix typo * update examples and description * Update purviewcatalog.json * update examples for query * update example & parameter name * Update purviewcatalog.json Co-authored-by: Johnson Yang <hayang@microsoft.com> * Storage File RenameIgnoreReadOnly parameter was incorrect (#16916) * Removes an unexpected character in the README file, which was causing issues when running autorest command. (#16911) Co-authored-by: Lucas Santos <lucassantos@microsoft.com> * Image Builder 2021-10-01 API (Gen2 Support, Error Schema Fix) (#16669) * first commit * first changes for 2021 version * updated readme.md * changed systemData path to v1 and removed in CloudError * renpeng description change * removed location from ListImageTemplates.json * removing more locations from examples * adding back location * common types resource * TrackedResource referenced * added location for listimagetempbyrg.json * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2021-10-01 (#16893) * Fixed Validation Correctness Error Detail Dataset * Fixed example property casing * Fixed model check * Add missing alert detais fields (#16778) * Track2 modify readme.go.md 5 (#16925) * Fix module name (#16926) * Placed Dot NET Sdk repo at correct position in README.md file (#16929) * Update README files to generate sdk in azure-sdk-for-net repo. * Changed namespace name. * Moved Dot NET sdk repo path up. Co-authored-by: Santosh Mishra <sanmishra@microsoft.com> * [Maps] Review request for Geocode to add version preview/2021-11-01-preview (#16664) * added Geocode API * Fixed a few issues with swagger and examples * Add x-ms-error-response to response codes * Fixed the error responses in sample * Fixed the format of sameple file * Fixed the operation name * Fixed spelling and prettier issues * move geocode folder to parent folder * update some descriptions * add geocode batch api * update batch geocode api example * update goecode batch api description * remove summayr field * address comments * update the strictMatch type to enum * update forward geocode sample query * update batchItem schema * fix the prettier issue * Fixed the $ref for some defitions * apply prettier * add readme to fix avacado error * upper case the parameter & response definition * address review board comments * address review board comments * structuralize request body of geocode batch api * update forward geocode sample json format * 1. adjust geocode batch api description due to the request body format change 2. add nextLink field to batch response * fix sdk track2 fail * update naming from geocode to geocoding * address review comments * add status code 206 to batch api * update api version * add optionalId * fix prettier error, add name to enum field for better code generation * update post api method name * move api key from header to query * move geocoding to search folder * change apiKey from query to header * improve the class name in sdk generation * update description * comment out python and java sdk generation since it's manually generated now * update description * add an api example Co-authored-by: Hongwei Sun <hongweis@microsoft.com> * Dec. release tag (#16932) * fix nullable (#16786) * [Synapse] Fix for parameter in Notebook activity (#16852) * fix for notebook activity parameter * remove required property * BugFix - Fixing a type error in the suppression directive usage (#16903) * [Do Not Merge]: Asr new version2021 11 01 (#16890) * introducing 2021-11-01 version * Adding inmage fields * branch * readme files * Correcting file name * prettier checks * SEMANTIC VALIDATIONS * prettier checks * Fixes * Fixes * Fixes * Fixes * Fixes * Update service.json * LintDiff fix Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Vishnu Priya Ananthu Sundaram <viananth@microsoft.com> * Revert "[Do Not Merge]: Asr new version2021 11 01 (#16890)" (#16951) This reverts commit 27fd919adafd7ad200bcc1296b50e075b5e4fc5a. * Add LRO property for deletion-jobs API (#16832) * add LRO property * fix the api * Zone mappings fix (#16667) * remove name validation from client side * remove name check from deploymentScripts swagger * remove name check from previous swagger versions * remove pattern from resourcegroupname parameter * add missing zoneMappings property to resources * fix linter errors * Update issue_assignment.yml (#16958) * Update monitor to latest package 2021-09 (#16746) * Remove OperationsHealth.json spec files and corresponding example files (#16940) * Track2 modify readme.go.md 6 (#16949) * Track2 modify readme.go.md 6 * mariadb derective description * Fixing s360 correctness items (#16953) * Fixing s360 correctness items * Fixing spell check and prettier * Updating Managed Identity type enum with space to make it consistent with RP behaviour (#16915) * Duplicating common-types v3 to v4 * updating version * adding space to SystemAssigned, UserAssigned" * removing unchanged files. Co-authored-by: Praveenkumar Ravikumar <prravikumar@microsoft.com> * [Azure Maps] Add the boundingBox type to Search (#16930) * Add address boundingbox def * Add entity enum * adding data plane apis for load test service (#16967) * adding data plane apis for load test service * adding custom words Co-authored-by: Krishna Chandak <krchanda@microsoft.com> * [Hub Generated] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 (#16706) * added extra fields to JSON list data response in docs * added content-type field to request header * took out content type from header field due to errors; JSON reponse fields for user Data are ready to commit * added content-type header to userData update docs * added a change which fixed prettier check * changed name of enum * added reference to ContentType * trying to add contenttype to docs * adding content type header * trying to add content type header to userDate update docs * adding content type header to update docs * adding example parameter for new content-type request header * changed xs-parameter-location * trying to fix invalid type error * Trying to fix model error * trying new changes * Making final changes: added content type header * getting rid of content type header changes to work on a diff bug * added corresponding content types for dataFormat in upload preview * reverting changes due to unforseen model errors * adding dataFormats that correspond to content-type * was missing a quote * changed format of some wording * adding schema to swagger spec for 400 response for data upload preview * fixing changes * reverted changes * trying to remove body from response examples * adding schema to 400 response in data upload * reverting changes again * adding schema to 400 response in data upload * removed header from 400 response * adding schema * reverting all changes * trying changes * reverting again 2.0 * moving responses to directions section * semantic validation changes * fixing model val errors * fixing model val errors * got rid of model val errors * fixing prettier check errors * fixing another prettier check error * fixed error code response message * removing required properties * removing unneeded definitions * fixed prettier check issues again * deleted 200 response for data update (LRO) * got rid of headers * added header back for download 200 * added 200 response back to data update * added content type header into user update * fixing invalid type err * trying to fix invalid type * reverting content type header changes * adding header to 202 response * Track2 modify readme.go.md 8 (#16973) * Track2 modify readme.go.md 8 * backup,siterecovery into recoveryservices * Datafactory duplicate schema issue (#16585) * require DataFlow * ManagedPrivateEndpoint,ManagedVirtualNetwork * fix * xx * ManagedPrivateEndpoint delete discriminator * Duplicate Schema named 'BlobEventTypes' * prettier * keep the enum type unchanged Co-authored-by: ArcturusZhang <dapzhang@microsoft.com> * add Win2022DataCenter alias (#16952) * [Communication] Adding 2022-02-01 NetworkTraversal API version for General Availability (#16946) * Adding base-line 2022-02-01 swagger * Making updates based on REST API feedback * Comments * Removed x-ms-content-type from File Rename (#17011) * Update consumption.json (#17012) * Update Azure Stream Analytics CLI to 0.1.1 (#16880) - simplify the name of group/command/parameter - add alias to parameters * Utkarshjain/elastic (#16979) * base api commit * adding 2021-09-01-preview * added 2021-10-01-preview * updating readme files * Fixing python readme * Fixing readme * Fixing readme * Fixing readme * adding elastic upgrade APIs Co-authored-by: Utkarsh Jain <utkarshjain@microsoft.com> Co-authored-by: pmp <pmp@microsoft.com> * Update SUSE aliases (#16707) * change js codegen config (#16909) * arnavshringi-patch-1 (#16975) * Added "readonly" in 2021-03-01-preview * Added "readonly" in 2021-09-01 * Fixed description of ConditionalOperator (#16267) * Fixed description of ConditionalOperator * Truncated description of ConditionalOperator Co-authored-by: Avi Jerafi <avjerafi@microsoft.com> * Fix in JobSupportedAction (#16986) * Fixing s360 correctness items * Fixing spell check and prettier * Updating latest version in readme * Fix in jobsupportedAction * Adding 2021-12-01-preview version for Microsoft.DataProtection (from latest stable version) (#16983) * Base_Copy 2021-07-01 version to 2021-12-01-preview * Adding changes to preview verion * updating readme * Add batch tag imagebuilder package-2021-10 (#17018) * add xiaoxuqi as reviewer (#17020) * Microsoft.SecurityInsights 2021-09-01-preview (#16933) * Adds base for updating Microsoft.SecurityInsights from version preview/2021-03-01-preview to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * Microsoft.security insights 2021 09 01 preview add missing resources (#15531) * Copy missing resources specs and examples from 2019-01-01-preview * Update added resources specs and examples and extract common types * Update readme * Extract ClientInfo, UserInfo and Lable to common types * Fix SpellCheck and Avocado * Return ThreatIntelligence to readme * Fix broken refs in Watchlists * Resolve duplicate schema errors * Run prettier * Make common types prettier * Add required property to operations according to ARM requirments * Fix readme * Add file separators to readme * Rename example file * Supress OBJECT_ADDITIONAL_PROPERTIES * Add 'where' to OBJECT_ADDITIONAL_PROPERTIES supression * Move OBJECT_ADDITIONAL_PROPERTIES supression under general Supression section. * Copy dataConnectors from 2021-03-01-preview * Update version of dataConnectors (this was done as there were errors when trying to generate C# client. Copying and changing version again fixed the problem). * Add dataConnectorsCheckRequirments path, parameters and definitions from 2019-01-01-preveiw Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Use newest common types in new 2021-09-01-preview API version (#15778) * Use newest common types in AlertRules * Use newest common types in AutomationRules * Use newest common types in Bookmarks * Use newest common types in dataConnectors * Use newest common types in Enrichment * Use newest common types in Entities * Use newest common types in EntityQueries * Use newest common types in Incidents * Use newest common types in Metadata * Use newest common types in OfficeConsents * Use newest common types in OnboardingStates * Use newest common types in operations * Use newest common types in Settings * Use newest common types in SourceControls * Use newest common types in ThreatIntelligence * Use newest common types in Watchlist * Use newest common types in EntityTypes * Use newest common types in RelationTypes * Fix ThreatIntelligence Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Add template version to the scheduled alert rule + scheduled template (#15919) * Add template version to the scheduled alert rule * Update AlertRules.json * Update AlertRules.json * Update AlertRules.json * Update AlertRules.json * Update GetAlertRuleTemplates.json * Update GetAlertRuleTemplateById.json * add aws s3 connector (#15844) * Add a new kind of alert rules - NRT (#15980) * add NRT rule * add NRT rule * add NRT rule * add NRT rule * fix typo * fix typo * fix * Align new Metadata feature with 2021-03-01-preview (#16304) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Add fixes from 2021-03-01-preview (#16238) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Add entity query templates (#16269) * Add entity query templates from 2021-03-01-preview * Update version * Use newest common types and update readme * Fix conflicting common types Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Fix bookmark relations operatinIds to be consistent with other operationIds. (#16519) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Add corrections from 2021-03-01-preview (#16490) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Remove unused parameters (#16619) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Update readme default readme tag for client generation (#16620) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Use CloudError instead of ErrorResponse to avoid breaking change (#16691) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Add data connectors polling ccp api support (#16293) * adding dataConnectors polling CCP api Support. (witout tests validations) * azure sentinel dataconnectors update examples * azure sentinel dataConnectors examples update and fix * azure sentinel dataConnectors prettier * azure sentinel dataConnectors add connect disconnect examples update path * azure sentinel dataConnectors add connect disconnect examples fix * azure sentinel dataConnectors add connect disconnect examples fix 2 * azure sentinel dataConnectors rebase dataConnectors dev * azure sentinel dataconnectors - fix put to post on connect and disconnect endpoints * azure sentinel dataconnectors - adding x-ms-secret to password on connect * azure sentinel dataconnectors - connect/disconnect endpoint remove unnedded 201 return * azure sentinel dataConnectors - remove empty body DataConnectorDisconnectBody Co-authored-by: Alon Danoch <adanoch@microsoft.com> * Add office IRM Connector (#16764) * Add office IRM * fix * fix * fix * fix Co-authored-by: omerhaimov <omer.haimovich@gmail.com> * Add teamInformation to IncidentProperties 2021-09-01-preview (#16787) * Fix Swagger for SecurityInsights - Add teamInformation to IncidentProperties * Try change description as advised by Swagger reviewer Yuchao Yan to fix the validation error. * Revert change in ntDomain description as it has nothing to do with validations Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Make CloudError and CloudErrorBody external resources (already exist under Microsoft.Rest.Azure namespace) (#16872) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Remove operational insights parameter 2021 09 01 preview (#16891) * Remove operationalInsightsResourceProvider parameter from specs * Remove parameter from examples Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Update EntityTypes.json (#16972) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> Co-authored-by: Amit Bergman <38046493+Amitbergman@users.noreply.github.com> Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com> Co-authored-by: necoh <53861229+necoh@users.noreply.github.com> Co-authored-by: alondanoch <alondanoch@hotmail.com> Co-authored-by: Alon Danoch <adanoch@microsoft.com> Co-authored-by: omerhaimov <55688621+omerhaimov@users.noreply.github.com> Co-authored-by: omerhaimov <omer.haimovich@gmail.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Add version 2018-04-02 into IMDS Swagger (#16937) * Adding swagger for version 2020-12-01 * Reverting new version * Adds base for updating Microsoft.InstanceMetadataService from version stable/2018-10-01 to version 2018-04-02 * Updates readme * Updates API version in new specs and examples * Swagger for 2018-04-02 * Updating readme * Adding new versions to readme * ??? * Small json change to rebuild Co-authored-by: jmccarthy <jmccarthy@microsoft.com> * Update readme.md (#17026) * [Go] Track2 modify readme.go.md 9 (#17000) * [Go] Track2 modify readme.go.md 9 * fix * Track2 modify readme.go.md 7 (#16971) * [Go] track2 modify readme.go.md 10 (#17002) * [Go] track2 modify readme.go.md 10 * add go batch tag multiapi * version to version_with_hyphens * remove videoindexer * fix * output-folder add mgmt * Review request for Microsoft.BotService to update version stable/2021-03-01 (#16882) * fix api * add name property * update OP Channels_ListWithKeys * update type * mark the parameter value as x-ms-secret * allow null in value * ' * sync changes to 2021-05-01-preview Co-authored-by: FAREAST\hond <hond@microsoft.com> * [Go] Add other resources module name (#17039) * [Go] Add other resources module name * fix * Adding missing advanced filters (#16997) * [Maps][Search V2] Update Geocoding api name (#16943) * update api name * add x-ms-client-name to fix the generated sdk method name * fix prettier fail * add Search category to geocoding apis * remove preview in the operationId and add it to description * Fix view example issue (#17046) * add `x-ms-enum` for sql (#17028) * add x-ms-enum for sql * fix to make sure track 1 generator is happy * [DO NOT MERGE]Dev resourcemover microsoft.migrate 2021 08 01 (#15496) * Adds base for updating Microsoft.Migrate from version stable/2021-01-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * Added systemData property in Move Collection & Move Resource object * Update resourcemovercollection.json Added Tags and User-Managed Identities Properties * Update resourcemovercollection.json Made changes for removing tags property for document resources and resource group. * Removed additional empty line * Swagger PrettierCheck * Updating examples for 2021-08-01 version. * CI Fix Co-authored-by: Anany Shah <anashah@microsoft.com> Co-authored-by: yashjain4 <87814230+yashjain4@users.noreply.github.com> * CosmosDB: Fix resource IDs in SqlContainer examples (#17030) * config readme.python (#17054) * [Microsoft.DeviceUpdate] Private Link - Added Network RP required properties (#17042) * Added group IDs array to PrivateEndpointConnection in v4 common type * Added private endpoint connections to the top level resource * Updated examples * Added types.json to commopn-types/v4 * Moved new version of privatelinks.json into our directory * Wrong level * Added period to the end of description for consistency * Updated version in privatelinks.json * Removed duplicate resource from privatelinks.json * Made PrivateEndpointConnection.properties required, added PEC payload to examples * Added Operations List example * Referenced Operations example file from the swagger * Reduce number of operations in the Operations_List example * Fixed Operations List example * Removed PrivateEnpointConnection from Account update example * datafactory, clean directive after Dapeng (#17016) * Schema resource added in REST API Spec for api-version 2021-08-01 (#16715) * Adds base for updating Microsoft.ApiManagement from version preview/2021-01-01-preview to version 2021-04-01-preview * Updates readme * Updates API version in new specs and examples * Added support for GraphQL API type (#14851) * Added support for GraphQL API type * Added missing enum value for GraphQL APIs. * add schema definition fix from 2021-01-01-preview (#14883) Co-authored-by: Alan Feng <alanfeng@microsoft.com> * Vanguard: Get Outbound Network Dependency (#14900) * outbound dependency * fix resource * Update backup/restore API for managed identities (#14973) * Update backup/restore API for system-assigned and user-assigned identities * Fix formatting issue * Rename user-assigned-msi-client-id with client-id * SystemData implemenation on API Management Control Plane (#14899) * system-data * fix spec * remove unreferenced file * APIM - Network Watcher Connectivity Check integration specs (#15056) * Connectivity Check API Specs * Fix * Fix errors * style fixs * Fix 202 code * HTTPConnect request parameters * Fix errors Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com> * Parameter examples added (#14836) * platformversion (#15114) * fix update service (#15478) * HttpConnect example (#15493) * HttpConnect example * Prettifier fix Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com> * Rename from SchemaContract to ApiSchemaContract * apimschema.json added to last apim preview version * Completing specification for Schema resource. Fixing changes in SchemaContract. * Value field added to Schema resource specification. * path fixed. Renamed from ApiSchema to Schema. Adding suppression rule to readme.md Custom word added for spellcheck * Fixing PR observations. * Added properties of difference API spec format for "SchemaDocumentProperties" (#15703) * add schema definition fix from 2021-01-01-preview * added properties for SchemaDocumentProperties * updated the fix * updated fix * [APIM]Add private endpoint connection APIs (#15115) * Add private endpoint connection apis * add readme * quick fixes * fix to PE contract * Small fixes * small fixes * small fixes * Small fixes * small fixes * small fix * small fixes * small fixes * small fixes * Update readme.md * fix error * small fix * fix format * address comments * small fixes * Change to lower case * small fixes Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * Adds base for updating Microsoft.ApiManagement from version preview/2021-04-01-preview to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * Merge main * Modifications to Schema definition to add "description" field. Updating examples of Schema. * Fixing apimanagement.json * Prettier applied in files * Fixing PR comments * fixing x-ms-long-running-operation. * x-ms-long-running-operation : true in apischema. * Removing "Resource" type from apimanagement.json * Apimschema.json updated to point to types.json for ErrorResponse. * Merging from 2021-04-01-preview to 2021-08-01 stable version. * undoing change of responseBody * Updating ErrorResponse. * Fixing definitions merge. * Changing definitions to fix output of examples. * Changes in definitions * Updating response in some examples. * Rolling back ApiSchema -> Schema Schema -> GlobalSchema * Changes to undo apimapis.json and adding prefix for Global example Schemas. * Setting x-ms-long-running-operation-options to location. Co-authored-by: Samir Solanki <samirsolanki@outlook.com> Co-authored-by: Alexander Zaslonov <zaslonov.alexander@gmail.com> Co-authored-by: DreamlessA <DreamlessA@users.noreply.github.com> Co-authored-by: Alan Feng <alanfeng@microsoft.com> Co-authored-by: Jatin Sanghvi <20547963+JatinSanghvi@users.noreply.github.com> Co-authored-by: Nicolás Barrera <nicolasbarrera@outlook.com> Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com> Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com> Co-authored-by: Christian Palomares <cpalomar@microsoft.com> Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * Remove Preview PrometheusRuleGroups resource type (#17060) This reverts commit 9dee51c3deb2b76628f6496665d53861cdb7efcf. * [Azure SignalR Service]changes introduced by new version of Swashbuckle (#16906) * [Azure SignalR Service]changes introduced by new version of Swashbuckle * add back default value * revert parameter orders * Update settings.json * videoanalyzer-readme-update (#17080) * Updated code owner for ADF (#17069) * Adding UAMI properties to the swagger (#16947) * Adding UAMI properties to the swagger * Update readme.go.md * fixing invalid exmaples of uuid * Update readme.go.md Co-authored-by: ArcturusZhang <dapzhang@microsoft.com> * Microsoft.DigitalTwins: add new Data Plane API Version 2021-06-30-preview (#16963) * Add swagger for new API version * Add new API version to autorest config * Relax parameter by removing enum restriction * Fix Go and Python config * Add config for Java SDK * Fix spacing * Add back enum value * Update headers in example (#17084) * Add `x-ms-enum` extension to keyvault (#17055) * fix * make these two sealed enums * Update Entity_ListByGuids.json (#17098) * Azure Notification Hubs Revert Namespace List Keys Change (#16221) * Revert namespace list keys * Changing results to proper type * [Hub Generated] Review request for Microsoft.Cache to add version stable/2021-06-01 (#15828) * Adds base for updating Microsoft.Cache from version stable/2020-12-01 to version 2021-06-01 * Updates readme * Updates API version in new specs and examples * Adding managed identities param * lint correction * Introduce common-types definitions useful for services that support ManagedIdentity. * Refactor latest redis.json to be the first usage of the new ManagedServiceIdentity definition from common-types. * Fix spellCheck failures * Fix model, redis service identity should be modeled as updatable. * modifying example response * ManagedServiceIdentityType should be modeled as string for extensibility. * Add commontypes/resource-management/v3/managedidentity which models managed identity for services supporting both SystemAssignedIdentity and UserAssignedIdentity. * fixing ROUNDTRIP_ADDITIONAL_PROPERTY s360 issue * redisConfiguration changes, Add Identity to resp * Fixing swagger lintdiff error * Add a canonical SystemAssignedServiceIdentityType type definition which supports 'None', since that is required going forward. Also make the 'type' property required, since omitting it from the request would not be clear in intent. * adding back additional properties * prettier fix * Add principalId and tenantId. * Update patch responses to include 202 when requests are longrunning * Adding swagger issue fixes made in last version * adding space in System&UserAssigned identity type * revert 78a8a8725558df64729569ccf38b2b83e3fb93b7 * updating managedidentity type version * adding example for 202 status code * reverting 202 status code addition Co-authored-by: Praveenkumar Ravikumar <prravikumar@microsoft.com> Co-authored-by: Tim Lovell-Smith <tilovell@microsoft.com> Co-authored-by: Chantal Olieman <choliema@microsoft.com> * Update openapi-authoring-automated-guidelines.md (#17101) * add `x-ms-enum` to storage (#17027) * add x-ms-enum to storage * add name * fix again * change one parameter name back to see if it breaks * change the parameter name back * update external link (#17100) * Update Anomaly Detection API (#16543) * update example * update result structure * update * update... * change version * delete test files * reset version * update last detect parameters * fix break changes * fix errors * update examples * add impute strategy * Add severity definition * update MultivariateAnomalyDetector.json * update examples * update swagger * update path * Revert "Merge branch 'main' into juaduan/mvad_swagger_latest" This reverts commit 9524fe794fb190bb7aea196d954203c55604efc5, reversing changes made to fef9721866e175d220def5ddfff69e15ce39add5. * fix merge errors * Create MultivariateAnomalyDetector.json * Revert "Create MultivariateAnomalyDetector.json" This reverts commit 35316761a348ea19c0ac585ebb5c17286ca603fb. * modify prop. of last detect request * uvad changes * Fix the brace problem * Fix uvad check errors * fix the x-ms-enum issue * Add impute strategy to examples * update swagger * update model * update readme * update example * update * update example * rename folder * update readme * update version of mvad * Update uvad to new version * update mvad json * change back * add api version * update api version * update examples * Fix version in uvad spec * fix api version in example * fix readme * update x-ms-parameterized-hots * update apiversion description * modify standard location * update nvad severity x-nullable * update uvad required fields * change name to body * modify standard location * change the x-nullable for impute * change error from list to obj * change x-nullable * remove nullable-false; modelAsString ture for enum * remove x-nullable false * Add severity to required fields of EntireDetectResponse and LastDetectResponse * remove the severity from required * update exmple name * update readme * Revert "update readme" This reverts commit 9d2790229b3280a7ea678cf4b1211d5a093b1b73. * add x-ms-error-code in examples * add x-ms-error-code * fix errors * update * update error responses * update * prettier * update default response * fix DetectAnomaly.json * Add x-ms-error-code and descriptions * fix the description typo * resolve comments * remove x-ms-error-response Co-authored-by: juaduan <juaduan@microsoft.com> Co-authored-by: Meng Ai <mengai@microsoft.com> Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> Co-authored-by: Xia Zhu <zhuxia@microsoft.com> * Added metadata to File and Directory Rename (#17087) * added propertied to classicaccount which contains the media services … (#17052) * added propertied to classicaccount which contains the media services inside of it * prettier * Add ActionType according to arm-rpc (#17078) * Add ActionType according to arm-rpc * add stable API version * add new rule XmsIdentifierValidation doc (#17076) * add new rule XmsIdentifierValidation doc * fix comment * fix comment * fix comment Co-authored-by: Tianxiang Chen <tianxchen@microsoft.com> * Creating new version( 2021-11-15) for passive stamp (#17044) * Adds base for updating Microsoft.RecoveryServices from version stable/2018-12-20 to version 2021-11-15 * Updates readme * Updates API version in new specs and examples * updating readme.md for C# * updating the api version * updating tag * updating active stamp tag * changes to fix checklist failures * changes to fix checklist failures-2 * Add batch tag for release track1 (#17111) * Adding 202 response code VM Patch operation.... (#16988) * adding 202 * 202 response for patch * example * [Go]Track2 modify readme.go.md 11 (#17099) * [Go]Track2 modify readme.go.md 11 * add go multiapi * remove addons * add directive * fix * beta to preview output-folder * Release microsoft.sql 2021 08 01 preview (#16968) * Adds base for updating Microsoft.Sql from version preview/2021-05-01-preview to version 2021-08-01-preview * Updates readme * Updates API version in new specs and examples * update default client tag to v5 * Generate the 2021-08-01-preview files from DSMainDev and commit * add new added ipv6 and example files * change "jobExecutionId": "5555-6666-7777-8888-999999999999" to "jobExecutionId": "5A86BF65-43AC-F258-2524-9E92992F97CA" in example files to pass the type validator * Add ListOperations.json example file * pass formatter npm pretty * update instanceFailoverGroups in the type of example files * remove ipv6 batch replace api due to arm concern. it will be in next version. * add x-ms-enum * Remove custom `ResourceGroupNameParameter` and replace them with the one from common-types (#16944) * remove custom resourceGroupNameParameter and replace them with the one from common-types * fix * move the directive that meant to work for go track 1 to readme.go.md * Revert "move the directive that meant to work for go track 1 to readme.go.md" This reverts commit bc9c13f8acdec3c8f29e5cd4a87bcefbfcf61f3a. * test * revert * add tag condition back * [Go] Delete saas track1 config (#17113) * [Go] Delete saas track1 config * fix * Update Go readme (#17061) Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com> * Added ParentId response header to File/Directory rename (#17119) * Revert dataset spelling change (#17124) * Dev datamigration microsoft.data migration 2020 09 01 preview (#16032) * Adds base for updating Microsoft.DataMigration from version stable/2021-06-30 to version 2020-09-01-preview * Updates readme * Updates API version in new specs and examples * add examples and change swagger * camel casing error (removing the resource since it is redundant) * added "systemData" property to the response of sqlMigrationService * adding isDataAction property in operationsDefinition * fixing Avocado error : removing unreferenced files * styling changes * adding systemData to DatabaseMigrations * suppressing lintDiff * Revert "styling changes" This reverts commit 4cba4308e6b3b4f35144f6ae28b4c760cd6f90f8. * formatting changes (after running npm run prettier) * adding v1 apis * adding v1 apis * Revert "adding v1 apis". Bad update This reverts commit 99b1f84465749a4948ece4cacfb63652b0cd5a4e. * Revert "adding v1 apis". Bad update This reverts commit 795344a819d2d72f3c86c3714274df48f5303205. * adding v1 paths in v2 spec * adding stable-2018 apis * updating api version in definitions * avocado error : removing unreferenced files * suppressing lintdiff errors R4013 and R4037 * removing subscriptioid parameter from v1 and referencing to susbscriptionid parameter from v2 (to resolve conflict) * adding v1 apis as a separate json file * adding a missing example for v1 spec * removing duplicate api (get operation) from v1 spec * Revert "removing duplicate api (get operation) from v1 spec" This reverts commit 545e6ff29239d3b33f393af8b8c4fd4021cebe1f. * avocado error : api versions correction * avocado error : adding definitions in readme and changing api version in v2 spec to 2020-09-01-preview * adding missing definitions and removing extra definitions in readme * removing operation path from v1 spec * trial : trying merging with 2021 stable version * nit errors in readme * updating api versions in definitions of 2021 stable version * removing operations api from v1 (stable 2021) * changing sqlMigrationInfo to sqlMigrationInformation in v2 swagger * Renaming FileShare to SqlFileShare in v2 spec * Renamimg BackupFileInfo to SqlBackupFileInfo in v2 spec * renaming BackupSeiInfdo to SqlBackupSetInfo in v2 spec * Renaming TrackedResource to TrackedResourceARM in the v1 spec * deleting duplicate subscriptionId parameter in v1 * sqlmigration casing error * referencing SystemData definition from the v2 spec * avacado error : removing unreferenced file Operations_List.json * adding custom-words.txt file * reverting adding custom-words.txt * exchanging positions of sqlmigration and datamigration in readme * adding sqlmigration in custom-words.txt * adding systemData to TrackedResource in v2 removing TrackedResourceARM from v1 and referring to v2 TrackedResource instead * adding "x-ms-azure-resource": true extension in DataMigrationService and Project definitions in v1 * changing veersion from 2020-09-01-preview to "2021-10-30-preview" * manually changing api version (to 2021-10-30)in readme * adding ooperations api to v1 spec * adding the subscriptionId parameter in v1 spec * adding operations_list in the examples (for v1) * Revert "adding ooperations api to v1 spec", adding the subscriptionId parameter in v1 spec, adding operations_list in the examples (for v1) This reverts commit b94a96d8f48edef45967a57050e09eb27f9ea0de, 40e80e0d2a8e9fab72443e3893a9f0712c224f0a, 7be34463aaf58418f4574d3df9288e64cd27c5e4 * removing x-ms-azure-resource extension * Revert "removing x-ms-azure-resource extension" This reverts commit 8bf42972d7a1f3e5f8f1f4bf0d1fad19b77a161c. * add subscriptionId to v1 spec * Revert "add subscriptionId to v1 spec" This reverts commit e3e729be0b1124875e279d9d718d8226dba2f8b8. * removing read only : true for systemData properties * setting readonly to true in systemData definition in v2 swagger. (note : the chnages in v2 swagger are done manually for now, change these from the RP side too) * renaming the specs to check if having the name datamigration.json has some importance * Revert "renaming the specs to check if having the name datamigration.json has some importance" This reverts commit a68c0c07d2a3f9932310eb910a683d1e824d7dfc. * adding "x-ms-azure-resource": true to trackedResource and removing it from datamigrationService and Project definition as they extend from trackedResource * correctly placing "x-ms-azure-resource": true * prettier check error on sqlmigration.json * referencing systemData from common-types/resource-management/v2/types.json#/definitions instead from v2 spec (to see if that affects the systemData error in cross-version) * Revert "referencing systemData from common-types/resource-management/v2/types.json#/definitions" This reverts commit 94641f1b36cc7828ea8efd21f4df89c282f51941. * keeping subscriptionId parameter in both specs (by renaming it in v2) * renaming subscriptionId to subscriptionIdParameter in the paths of v2 * casing error * using subscriptionIdParameter instead of subscriptionId in the examples of v2 * renaming subscriptionId to subscriptionidParameter in v2 example * Reverting the changes related to keeping subscriptionId parameter in both specs This reverts commit fa22043a2b4ca284466bacda244f19c087a78718, 13d549928711b2d85e776f0680a7347242582ac2, 2755f643ed32b766fbb98ed6a7fd814211aecea3, 6e74171367ddf0a4a9f7a6b36b8f41a65a2c7701, f3142b41b841793ae409a7e2d89d9bc4c262e9e7 * update tag in readme * renaming trackedResource to trackedResourceARM in v2 and restoring the trackedResource in v1 * Revert "renaming trackedResource to trackedResourceARM in v2 and restoring the trackedResource in v1" This reverts commit 269a4c3305c6e282bfa192b162b959d1b8083033. * removing system data and x-ms-azure extension from tracked resource (because making changes in the tracked resource will involove dsMianDev repo changes) * adding "x-ms-azure-resource": true to trackedResource of v1 * adding "x-ms-azure-resource": true to dataMigration service and project (because of the error : The 200 response model for an ARM PUT operation must have x-ms-azure-resource extension set to true in its hierarchy. Operation: 'Services_CreateOrUpdate' Model: 'DataMigrationService'. Location: Microsoft.DataMigration/preview/2021-10-30-preview/datamigration.json#L97) also, removing x-ms-azure-resource from trackedResource * Revert "adding "x-ms-azure-resource": true to trackedResource of v1" This reverts commit bd0fb9c3bb96a736712baaa71efd2e91c49375c0. and f2440eef137d7771217b9924ce941e876363afe9 (bad commit) * Revert "removing system data and x-ms-azure extension from tracked resource (because making changes in the tracked resource will involove dsMianDev repo changes)" This reverts commit e330db6a6abe2209d8d28a07da295267a036a9de. SystemData is required to be in trackedResource * Adding Scope Parameter to examples * Revert "Adding Scope Parameter to examples" This reverts commit b6c827585bb509306f2082e5686b31ee0333b182. * Adding Scope parameter in response of SqlMiGetDatabaseMigration.json * Adding Scope Parameter to other examples * ARM: Adding x-ms-secret: true to password (SqlFileshare and SqlConnectionInfomation), accountkey, authkey1 and authkey2 * Adding x-ms-pageable to DatabaseMigrations_ListByScope, Operations_List, SqlMigrationServices_ListByResourceGroup, SqlMigrationServices_listMigrations, SqlMigrationServices_ListBySubscription * Removing x-ms-secret from Authkeys * Adding x-ms-secret to authKeys in AuthenticationKeys and RegenAuthKeys defination * Suppressing Secret_Property model validation error * Adding suppress SECRET_PROPERTY in Suppression section * changing GET getMonitoringData to POST listMonitoringData * Removing location property from DatabaseMigration definition * New Cancel\Cutover operations with MigrationOperationId in Request body. * updating examples for cancel and cutover operations * Chaning SqlMigrationService_GetResourceState to SqlMigrationService_Get * Revert "Chaning SqlMigrationService_GetResourceState to SqlMigrationService_Get" This reverts commit d16dc91a39245cecc4289b206af070eccb74b783. * Changing GetResourceState to Get * Adding 2 namespaces 2 SqlMi Migration API and updating examples * Add Vm APIs, change operation Id of Mi and VM APIs and Update examples * Suppressing list by subscription DatabaseMigration LintDiff error * Adding discriminator to databaseMigrationProperties in order to separate SqlMi and SqlVm migrations * [nit error] changing SqlConnectionInfo to SqlConnectionInformation * nit error * updating the example SqlMiGetDatabaseMigration.json to use"kind" in order to resolve the error : Additional properties not allowed * updating all Mi and Vm examples to use "kind" in the properties * styling changes (for prettier check) * updating listMigrationsByService.json xample to use kind property * running prettier check * adding other properties in request along with kind in sqlVmCreateOrUpdateMax.json example * Revert "adding other properties in request along with kind in sqlVmCreateOrUpdateMax.json example" This reverts commit 8a47679fa45846b8bc41d7651c7c91e2f7ef943c. * keeping both kind and other properties in the request body for sqlMiCreateOrUpdateDatabaseMigrationMax.json * keeping both kind and other properties in all the examples * adding enums for commandType and taskType discriminator * adding x-ms-enum for commandType and taskType (v1) * adding remaining enum values for taskType and commandType * Removing List By Scope APIs for Mi and VM * Remove Delete APIs for SqlMi and SqlVm * Making DatabaseMigrationSqlVm_Cancel a x-ms-long-running-operation * Moving common properties to DatabaseMigrationProperties * Creating ResourceClass for SqlMi and SqlVm and updating the APIs accordingly * Suppressing LintDiff errors for SqlMi and SqlVm Resource Classess * Making x-ms-client-flatten: false for DatabaseMigration and other SqlMi and SqlVm Resource Class * updating parameters in examples: Services_checkChildrenNameAvailability.json and Services_CheckNameAvailability * v1 s360 errors * object_missing_required_property error: updating example services_Start.json * revert 81733a02cc88d52d69497fff3a5b7abafadedeee * prettier check * reverting all chnages related to "v1 s360 errors" * v1 s360 errors: adding missing properties to mongoDbConnectionInfo in common.json * nit error * v1 s360 errors: adding missing properties to sqlConnectionInfo in common.json * v1 s360 errors: adding missing properties to mySqlConnectionInfo in common.json * v1 s360 errors: adding missing properties to PostgreSqlConnectionInfo in common.json * v1 s360 errors: adding missing properties in MigratePostgreSqlAzureDbForPostgreSqlSyncTask.json * v1 s360 errors: removing problematic property from MigratePostgreSqlAzureDbForPostgreSqlSyncTask * v1 errors: adding missing properties in MigrateSchemaSqlServerSqlDbTask.json * v1 s360 errors: adding missing properties in MigrateSqlServerSqlDbTask.json and MigrateSqlServerSqlMITask.json * v1 360 errors: adding missing properties in projects.json * v1 s360 errors: adding missing properties in Services.json * v1 s360 error: adding missing properties in Tasks.json * v1 s360 errors: adding missing properties in TasksCommon.json * v1 s360 error: adding missing properties to MigratePostgreSqlAzureDbForPostgreSqlSyncTask.json * v1 s360 errors: adding items to events in "MigratePostgreSqlAzureDbForPostgreSqlSyncTaskOutputError" * v1 s360 errors: removing required property * prettier check * nit Co-authored-by: Vasundhra Manhas <vmanhas@microsoft.com> Co-authored-by: Thakur Ashutosh Suman <tsuman@microsoft.com> * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-10-01 (#16900) * Adding The new three properties to the latest API version for RI Transactions * Error Fixes * Fixing Type errors * Changing billingMonth format * Add connectionProperties in GoogleAdWordsLinkedServiceTypeProperties (#17001) * Microsoft.Cdn : 2021-06-01 API (#16868) * Adds base for updating Microsoft.Cdn from version stable/2020-09-01 to version 2021-06-01 * Updates readme * Updates API version in new specs and examples * Update CODEOWNERS file (#1) * update CODEOWNERS file * update CODEOWNERS file * add new cdn code owner Co-authored-by: Jorin Mejia <jomejia@microsoft.com> * add forwardingProtocol to OriginGroupOverride (#2) * Cache Behavior and Case Transform (#3) * add forwardingProtocol to OriginGroupOverride * added new cache behavior attributes and case transform enum values * update cache behavior * Swagger changes for enabling certname check and onboarding prevalidated customdomains * Fixing formatting - Swagger changes for enabling certname check and onboarding prevalidated customdomains * Correct input and output types of checkHostNameAvailability API * Set CA and SAN to readonly * Update ValidateSecretInput to include SecretVersion * Nit fix grammar * Swagger changes to move originResponseTimeoutSeconds property from afdendpoint to profile level * Remove redundant fields and mark certificate properties readonly * Reoganize parameters and update descriptions * Update examples * Fix typos and expand abbhreviations * Fix more typo * Update odatatype (#10) * Update odatatype * Update odatatype * Update typeName * camel casing typeName Co-authored-by: Chenglong …
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* remove name validation from client side * remove name check from deploymentScripts swagger * remove name check from previous swagger versions * remove pattern from resourcegroupname parameter * add missing zoneMappings property to resources * fix linter errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
To fix #16412
Add missing zoneMappings property to resources.json
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.