Update output-folders to generate in _generated. #16685

tjprescott · 2021-11-05T21:12:36Z

This change to the readmes will allow you to generate your _generated folder while leaving any custom written code in-place.

openapi-workflow-bot · 2021-11-05T21:12:38Z

Hi, @tjprescott Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-11-05T21:12:39Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-11-05T21:12:39Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-11-05T21:12:39Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-maps-creator - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-elevation - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-geolocation - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-render - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-route - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-search - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-timezone - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-traffic - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-weather - first release

️❌ azure-sdk-for-python-track2 failed [Detail]

❌Failed [Logs]Release - Generate from a7f7f31. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from a7f7f31. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-11-15 17:55:05 ERROR [Skip] readme path does not format as specification/*/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from a7f7f31. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
warn		specification/maps/data-plane/Search/readme.md skipped due to azure-sdk-for-net not found in swagger-to-sdk
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Creator/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'GeoJsonObjectType' and different values: Point,MultiPoint,LineString,MultiLineString,Polygon,MultiPolygon,GeometryCollection,Feature,FeatureCollection vs. FeatureCollection
cmderr	[Autorest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 150
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66
cmderr	[Autorest]    at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60
cmderr	[Autorest] --- End of stack trace from previous location where exception was thrown ---
cmderr	[Autorest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
cmderr	[Autorest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
cmderr	[Autorest]    at NewPlugin.<Process>d__15.MoveNext()
cmderr	[Autorest] FATAL: csharp/imodeler1 - FAILED
cmderr	[Autorest] FATAL: Error: Plugin imodeler1 reported failure.
cmderr	[Autorest]   Error: Plugin imodeler1 reported failure.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip command for failed context: autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/DEM/readme.md
warn	Skip command for failed context: autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Geolocation/readme.md
warn	Skip command for failed context: autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Render/readme.md
warn	Skip command for failed context: autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Route/readme.md
warn	Skip command for failed context: autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Timezone/readme.md
warn	Skip command for failed context: autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Traffic/readme.md
warn	Skip command for failed context: autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Weather/readme.md
warn	Skip package processing as generation is failed

_{Posted by Swagger Pipeline | How to fix these errors?}

daniel-rocha · 2021-11-08T07:20:23Z

Hi @tjprescott I am fine with the change but the pipeline is failing to generate the SDK, is that ok?

tjprescott · 2021-11-08T22:50:14Z

Yeah, trying to get to the bottom of that one. It definitely does generate. I love CI...

tjprescott · 2021-11-12T17:36:39Z

Azure/azure-sdk-for-python#21737

Per discussion with @msyyc, the automation_generate.py script is intended for management plane, and should not block the build or the PR. @lmazuel can you merge this?

tjprescott · 2021-11-12T17:37:51Z

I think this pipeline will pass once you have committed your first version of each SDK to the Python SDK repo.

* Update output-folders to generate in _generated. * Remove _generated annotation from Creator. * Include _generated only on updates, not create.

Update output-folders to generate in _generated.

14642b2

tjprescott requested a review from daniel-rocha November 5, 2021 21:12

openapi-assignment-bot bot assigned anuchandy Nov 5, 2021

daniel-rocha approved these changes Nov 8, 2021

View reviewed changes

tjprescott added 2 commits November 11, 2021 09:58

Remove _generated annotation from Creator.

d41ce24

Include _generated only on updates, not create.

bc850a1

tjprescott force-pushed the tjprescott/MapsPython branch 2 times, most recently from 616b4c8 to bc850a1 Compare November 12, 2021 17:34

lmazuel merged commit a7f7f31 into main Nov 15, 2021

lmazuel deleted the tjprescott/MapsPython branch November 15, 2021 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update output-folders to generate in _generated. #16685

Update output-folders to generate in _generated. #16685

tjprescott commented Nov 5, 2021

openapi-workflow-bot bot commented Nov 5, 2021

openapi-pipeline-app bot commented Nov 5, 2021 •

edited

Loading

openapi-workflow-bot bot commented Nov 5, 2021

openapi-pipeline-app bot commented Nov 5, 2021 •

edited

Loading

Breaking Changes Tracking

daniel-rocha commented Nov 8, 2021

tjprescott commented Nov 8, 2021

tjprescott commented Nov 12, 2021

tjprescott commented Nov 12, 2021

Update output-folders to generate in _generated. #16685

Update output-folders to generate in _generated. #16685

Conversation

tjprescott commented Nov 5, 2021

openapi-workflow-bot bot commented Nov 5, 2021

openapi-pipeline-app bot commented Nov 5, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Nov 5, 2021

openapi-pipeline-app bot commented Nov 5, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

daniel-rocha commented Nov 8, 2021

tjprescott commented Nov 8, 2021

tjprescott commented Nov 12, 2021

tjprescott commented Nov 12, 2021

openapi-pipeline-app bot commented Nov 5, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 5, 2021 •

edited

Loading