-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples for some RPs #16763
Fix examples for some RPs #16763
Conversation
Hi, @KeYu-AnkhSpirit Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Thank you for your contribution KeYu-AnkhSpirit! We will review the pull request and get back to you soon. |
Swagger Validation Report
|
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.OperationalInsights/operations' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/tables' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Tables.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/tables/{tableName}' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Tables.json#L82:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.OperationalInsights/workspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L76:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L118:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.OperationalInsights/deletedWorkspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L319:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/deletedWorkspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L358:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'Schema' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'SearchResults' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'RestoredLogs' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ResultStatistics' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'TableProperties' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'Table' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceSku' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceCapping' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceProperties' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceFeatures' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'Workspace' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspacePatch' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PublicNetworkAccessType' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'TableNameParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'WorkspaceNameParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3 |
️️✔️
LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/operationalinsights/resource-manager/readme.md tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2021-06 |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
/azp run |
2 similar comments
/azp run |
/azp run |
Hi @KeYu-AnkhSpirit, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
* fix LRO_RESPONSE_HEADER error in "keyvault" * fix LRO_RESPONSE_HEADER error in "managementgroups" * fix XMS_EXAMPLE_NOTFOUND_ERROR error in "managementgroups" * fix RESPONSE_BODY_NOT_IN_EXAMPLE error in "relay" * fix XMS_EXAMPLE_NOTFOUND_ERROR error in "servicefabric" * fix LRO_RESPONSE_HEADER error in "storage" * update api version to 2021-06-01 * fix code style issues
Adding Location header for some examples;
Adding examples for some operations which are missing x-ms-examples.