Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional fields to CallRecording File Status Udpated event #16936

Merged
merged 4 commits into from
Dec 27, 2021

Conversation

pgrandhi
Copy link
Contributor

@pgrandhi pgrandhi commented Dec 1, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • [X ] update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @pgrandhi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 1, 2021

    Swagger Validation Report

    ️⌛BreakingChange pending [Detail]
    ️⌛LintDiff pending [Detail]
    ️⌛Avocado pending [Detail]
    ️⌛~[Staging] ApiReadinessCheck pending [Detail]
    ️⌛ModelValidation pending [Detail]
    ️⌛SemanticValidation pending [Detail]
    ️⌛Cross-Version Breaking Changes pending [Detail]
    ️⌛CredScan pending [Detail]
    ️⌛SDK Track2 Validation pending [Detail]
    ️⌛PrettierCheck pending [Detail]
    ️⌛SpellCheck pending [Detail]
    ️⌛Lint(RPaaS) pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 1, 2021

    Swagger Generation Artifacts

    ️⌛ApiDocPreview pending [Detail]
    ️⌛SDK Breaking Change Tracking pending [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a21a67a. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️eventgrid/2018-01-01/eventgrid [View full logs]  [Release SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New const `StampKindAseV2`
      info	[Changelog] - New const `Gcch`
      info	[Changelog] - New const `Unmixed`
      info	[Changelog] - New const `AudioVideo`
      info	[Changelog] - New const `StampKindAseV1`
      info	[Changelog] - New const `Dod`
      info	[Changelog] - New const `Audio`
      info	[Changelog] - New const `Mp4`
      info	[Changelog] - New const `Wav`
      info	[Changelog] - New function `AcsChatThreadPropertiesUpdatedPerUserEventData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleRecordingFormatTypeValues() []RecordingFormatType`
      info	[Changelog] - New function `AcsChatMessageEditedEventData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleCommunicationCloudEnvironmentModelValues() []CommunicationCloudEnvironmentModel`
      info	[Changelog] - New function `AcsChatMessageReceivedInThreadEventData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `AcsChatThreadCreatedWithUserEventData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleRecordingChannelTypeValues() []RecordingChannelType`
      info	[Changelog] - New function `MediaLiveEventChannelArchiveHeartbeatEventData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `AcsChatMessageEditedInThreadEventData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleRecordingContentTypeValues() []RecordingContentType`
      info	[Changelog] - New function `AcsChatThreadCreatedEventData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `AcsChatMessageReceivedEventData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `AcsChatThreadPropertiesUpdatedEventData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `APIManagementAPICreatedEventData`
      info	[Changelog] - New struct `APIManagementAPIDeletedEventData`
      info	[Changelog] - New struct `APIManagementAPIReleaseCreatedEventData`
      info	[Changelog] - New struct `APIManagementAPIReleaseDeletedEventData`
      info	[Changelog] - New struct `APIManagementAPIReleaseUpdatedEventData`
      info	[Changelog] - New struct `APIManagementAPIUpdatedEventData`
      info	[Changelog] - New struct `APIManagementProductCreatedEventData`
      info	[Changelog] - New struct `APIManagementProductDeletedEventData`
      info	[Changelog] - New struct `APIManagementProductUpdatedEventData`
      info	[Changelog] - New struct `APIManagementSubscriptionCreatedEventData`
      info	[Changelog] - New struct `APIManagementSubscriptionDeletedEventData`
      info	[Changelog] - New struct `APIManagementSubscriptionUpdatedEventData`
      info	[Changelog] - New struct `APIManagementUserCreatedEventData`
      info	[Changelog] - New struct `APIManagementUserDeletedEventData`
      info	[Changelog] - New struct `APIManagementUserUpdatedEventData`
      info	[Changelog] - New struct `AcsChatEventBaseProperties`
      info	[Changelog] - New struct `AcsChatEventInThreadBaseProperties`
      info	[Changelog] - New struct `AcsChatMessageDeletedEventData`
      info	[Changelog] - New struct `AcsChatMessageDeletedInThreadEventData`
      info	[Changelog] - New struct `AcsChatMessageEditedEventData`
      info	[Changelog] - New struct `AcsChatMessageEditedInThreadEventData`
      info	[Changelog] - New struct `AcsChatMessageEventBaseProperties`
      info	[Changelog] - New struct `AcsChatMessageEventInThreadBaseProperties`
      info	[Changelog] - New struct `AcsChatMessageReceivedEventData`
      info	[Changelog] - New struct `AcsChatMessageReceivedInThreadEventData`
      info	[Changelog] - New struct `AcsChatParticipantAddedToThreadEventData`
      info	[Changelog] - New struct `AcsChatParticipantAddedToThreadWithUserEventData`
      info	[Changelog] - New struct `AcsChatParticipantRemovedFromThreadEventData`
      info	[Changelog] - New struct `AcsChatParticipantRemovedFromThreadWithUserEventData`
      info	[Changelog] - New struct `AcsChatThreadCreatedEventData`
      info	[Changelog] - New struct `AcsChatThreadCreatedWithUserEventData`
      info	[Changelog] - New struct `AcsChatThreadDeletedEventData`
      info	[Changelog] - New struct `AcsChatThreadEventBaseProperties`
      info	[Changelog] - New struct `AcsChatThreadEventInThreadBaseProperties`
      info	[Changelog] - New struct `AcsChatThreadParticipantProperties`
      info	[Changelog] - New struct `AcsChatThreadPropertiesUpdatedEventData`
      info	[Changelog] - New struct `AcsChatThreadPropertiesUpdatedPerUserEventData`
      info	[Changelog] - New struct `AcsChatThreadWithUserDeletedEventData`
      info	[Changelog] - New struct `AcsRecordingChunkInfoProperties`
      info	[Changelog] - New struct `AcsRecordingFileStatusUpdatedEventData`
      info	[Changelog] - New struct `AcsRecordingStorageInfoProperties`
      info	[Changelog] - New struct `AcsUserDisconnectedEventData`
      info	[Changelog] - New struct `CommunicationIdentifierModel`
      info	[Changelog] - New struct `CommunicationUserIdentifierModel`
      info	[Changelog] - New struct `ContainerRegistryEventConnectedRegistry`
      info	[Changelog] - New struct `ContainerServiceNewKubernetesVersionAvailableEventData`
      info	[Changelog] - New struct `MediaLiveEventChannelArchiveHeartbeatEventData`
      info	[Changelog] - New struct `MicrosoftTeamsUserIdentifierModel`
      info	[Changelog] - New struct `PhoneNumberIdentifierModel`
      info	[Changelog] - New struct `PolicyInsightsPolicyStateChangedEventData`
      info	[Changelog] - New struct `PolicyInsightsPolicyStateCreatedEventData`
      info	[Changelog] - New struct `PolicyInsightsPolicyStateDeletedEventData`
      info	[Changelog] - New struct `ServiceBusActiveMessagesAvailablePeriodicNotificationsEventData`
      info	[Changelog] - New struct `ServiceBusDeadletterMessagesAvailablePeriodicNotificationsEventData`
      info	[Changelog] - New struct `StorageAsyncOperationInitiatedEventData`
      info	[Changelog] - New struct `StorageBlobInventoryPolicyCompletedEventData`
      info	[Changelog] - New struct `StorageBlobTierChangedEventData`
      info	[Changelog] - New field `ConnectedRegistry` in struct `ContainerRegistryImagePushedEventData`
      info	[Changelog] - New field `Location` in struct `ContainerRegistryImagePushedEventData`
      info	[Changelog] - New field `SyncToken` in struct `AppConfigurationKeyValueModifiedEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultSecretNearExpiryEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultSecretNearExpiryEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultVaultAccessPolicyChangedEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultVaultAccessPolicyChangedEventData`
      info	[Changelog] - New field `Location` in struct `ContainerRegistryChartDeletedEventData`
      info	[Changelog] - New field `ConnectedRegistry` in struct `ContainerRegistryChartDeletedEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultKeyNearExpiryEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultKeyNearExpiryEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultCertificateNewVersionCreatedEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultCertificateNewVersionCreatedEventData`
      info	[Changelog] - New field `Tag` in struct `AcsSmsDeliveryReportReceivedEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultCertificateNearExpiryEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultCertificateNearExpiryEventData`
      info	[Changelog] - New field `SyncToken` in struct `AppConfigurationKeyValueDeletedEventData`
      info	[Changelog] - New field `Location` in struct `ContainerRegistryChartPushedEventData`
      info	[Changelog] - New field `ConnectedRegistry` in struct `ContainerRegistryChartPushedEventData`
      info	[Changelog] - New field `IngestDriftValue` in struct `MediaLiveEventIngestHeartbeatEventData`
      info	[Changelog] - New field `TranscriptionState` in struct `MediaLiveEventIngestHeartbeatEventData`
      info	[Changelog] - New field `LastFragmentArrivalTime` in struct `MediaLiveEventIngestHeartbeatEventData`
      info	[Changelog] - New field `TranscriptionLanguage` in struct `MediaLiveEventIngestHeartbeatEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultSecretExpiredEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultSecretExpiredEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultCertificateExpiredEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultCertificateExpiredEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultKeyExpiredEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultKeyExpiredEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultKeyNewVersionCreatedEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultKeyNewVersionCreatedEventData`
      info	[Changelog] - New field `ConnectedRegistry` in struct `ContainerRegistryArtifactEventData`
      info	[Changelog] - New field `Location` in struct `ContainerRegistryArtifactEventData`
      info	[Changelog] - New field `ConnectedRegistry` in struct `ContainerRegistryEventData`
      info	[Changelog] - New field `Location` in struct `ContainerRegistryEventData`
      info	[Changelog] - New field `Location` in struct `ContainerRegistryImageDeletedEventData`
      info	[Changelog] - New field `ConnectedRegistry` in struct `ContainerRegistryImageDeletedEventData`
      info	[Changelog] - New field `NBF` in struct `KeyVaultSecretNewVersionCreatedEventData`
      info	[Changelog] - New field `EXP` in struct `KeyVaultSecretNewVersionCreatedEventData`
      info	[Changelog]
      info	[Changelog] Total 39 breaking change(s), 159 additive change(s).
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a21a67a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] opencensus-ext-azure 1.1.0 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] azure-identity 1.7.1 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.3.0` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️azure-eventgrid [View full logs]  [Release SDK Changes]
      info	[Changelog] data-plan skip changelog generation temporarily
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from a21a67a. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Automation-Sdk-Generate.ps1] Could not execute because the application was not found or a compatible .NET SDK is not installed.
      cmderr	[Automation-Sdk-Generate.ps1] Possible reasons for this include:
      cmderr	[Automation-Sdk-Generate.ps1]   * You intended to execute a .NET program:
      cmderr	[Automation-Sdk-Generate.ps1]       The application 'msbuild' does not exist.
      cmderr	[Automation-Sdk-Generate.ps1]   * You intended to execute a .NET SDK command:
      cmderr	[Automation-Sdk-Generate.ps1]       A compatible installed .NET SDK for global.json version [6.0.100] from [/home/vsts/work/1/s/azure-sdk-for-net/global.json] was not found.
      cmderr	[Automation-Sdk-Generate.ps1]       Install the [6.0.100] .NET SDK or update [/home/vsts/work/1/s/azure-sdk-for-net/global.json] with an installed .NET SDK:
      cmderr	[Automation-Sdk-Generate.ps1] �[91mWrite-Error: �[91mError occurred while generating code for Azure.Messaging.EventGrid
      cmderr	[Automation-Sdk-Generate.ps1] �[0m
    • Azure.Messaging.EventGrid [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a21a67a. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/eventgrid [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @pgrandhi
    Copy link
    Contributor Author

    pgrandhi commented Dec 1, 2021

    Task 2660168: Update EventGrid SDK for Call Recording properties for Delete API

    @ghost
    Copy link

    ghost commented Dec 19, 2021

    Hi, @pgrandhi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @lmazuel lmazuel merged commit a21a67a into main Dec 27, 2021
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    …zure#16936)
    
    * Adding additional fields to CallRecording File Status Udpated event
    
    * Updating the Recording event fields to enum
    
    * Updating the example for RecordingFileStatusUpdated event
    
    * Updating the recordingFormatType in recordingFileStatusUpdated example
    @JackTn JackTn deleted the user/pgrandhi/UpdateRecordingEventFields branch June 16, 2022 00:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants