-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Batch 2022-01-01 Management Plane Update #16961
Conversation
Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Generation Artifacts
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Hi @paterasMSFT, Your PR has some issues. Please fix the CI sequentially by following the order of
|
cec4384
to
56422fa
Compare
Hi, @paterasMSFT your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
85e9ec7
to
7632daf
Compare
0c3010a
to
6f5d67a
Compare
/azp run API Readiness Check |
No pipelines are associated with this pull request. |
6f5d67a
to
d1e1886
Compare
d1e1886
to
fb18acb
Compare
@pilor can we get a new ARM review? We've updated the swagger to add a new property to 'NetworkConfiguration', named 'dynamicVNetAssignmentScope'. |
I last looked at this in December and don't have any familiarity anymore. @suhasaraos is the ARM reviewer this week |
@suhasaraos can we get a review here? We'd like to get this merged as soon as possible. Thank you. |
801e74a
to
7065c2a
Compare
Ran prettier Updated comments for Spot/Low-priority. Added dynamicVNetAssignmentScope Fixed casing Added x-ms-idenfiers from recent patch
Ran prettier Fixed cred scan issue Spot/Low-priority example fix Fixed casing
Added suppression
7065c2a
to
27b62ab
Compare
* Initial commit for comparison * Update BatchManagement swagger Ran prettier Updated comments for Spot/Low-priority. Added dynamicVNetAssignmentScope Fixed casing Added x-ms-idenfiers from recent patch * Update examples Ran prettier Fixed cred scan issue Spot/Low-priority example fix Fixed casing * Updated readme Added suppression
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.