Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Batch 2022-01-01 Management Plane Update #16961

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

paterasMSFT
Copy link
Contributor

@paterasMSFT paterasMSFT commented Dec 3, 2021

  • Adds AppLens detector support to enable the "Diagnose and solve" blade in the portal.
  • Updates comments containing "low-priority" to "Spot/Low-priority", to reflect service adding Spot VM support for Batch Managed pools.
  • Adds 'dynamicVNetAssignmentScope' property 'NetworkConfiguration', to allow per-job VNet assignment (used for SWIFT-approved accounts only).

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Already deployed.
  3. When do you expect to publish the swagger? 2022-01-01
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 3, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'detectors' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L3586


    The following errors/warnings exist before current PR submission:

    Rule Message
    R4041 - XmsIdentifierValidation Missing identifier registryServers in array item property
    Location: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L4503
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'applications' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L3078
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'versions' with immediate parent 'Application', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L3112
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'certificates' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L3487
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateLinkResources' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L3612
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L3656
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'pools' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L3780
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 3, 2021

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armbatch - 0.3.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-batch - 16.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2021-06-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2021-01-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2020-09-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2020-05-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2020-03-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2019-08-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2019-04-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2018-12-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2017-09-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2017-05-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2017-01-01/batch - v61.5.0
    ️✔️azure-sdk-for-go - batch/mgmt/2015-12-01/batch - v61.5.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from caced2b. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/batch/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5962:8 ($.definitions.EndpointDependency.properties.endpointDetails)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5935:8 ($.definitions.OutboundEnvironmentEndpoint.properties.endpoints)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5911:8 ($.definitions.OutboundEnvironmentEndpointCollection.properties.value)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5658:8 ($.definitions.OperationListResult.properties.value)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5587:8 ($.definitions.SupportedSkusResult.properties.value)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5570:8 ($.definitions.SupportedSku.properties.capabilities)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5527:8 ($.definitions.CloudErrorBody.properties.details)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5378:8 ($.definitions.InboundNatPool.properties.networkSecurityGroupRules)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5313:8 ($.definitions.PoolEndpointConfiguration.properties.inboundNatPools)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:5297:8 ($.definitions.ResizeOperationStatus.properties.errors)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:4811:8 ($.definitions.StartTask.properties.environmentSettings)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:4801:8 ($.definitions.StartTask.properties.resourceFiles)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:4503:8 ($.definitions.ContainerConfiguration.properties.containerRegistries)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:4390:8 ($.definitions.VirtualMachineConfiguration.properties.extensions)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:4359:8 ($.definitions.VirtualMachineConfiguration.properties.dataDisks)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:4304:8 ($.definitions.AutoScaleRunError.properties.details)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:4278:8 ($.definitions.ResizeError.properties.details)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:4010:8 ($.definitions.PoolProperties.properties.mountConfiguration)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:3965:8 ($.definitions.PoolProperties.properties.metadata)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:3955:8 ($.definitions.PoolProperties.properties.userAccounts)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:3551:8 ($.definitions.DeleteCertificateError.properties.details)
      cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
      cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2022-01-01/BatchManagement.json:2867:8 ($.definitions.BatchAccountProperties.properties.dedicatedCoreQuotaPerVMFamily)
      cmderr	[Autorest] FATAL: swagger-document/individual/schema-validator - FAILED
      cmderr	[Autorest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
      cmderr	[Autorest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from caced2b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.5.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.0` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-batch [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation BatchAccountOperations.get_detector
      info	[Changelog]   - Added operation BatchAccountOperations.list_detectors
      info	[Changelog]   - Model NetworkConfiguration has a new parameter dynamic_v_net_assignment_scope
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from caced2b. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2022-02-16 00:53:01 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-batch;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2022-02-16 00:53:01 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2022-02-16 00:53:01 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.50 --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/batch/azure-resourcemanager-batch --java.namespace=com.azure.resourcemanager.batch   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/batch/resource-manager/readme.md
      cmderr	[generate.py] 2022-02-16 00:53:34 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-batch
      cmderr	[generate.py] 2022-02-16 00:53:34 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2022-02-16 00:53:34 INFO [POM][Skip] pom already has module azure-resourcemanager-batch
      cmderr	[generate.py] 2022-02-16 00:53:34 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2022-02-16 00:53:34 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2022-02-16 00:53:34 INFO [POM][Skip] pom already has module sdk/batch
      cmderr	[generate.py] 2022-02-16 00:53:34 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-batch [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2022-02-16 00:55:10 DEBUG Got artifact_id: azure-resourcemanager-batch
      cmderr	[Inst] 2022-02-16 00:55:10 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2022-02-16 00:55:10 DEBUG Got artifact: azure-resourcemanager-batch-1.0.0-beta.3.jar
      cmderr	[Inst] 2022-02-16 00:55:10 DEBUG Match jar package: azure-resourcemanager-batch-1.0.0-beta.3.jar
      cmderr	[Inst] 2022-02-16 00:55:10 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16961/azure-sdk-for-java/azure-resourcemanager-batch/azure-resourcemanager-batch-1.0.0-beta.3.jar\" -o azure-resourcemanager-batch-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-batch -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-batch-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from caced2b. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️batch/mgmt/2021-06-01/batch [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2021-01-01/batch [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️batch/mgmt/2020-09-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2020-05-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2020-03-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2019-08-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2019-04-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2018-12-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2017-09-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2017-05-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2017-01-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2015-12-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from caced2b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armbatch [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `Operation.Properties` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Type of `VMExtension.ProtectedSettings` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Type of `VMExtension.Settings` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Function `CloudErrorBody.MarshalJSON` has been removed
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog] - Struct `CloudErrorBody` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `DynamicVNetAssignmentScopeJob`
      info	[Changelog] - New const `DynamicVNetAssignmentScopeNone`
      info	[Changelog] - New function `DetectorListResult.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*AccountClient.ListDetectors(string, string, *AccountClientListDetectorsOptions) *AccountClientListDetectorsPager`
      info	[Changelog] - New function `*AccountClientListDetectorsPager.PageResponse() AccountClientListDetectorsResponse`
      info	[Changelog] - New function `*AccountClient.GetDetector(context.Context, string, string, string, *AccountClientGetDetectorOptions) (AccountClientGetDetectorResponse, error)`
      info	[Changelog] - New function `PossibleDynamicVNetAssignmentScopeValues() []DynamicVNetAssignmentScope`
      info	[Changelog] - New function `DynamicVNetAssignmentScope.ToPtr() *DynamicVNetAssignmentScope`
      info	[Changelog] - New function `*AccountClientListDetectorsPager.NextPage(context.Context) bool`
      info	[Changelog] - New function `*AccountClientListDetectorsPager.Err() error`
      info	[Changelog] - New struct `AccountClientGetDetectorOptions`
      info	[Changelog] - New struct `AccountClientGetDetectorResponse`
      info	[Changelog] - New struct `AccountClientGetDetectorResult`
      info	[Changelog] - New struct `AccountClientListDetectorsOptions`
      info	[Changelog] - New struct `AccountClientListDetectorsPager`
      info	[Changelog] - New struct `AccountClientListDetectorsResponse`
      info	[Changelog] - New struct `AccountClientListDetectorsResult`
      info	[Changelog] - New struct `DetectorListResult`
      info	[Changelog] - New struct `DetectorResponse`
      info	[Changelog] - New struct `DetectorResponseProperties`
      info	[Changelog] - New field `DynamicVNetAssignmentScope` in struct `NetworkConfiguration`
      info	[Changelog]
      info	[Changelog] Total 7 breaking change(s), 31 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from caced2b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-batch [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation BatchAccountOperations.getDetector
      info	[Changelog]   - Added operation BatchAccountOperations.listDetectors
      info	[Changelog]   - Added Interface BatchAccountGetDetectorOptionalParams
      info	[Changelog]   - Added Interface BatchAccountListDetectorsNextOptionalParams
      info	[Changelog]   - Added Interface BatchAccountListDetectorsOptionalParams
      info	[Changelog]   - Added Interface DetectorListResult
      info	[Changelog]   - Added Type Alias BatchAccountGetDetectorResponse
      info	[Changelog]   - Added Type Alias BatchAccountListDetectorsNextResponse
      info	[Changelog]   - Added Type Alias BatchAccountListDetectorsResponse
      info	[Changelog]   - Added Type Alias DetectorResponse
      info	[Changelog]   - Added Type Alias DynamicVNetAssignmentScope
      info	[Changelog]   - Interface NetworkConfiguration has a new optional parameter dynamicVNetAssignmentScope
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from caced2b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot
    Copy link

    Hi @paterasMSFT, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @paterasMSFT your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @dpwatrous
    Copy link
    Member

    /azp run API Readiness Check

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @paterasMSFT paterasMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 1, 2022
    @paterasMSFT
    Copy link
    Contributor Author

    @pilor can we get a new ARM review? We've updated the swagger to add a new property to 'NetworkConfiguration', named 'dynamicVNetAssignmentScope'.

    @pilor
    Copy link
    Contributor

    pilor commented Feb 1, 2022

    I last looked at this in December and don't have any familiarity anymore. @suhasaraos is the ARM reviewer this week

    @paterasMSFT
    Copy link
    Contributor Author

    @suhasaraos can we get a review here? We'd like to get this merged as soon as possible. Thank you.

    @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 8, 2022
    @paterasMSFT paterasMSFT force-pushed the mipatera-batch20220101management branch from 801e74a to 7065c2a Compare February 15, 2022 19:45
    Ran prettier
    
    Updated comments for Spot/Low-priority.
    
    Added dynamicVNetAssignmentScope
    
    Fixed casing
    
    Added x-ms-idenfiers from recent patch
    Ran prettier
    
    Fixed cred scan issue
    
    Spot/Low-priority example fix
    
    Fixed casing
    Added suppression
    @ArcturusZhang ArcturusZhang merged commit caced2b into main Feb 16, 2022
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022
    * Initial commit for comparison
    
    * Update BatchManagement swagger
    
    Ran prettier
    
    Updated comments for Spot/Low-priority.
    
    Added dynamicVNetAssignmentScope
    
    Fixed casing
    
    Added x-ms-idenfiers from recent patch
    
    * Update examples
    
    Ran prettier
    
    Fixed cred scan issue
    
    Spot/Low-priority example fix
    
    Fixed casing
    
    * Updated readme
    
    Added suppression
    @JackTn JackTn deleted the mipatera-batch20220101management branch June 16, 2022 00:50
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-SdkBreakingChange-Go-V2 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 ReadyForSDKReview
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants