[Hub Generated] Review request for Microsoft.ManagedServices to add version preview/2022-01-01-preview #17089

skayani · 2021-12-14T19:57:32Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…/2020-02-01-preview to version 2022-01-01-preview

openapi-workflow-bot · 2021-12-14T19:57:34Z

Hi, @skayani Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-12-14T19:57:34Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-12-14T19:57:35Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌LintDiff: 2 Errors, 2 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- managedservices/resource-manager/readme.md tag:package-preview-2022-01
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- managedservices/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'MarketplaceRegistrationDefinitions_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L483
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'MarketplaceRegistrationDefinitionsWithoutScope_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L522
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'OperationsWithScope_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L591
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Registration Operations Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L619

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ManagedServices/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L557
`❌` R4037 - MissingTypeObject	The schema 'RegistrationDefinitionList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L737
`❌` R4037 - MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L818
`❌` R4037 - MissingTypeObject	The schema 'RegistrationAssignmentList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L918
`❌` R4037 - MissingTypeObject	The schema 'MarketplaceRegistrationDefinitionList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L1005
`❌` R4037 - MissingTypeObject	The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L1058
`❌` R4037 - MissingTypeObject	The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L1231
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L630
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L757
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L818
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L938
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L558
⚠️ R4021 - DescriptionAndTitleMissing	'MarketplaceRegistrationDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L936
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Registration Definitions Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L436
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Registration Definitions Location: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L514

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` API Readiness check failed. Please make sure your service is deployed.	"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.ManagedServices' for api version '2022-01-01-preview'. The supported api-versions are '2018-06-01-preview, 2019-04-01-preview, 2019-06-01, 2019-09-01, 2020-02-01-preview'."

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️Cross-Version Breaking Changes: 1 Warnings warning [Detail]

Compared Swaggers (Based on Oad v0.9.1)
- current:preview/2022-01-01-preview/managedservices.json compared with base:stable/2019-09-01/managedservices.json
- current:preview/2022-01-01-preview/managedservices.json compared with base:preview/2020-02-01-preview/managedservices.json

The following breaking changes are detected by comparison with latest preview version:

Rule	Message
⚠️ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'RegistrationDefinitionIdParameter' removed or renamed? New: Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json#L1242:3 Old: Microsoft.ManagedServices/preview/2020-02-01-preview/managedservices.json#L1173:3

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

managedservices/resource-manager/readme.md#package-preview-2022-01

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-12-14T19:57:36Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armmanagedservices - 0.3.0

+	Function `ErrorDefinition.MarshalJSON` has been removed
+	Struct `ErrorDefinition` has been removed
+	Struct `ErrorResponse` has been removed

️✔️azure-sdk-for-go - managedservices/mgmt/2019-06-01/managedservices - v61.3.0
️✔️azure-sdk-for-go - preview/managedservices/mgmt/2019-04-01/managedservices - v61.3.0
️✔️azure-sdk-for-go - preview/managedservices/mgmt/2018-06-01/managedservices - v61.3.0
❌azure-sdk-for-python-track2 - track2_azure-mgmt-managedservices - Approved - 6.0.0

+	Operation RegistrationAssignmentsOperations.list has a new signature
+	Operation RegistrationDefinitionsOperations.list has a new signature

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f671a8a. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/managedservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ManagedServices [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.ManagedServices.1.1.0.nupkg
- Microsoft.Azure.Management.ManagedServices.1.1.0.symbols.nupkg

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from f671a8a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] opencensus-ext-azure 1.1.1 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-identity 1.7.1 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️azure-mgmt-managedservices [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model RegistrationAssignment has a new parameter system_data
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter managee_tenant_name
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter eligible_authorizations
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter managee_tenant_id
info	[Changelog]   - Model Authorization has a new parameter delegated_role_definition_ids
info	[Changelog]   - Model Authorization has a new parameter principal_id_display_name
info	[Changelog]   - Model RegistrationAssignmentPropertiesRegistrationDefinition has a new parameter system_data
info	[Changelog]   - Model RegistrationDefinition has a new parameter system_data
info	[Changelog]   - Model RegistrationAssignmentPropertiesRegistrationDefinitionProperties has a new parameter eligible_authorizations
info	[Changelog]   - Added operation group OperationsWithScopeOperations
info	[Changelog]   - Added operation group MarketplaceRegistrationDefinitionsWithoutScopeOperations
info	[Changelog]   - Added operation group MarketplaceRegistrationDefinitionsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation RegistrationAssignmentsOperations.list has a new signature
info	[Changelog]   - Operation RegistrationDefinitionsOperations.list has a new signature

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from f671a8a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-managedservices [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group OperationsWithScopeOperations
info	[Changelog]   - Model JustInTimeAccessPolicy has a new parameter managed_by_tenant_approvers
info	[Changelog]   - Model RegistrationAssignment has a new parameter system_data
info	[Changelog]   - Model RegistrationAssignmentPropertiesRegistrationDefinition has a new parameter system_data
info	[Changelog]   - Model RegistrationDefinition has a new parameter system_data
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter managee_tenant_id
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter managee_tenant_name
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation RegistrationAssignmentsOperations.list has a new signature
info	[Changelog]   - Operation RegistrationDefinitionsOperations.list has a new signature

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from f671a8a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-08 03:30:09 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-managedservices"
cmderr	[generate.py] 2022-02-08 03:30:09 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2022-02-08 03:30:09 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/managedservices/azure-resourcemanager-managedservices --java.namespace=com.azure.resourcemanager.managedservices   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/managedservices/resource-manager/readme.md
cmderr	[generate.py] 2022-02-08 03:30:33 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2022-02-08 03:30:33 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-08 03:30:33 INFO [POM][Skip] pom already has module azure-resourcemanager-managedservices
cmderr	[generate.py] 2022-02-08 03:30:33 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-08 03:30:33 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-08 03:30:33 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-managedservices [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-02-08 03:31:43 DEBUG Got artifact_id: azure-resourcemanager-managedservices
cmderr	[Inst] 2022-02-08 03:31:43 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-08 03:31:43 DEBUG Got artifact: azure-resourcemanager-managedservices-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-08 03:31:43 DEBUG Match jar package: azure-resourcemanager-managedservices-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-08 03:31:43 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17089/azure-sdk-for-java/azure-resourcemanager-managedservices/azure-resourcemanager-managedservices-1.0.0-beta.1.jar\" -o azure-resourcemanager-managedservices-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-managedservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-managedservices-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f671a8a. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️managedservices/mgmt/2019-06-01/managedservices [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/managedservices/mgmt/2019-04-01/managedservices [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/managedservices/mgmt/2018-06-01/managedservices [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f671a8a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armmanagedservices [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ErrorDefinition.MarshalJSON` has been removed
info	[Changelog] - Struct `ErrorDefinition` has been removed
info	[Changelog] - Struct `ErrorResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `CreatedByTypeManagedIdentity`
info	[Changelog] - New const `CreatedByTypeUser`
info	[Changelog] - New const `CreatedByTypeApplication`
info	[Changelog] - New const `CreatedByTypeKey`
info	[Changelog] - New function `*OperationsWithScopeClient.List(context.Context, string, *OperationsWithScopeClientListOptions) (OperationsWithScopeClientListResponse, error)`
info	[Changelog] - New function `*timeRFC3339.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `CreatedByType.ToPtr() *CreatedByType`
info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New function `NewOperationsWithScopeClient(azcore.TokenCredential, *arm.ClientOptions) *OperationsWithScopeClient`
info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
info	[Changelog] - New function `*SystemData.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
info	[Changelog] - New function `SystemData.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `timeRFC3339.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `OperationsWithScopeClient`
info	[Changelog] - New struct `OperationsWithScopeClientListOptions`
info	[Changelog] - New struct `OperationsWithScopeClientListResponse`
info	[Changelog] - New struct `OperationsWithScopeClientListResult`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `SystemData` in struct `RegistrationAssignmentPropertiesRegistrationDefinition`
info	[Changelog] - New field `SystemData` in struct `RegistrationAssignment`
info	[Changelog] - New field `SystemData` in struct `RegistrationDefinition`
info	[Changelog] - New field `Filter` in struct `RegistrationAssignmentsClientListOptions`
info	[Changelog] - New field `Filter` in struct `RegistrationDefinitionsClientListOptions`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 30 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from f671a8a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from f671a8a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-12-14T19:59:49Z

Hi @skayani, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

skayani · 2021-12-14T20:22:09Z

@akning-ms Not sure how to resolve the Python SDK issues. Can you give some pointers?

akning-ms · 2021-12-22T08:20:13Z

@akning-ms Not sure how to resolve the Python SDK issues. Can you give some pointers?

You are saying pythons SDK breaking change? @msyyc to help python SDK issue.
BTW, you may also need to fix linter and prettier check issue and looks you renamed "registrationDefinitionIdParameter" which may need a breaking change review board review

msyyc · 2021-12-23T01:49:03Z

approved for python breaking change

skayani · 2022-01-05T19:26:54Z

Hi @akning-ms I have fixed the prettier check issues. For the lint issue, that will remain unfixed because our RP doesn't implement systemData for the MarketplaceRegistrationDefinition data type (it is not customer facing anyway). Also for the registrationDefinitionIdParameter, it shouldn't be a breaking change as we pulled this from the latest preview API.

Can we make sure this PR is merge-ready (but don't merge yet)? We will give ack on merge as soon as the new API is live.

skayani · 2022-01-11T00:27:42Z

Hi @akning-ms , can you please ack on this PR? Once you do, I will update our RP manifest with the new version so that we can then merge this

akning-ms · 2022-01-18T02:06:53Z

e sure this PR is merge-ready (but don't merge yet)? We will give ack on merge as soon as the new API is live.

Hi @skayani, For registrationDefinitionIdParameter, as it is breaking your latest stable version, if your previous preview version is not get breaking change review board approval, you may have to get breaking change review board approval. if yes. can you show me the PR# for previous preivew version's approval?
And for systemData, it is ok now, but do you have a roughly plan to support it?

openapi-workflow-bot · 2022-01-21T07:26:17Z

Hi @skayani, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

...s/resource-manager/Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json

mentat9 · 2022-01-26T00:26:38Z

Signed off with comments from ARM perspective.

akning-ms · 2022-01-26T06:01:05Z

Hi @skayani, I have approved your PR. Seems your service is not ready. Can I know when it will be deployed? I will help merge it when your service is deploy to production.

skayani · 2022-01-31T17:44:58Z

Hi @skayani, I have approved your PR. Seems your service is not ready. Can I know when it will be deployed? I will help merge it when your service is deploy to production.

Hey @akning-ms , I kicked off the RP manifest update job last week. I see the changes are in prod now, can we merge?

skayani · 2022-02-03T02:48:43Z

@akning-ms Ping again, can we please merge the PR?

skayani added 4 commits December 14, 2021 11:02

Adds base for updating Microsoft.ManagedServices from version preview…

ae68d70

…/2020-02-01-preview to version 2022-01-01-preview

Updates readme

52af676

Updates API version in new specs and examples

6b74bec

Add 2022 API swagger details

971b2ee

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Dec 14, 2021

openapi-sdkautomation bot mentioned this pull request Dec 14, 2021

[AutoPR azure-mgmt-managedservices] [Hub Generated] Review request for Microsoft.ManagedServices to add version preview/2022-01-01-preview AzureSDKAutomation/azure-sdk-for-python#8394

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Dec 14, 2021

openapi-sdkautomation bot mentioned this pull request Dec 14, 2021

[AutoPR track2_azure-mgmt-managedservices] [Hub Generated] Review request for Microsoft.ManagedServices to add version preview/2022-01-01-preview AzureSDKAutomation/azure-sdk-for-python#8395

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Dec 14, 2021

skayani marked this pull request as ready for review December 14, 2021 20:06

openapi-assignment-bot bot assigned akning-ms Dec 14, 2021

skayani mentioned this pull request Dec 14, 2021

Add new 2021-11-01-preview API to support SystemData and managedByTenantId query filtering #16859

Closed

25 tasks

msyyc added the Approved-SdkBreakingChange-Python label Dec 23, 2021

Prettier fix changes

b1f0821

skayani added 2 commits January 10, 2022 14:58

Fix for operations API

b4d417e

Fix example ref

992b6f5

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 18, 2022

akning-ms added the BreakingChangeReviewRequired label Jan 21, 2022

Further swagger fixes

69132c5

openapi-pipeline-app bot added CI-BreakingChange-Go-V2 and removed CI-BreakingChange-Python labels Jan 21, 2022

Further swagger fixes

6bcbc0c

openapi-pipeline-app bot added the CI-BreakingChange-Python label Jan 21, 2022

mentat9 reviewed Jan 26, 2022

View reviewed changes

...s/resource-manager/Microsoft.ManagedServices/preview/2022-01-01-preview/managedservices.json Outdated Show resolved Hide resolved

mentat9 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChangeReviewRequired labels Jan 26, 2022

Changed system data definition ref to v3

79e6866

akning-ms added the Approved-LintDiff label Jan 26, 2022

akning-ms approved these changes Jan 26, 2022

View reviewed changes

akning-ms added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jan 26, 2022

akning-ms merged commit f671a8a into Azure:main Feb 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.ManagedServices to add version preview/2022-01-01-preview #17089

[Hub Generated] Review request for Microsoft.ManagedServices to add version preview/2022-01-01-preview #17089

skayani commented Dec 14, 2021 •

edited by akning-ms

Loading

openapi-workflow-bot bot commented Dec 14, 2021

openapi-workflow-bot bot commented Dec 14, 2021

openapi-pipeline-app bot commented Dec 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Dec 14, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Dec 14, 2021

skayani commented Dec 14, 2021

akning-ms commented Dec 22, 2021

msyyc commented Dec 23, 2021

skayani commented Jan 5, 2022 •

edited

Loading

skayani commented Jan 11, 2022

akning-ms commented Jan 18, 2022 •

edited

Loading

openapi-workflow-bot bot commented Jan 21, 2022

mentat9 commented Jan 26, 2022

akning-ms commented Jan 26, 2022

skayani commented Jan 31, 2022

skayani commented Feb 3, 2022

[Hub Generated] Review request for Microsoft.ManagedServices to add version preview/2022-01-01-preview #17089

[Hub Generated] Review request for Microsoft.ManagedServices to add version preview/2022-01-01-preview #17089

Conversation

skayani commented Dec 14, 2021 • edited by akning-ms Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Dec 14, 2021

openapi-workflow-bot bot commented Dec 14, 2021

openapi-pipeline-app bot commented Dec 14, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Dec 14, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Dec 14, 2021

skayani commented Dec 14, 2021

akning-ms commented Dec 22, 2021

msyyc commented Dec 23, 2021

skayani commented Jan 5, 2022 • edited Loading

skayani commented Jan 11, 2022

akning-ms commented Jan 18, 2022 • edited Loading

openapi-workflow-bot bot commented Jan 21, 2022

mentat9 commented Jan 26, 2022

akning-ms commented Jan 26, 2022

skayani commented Jan 31, 2022

skayani commented Feb 3, 2022

skayani commented Dec 14, 2021 •

edited by akning-ms

Loading

openapi-pipeline-app bot commented Dec 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Dec 14, 2021 •

edited

Loading

skayani commented Jan 5, 2022 •

edited

Loading

akning-ms commented Jan 18, 2022 •

edited

Loading