Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse] Azure Synapse Correctness #17116

Merged
merged 13 commits into from
Dec 27, 2021
Merged

Conversation

niks02
Copy link
Contributor

@niks02 niks02 commented Dec 16, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @niks02 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 16, 2021

    Swagger Validation Report

    ️❌BreakingChange: 40 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Synapse/stable/2021-06-01/firewallRule.json#L122:11
    1019 - RemovedEnumValue The new version is removing enum value(s) 'ZRS' from the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5381:9
    Old: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5371:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'ZRS' from the old version.
    New: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5382:9
    Old: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5371:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Synapse/preview/2021-06-01-preview/workspace.json#L1287:9
    Old: Microsoft.Synapse/preview/2021-06-01-preview/workspace.json#L1279:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5327:9
    Old: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5327:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5382:9
    Old: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5371:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6122:9
    Old: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6107:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6132:9
    Old: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6116:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1237:9
    Old: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1237:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Synapse/stable/2021-06-01/workspace.json#L1291:9
    Old: Microsoft.Synapse/stable/2021-06-01/workspace.json#L1279:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L406:9
    Old: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L406:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5347:9
    Old: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5343:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5375:9
    Old: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5366:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5418:13
    Old: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5409:13
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L406:9
    Old: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L406:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5348:9
    Old: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5343:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5376:9
    Old: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5366:9
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'state' renamed or removed?
    New: Microsoft.Synapse/stable/2021-06-01/integrationRuntime.json#L1379:7
    Old: Microsoft.Synapse/stable/2021-06-01/integrationRuntime.json#L1379:7
    1041 - AddedPropertyInResponse The new version has a new property 'minExecutors' in response that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L544:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L543:7
    1041 - AddedPropertyInResponse The new version has a new property 'maxExecutors' in response that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L544:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L543:7
    1041 - AddedPropertyInResponse The new version has a new property 'trustedServiceBypassEnabled' in response that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/workspace.json#L1208:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/workspace.json#L1200:7
    1041 - AddedPropertyInResponse The new version has a new property 'minExecutors' in response that was not found in the old version.
    New: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L544:7
    Old: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L543:7
    1041 - AddedPropertyInResponse The new version has a new property 'maxExecutors' in response that was not found in the old version.
    New: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L544:7
    Old: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L543:7
    1041 - AddedPropertyInResponse The new version has a new property 'configurationType' in response that was not found in the old version.
    New: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L625:7
    Old: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L593:7
    1041 - AddedPropertyInResponse The new version has a new property 'isDevopsAuditEnabled' in response that was not found in the old version.
    New: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1200:7
    Old: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1200:7
    1041 - AddedPropertyInResponse The new version has a new property 'isDevopsAuditEnabled' in response that was not found in the old version.
    New: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1303:7
    Old: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1298:7
    1041 - AddedPropertyInResponse The new version has a new property 'trustedServiceBypassEnabled' in response that was not found in the old version.
    New: Microsoft.Synapse/stable/2021-06-01/workspace.json#L1208:7
    Old: Microsoft.Synapse/stable/2021-06-01/workspace.json#L1200:7
    1045 - AddedOptionalProperty The new version has a new optional property 'minExecutors' that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L544:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L543:7
    1045 - AddedOptionalProperty The new version has a new optional property 'maxExecutors' that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L544:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L543:7
    1045 - AddedOptionalProperty The new version has a new optional property 'managedVirtualNetwork' that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L1379:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L1379:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: synapse/common/v1/privateEndpointConnection.json#L326
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: synapse/common/v1/privateEndpointConnection.json#L326
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: synapse/common/v1/privateEndpointConnection.json#L326
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: synapse/common/v1/privateEndpointConnection.json#L326
    R4009 - RequiredReadOnlySystemData The response of operation:'BigDataPools_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L25
    R4009 - RequiredReadOnlySystemData The response of operation:'IpFirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/firewallRule.json#L206
    R4009 - RequiredReadOnlySystemData The response of operation:'IntegrationRuntimes_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/integrationRuntime.json#L85
    R4009 - RequiredReadOnlySystemData The response of operation:'Keys_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/keys.json#L75
    R4009 - RequiredReadOnlySystemData The response of operation:'Library_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/library.json#L25
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/privateEndpointConnections.json#L46
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/privateLinkResources.json#L75
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateLinkHubPrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/privateLinkResources.json#L175
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateLinkHubs_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/privatelinkhub.json#L86
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPools_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L25
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolMetadataSyncConfigs_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L520
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolGeoBackupPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L851
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolDataWarehouseUserActivities_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L921
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolReplicationLinks_GetByName' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L1172
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolMaintenanceWindows_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L1233
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolMaintenanceWindowOptions_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L1356
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolTransparentDataEncryptions_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L1414
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L1619
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolSensitivityLabels_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L2290
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolConnectionPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L2739
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolSecurityAlertPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L3130
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolVulnerabilityAssessmentRuleBaselines_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L3449
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolVulnerabilityAssessments_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L3535
    R4009 - RequiredReadOnlySystemData The response of operation:'ExtendedSqlPoolBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L3747
    R4009 - RequiredReadOnlySystemData The response of operation:'DataMaskingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L4007
    R4009 - RequiredReadOnlySystemData The response of operation:'DataMaskingRules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L4148
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/synapse/resource-manager/readme.md
    tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 16, 2021

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armsynapse - 0.2.0
    +	Const `StorageAccountTypeZRS` has been removed
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.1.0b3
    azure-sdk-for-go - synapse/mgmt/2021-03-01/synapse - v60.3.0
    +	Const `Default` type has been changed from `VulnerabilityAssessmentPolicyBaselineName` to `CreateMode`
    +	Const `Master` has been removed
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    azure-sdk-for-go - synapse/mgmt/2020-12-01/synapse - v60.3.0
    +	Const `Default` type has been changed from `VulnerabilityAssessmentPolicyBaselineName` to `CreateMode`
    +	Const `Master` has been removed
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    azure-sdk-for-go - preview/synapse/mgmt/v2.0/synapse - v60.3.0
    +	Const `StorageAccountTypeZRS` has been removed
    azure-sdk-for-go - preview/synapse/mgmt/v1.0/synapse - v60.3.0
    +	Const `StorageAccountTypeZRS` has been removed
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    azure-sdk-for-go - preview/synapse/mgmt/2021-06-01-preview/synapse - v60.3.0
    +	Const `StorageAccountTypeZRS` has been removed
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    azure-sdk-for-go - preview/synapse/mgmt/2019-06-01-preview/synapse - v60.3.0
    +	Const `Default` type has been changed from `VulnerabilityAssessmentPolicyBaselineName` to `CreateMode`
    +	Const `Master` has been removed
    +	Field `HaveLibraryRequirementsChanged` of struct `BigDataPoolResourceProperties` has been removed
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs] Generate from 9ac4ed6eee4c6c352f1f110e09a54556f26100a5. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.Synapse [View full logs]  [Preview SDK Changes]
      cmderr	[msbuild] Could not execute because the application was not found or a compatible .NET SDK is not installed.
      cmderr	[msbuild] Possible reasons for this include:
      cmderr	[msbuild]   * You intended to execute a .NET program:
      cmderr	[msbuild]       The application 'msbuild' does not exist.
      cmderr	[msbuild]   * You intended to execute a .NET SDK command:
      cmderr	[msbuild]       A compatible installed .NET SDK for global.json version [6.0.100] from [/home/vsts/work/1/s/azure-sdk-for-net/global.json] was not found.
      cmderr	[msbuild]       Install the [6.0.100] .NET SDK or update [/home/vsts/work/1/s/azure-sdk-for-net/global.json] with an installed .NET SDK:
      error	Script return with result [failed] code [145] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from 9ac4ed6eee4c6c352f1f110e09a54556f26100a5. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] npm notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-synapse [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 9ac4ed6eee4c6c352f1f110e09a54556f26100a5. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-12-23 12:43:27 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-synapse;1.0.0-beta.4;1.0.0-beta.5"
      cmderr	[generate.py] 2021-12-23 12:43:27 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.5"
      cmderr	[generate.py] 2021-12-23 12:43:27 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.43 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
      cmderr	[generate.py] 2021-12-23 12:44:32 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-synapse
      cmderr	[generate.py] 2021-12-23 12:44:32 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-12-23 12:44:32 INFO [POM][Skip] pom already has module azure-resourcemanager-synapse
      cmderr	[generate.py] 2021-12-23 12:44:32 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-12-23 12:44:32 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-12-23 12:44:32 INFO [POM][Skip] pom already has module sdk/synapse
      cmderr	[generate.py] 2021-12-23 12:44:32 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-synapse [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-12-23 12:47:14 DEBUG Got artifact_id: azure-resourcemanager-synapse
      cmderr	[Inst] 2021-12-23 12:47:14 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-12-23 12:47:14 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.5.jar
      cmderr	[Inst] 2021-12-23 12:47:14 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.5.jar
      cmderr	[Inst] 2021-12-23 12:47:14 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17116/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.5.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.5.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.5.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 9ac4ed6eee4c6c352f1f110e09a54556f26100a5. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh]  New minor version of npm available! 8.1.2 -> 8.3.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.3.0` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-synapse [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model DynamicExecutorAllocation has a new parameter max_executors
      info	[Changelog]   - Model DynamicExecutorAllocation has a new parameter min_executors
      info	[Changelog]   - Model ExtendedServerBlobAuditingPolicy has a new parameter is_devops_audit_enabled
      info	[Changelog]   - Model ManagedIntegrationRuntime has a new parameter id
      info	[Changelog]   - Model ManagedIntegrationRuntime has a new parameter reference_name
      info	[Changelog]   - Model ManagedIntegrationRuntime has a new parameter type_managed_virtual_network_type
      info	[Changelog]   - Model SelfHostedIntegrationRuntimeStatus has a new parameter newer_versions
      info	[Changelog]   - Model SelfHostedIntegrationRuntimeStatus has a new parameter service_region
      info	[Changelog]   - Model ServerBlobAuditingPolicy has a new parameter is_devops_audit_enabled
      info	[Changelog]   - Model Workspace has a new parameter trusted_service_bypass_enabled
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 9ac4ed6eee4c6c352f1f110e09a54556f26100a5. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️synapse/mgmt/2021-03-01/synapse [View full logs]  [Preview SDK Changes]
      Only show 20 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] - New const `VulnerabilityAssessmentPolicyBaselineNameDefault`
      info	[Changelog] - New const `VulnerabilityAssessmentPolicyBaselineNameMaster`
      info	[Changelog] - New const `Recovery`
      info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedFPGA`
      info	[Changelog] - New const `PointInTimeRestore`
      info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedGPU`
      info	[Changelog] - New const `Restore`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsResponder(*http.Response) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)`
      info	[Changelog] - New function `PossibleCreateModeValues() []CreateMode`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpoints(context.Context, string, string, string) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsPreparer(context.Context, string, string, string) (*http.Request, error)`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesCategoryEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointDetails`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse`
      info	[Changelog] - New field `SubnetID` in struct `IntegrationRuntimeVNetProperties`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 21 additive change(s).
    • ️✔️synapse/mgmt/2020-12-01/synapse [View full logs
      Only show 20 items here, please refer to log for details.
      info	[Changelog] - New function `LibrariesClient.ListByWorkspacePreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `LibrariesClient.ListByWorkspaceResponder(*http.Response) (LibraryListResponse, error)`
      info	[Changelog] - New function `*LibraryListResponsePage.NextWithContext(context.Context) error`
      info	[Changelog] - New function `*LibraryListResponseIterator.Next() error`
      info	[Changelog] - New function `NewLibraryListResponseIterator(LibraryListResponsePage) LibraryListResponseIterator`
      info	[Changelog] - New function `PossibleCreateModeValues() []CreateMode`
      info	[Changelog] - New function `LibraryListResponsePage.NotDone() bool`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesCategoryEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointDetails`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse`
      info	[Changelog] - New struct `LibrariesClient`
      info	[Changelog] - New struct `LibraryClient`
      info	[Changelog] - New struct `LibraryListResponse`
      info	[Changelog] - New struct `LibraryListResponseIterator`
      info	[Changelog] - New struct `LibraryListResponsePage`
      info	[Changelog] - New struct `LibraryResource`
      info	[Changelog] - New field `SubnetID` in struct `IntegrationRuntimeVNetProperties`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 61 additive change(s).
    • ️✔️preview/synapse/mgmt/v2.0/synapse [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Const `StorageAccountTypeZRS` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `SQLPoolResourceProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `ManagedIntegrationRuntimeManagedVirtualNetworkReference`
      info	[Changelog] - New field `ServiceRegion` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog] - New field `NewerVersions` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog] - New field `IsDevopsAuditEnabled` in struct `ExtendedServerBlobAuditingPolicyProperties`
      info	[Changelog] - New anonymous field `*ManagedIntegrationRuntimeManagedVirtualNetworkReference` in struct `ManagedIntegrationRuntime`
      info	[Changelog] - New field `IsDevopsAuditEnabled` in struct `ServerBlobAuditingPolicyProperties`
      info	[Changelog] - New field `MinExecutors` in struct `DynamicExecutorAllocation`
      info	[Changelog] - New field `MaxExecutors` in struct `DynamicExecutorAllocation`
      info	[Changelog] - New field `TrustedServiceBypassEnabled` in struct `WorkspaceProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 9 additive change(s).
    • ️✔️preview/synapse/mgmt/v1.0/synapse [View full logs
      Only show 20 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `CreateModeRecovery`
      info	[Changelog] - New const `CreateModeRestore`
      info	[Changelog] - New const `CreateModeDefault`
      info	[Changelog] - New const `CreateModePointInTimeRestore`
      info	[Changelog] - New function `SQLPoolResourceProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleCreateModeValues() []CreateMode`
      info	[Changelog] - New struct `ManagedIntegrationRuntimeManagedVirtualNetworkReference`
      info	[Changelog] - New anonymous field `*ManagedIntegrationRuntimeManagedVirtualNetworkReference` in struct `ManagedIntegrationRuntime`
      info	[Changelog] - New field `IsDevopsAuditEnabled` in struct `ServerBlobAuditingPolicyProperties`
      info	[Changelog] - New field `ServiceRegion` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog] - New field `NewerVersions` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog] - New field `MinExecutors` in struct `DynamicExecutorAllocation`
      info	[Changelog] - New field `MaxExecutors` in struct `DynamicExecutorAllocation`
      info	[Changelog] - New field `TrustedServiceBypassEnabled` in struct `WorkspaceProperties`
      info	[Changelog] - New field `IsDevopsAuditEnabled` in struct `ExtendedServerBlobAuditingPolicyProperties`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 14 additive change(s).
    • ️✔️preview/synapse/mgmt/2021-06-01-preview/synapse [View full logs
      Only show 20 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `CreateModeDefault`
      info	[Changelog] - New const `CreateModePointInTimeRestore`
      info	[Changelog] - New const `CreateModeRecovery`
      info	[Changelog] - New const `CreateModeRestore`
      info	[Changelog] - New function `SQLPoolResourceProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `MetadataSyncConfigProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleCreateModeValues() []CreateMode`
      info	[Changelog] - New struct `ManagedIntegrationRuntimeManagedVirtualNetworkReference`
      info	[Changelog] - New field `TrustedServiceBypassEnabled` in struct `WorkspaceProperties`
      info	[Changelog] - New field `MinExecutors` in struct `DynamicExecutorAllocation`
      info	[Changelog] - New field `MaxExecutors` in struct `DynamicExecutorAllocation`
      info	[Changelog] - New field `Cleanup` in struct `IntegrationRuntimeDataFlowProperties`
      info	[Changelog] - New anonymous field `*ManagedIntegrationRuntimeManagedVirtualNetworkReference` in struct `ManagedIntegrationRuntime`
      info	[Changelog] - New field `NewerVersions` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog] - New field `ServiceRegion` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 14 additive change(s).
    • ️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logs
      Only show 20 items here, please refer to log for details.
      info	[Changelog] - New struct `SensitivityLabelUpdateProperties`
      info	[Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties`
      info	[Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `Cleanup` in struct `IntegrationRuntimeDataFlowProperties`
      info	[Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties`
      info	[Changelog] - New field `ManagedBy` in struct `SensitivityLabel`
      info	[Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime`
      info	[Changelog] - New field `ClientID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `ClientSecret` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `Rank` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `TableName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 128 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 9ac4ed6eee4c6c352f1f110e09a54556f26100a5. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armsynapse [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Const `StorageAccountTypeZRS` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `ManagedIntegrationRuntimeManagedVirtualNetworkReference`
      info	[Changelog] - New field `IsDevopsAuditEnabled` in struct `ServerBlobAuditingPolicyProperties`
      info	[Changelog] - New field `IsDevopsAuditEnabled` in struct `ExtendedServerBlobAuditingPolicyProperties`
      info	[Changelog] - New field `MaxExecutors` in struct `DynamicExecutorAllocation`
      info	[Changelog] - New field `MinExecutors` in struct `DynamicExecutorAllocation`
      info	[Changelog] - New field `NewerVersions` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog] - New field `ServiceRegion` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime`
      info	[Changelog] - New field `TrustedServiceBypassEnabled` in struct `WorkspaceProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 8 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 9ac4ed6eee4c6c352f1f110e09a54556f26100a5. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️synapse [View full logs]  [Preview Schema Changes]
    ️🔄 $(sdkName) inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @niks02, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @wonner
    Copy link
    Contributor

    wonner commented Dec 17, 2021

    Hi @niks02 , it will be breaking changes, you may need to add new API version or go through breaking change review process.

    @openapi-workflow-bot
    Copy link

    Hi @niks02, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 24, 2021
    @ruowan ruowan merged commit a63f789 into Azure:main Dec 27, 2021
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * [Synapse] Azure Synapse Correctness
    
    * roundtripCorrectnessFixes
    
    * Prettier and Semantic fix
    
    * Model, Semantic and Prettier fix
    
    * More Correctness changes
    
    * More Correctness changes
    
    * Lint changes
    
    * Lint Diff Fix
    
    * Suggestions Incoporation
    
    * Review Comment Incoporation
    
    * Review Comments Incoporation 1
    
    * Semantic fix
    
    * Review Comment Incoporation
    
    Co-authored-by: Nikhil Kumar <nikhilkumar@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go-V2 CI-FixRequiredOnFailure FixS360 Synapses
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants