Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new API version (2022-01-01-preview) for microsoft.app RP #17125

Closed
wants to merge 14 commits into from
Closed

Add a new API version (2022-01-01-preview) for microsoft.app RP #17125

wants to merge 14 commits into from

Conversation

ruslany
Copy link
Contributor

@ruslany ruslany commented Dec 16, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    January 2022
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    January 2022
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ruslany Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 16, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @ruslany your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 16, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2015 - ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-01-01-preview/CommonDefinitions.json#L1
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: AuthorizationFailed,
    message: The client '0a32c980-8601-446c-843e-9411a8f586c7' with object id '0a32c980-8601-446c-843e-9411a8f586c7' does not have authorization to perform action 'Microsoft.App/operations/read' over scope '/providers/Microsoft.App' or the scope is invalid. If access was recently granted,
    please refresh your credentials."
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 16, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armapp - 0.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-app - first release
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from e33197c1e034df214901275b48f3229c177f5a3f. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh]  New minor version of npm available! 8.1.2 -> 8.3.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.3.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-app [View full logs]  [Preview SDK Changes] 
      info	[Changelog]   - Initial Release
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from e33197c1e034df214901275b48f3229c177f5a3f. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-12-17 00:09:08 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-app"
cmderr	[generate.py] 2021-12-17 00:09:08 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-12-17 00:09:08 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.43 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/app/azure-resourcemanager-app --java.namespace=com.azure.resourcemanager.app   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/app/resource-manager/readme.md
cmderr	[generate.py] 2021-12-17 00:09:40 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-12-17 00:09:40 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-12-17 00:09:40 INFO [POM][Skip] pom already has module azure-resourcemanager-app
cmderr	[generate.py] 2021-12-17 00:09:40 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-12-17 00:09:40 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-12-17 00:09:40 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-app [View full logs]  [Preview SDK Changes] 
      cmderr	[Inst] 2021-12-17 00:11:19 DEBUG Got artifact_id: azure-resourcemanager-app
cmderr	[Inst] 2021-12-17 00:11:19 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-12-17 00:11:19 DEBUG Got artifact: azure-resourcemanager-app-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-12-17 00:11:19 DEBUG Got artifact: azure-resourcemanager-app-1.0.0-beta.1.jar
cmderr	[Inst] 2021-12-17 00:11:19 DEBUG Match jar package: azure-resourcemanager-app-1.0.0-beta.1.jar
cmderr	[Inst] 2021-12-17 00:11:19 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17125/azure-sdk-for-java/azure-resourcemanager-app/azure-resourcemanager-app-1.0.0-beta.1.jar\" -o azure-resourcemanager-app-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-app -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-app-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from e33197c1e034df214901275b48f3229c177f5a3f. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armapp [View full logs]  [Preview SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New function `*ManagedEnvironmentsClient.ListBySubscription(*ManagedEnvironmentsListBySubscriptionOptions) *ManagedEnvironmentsListBySubscriptionPager`
info	[Changelog] - New function `*ContainerAppsClient.ListBySubscription(*ContainerAppsListBySubscriptionOptions) *ContainerAppsListBySubscriptionPager`
info	[Changelog] - New function `PossibleRevisionHealthStateValues() []RevisionHealthState`
info	[Changelog] - New function `*ContainerAppsCreateOrUpdatePoller.FinalResponse(context.Context) (ContainerAppsCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*ContainerAppsRevisionsListRevisionsPager.NextPage(context.Context) bool`
info	[Changelog] - New function `*ContainerAppsRevisionsClient.GetRevision(context.Context, string, string, string, *ContainerAppsRevisionsGetRevisionOptions) (ContainerAppsRevisionsGetRevisionResponse, error)`
info	[Changelog] - New function `*ContainerAppsClient.Get(context.Context, string, string, *ContainerAppsGetOptions) (ContainerAppsGetResponse, error)`
info	[Changelog] - New function `QueueScaleRule.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleRevisionProvisioningStateValues() []RevisionProvisioningState`
info	[Changelog] - New struct `AppLogsConfiguration`
info	[Changelog] - New struct `AvailableOperations`
info	[Changelog] - New struct `Configuration`
info	[Changelog] - New struct `Container`
info	[Changelog] - New struct `ContainerApp`
info	[Changelog] - New struct `ContainerAppCollection`
info	[Changelog] - New struct `ContainerAppPatch`
info	[Changelog] - New struct `ContainerAppProperties`
info	[Changelog] - New struct `ContainerAppsBeginCreateOrUpdateOptions`
info	[Changelog] - New struct `ContainerAppsBeginDeleteOptions`
info	[Changelog] - New struct `ContainerAppsClient`
info	[Changelog] - New struct `ContainerAppsCreateOrUpdatePoller`
info	[Changelog] - New struct `ContainerAppsCreateOrUpdatePollerResponse`
info	[Changelog] - New struct `ContainerAppsCreateOrUpdateResponse`
info	[Changelog] - New struct `ContainerAppsCreateOrUpdateResult`
info	[Changelog] - New struct `ContainerAppsDeletePoller`
info	[Changelog] - New struct `ContainerAppsDeletePollerResponse`
info	[Changelog] - New struct `ContainerAppsDeleteResponse`
info	[Changelog] - New struct `ContainerAppsGetOptions`
info	[Changelog] - New struct `ContainerAppsGetResponse`
info	[Changelog] - New struct `ContainerAppsGetResult`
info	[Changelog] - New struct `ContainerAppsListByResourceGroupOptions`
info	[Changelog] - New struct `ContainerAppsListByResourceGroupPager`
info	[Changelog] - New struct `ContainerAppsListByResourceGroupResponse`
info	[Changelog] - New struct `ContainerAppsListByResourceGroupResult`
info	[Changelog] - New struct `ContainerAppsListBySubscriptionOptions`
info	[Changelog] - New struct `ContainerAppsListBySubscriptionPager`
info	[Changelog] - New struct `ContainerAppsListBySubscriptionResponse`
info	[Changelog] - New struct `ContainerAppsListBySubscriptionResult`
info	[Changelog] - New struct `ContainerAppsRevisionsActivateRevisionOptions`
info	[Changelog] - New struct `ContainerAppsRevisionsActivateRevisionResponse`
info	[Changelog] - New struct `ContainerAppsRevisionsClient`
info	[Changelog] - New struct `ContainerAppsRevisionsDeactivateRevisionOptions`
info	[Changelog] - New struct `ContainerAppsRevisionsDeactivateRevisionResponse`
info	[Changelog] - New struct `ContainerAppsRevisionsGetRevisionOptions`
info	[Changelog] - New struct `ContainerAppsRevisionsGetRevisionResponse`
info	[Changelog] - New struct `ContainerAppsRevisionsGetRevisionResult`
info	[Changelog] - New struct `ContainerAppsRevisionsListRevisionsOptions`
info	[Changelog] - New struct `ContainerAppsRevisionsListRevisionsPager`
info	[Changelog] - New struct `ContainerAppsRevisionsListRevisionsResponse`
info	[Changelog] - New struct `ContainerAppsRevisionsListRevisionsResult`
info	[Changelog] - New struct `ContainerAppsRevisionsRestartRevisionOptions`
info	[Changelog] - New struct `ContainerAppsRevisionsRestartRevisionResponse`
info	[Changelog] - New struct `ContainerAppsUpdateOptions`
info	[Changelog] - New struct `ContainerAppsUpdateResponse`
info	[Changelog] - New struct `ContainerAppsUpdateResult`
info	[Changelog] - New struct `ContainerResources`
info	[Changelog] - New struct `CustomScaleRule`
info	[Changelog] - New struct `Dapr`
info	[Changelog] - New struct `DaprComponent`
info	[Changelog] - New struct `DaprMetadata`
info	[Changelog] - New struct `DefaultErrorResponse`
info	[Changelog] - New struct `DefaultErrorResponseError`
info	[Changelog] - New struct `DefaultErrorResponseErrorDetailsItem`
info	[Changelog] - New struct `EnvironmentVar`
info	[Changelog] - New struct `HTTPScaleRule`
info	[Changelog] - New struct `Ingress`
info	[Changelog] - New struct `LogAnalyticsConfiguration`
info	[Changelog] - New struct `ManagedEnvironment`
info	[Changelog] - New struct `ManagedEnvironmentPatch`
info	[Changelog] - New struct `ManagedEnvironmentProperties`
info	[Changelog] - New struct `ManagedEnvironmentsBeginCreateOrUpdateOptions`
info	[Changelog] - New struct `ManagedEnvironmentsBeginDeleteOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClient`
info	[Changelog] - New struct `ManagedEnvironmentsCollection`
info	[Changelog] - New struct `ManagedEnvironmentsCreateOrUpdatePoller`
info	[Changelog] - New struct `ManagedEnvironmentsCreateOrUpdatePollerResponse`
info	[Changelog] - New struct `ManagedEnvironmentsCreateOrUpdateResponse`
info	[Changelog] - New struct `ManagedEnvironmentsCreateOrUpdateResult`
info	[Changelog] - New struct `ManagedEnvironmentsDeletePoller`
info	[Changelog] - New struct `ManagedEnvironmentsDeletePollerResponse`
info	[Changelog] - New struct `ManagedEnvironmentsDeleteResponse`
info	[Changelog] - New struct `ManagedEnvironmentsGetOptions`
info	[Changelog] - New struct `ManagedEnvironmentsGetResponse`
info	[Changelog] - New struct `ManagedEnvironmentsGetResult`
info	[Changelog] - New struct `ManagedEnvironmentsListByResourceGroupOptions`
info	[Changelog] - New struct `ManagedEnvironmentsListByResourceGroupPager`
info	[Changelog] - New struct `ManagedEnvironmentsListByResourceGroupResponse`
info	[Changelog] - New struct `ManagedEnvironmentsListByResourceGroupResult`
info	[Changelog] - New struct `ManagedEnvironmentsListBySubscriptionOptions`
info	[Changelog] - New struct `ManagedEnvironmentsListBySubscriptionPager`
info	[Changelog] - New struct `ManagedEnvironmentsListBySubscriptionResponse`
info	[Changelog] - New struct `ManagedEnvironmentsListBySubscriptionResult`
info	[Changelog] - New struct `ManagedEnvironmentsUpdateOptions`
info	[Changelog] - New struct `ManagedEnvironmentsUpdateResponse`
info	[Changelog] - New struct `ManagedEnvironmentsUpdateResult`
info	[Changelog] - New struct `OperationDetail`
info	[Changelog] - New struct `OperationDisplay`
info	[Changelog] - New struct `OperationsClient`
info	[Changelog] - New struct `OperationsListOptions`
info	[Changelog] - New struct `OperationsListPager`
info	[Changelog] - New struct `OperationsListResponse`
info	[Changelog] - New struct `OperationsListResult`
info	[Changelog] - New struct `ProxyResource`
info	[Changelog] - New struct `QueueScaleRule`
info	[Changelog] - New struct `RegistryCredentials`
info	[Changelog] - New struct `Resource`
info	[Changelog] - New struct `Revision`
info	[Changelog] - New struct `RevisionCollection`
info	[Changelog] - New struct `RevisionProperties`
info	[Changelog] - New struct `Scale`
info	[Changelog] - New struct `ScaleRule`
info	[Changelog] - New struct `ScaleRuleAuth`
info	[Changelog] - New struct `Secret`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `Template`
info	[Changelog] - New struct `TrackedResource`
info	[Changelog] - New struct `TrafficWeight`
info	[Changelog] - New struct `VnetConfiguration`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 359 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from e33197c1e034df214901275b48f3229c177f5a3f. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-app [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from e33197c1e034df214901275b48f3229c177f5a3f. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ruslany, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Dec 16, 2021
    Draft
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Dec 16, 2021
    Draft
    This was referenced Dec 16, 2021
    Draft
    Draft
    @ruslany
    Copy link
    Contributor Author

    ruslany commented Dec 16, 2021

    @msyyc - the API Readiness check fails because we haven't onboarded the RP yet. In order to onboard we need to upload an ARM Manifest and the prereq to the ARM manifest is the swagger PR signoff.

    @ruslany
    Copy link
    Contributor Author

    ruslany commented Dec 17, 2021

    @msyyc - this is the same set of changes that were already approved in the private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/5629

    @ruslany
    Copy link
    Contributor Author

    ruslany commented Dec 17, 2021

    Created a different PR to a separate branch

    @ruslany ruslany closed this Dec 17, 2021
    @ruslany
    Copy link
    Contributor Author

    ruslany commented Dec 17, 2021

    #17135

    @ruslany ruslany deleted the dev-app-Microsoft.App-2022-01-01-preview branch May 13, 2022 23:13
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

    @BigCat20196 BigCat20196 Awaiting requested review from BigCat20196

    @jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

    @msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

    @qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

    @RAY-316 RAY-316 Awaiting requested review from RAY-316

    Assignees

    @msyyc msyyc

    Labels
    WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @ruslany @msyyc