[Microsoft.StorageSync] Update 2020-03-01 and 2020-09-01 API versions to fix swagger correctness issues. #17159

anpint · 2021-12-21T19:55:53Z

Changes to 2020-09-01:

update resource contracts to support systemData, which our service is already returning today.
add missing defaults in put server endpoint properties for optional properties
add missing property supportedAggregationTypes
change innerError property to innererror to reflect what the service actually returns

Changes to 2020-03-01:

add missing defaults in put server endpoint properties for optional properties
add missing property supportedAggregationTypes
change innerError property to innererror to reflect what the service actually returns

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…ing defaults in put server endpoint properties, add missing property supportedAggregationTypes

openapi-workflow-bot · 2021-12-21T19:55:55Z

Hi, @anpint Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-12-21T19:55:56Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-12-21T19:55:57Z

Swagger Validation Report

️❌BreakingChange: 22 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2020-03-01/storagesync.json compared with base:stable/2020-03-01/storagesync.json
- current:stable/2020-09-01/storagesync.json compared with base:stable/2020-09-01/storagesync.json

Rule	Message
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3475:9 Old: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3475:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3482:9 Old: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3481:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3482:9 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3482:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'innerError' renamed or removed? New: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3154:7 Old: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3154:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'innerError' renamed or removed? New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3154:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3154:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'systemData' in response that was not found in the old version. New: common-types/resource-management/v3/privatelinks.json#L22:7 Old: common-types/resource-management/v1/privatelinks.json#L22:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'systemData' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3276:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3276:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'systemData' in response that was not found in the old version. New: common-types/resource-management/v3/privatelinks.json#L105:7 Old: common-types/resource-management/v1/privatelinks.json#L105:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'systemData' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3292:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3292:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'systemData' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3308:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3308:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'systemData' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3607:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3606:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'systemData' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3623:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3622:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'systemData' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3656:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3655:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'supportedAggregationTypes' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3768:7 Old: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3766:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'innererror' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3154:7 Old: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3154:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'supportedAggregationTypes' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3773:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3772:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'innererror' in response that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3154:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3154:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'systemData' that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3388:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3388:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'systemData' that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3409:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3409:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'systemData' that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3455:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3455:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'systemData' that was not found in the old version. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3539:7 Old: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3538:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'systemData' that was not found in the old version. New: common-types/resource-management/v3/privatelinks.json#L22:7 Old: common-types/resource-management/v1/privatelinks.json#L22:7

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- storagesync/resource-manager/readme.md tag:package-2020-09-01
- storagesync/resource-manager/readme.md tag:package-2020-03-01
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- storagesync/resource-manager/readme.md tag:package-2020-09-01
- storagesync/resource-manager/readme.md tag:package-2020-03-01

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L109
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L549
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L109
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L549
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L2235
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L2235
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3475
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3482
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3966
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L4135
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L4256
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L4388
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L4394
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L4426
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L4432
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3475
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3482
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3961
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L4130
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L4234
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L4355
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L4361
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L4393
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L4399
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.StorageSync/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L22
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.StorageSync/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L22
`❌` R4037 - MissingTypeObject	The schema 'TriggerChangeDetectionParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3316
`❌` R4037 - MissingTypeObject	The schema 'RecallActionParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3344
`❌` R4037 - MissingTypeObject	The schema 'StorageSyncServiceCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3357
`❌` R4037 - MissingTypeObject	The schema 'StorageSyncServiceCreateParametersProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3418

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-12-21T19:55:57Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armstoragesync - 0.3.0

+	Field `InnerError` of struct `APIError` has been removed
+	Function `ResourcesMoveInfo.MarshalJSON` has been removed
+	Struct `Error` has been removed
+	Struct `OperationDisplayResource` has been removed
+	Struct `ResourcesMoveInfo` has been removed
+	Struct `SubscriptionState` has been removed
+	Type of `SyncGroupCreateParameters.Properties` has been changed from `map[string]interface{}` to `interface{}`

❌azure-sdk-for-python-track2 - track2_azure-mgmt-storagesync - Approved - 1.0.0

+	Model StorageSyncApiError no longer has parameter inner_error

️✔️azure-sdk-for-go - storagesync/mgmt/2020-09-01/storagesync - v61.3.0
️✔️azure-sdk-for-go - storagesync/mgmt/2020-03-01/storagesync - v61.3.0
️✔️azure-sdk-for-go - storagesync/mgmt/2019-10-01/storagesync - v61.3.0
️✔️azure-sdk-for-go - storagesync/mgmt/2019-06-01/storagesync - v61.3.0
️✔️azure-sdk-for-go - storagesync/mgmt/2019-02-01/storagesync - v61.3.0
️✔️azure-sdk-for-go - storagesync/mgmt/2018-10-01/storagesync - v61.3.0
️✔️azure-sdk-for-go - storagesync/mgmt/2018-07-01/storagesync - v61.3.0
️✔️azure-sdk-for-go - storagesync/mgmt/2018-04-02/storagesync - v61.3.0
❌azure-sdk-for-js - track2_@azure/arm-storagesync - Approved - 10.0.0

+	Interface StorageSyncApiError no longer has parameter innerError

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4c50e69. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/storagesync/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.StorageSync [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.StorageSync.6.0.0.nupkg
- Microsoft.Azure.Management.StorageSync.6.0.0.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 4c50e69. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-storagesync [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group MicrosoftStorageSyncOperationsMixin
info	[Changelog]   - Model CloudEndpoint has a new parameter change_enumeration_status
info	[Changelog]   - Model CloudEndpoint has a new parameter system_data
info	[Changelog]   - Model CloudEndpointCreateParameters has a new parameter system_data
info	[Changelog]   - Model OperationResourceMetricSpecification has a new parameter supported_aggregation_types
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
info	[Changelog]   - Model PrivateLinkResource has a new parameter system_data
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model RegisteredServer has a new parameter system_data
info	[Changelog]   - Model RegisteredServerCreateParameters has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model ServerEndpoint has a new parameter initial_upload_policy
info	[Changelog]   - Model ServerEndpoint has a new parameter system_data
info	[Changelog]   - Model ServerEndpointBackgroundDataDownloadActivity has a new parameter started_timestamp
info	[Changelog]   - Model ServerEndpointCreateParameters has a new parameter initial_upload_policy
info	[Changelog]   - Model ServerEndpointCreateParameters has a new parameter system_data
info	[Changelog]   - Model ServerEndpointSyncActivityStatus has a new parameter session_minutes_remaining
info	[Changelog]   - Model StorageSyncApiError has a new parameter innererror
info	[Changelog]   - Model StorageSyncService has a new parameter system_data
info	[Changelog]   - Model SyncGroup has a new parameter system_data
info	[Changelog]   - Model SyncGroupCreateParameters has a new parameter system_data
info	[Changelog]   - Model TrackedResource has a new parameter system_data
info	[Changelog]   - Model Workflow has a new parameter system_data
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model StorageSyncApiError no longer has parameter inner_error

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 4c50e69. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-10 07:10:35 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-storagesync"
cmderr	[generate.py] 2022-02-10 07:10:35 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2022-02-10 07:10:35 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/storagesync/azure-resourcemanager-storagesync --java.namespace=com.azure.resourcemanager.storagesync   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/storagesync/resource-manager/readme.md
cmderr	[generate.py] 2022-02-10 07:11:06 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2022-02-10 07:11:06 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-10 07:11:06 INFO [POM][Skip] pom already has module azure-resourcemanager-storagesync
cmderr	[generate.py] 2022-02-10 07:11:06 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-10 07:11:06 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-10 07:11:06 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-storagesync [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-02-10 07:12:34 DEBUG Got artifact_id: azure-resourcemanager-storagesync
cmderr	[Inst] 2022-02-10 07:12:34 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-10 07:12:34 DEBUG Got artifact: azure-resourcemanager-storagesync-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-10 07:12:34 DEBUG Match jar package: azure-resourcemanager-storagesync-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-10 07:12:34 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17159/azure-sdk-for-java/azure-resourcemanager-storagesync/azure-resourcemanager-storagesync-1.0.0-beta.1.jar\" -o azure-resourcemanager-storagesync-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-storagesync -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-storagesync-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4c50e69. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️storagesync/mgmt/2020-09-01/storagesync [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️storagesync/mgmt/2020-03-01/storagesync [View full logs]

Only show 15 items here, please refer to log for details.

info	[Changelog] - New struct `OperationResourceMetricSpecificationDimension`
info	[Changelog] - New struct `OperationResourceServiceSpecification`
info	[Changelog] - New field `Innererror` in struct `APIError`
info	[Changelog] - New field `Properties` in struct `OperationEntity`
info	[Changelog] - New field `SyncMode` in struct `ServerEndpointSyncActivityStatus`
info	[Changelog] - New field `HTTPMethod` in struct `ErrorDetails`
info	[Changelog] - New field `HashedMessage` in struct `ErrorDetails`
info	[Changelog] - New field `HTTPErrorCode` in struct `ErrorDetails`
info	[Changelog] - New field `RequestURI` in struct `ErrorDetails`
info	[Changelog] - New field `ExceptionType` in struct `ErrorDetails`
info	[Changelog] - New field `AgentVersionStatus` in struct `RegisteredServerProperties`
info	[Changelog] - New field `AgentVersionExpirationDate` in struct `RegisteredServerProperties`
info	[Changelog] - New field `LastSyncMode` in struct `ServerEndpointSyncSessionStatus`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 35 additive change(s).

️✔️storagesync/mgmt/2019-10-01/storagesync [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️storagesync/mgmt/2019-06-01/storagesync [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️storagesync/mgmt/2019-02-01/storagesync [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️storagesync/mgmt/2018-10-01/storagesync [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️storagesync/mgmt/2018-07-01/storagesync [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️storagesync/mgmt/2018-04-02/storagesync [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4c50e69. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armstoragesync [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `SyncGroupCreateParameters.Properties` has been changed from `map[string]interface{}` to `interface{}`
info	[Changelog] - Function `ResourcesMoveInfo.MarshalJSON` has been removed
info	[Changelog] - Struct `Error` has been removed
info	[Changelog] - Struct `OperationDisplayResource` has been removed
info	[Changelog] - Struct `ResourcesMoveInfo` has been removed
info	[Changelog] - Struct `SubscriptionState` has been removed
info	[Changelog] - Field `InnerError` of struct `APIError` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `CreatedByTypeManagedIdentity`
info	[Changelog] - New const `CreatedByTypeApplication`
info	[Changelog] - New const `CreatedByTypeKey`
info	[Changelog] - New const `CreatedByTypeUser`
info	[Changelog] - New function `*SystemData.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New function `CreatedByType.ToPtr() *CreatedByType`
info	[Changelog] - New function `SystemData.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `Innererror` in struct `APIError`
info	[Changelog] - New field `SystemData` in struct `SyncGroupCreateParameters`
info	[Changelog] - New field `SupportedAggregationTypes` in struct `OperationResourceMetricSpecification`
info	[Changelog] - New field `SystemData` in struct `CloudEndpointCreateParameters`
info	[Changelog] - New field `SystemData` in struct `PrivateLinkResource`
info	[Changelog] - New field `SystemData` in struct `RegisteredServerCreateParameters`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `SystemData` in struct `CloudEndpoint`
info	[Changelog] - New field `SystemData` in struct `SyncGroup`
info	[Changelog] - New field `SystemData` in struct `ServerEndpointCreateParameters`
info	[Changelog] - New field `SystemData` in struct `RegisteredServer`
info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `SystemData` in struct `Service`
info	[Changelog] - New field `SystemData` in struct `Workflow`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog] - New field `SystemData` in struct `ServerEndpoint`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog]
info	[Changelog] Total 11 breaking change(s), 27 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 4c50e69. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️track2_@azure/arm-storagesync [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-storagesync-10.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface SystemData
info	[Changelog]   - Added Type Alias CreatedByType
info	[Changelog]   - Interface OperationResourceMetricSpecification has a new optional parameter supportedAggregationTypes
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Interface StorageSyncApiError has a new optional parameter innererror
info	[Changelog]   - Added Enum KnownCreatedByType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface StorageSyncApiError no longer has parameter innerError

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 4c50e69. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️storagesync [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-12-21T19:58:40Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2021-12-21T19:58:40Z

Hi @anpint, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

changlong-liu · 2022-01-28T03:54:55Z

/azp run

azure-pipelines · 2022-01-28T03:55:05Z

Azure Pipelines successfully started running 1 pipeline(s).

anpint · 2022-01-31T19:47:38Z

@changlong-liu Please let me know if there's anything remaining to do with this PR or if it's ready to be merged. Looks like the only check that is failing is the breaking change check, and we've already received approval to make the changes.

changlong-liu · 2022-02-01T06:30:00Z

Hi @anpint , the approved breaking change is in swagger level, and still need to have SDK breaking review.

Adding @ArcturusZhang , @qiaozha , @msyyc for SDK breaking change. Thanks.

anpint · 2022-02-03T18:34:18Z

Hi @anpint , the approved breaking change is in swagger level, and still need to have SDK breaking review.

Adding @ArcturusZhang , @qiaozha , @msyyc for SDK breaking change. Thanks.

@changlong-liu What is "SDK breaking review"? I don't see it documented anywhere in the breaking change review process.

changlong-liu · 2022-02-05T01:12:30Z

Hi @anpint, it's about the breaking change on the released SDKs: https://github.com/Azure/azure-rest-api-specs/pull/17159/checks?check_run_id=4976024637

anpint · 2022-02-05T01:29:51Z

Hi @anpint, it's about the breaking change on the released SDKs: https://github.com/Azure/azure-rest-api-specs/pull/17159/checks?check_run_id=4976024637

@changlong-liu I already followed the documented breaking change process which included filing an item and it included sections for the necessary SDK changes. I received approval from breaking change office hours to make the changes. This is the first time that I'm hearing of a separate SDK breaking change review process and it's not documented anywhere.
Scenario 12981796: Breaking change review for Microsoft.StorageSync, API Versions 2020-03-01 and 2020-09-01

changlong-liu · 2022-02-05T04:18:07Z

Hi @anpint , there is SDK breaking approval requirement in the main diagram of below page:
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review

anpint · 2022-02-07T18:48:26Z

Hi @anpint , there is SDK breaking approval requirement in the main diagram of below page: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review

@changlong-liu thanks for sharing that. I didn't know it existed. The diagram is very helpful. I guess I will wait for the SDK breaking change review.

changlong-liu · 2022-02-08T04:26:06Z

Hi, @ArcturusZhang , @qiaozha , @msyyc, would you please review the SDK breaking change on Go/JS/Python. Thanks.

… 2020-09-01 API versions to fix swagger correctness issues. (#2201) Create to sync Azure/azure-rest-api-specs#17159 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/storagesync?expand=1)

…ing defaults in put server endpoint properties, add missing property supportedAggregationTypes (Azure#17159)

Update 2020-09-01 resource contracts to support system data, add miss…

a917c08

…ing defaults in put server endpoint properties, add missing property supportedAggregationTypes

openapi-workflow-bot bot added the FixS360 label Dec 21, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired labels Dec 21, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Dec 21, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Dec 21, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 24, 2022

anpint marked this pull request as ready for review January 24, 2022 18:50

anpint requested a review from ankushbindlish2 as a code owner January 24, 2022 18:50

openapi-assignment-bot bot assigned changlong-liu Jan 24, 2022

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Jan 28, 2022

qiaozha added the Approved-SdkBreakingChange-JavaScript label Feb 10, 2022

msyyc added the Approved-SdkBreakingChange-Python label Feb 10, 2022

ArcturusZhang added the Approved-SdkBreakingChange-Go-V2 label Feb 10, 2022

ArcturusZhang approved these changes Feb 10, 2022

View reviewed changes

ArcturusZhang merged commit 4c50e69 into Azure:main Feb 10, 2022

anpint mentioned this pull request Mar 5, 2022

[Microsoft.StorageSync] Update .NET SDK to 7.0.0 to address swagger correctness changes Azure/azure-sdk-for-net#27271

Merged

anpint deleted the storagesync-fixS360 branch February 7, 2023 22:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Microsoft.StorageSync] Update 2020-03-01 and 2020-09-01 API versions to fix swagger correctness issues. #17159

[Microsoft.StorageSync] Update 2020-03-01 and 2020-09-01 API versions to fix swagger correctness issues. #17159

anpint commented Dec 21, 2021 •

edited

Loading

openapi-workflow-bot bot commented Dec 21, 2021

openapi-workflow-bot bot commented Dec 21, 2021

openapi-pipeline-app bot commented Dec 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Dec 21, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Dec 21, 2021

openapi-workflow-bot bot commented Dec 21, 2021

changlong-liu commented Jan 28, 2022

azure-pipelines bot commented Jan 28, 2022

anpint commented Jan 31, 2022

changlong-liu commented Feb 1, 2022

anpint commented Feb 3, 2022

changlong-liu commented Feb 5, 2022

anpint commented Feb 5, 2022 •

edited

Loading

changlong-liu commented Feb 5, 2022

anpint commented Feb 7, 2022

changlong-liu commented Feb 8, 2022

[Microsoft.StorageSync] Update 2020-03-01 and 2020-09-01 API versions to fix swagger correctness issues. #17159

[Microsoft.StorageSync] Update 2020-03-01 and 2020-09-01 API versions to fix swagger correctness issues. #17159

Conversation

anpint commented Dec 21, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Dec 21, 2021

openapi-workflow-bot bot commented Dec 21, 2021

openapi-pipeline-app bot commented Dec 21, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Dec 21, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Dec 21, 2021

openapi-workflow-bot bot commented Dec 21, 2021

changlong-liu commented Jan 28, 2022

azure-pipelines bot commented Jan 28, 2022

anpint commented Jan 31, 2022

changlong-liu commented Feb 1, 2022

anpint commented Feb 3, 2022

changlong-liu commented Feb 5, 2022

anpint commented Feb 5, 2022 • edited Loading

changlong-liu commented Feb 5, 2022

anpint commented Feb 7, 2022

changlong-liu commented Feb 8, 2022

anpint commented Dec 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Dec 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Dec 21, 2021 •

edited

Loading

anpint commented Feb 5, 2022 •

edited

Loading