fixes for s360 errors under a new api version #17190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @vasundhraManhas Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi, @vasundhraManhas your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi @vasundhraManhas, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Dec 30, 2021
|
Please publish this PR (take it out of draft mode) when its ready and @ me for an ARM API review |
pilor
added
the
ARMChangesRequested
|
@vasundhraManhas your PR contains cross version breaking change https://github.com/Azure/azure-rest-api-specs/pull/17190/checks?check_run_id=4666962430 and need do breaking change review. |
@zhenglaizhang a) for the 1005-RemovedPath error, we have removed the mentioned operations API from datamigration.json (which was the latest stable swagger) but we have added this path in the sqlmigration.json (the new preview version) and we will make changes so that operations api request always goes to the new endpoint and returns both the old and new operations. Since we are keeping both datamigration.json and sqlmigration.json in the 2022-01-30-preview folder, will that be fine or is it still a breaking change problem? b) for the 1006-RemovedDefinition error, there is no information being provided regarding the error . clicking on the provided links opens a page not found tab . Any suggestions here? c) for the 1007-RemovedClientParameter error, again the referred parameter was removed from datamigration.json but it is there in sqlmigration.json and datamigration.json is referring to this parameter from sqlmigration.json (something like this : "$ref": "./sqlmigration.json#/parameters/SubscriptionIdParameter" ) . So, should this be fine too ? We had these exact same issues in our previous PR (for 2021-10-30-preview version) and they got a pass without the breaking change review process. Here's the PR: https://github.com/Azure/azure-rest-api-specs/pull/16032/checks?check_run_id=4555175737 |
@pilor Hi, the PR is ready for review |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @vasundhraManhas. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jianyexi
added
the
Approved-BreakingChange
jianyexi
approved these changes
Mar 10, 2022
This was referenced Mar 10, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Mar 10, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* fixes for s360 errors under a new api version * updating version in v1 swagger * updating readme for 2022-01-30-preview version * suppress secret property and add directives * suppressing R4016 and R4017 * prettier check * adding systemData property * adding schema for azureAuthenticationInfo * Revert "adding systemData property" This reverts commit a0e3ede. * nit error * API description changes * adding get examples with expand parameter * prettier check * using the newly added get examples (with expand parameter) * nit * prettier check * Solving new s360 error of invalid type in dictonary * resolving OBJECT_ADDITIONAL_PROPERTIES type of errors by adding the missing properties * Resolving ENUM_MISMATCH and OBJECT_MISSING_REQUIRED_PROPERTY errors * nit: adding missing discriminator * reverting changes made to MiSqlConnectionInfo * fixing more s360 errors * fixing s360 correctness issues * adding $expand parameter in examples of get MI expanded and get VM expanded Co-authored-by: Vasundhra Manhas <vmanhas@microsoft.com> Co-authored-by: Thakur Ashutosh Suman <tsuman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.