Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyVault: Add OKP/EdDSA support to version 7.3-preview #17251

Merged
merged 1 commit into from
Jan 6, 2022
Merged

KeyVault: Add OKP/EdDSA support to version 7.3-preview #17251

merged 1 commit into from
Jan 6, 2022

Conversation

docschmidt
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

The new feature is already deployed to public regions.

  1. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

Target date is the release of version 7.3

  1. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @docschmidt Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.KeyVault/preview/7.3-preview/rbac.json#L476
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.KeyVault/preview/7.3-preview/rbac.json#L518
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.KeyVault/preview/7.3-preview/rbac.json#L530
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'CreateCertificate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.KeyVault/preview/7.3-preview/certificates.json#L458
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2022 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @tjprescott
    Copy link
    Member

    @docschmidt I don't understand this response:

    Target date is the release of version 7.3

    When do you want this merged?

    @docschmidt
    Copy link
    Contributor Author

    docschmidt commented Jan 6, 2022 via email

    @tjprescott tjprescott merged commit d50e631 into Azure:main Jan 6, 2022
    @docschmidt docschmidt deleted the feature/keyvault/okp-eddsa branch January 7, 2022 00:06
    maorleger added a commit to maorleger/azure-rest-api-specs that referenced this pull request Jan 13, 2022
    @maorleger
    Revert "KeyVault: Add OKP/EdDSA support to version 7.3-preview (Azure…
    e4f551a 
    …#17251)"

This reverts commit d50e631.
    tjprescott pushed a commit that referenced this pull request Jan 18, 2022
    @maorleger
    Revert "KeyVault: Add OKP/EdDSA support to version 7.3-preview (#17251)…
    8a061f1 
    …" (#17331)

This reverts commit d50e631.
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    @maorleger @mstrisoline
    Revert "KeyVault: Add OKP/EdDSA support to version 7.3-preview (Azure…
    6f473a1 
    …#17251)" (Azure#17331)

This reverts commit d50e631.
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @docschmidt @LeiWang3
    KeyVault: Add OKP/EdDSA support to version 7.3-preview (Azure#17251)
    9eb0be9
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @maorleger @LeiWang3
    Revert "KeyVault: Add OKP/EdDSA support to version 7.3-preview (Azure…
    e6470d2 
    …#17251)" (Azure#17331)

This reverts commit d50e631.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jlichwa jlichwa jlichwa approved these changes

    @tjprescott tjprescott tjprescott approved these changes

    @heaths heaths Awaiting requested review from heaths heaths is a code owner

    @RandalliLama RandalliLama Awaiting requested review from RandalliLama

    Assignees

    @tjprescott tjprescott

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @docschmidt @tjprescott @jlichwa