New Azure Virtual Network Manager API Version #17311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jago2136 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
ghost
added
the
customer-reported
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Thank you for your contribution jago2136! We will review the pull request and get back to you soon. |
|
Hi, @jago2136 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Generation Artifacts
|
|
|
|
Hi @jago2136, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 11, 2022
|
@jago2136 , can you fix the CI check errors? |
|
Hi @raych1 thanks for taking a look! I was confused as to why the required LintDiff check was failing, because the error being thrown is unrelated to my changes. Would you be able to provide guidance on this issue? |
|
@raych1 also, for the ~[Staging] Swagger ModelValidation check, this error is incorrect. The required attribute that is says is not there, actually is. I had this confirmed as an error in the automated checks on a different PR. Thanks! |
jorgecotillo
added
ARMSignedOff
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
raych1
approved these changes
Jan 20, 2022
This was referenced Jan 20, 2022
mstrisoline
pushed a commit
to mstrisoline/azure-rest-api-specs
that referenced
this pull request
Feb 1, 2022
* add base api to new version folder for reviewer reference * add chenges for new api versiongit add . * adding changes for new api version * removing extra files left over from PR fix * fixing xmsIdentifierValidation errors * checks not running, changing text to retrigger * checks not running, changing text to retrigger * adding force delete and recursive delete parameters * add missing x-mx-paramter-location attributes, and fix warnings * adding force delete and recursive delete parameters * adding force delete and recursive delete parameters Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* add base api to new version folder for reviewer reference * add chenges for new api versiongit add . * adding changes for new api version * removing extra files left over from PR fix * fixing xmsIdentifierValidation errors * checks not running, changing text to retrigger * checks not running, changing text to retrigger * adding force delete and recursive delete parameters * add missing x-mx-paramter-location attributes, and fix warnings * adding force delete and recursive delete parameters * adding force delete and recursive delete parameters Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
February 2022
January 2022
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.