Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change x-ms-long-running-operation-options for QuotaRP 2021-03-15-preview #17454

Conversation

stephenbudhi-msft
Copy link
Contributor

@stephenbudhi-msft stephenbudhi-msft commented Jan 21, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 21, 2022

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]
The following errors/warnings exist before current PR submission:
Rule Message
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L580
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L617
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L660
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L697
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L933
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L1007
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L1145
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isQuotaApplicable
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L612
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isQuotaApplicable
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L692
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isQuotaApplicable
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L1136
⚠️ R4021 - DescriptionAndTitleMissing 'OperationList' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L489
⚠️ R4021 - DescriptionAndTitleMissing 'OperationResponse' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L504
⚠️ R4021 - DescriptionAndTitleMissing 'OperationDisplay' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L518
⚠️ R4021 - DescriptionAndTitleMissing 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L492
⚠️ R4021 - DescriptionAndTitleMissing 'name' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L507
⚠️ R4021 - DescriptionAndTitleMissing 'origin' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L513
⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Quotas_UsagesRequest_ForNetwork
Location: Microsoft.Quota/preview/2021-03-15-preview/quota.json#L143
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @sbudhi-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 21, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armquota - 0.3.0
    +	Function `*RequestOneResourceProperties.UnmarshalJSON` has been removed
    +	Function `CreateGenericQuotaRequestParameters.MarshalJSON` has been removed
    +	Function `LimitsResponse.MarshalJSON` has been removed
    +	Function `RequestOneResourceProperties.MarshalJSON` has been removed
    +	Function `ServiceError.MarshalJSON` has been removed
    +	Struct `CommonResourceProperties` has been removed
    +	Struct `CreateGenericQuotaRequestParameters` has been removed
    +	Struct `ExceptionResponse` has been removed
    +	Struct `LimitsResponse` has been removed
    +	Struct `RequestOneResourceProperties` has been removed
    +	Struct `RequestOneResourceSubmitResponse` has been removed
    +	Struct `RequestStatusDetails` has been removed
    +	Struct `RequestSubmitResponse202` has been removed
    +	Struct `RequestSubmitResponse` has been removed
    +	Struct `ServiceError` has been removed
    +	Type of `Properties.Properties` has been changed from `map[string]interface{}` to `interface{}`
    +	Type of `UsagesProperties.Properties` has been changed from `map[string]interface{}` to `interface{}`
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-quota - 1.0.0b2
    ️✔️azure-sdk-for-go - quota/mgmt/2021-03-15/quota - v61.3.0
    ️✔️azure-sdk-for-go - preview/quota/mgmt/2021-03-15-preview/quota - v61.3.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 679887a. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/quota/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Quota [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 679887a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.3.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-quota [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 679887a. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2022-01-26 02:27:31 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-quota;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2022-01-26 02:27:31 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2022-01-26 02:27:31 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/quota/azure-resourcemanager-quota --java.namespace=com.azure.resourcemanager.quota   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/quota/resource-manager/readme.md
      cmderr	[generate.py] 2022-01-26 02:27:55 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-quota
      cmderr	[generate.py] 2022-01-26 02:27:55 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2022-01-26 02:27:55 INFO [POM][Skip] pom already has module azure-resourcemanager-quota
      cmderr	[generate.py] 2022-01-26 02:27:55 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2022-01-26 02:27:55 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2022-01-26 02:27:55 INFO [POM][Skip] pom already has module sdk/quota
      cmderr	[generate.py] 2022-01-26 02:27:55 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-quota [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2022-01-26 02:28:55 DEBUG Got artifact_id: azure-resourcemanager-quota
      cmderr	[Inst] 2022-01-26 02:28:55 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2022-01-26 02:28:55 DEBUG Got artifact: azure-resourcemanager-quota-1.0.0-beta.3.jar
      cmderr	[Inst] 2022-01-26 02:28:55 DEBUG Match jar package: azure-resourcemanager-quota-1.0.0-beta.3.jar
      cmderr	[Inst] 2022-01-26 02:28:55 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17454/azure-sdk-for-java/azure-resourcemanager-quota/azure-resourcemanager-quota-1.0.0-beta.3.jar\" -o azure-resourcemanager-quota-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-quota -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-quota-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 679887a. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️quota/mgmt/2021-03-15/quota [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️preview/quota/mgmt/2021-03-15-preview/quota [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 679887a. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armquota [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `Properties.Properties` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Type of `UsagesProperties.Properties` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Function `ServiceError.MarshalJSON` has been removed
      info	[Changelog] - Function `LimitsResponse.MarshalJSON` has been removed
      info	[Changelog] - Function `RequestOneResourceProperties.MarshalJSON` has been removed
      info	[Changelog] - Function `*RequestOneResourceProperties.UnmarshalJSON` has been removed
      info	[Changelog] - Function `CreateGenericQuotaRequestParameters.MarshalJSON` has been removed
      info	[Changelog] - Struct `CommonResourceProperties` has been removed
      info	[Changelog] - Struct `CreateGenericQuotaRequestParameters` has been removed
      info	[Changelog] - Struct `ExceptionResponse` has been removed
      info	[Changelog] - Struct `LimitsResponse` has been removed
      info	[Changelog] - Struct `RequestOneResourceProperties` has been removed
      info	[Changelog] - Struct `RequestOneResourceSubmitResponse` has been removed
      info	[Changelog] - Struct `RequestStatusDetails` has been removed
      info	[Changelog] - Struct `RequestSubmitResponse` has been removed
      info	[Changelog] - Struct `RequestSubmitResponse202` has been removed
      info	[Changelog] - Struct `ServiceError` has been removed
      info	[Changelog]
      info	[Changelog] Total 27 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 679887a. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-quota [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 679887a. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️quota [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    Copy link
    Member

    @weidongxu-microsoft weidongxu-microsoft left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    final-state-via probably has no effect on PUT/PATCH (at least for some language), as original URL is the only option.

    Let me know when to merge.

    @weidongxu-microsoft weidongxu-microsoft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jan 23, 2022
    @stephenbudhi-msft
    Copy link
    Contributor Author

    final-state-via probably has no effect on PUT/PATCH (at least for some language), as original URL is the only option.

    Let me know when to merge.

    Thanks @weidongxu-microsoft. Yes, we are ok to merge

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates CI-BreakingChange-Go-V2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants