Fixing global parameters for siterecovery and resourcehealth #1753
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3130,25 +3130,23 @@ | |
| "in": "query", | ||
| "description": "The version of the API. This is a required parameter and it's value must be \"2016-09-01\".", | ||
| "required": true, | ||
| "type": "string" | ||
|
There was a problem hiding this comment. @samedder - Can you please take a look at changes I made in the service fabric resource-manager spec.
There was a problem hiding this comment. @chingchenmsft needs to sign off on this. I believe this may break our clients so he should verify. There was a problem hiding this comment. Can you fix the description as well? "This is a required parameter and it's value must be "2016-09-01"." |
||
| }, | ||
| "applicationName": { | ||
| "name": "applicationName", | ||
| "in": "path", | ||
| "description": "The name of the application resource.", | ||
| "required": true, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "applicationTypeName": { | ||
| "name": "applicationTypeName", | ||
| "in": "path", | ||
| "description": "The name of the application type name resource", | ||
| "required": true, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "clusterNameParameter": { | ||
| "name": "clusterName", | ||
|
|
@@ -3199,7 +3197,8 @@ | |
| "in": "path", | ||
| "description": "The name of the service resource in the format of {applicationName}~{serviceName}.", | ||
| "required": true, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "subscriptionId": { | ||
| "name": "subscriptionId", | ||
|
|
@@ -3213,7 +3212,8 @@ | |
| "in": "path", | ||
| "description": "The application type version.", | ||
| "required": true, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "clusterBodyParam": { | ||
| "name": "Cluster", | ||
|
|
@@ -3222,7 +3222,8 @@ | |
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/Cluster" | ||
| }, | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "clusterUpdateParameterBody": { | ||
| "name": "ClusterUpdateParameters", | ||
|
|
@@ -3231,7 +3232,8 @@ | |
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/ClusterUpdateParameters" | ||
| }, | ||
| "x-ms-parameter-location": "method" | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what issue was not having this causing? what's the breaking change on generated code due to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new SiteRecoveryManagementClient(credentials, subscriptionId, resourceGroupName, resourceName);This makes the client require resourceGroupName and resourceName in the client constructor. Both of these become client properties and that is incorrect. I had filed an issue in the linter repo about this. If it is management-plane swagger then the linter should warn if it sees anything else apart from subscriptionId and apiVersion and does not have x-ms-parameter-location set to method. Azure/azure-openapi-validator#84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As responded over the mail thread:
As per our scenarios, customers are more likely to work in the context of a single ResourceName, so, It makes more sense to have ResourceGroupName and ResourceName in global parameters section for recoveryservicessiterecovery specification. For more context we have:
Moreover, any change as suggested in the thread would be a breaking change for our existing clients like PowerShell and Ibiza (requires passing ResourceGroupName and ResourceName explicitly as input to every call rather than just once at sdk client initialization) as I can understand, which we would not be able to take at this point.
Let us know if we are missing some point to understand here.
Thanks,
Avneesh