Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing new API version 2022-01-01 for Azure Site Recovery Service #17531

Merged
merged 7 commits into from
Mar 11, 2022

Conversation

singhabh27
Copy link
Contributor

@singhabh27 singhabh27 commented Jan 27, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @singhabh27 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 27, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L7977
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L7984
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L8142
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L8149
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L8336
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L8343
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L8966
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L8973
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L8980
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L9031
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L9203
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L9210
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L9322
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L9361
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L9368
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L9539
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L9824
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L9924
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L10069
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L10162
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L10238
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L10361
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L10439
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L10553
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L10560
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L10845
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L11050
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L11361
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L11489
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-01-01/service.json#L11592
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 27, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-recoveryservicessiterecovery - 1.0.0b1
    azure-sdk-for-go-track2 - armrecoveryservicessiterecovery - 0.3.0
    +	Function `*EventQueryParameter.UnmarshalJSON` has been removed
    +	Function `EventQueryParameter.MarshalJSON` has been removed
    +	Struct `ApplianceQueryParameter` has been removed
    +	Struct `EventQueryParameter` has been removed
    +	Struct `FabricQueryParameter` has been removed
    +	Struct `MigrationItemsQueryParameter` has been removed
    +	Struct `ProtectableItemQueryParameter` has been removed
    +	Struct `ProtectedItemsQueryParameter` has been removed
    +	Struct `RoleAssignment` has been removed
    +	Type of `OperationsDiscovery.Properties` has been changed from `map[string]interface{}` to `interface{}`
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2022-01-01/siterecovery - v61.4.0
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2021-12-01/siterecovery - v61.4.0
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2021-11-01/siterecovery - v61.4.0
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2021-10-01/siterecovery - v61.4.0
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2021-08-01/siterecovery - v61.4.0
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2021-06-01/siterecovery - v61.4.0
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2021-02-10/siterecovery - v61.4.0
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2018-07-10/siterecovery - v61.4.0
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2018-01-10/siterecovery - v61.4.0
    ️✔️azure-sdk-for-go - recoveryservices/mgmt/2016-08-10/siterecovery - v61.4.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2c66a68. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/recoveryservicessiterecovery/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.RecoveryServices.SiteRecovery [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2c66a68. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.4` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-recoveryservicessiterecovery [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation ReplicationProtectedItemsOperations.begin_switch_provider
      info	[Changelog]   - Added operation group ReplicationAppliancesOperations
      info	[Changelog]   - Model A2AContainerMappingInput has a new parameter automation_account_authentication_type
      info	[Changelog]   - Model A2ACreateProtectionIntentInput has a new parameter agent_auto_update_status
      info	[Changelog]   - Model A2ACreateProtectionIntentInput has a new parameter automation_account_arm_id
      info	[Changelog]   - Model A2ACreateProtectionIntentInput has a new parameter automation_account_authentication_type
      info	[Changelog]   - Model A2AEnableProtectionInput has a new parameter recovery_capacity_reservation_group_id
      info	[Changelog]   - Model A2AEnableProtectionInput has a new parameter recovery_extended_location
      info	[Changelog]   - Model A2AProtectionContainerMappingDetails has a new parameter automation_account_authentication_type
      info	[Changelog]   - Model A2AReplicationDetails has a new parameter initial_primary_extended_location
      info	[Changelog]   - Model A2AReplicationDetails has a new parameter initial_recovery_extended_location
      info	[Changelog]   - Model A2AReplicationDetails has a new parameter primary_extended_location
      info	[Changelog]   - Model A2AReplicationDetails has a new parameter recovery_capacity_reservation_group_id
      info	[Changelog]   - Model A2AReplicationDetails has a new parameter recovery_extended_location
      info	[Changelog]   - Model A2AReplicationIntentDetails has a new parameter agent_auto_update_status
      info	[Changelog]   - Model A2AReplicationIntentDetails has a new parameter automation_account_arm_id
      info	[Changelog]   - Model A2AReplicationIntentDetails has a new parameter automation_account_authentication_type
      info	[Changelog]   - Model A2ASwitchProtectionInput has a new parameter recovery_capacity_reservation_group_id
      info	[Changelog]   - Model A2AUpdateContainerMappingInput has a new parameter automation_account_authentication_type
      info	[Changelog]   - Model A2AUpdateReplicationProtectedItemInput has a new parameter recovery_capacity_reservation_group_id
      info	[Changelog]   - Model HyperVVirtualMachineDetails has a new parameter hyper_v_host_id
      info	[Changelog]   - Model InMageAzureV2ProtectedDiskDetails has a new parameter seconds_to_take_switch_provider
      info	[Changelog]   - Model InMageAzureV2ReplicationDetails has a new parameter switch_provider_blocking_error_details
      info	[Changelog]   - Model InMageAzureV2ReplicationDetails has a new parameter switch_provider_details
      info	[Changelog]   - Model RecoveryPlanA2AInput has a new parameter primary_extended_location
      info	[Changelog]   - Model RecoveryPlanA2AInput has a new parameter recovery_extended_location
      info	[Changelog]   - Model ReplicationProtectedItemProperties has a new parameter switch_provider_state
      info	[Changelog]   - Model ReplicationProtectedItemProperties has a new parameter switch_provider_state_description
      info	[Changelog]   - Model VMwareCbtEnableMigrationInput has a new parameter test_network_id
      info	[Changelog]   - Model VMwareCbtEnableMigrationInput has a new parameter test_subnet_name
      info	[Changelog]   - Model VMwareCbtNicDetails has a new parameter test_ip_address
      info	[Changelog]   - Model VMwareCbtNicDetails has a new parameter test_ip_address_type
      info	[Changelog]   - Model VMwareCbtNicDetails has a new parameter test_network_id
      info	[Changelog]   - Model VMwareCbtNicDetails has a new parameter test_subnet_name
      info	[Changelog]   - Model VMwareCbtNicInput has a new parameter test_static_ip_address
      info	[Changelog]   - Model VMwareCbtNicInput has a new parameter test_subnet_name
      info	[Changelog]   - Model VMwareCbtTestMigrateInput has a new parameter vm_nics
      info	[Changelog]   - Model VMwareCbtUpdateMigrationItemInput has a new parameter test_network_id
      info	[Changelog]   - Model VMwareDetails has a new parameter switch_provider_blocking_error_details
      info	[Changelog]   - Model VmmVirtualMachineDetails has a new parameter hyper_v_host_id
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2c66a68. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️recoveryservices/mgmt/2022-01-01/siterecovery [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️recoveryservices/mgmt/2021-12-01/siterecovery [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️recoveryservices/mgmt/2021-11-01/siterecovery [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️recoveryservices/mgmt/2021-10-01/siterecovery [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️recoveryservices/mgmt/2021-08-01/siterecovery [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️recoveryservices/mgmt/2021-06-01/siterecovery [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️recoveryservices/mgmt/2021-02-10/siterecovery [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️recoveryservices/mgmt/2018-07-10/siterecovery [View full logs
      Only show 12 items here, please refer to log for details.
      info	[Changelog] - New function `ExistingRecoveryVirtualNetwork.AsNewRecoveryVirtualNetwork() (*NewRecoveryVirtualNetwork, bool)`
      info	[Changelog] - New function `NewRecoveryVirtualNetwork.AsNewRecoveryVirtualNetwork() (*NewRecoveryVirtualNetwork, bool)`
      info	[Changelog] - New function `NewRecoveryVirtualNetwork.AsRecoveryVirtualNetworkCustomDetails() (*RecoveryVirtualNetworkCustomDetails, bool)`
      info	[Changelog] - New function `NewRecoveryVirtualNetwork.AsBasicRecoveryVirtualNetworkCustomDetails() (BasicRecoveryVirtualNetworkCustomDetails, bool)`
      info	[Changelog] - New function `RecoveryVirtualNetworkCustomDetails.AsNewRecoveryVirtualNetwork() (*NewRecoveryVirtualNetwork, bool)`
      info	[Changelog] - New struct `NewRecoveryVirtualNetwork`
      info	[Changelog] - New field `TargetAvailabilitySetID` in struct `HyperVReplicaAzureEnableProtectionInput`
      info	[Changelog] - New field `TargetVMSize` in struct `HyperVReplicaAzureEnableProtectionInput`
      info	[Changelog] - New field `TargetAvailabilitySetID` in struct `InMageAzureV2EnableProtectionInput`
      info	[Changelog] - New field `TargetVMSize` in struct `InMageAzureV2EnableProtectionInput`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 13 additive change(s).
    • ️✔️recoveryservices/mgmt/2018-01-10/siterecovery [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️recoveryservices/mgmt/2016-08-10/siterecovery [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2c66a68. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armrecoveryservicessiterecovery [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `OperationsDiscovery.Properties` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Function `EventQueryParameter.MarshalJSON` has been removed
      info	[Changelog] - Function `*EventQueryParameter.UnmarshalJSON` has been removed
      info	[Changelog] - Struct `ApplianceQueryParameter` has been removed
      info	[Changelog] - Struct `EventQueryParameter` has been removed
      info	[Changelog] - Struct `FabricQueryParameter` has been removed
      info	[Changelog] - Struct `MigrationItemsQueryParameter` has been removed
      info	[Changelog] - Struct `ProtectableItemQueryParameter` has been removed
      info	[Changelog] - Struct `ProtectedItemsQueryParameter` has been removed
      info	[Changelog] - Struct `RoleAssignment` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `TestSubnetName` in struct `VMwareCbtNicInput`
      info	[Changelog] - New field `TestStaticIPAddress` in struct `VMwareCbtNicInput`
      info	[Changelog] - New field `TestNetworkID` in struct `VMwareCbtEnableMigrationInput`
      info	[Changelog] - New field `TestSubnetName` in struct `VMwareCbtEnableMigrationInput`
      info	[Changelog] - New field `TestNetworkID` in struct `VMwareCbtUpdateMigrationItemInput`
      info	[Changelog] - New field `VMNics` in struct `VMwareCbtTestMigrateInput`
      info	[Changelog] - New field `TestSubnetName` in struct `VMwareCbtNicDetails`
      info	[Changelog] - New field `TestNetworkID` in struct `VMwareCbtNicDetails`
      info	[Changelog] - New field `TestIPAddress` in struct `VMwareCbtNicDetails`
      info	[Changelog] - New field `TestIPAddressType` in struct `VMwareCbtNicDetails`
      info	[Changelog]
      info	[Changelog] Total 17 breaking change(s), 5 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2c66a68. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-recoveryservices-siterecovery [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testIPAddress
      info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testIPAddressType
      info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testNetworkId
      info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testSubnetName
      info	[Changelog]   - Interface VMwareCbtNicInput has a new optional parameter testStaticIPAddress
      info	[Changelog]   - Interface VMwareCbtNicInput has a new optional parameter testSubnetName
      info	[Changelog]   - Type Alias VMwareCbtEnableMigrationInput has a new parameter testNetworkId
      info	[Changelog]   - Type Alias VMwareCbtEnableMigrationInput has a new parameter testSubnetName
      info	[Changelog]   - Type Alias VMwareCbtTestMigrateInput has a new parameter vmNics
      info	[Changelog]   - Type Alias VMwareCbtUpdateMigrationItemInput has a new parameter testNetworkId
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2c66a68. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️recoveryservicessiterecovery [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot
    Copy link

    Hi @singhabh27, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @prsadhu-ms-idc prsadhu-ms-idc added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 28, 2022
    @singhabh27 singhabh27 marked this pull request as ready for review January 28, 2022 05:28
    @jianyexi jianyexi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2022
    @raosuhas
    Copy link

    raosuhas commented Feb 4, 2022

    "VMwareCbtTestMigrateInput": {
    

    Is this object used anywhere ? I cant see to find any reference to this one. Please remove if not used


    Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-01-01/service.json:23986 in 5804a17. [](commit_id = 5804a17, deletion_comment = False)

    Copy link

    @raosuhas raosuhas left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @raosuhas raosuhas added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 4, 2022
    @singhabh27
    Copy link
    Contributor Author

    VMwareCbtTestMigrateInput is passed as input during test failover.

    @ghost
    Copy link

    ghost commented Feb 27, 2022

    Hi, @singhabh27. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Feb 27, 2022
    @ruowan ruowan merged commit 2c66a68 into Azure:main Mar 11, 2022
    This was referenced Mar 11, 2022
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Mar 11, 2022
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022
    Azure#17531)
    
    * Initial commit with 2021-12-01 version
    
    * New API version 2022-01-01 for Azure Site Recovery
    
    * Add Readme changes
    
    * Prettier Check fixed
    
    * azure-sdk-for-go check fix
    
    * Lintdiff error fixed for my changes
    
    * Prettier Check fixed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 CI-FixRequiredOnFailure DoNotMerge <valid label in PR review process> use to hold merge after approval
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants