Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding xms-ids for AppConfiguration #17587

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Adding xms-ids for AppConfiguration #17587

merged 4 commits into from
Feb 9, 2022

Conversation

agalerrotaru
Copy link
Contributor

@agalerrotaru agalerrotaru commented Feb 1, 2022 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @agalerrotaru Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/ListKeys'
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L365
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/RegenerateKey'
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L417
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L47
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L96
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L141
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L196
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L243
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L299
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L348
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L400
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L454
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L494
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L544
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L586
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L638
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L700
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L751
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L794
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L846
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L559
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'KeyValues_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L868
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L606
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'KeyValues_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L915
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ConfigurationStores_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L114
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L604
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ConfigurationStores_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L154
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L651
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ConfigurationStores_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L257
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.AppConfiguration/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L468
    ❌ R4037 - MissingTypeObject The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1898
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go-track2 - armappconfiguration - 0.3.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-appconfiguration - 2.0.0
    ️✔️azure-sdk-for-go - appconfiguration/mgmt/2020-06-01/appconfiguration - v61.4.0
    ️✔️azure-sdk-for-go - appconfiguration/mgmt/2019-10-01/appconfiguration - v61.4.0
    ️✔️azure-sdk-for-go - preview/appconfiguration/mgmt/2021-03-01-preview/appconfiguration - v61.4.0
    ️✔️azure-sdk-for-go - preview/appconfiguration/mgmt/2020-07-01-preview/appconfiguration - v61.4.0
    ️✔️azure-sdk-for-go - preview/appconfiguration/mgmt/2019-11-01-preview/appconfiguration - v61.4.0
    ️✔️azure-sdk-for-go - preview/appconfiguration/mgmt/2019-02-01-preview/appconfiguration - v61.4.0
    ️❌ azure-powershell failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 1ada19d. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
the given reference name 'refs/heads/sdkAuto/Az.' is not valid
Error: the given reference name 'refs/heads/sdkAuto/Az.' is not valid
    • ⚠️Az.        [View full logs]       
      error	Fatal error: the given reference name 'refs/heads/sdkAuto/Az.' is not valid
error	The following packages are still pending:
error		Az.
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 1ada19d. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-appconfiguration        [View full logs]         [Release SDK Changes]      
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ConfigurationStoresOperations.begin_purge_deleted
info	[Changelog]   - Added operation ConfigurationStoresOperations.get_deleted
info	[Changelog]   - Added operation ConfigurationStoresOperations.list_deleted
info	[Changelog]   - Added operation Operations.regional_check_name_availability
info	[Changelog]   - Model ConfigurationStore has a new parameter create_mode
info	[Changelog]   - Model ConfigurationStore has a new parameter enable_purge_protection
info	[Changelog]   - Model ConfigurationStore has a new parameter soft_delete_retention_in_days
    ️❌ azure-sdk-for-net-track2 failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 1ada19d. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Automation-Sdk-Generate.ps1] �[91mWrite-Error: �[91mError occurred while generating code for Azure.ResourceManager.AppConfiguration
cmderr	[Automation-Sdk-Generate.ps1] �[0m
    • ❌Azure.ResourceManager.AppConfiguration        [View full logs]         [Release SDK Changes]      
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 1ada19d. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-09 06:55:41 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-appconfiguration;1.0.0-beta.3;1.0.0-beta.4"
cmderr	[generate.py] 2022-02-09 06:55:41 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.4"
cmderr	[generate.py] 2022-02-09 06:55:41 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/appconfiguration/azure-resourcemanager-appconfiguration --java.namespace=com.azure.resourcemanager.appconfiguration   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/appconfiguration/resource-manager/readme.md
cmderr	[generate.py] 2022-02-09 06:56:07 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-appconfiguration
cmderr	[generate.py] 2022-02-09 06:56:07 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-09 06:56:07 INFO [POM][Skip] pom already has module azure-resourcemanager-appconfiguration
cmderr	[generate.py] 2022-02-09 06:56:07 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-09 06:56:07 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-09 06:56:07 INFO [POM][Skip] pom already has module sdk/appconfiguration
cmderr	[generate.py] 2022-02-09 06:56:07 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-appconfiguration        [View full logs]         [Release SDK Changes]      
      cmderr	[Inst] 2022-02-09 06:57:58 DEBUG Got artifact_id: azure-resourcemanager-appconfiguration
cmderr	[Inst] 2022-02-09 06:57:58 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-09 06:57:58 DEBUG Got artifact: azure-resourcemanager-appconfiguration-1.0.0-beta.4-sources.jar
cmderr	[Inst] 2022-02-09 06:57:58 DEBUG Got artifact: azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar
cmderr	[Inst] 2022-02-09 06:57:58 DEBUG Match jar package: azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar
cmderr	[Inst] 2022-02-09 06:57:58 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17587/azure-sdk-for-java/azure-resourcemanager-appconfiguration/azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar\" -o azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-appconfiguration -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️❌ azure-sdk-for-net failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 1ada19d. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/appconfiguration/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json:1911:8 ($.definitions.ErrorDetails.properties.additionalInfo)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json:1797:8 ($.definitions.MetricSpecification.properties.dimensions)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json:1738:8 ($.definitions.ServiceSpecification.properties.metricSpecifications)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json:1727:8 ($.definitions.ServiceSpecification.properties.logSpecifications)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json:1648:8 ($.definitions.OperationDefinitionListResult.properties.value)
cmderr	[Autorest] FATAL: swagger-document/individual/schema-validator - FAILED
cmderr	[Autorest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
cmderr	[Autorest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 1ada19d. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-appconfiguration        [View full logs]         [Release SDK Changes]      
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 1ada19d. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️appconfiguration/mgmt/2020-06-01/appconfiguration        [View full logs]         [Release SDK Changes]      
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️appconfiguration/mgmt/2019-10-01/appconfiguration        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/appconfiguration/mgmt/2021-03-01-preview/appconfiguration        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/appconfiguration/mgmt/2020-07-01-preview/appconfiguration        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/appconfiguration/mgmt/2019-11-01-preview/appconfiguration        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/appconfiguration/mgmt/2019-02-01-preview/appconfiguration        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 1ada19d. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armappconfiguration        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ErrorDetails.MarshalJSON` has been removed
info	[Changelog] - Struct `ErrorAdditionalInfo` has been removed
info	[Changelog] - Struct `ErrorDetails` has been removed
info	[Changelog] - Struct `ErrorResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `CreateModeDefault`
info	[Changelog] - New const `CreateModeRecover`
info	[Changelog] - New function `*ConfigurationStoresClient.ListDeleted(*ConfigurationStoresClientListDeletedOptions) *ConfigurationStoresClientListDeletedPager`
info	[Changelog] - New function `DeletedConfigurationStoreListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `CreateMode.ToPtr() *CreateMode`
info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPoller.Done() bool`
info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPoller.ResumeToken() (string, error)`
info	[Changelog] - New function `*ConfigurationStoresClient.GetDeleted(context.Context, string, string, *ConfigurationStoresClientGetDeletedOptions) (ConfigurationStoresClientGetDeletedResponse, error)`
info	[Changelog] - New function `DeletedConfigurationStoreProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ConfigurationStoresClientListDeletedPager.PageResponse() ConfigurationStoresClientListDeletedResponse`
info	[Changelog] - New function `*ConfigurationStoresClientListDeletedPager.NextPage(context.Context) bool`
info	[Changelog] - New function `ConfigurationStoresClientPurgeDeletedPollerResponse.PollUntilDone(context.Context, time.Duration) (ConfigurationStoresClientPurgeDeletedResponse, error)`
info	[Changelog] - New function `PossibleCreateModeValues() []CreateMode`
info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPollerResponse.Resume(context.Context, *ConfigurationStoresClient, string) error`
info	[Changelog] - New function `*OperationsClient.RegionalCheckNameAvailability(context.Context, string, CheckNameAvailabilityParameters, *OperationsClientRegionalCheckNameAvailabilityOptions) (OperationsClientRegionalCheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `*DeletedConfigurationStoreProperties.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `*ConfigurationStoresClient.BeginPurgeDeleted(context.Context, string, string, *ConfigurationStoresClientBeginPurgeDeletedOptions) (ConfigurationStoresClientPurgeDeletedPollerResponse, error)`
info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPoller.FinalResponse(context.Context) (ConfigurationStoresClientPurgeDeletedResponse, error)`
info	[Changelog] - New function `*ConfigurationStoresClientListDeletedPager.Err() error`
info	[Changelog] - New struct `ConfigurationStoresClientBeginPurgeDeletedOptions`
info	[Changelog] - New struct `ConfigurationStoresClientGetDeletedOptions`
info	[Changelog] - New struct `ConfigurationStoresClientGetDeletedResponse`
info	[Changelog] - New struct `ConfigurationStoresClientGetDeletedResult`
info	[Changelog] - New struct `ConfigurationStoresClientListDeletedOptions`
info	[Changelog] - New struct `ConfigurationStoresClientListDeletedPager`
info	[Changelog] - New struct `ConfigurationStoresClientListDeletedResponse`
info	[Changelog] - New struct `ConfigurationStoresClientListDeletedResult`
info	[Changelog] - New struct `ConfigurationStoresClientPurgeDeletedPoller`
info	[Changelog] - New struct `ConfigurationStoresClientPurgeDeletedPollerResponse`
info	[Changelog] - New struct `ConfigurationStoresClientPurgeDeletedResponse`
info	[Changelog] - New struct `DeletedConfigurationStore`
info	[Changelog] - New struct `DeletedConfigurationStoreListResult`
info	[Changelog] - New struct `DeletedConfigurationStoreProperties`
info	[Changelog] - New struct `OperationsClientRegionalCheckNameAvailabilityOptions`
info	[Changelog] - New struct `OperationsClientRegionalCheckNameAvailabilityResponse`
info	[Changelog] - New struct `OperationsClientRegionalCheckNameAvailabilityResult`
info	[Changelog] - New field `EnablePurgeProtection` in struct `ConfigurationStoreProperties`
info	[Changelog] - New field `SoftDeleteRetentionInDays` in struct `ConfigurationStoreProperties`
info	[Changelog] - New field `CreateMode` in struct `ConfigurationStoreProperties`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 55 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 1ada19d. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️appconfiguration        [View full logs]       
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            
    
    
    
      
    
    
    
    

      

          @ghost
  ghost


          added
  the 

  customer-reported

  Issues that are reported by GitHub users external to the Azure organization.
 label


      Feb 1, 2022

    
    
  
    





    

      
    
  
      

    

  
    
  @ghost


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    
    
      

      
            ghost
  

      

      

      commented


        Feb 1, 2022


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Thank you for your contribution agalerrotaru! We will review the pull request and get back to you soon.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            


  
    
  
    
    
  
    

  
    
      
    
  This was referenced Feb 1, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Draft

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Draft

  
    

    



  
    

    




    

      
    
  
        



    

      
    
  
      

    

  
    
  @lirenhe


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  
    

  
    
    
    
      

      
            lirenhe
  

      

      

      commented


        Feb 8, 2022


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    /azp run
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @azure-pipelines


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
Azure Pipelines successfully started running 1 pipeline(s).
    
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @ArcturusZhang


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    /azp run
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @azure-pipelines


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
Azure Pipelines successfully started running 1 pipeline(s).
    
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @ArcturusZhang


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    /azp run
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @azure-pipelines


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
Azure Pipelines successfully started running 1 pipeline(s).
    
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @agalerrotaru


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
    Contributor


      

  Author


  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    @x9xu This PR intends to add xms identifiers as part of the future requirement by Swagger API https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers for all RPs. I see a breaking change in SDK tracking that is not related to my changes. Since you have been a contributor to appconfig specs, please review the breaking change and advise on what to do, so that I get unblocked. @lirenhe
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            

    
    

    
    
    
    
      
    
    
    
    

      

          @agalerrotaru
agalerrotaru




        reopened this

      Feb 9, 2022

    
    
  
    





    

      
    
  
        



    

      
    
  
          
    
  
    
    
  
    
  
    


        @lirenhe
  lirenhe



        merged commit 1ada19d
      into

      
  
    Azure:main
  


    Feb 9, 2022

  
    

    


    

  
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Feb 9, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    




    



        
    
  
          
    
  
    
    
  
    

  
    
      
    
  This was referenced Feb 9, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

  

    
  
    
  
  
    
    
  FredericHeem 

      pushed a commit
        to grucloud/azure-rest-api-specs
      that referenced
      this pull request

    
      Mar 7, 2022
    
    
    
      

    
  
    
    
    
      

    
  
    
      
        @agalerrotaru
      
        @FredericHeem
  
    

    


      
    
        
          Adding xms-ids for AppConfiguration (Azure#17587)
        

          
            
          

      
    

      
    
          

    
    
    

  

      
    

      
    
      
    

      
      
    
        
          f11cbeb
        
      
    
    
    
  
    
    
    
      
    * Adding xms-ids for AppConfiguration

* corrections after rebasing

* prettier fix
    
    
    

    

    
    
  
    

    

  
  
  
  



    



  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @lirenhe
  
    lirenhe



          
            
              
            
          
          lirenhe approved these changes

        
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
      @lirenhe
  
    lirenhe
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    CI-BreakingChange-Go-V2

  

    customer-reported

  Issues that are reported by GitHub users external to the Azure organization.


    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

          

    

  
      
    
  
    
    
    
      3 participants
    
    
    
    
        
          @agalerrotaru 
        
          @lirenhe 
        
          @ArcturusZhang