Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge conflict for Microsoft.ContainerService 2022-01-02-preview dev branch PR #17624

Conversation

FumingZhang
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Fix merge conflict for dev branch PR #17579.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @FumingZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️🔄SDK Track2 Validation inProgress [Detail]
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    Posted by Swagger Pipeline | How to fix these errors?

    @FumingZhang
    Copy link
    Member Author

    Hi @akning-ms, could you please help merge this PR? This should fix the merge conflict for PR #17579 .

    @akning-ms akning-ms merged commit 0cc76de into Azure:dev-containerservice-Microsoft.ContainerService-2022-01-02-preview Feb 7, 2022
    ruowan pushed a commit that referenced this pull request Feb 10, 2022
    …02-preview (#17579)
    
    * Adds base for updating Microsoft.ContainerService from version preview/2021-11-01-preview to version 2022-01-02-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add NetworkPlugin none option (#17393)
    
    * Update readme to help generate SDK (#17372)
    
    * update readme to help generate SDK
    
    * update readme
    
    * fix golang readme
    
    * fix tag
    
    * Add adminUsers in aadprofile (#17367)
    
    * Add  adminUsers in aadprofile
    
    * Update description
    
    * Support query parameter 'format' in listClusterUserCredential handler (#17211)
    
    * Support query parameter 'format' in listClusterUserCredential handler
    
    * Fix lint
    
    * Fix typo
    
    * Add property HostGroupID and its examples (#17459)
    
    * Add property HostGroupID and its examples
    
    * fix format issue
    
    * add more details for Dedicated host group
    
    Co-authored-by: Jianping Zeng <jizen@microsoft.com>
    
    * Revert "Add adminUsers in aadprofile (#17367)" (#17522)
    
    This reverts commit ba6e656.
    
    * fix conflict (#17624)
    
    Co-authored-by: Matt Stam <mattstam@live.com>
    Co-authored-by: Tongyao Si <tosi@microsoft.com>
    Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
    Co-authored-by: Jianping Zeng <jizen@microsoft.com>
    @FumingZhang FumingZhang deleted the fuming/fix-conflict-2022-01-02-preview branch February 17, 2022 06:36
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022
    …02-preview (Azure#17579)
    
    * Adds base for updating Microsoft.ContainerService from version preview/2021-11-01-preview to version 2022-01-02-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add NetworkPlugin none option (Azure#17393)
    
    * Update readme to help generate SDK (Azure#17372)
    
    * update readme to help generate SDK
    
    * update readme
    
    * fix golang readme
    
    * fix tag
    
    * Add adminUsers in aadprofile (Azure#17367)
    
    * Add  adminUsers in aadprofile
    
    * Update description
    
    * Support query parameter 'format' in listClusterUserCredential handler (Azure#17211)
    
    * Support query parameter 'format' in listClusterUserCredential handler
    
    * Fix lint
    
    * Fix typo
    
    * Add property HostGroupID and its examples (Azure#17459)
    
    * Add property HostGroupID and its examples
    
    * fix format issue
    
    * add more details for Dedicated host group
    
    Co-authored-by: Jianping Zeng <jizen@microsoft.com>
    
    * Revert "Add adminUsers in aadprofile (Azure#17367)" (Azure#17522)
    
    This reverts commit ba6e656.
    
    * fix conflict (Azure#17624)
    
    Co-authored-by: Matt Stam <mattstam@live.com>
    Co-authored-by: Tongyao Si <tosi@microsoft.com>
    Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
    Co-authored-by: Jianping Zeng <jizen@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants