Adding xms-ids for AppPlatform #17632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @agalerrotaru Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'Services_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L20 |
|
The response of operation:'ConfigServers_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L407 |
|
The response of operation:'MonitoringSettings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L628 |
|
The response of operation:'Apps_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L788 |
|
The response of operation:'Bindings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1110 |
|
The response of operation:'Certificates_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1395 |
|
The response of operation:'CustomDomains_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1655 |
|
The response of operation:'Deployments_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1994 |
|
The response of operation:'Services_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L60 |
|
The response of operation:'ConfigServers_UpdatePut' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L447 |
|
The response of operation:'MonitoringSettings_UpdatePut' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L668 |
|
The response of operation:'Apps_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L838 |
|
The response of operation:'Bindings_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1156 |
|
The response of operation:'Certificates_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1438 |
|
The response of operation:'CustomDomains_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1701 |
|
The response of operation:'Deployments_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L2040 |
|
The response of operation:'Services_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L172 |
|
The response of operation:'ConfigServers_UpdatePatch' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L506 |
|
The response of operation:'MonitoringSettings_UpdatePatch' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L727 |
|
The response of operation:'Apps_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L956 |
|
The response of operation:'Bindings_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1280 |
|
The response of operation:'CustomDomains_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1825 |
|
The response of operation:'Deployments_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L2164 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L148 |
|
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L4519 |
|
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L4529 |
| Per the Noun_Verb convention for Operation Ids, the noun 'RuntimeVersions' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L2677 |
|
| Since operation 'ConfigServers_Validate' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L572 |
|
| 'PUT' operation 'ConfigServers_UpdatePut' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L452 |
|
| 'PUT' operation 'MonitoringSettings_UpdatePut' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L673 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
…thub.com/agalerrotaru/azure-rest-api-specs into agalerrotaru/xms-ids-appplatform-rebased
agalerrotaru
changed the title
This was referenced Feb 2, 2022
Closed
|
@agalerrotaru , appPlatform is onboarded to shiftleft PR review pipeline. Please make swagger change in ADO repository then it will be synced to github. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17632 in repo Azure/azure-rest-api-specs |
yuwzho
reviewed
Feb 9, 2022
...cation/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/appplatform.json
Outdated
Show resolved
Hide resolved
|
@yuwzho Our service only uses the public api version - the stable specs. Also to get the places which require xms identifiers, we run the autorest command: 'autorest --validation --azure-validator --openapi-type=arm --use=@microsoft.azure/classic-openapi-validator@1.1.13 --use=@microsoft.azure/openapi-validator@1.12.1 "specification/appplatform/resource-manager/readme.md" > output.txt` . This will grab the files under the most recent tag of the stable version api. |
@agalerrotaru good to know that! |
|
Hi @agalerrotaru, Your PR has some issues. Please fix the CI sequentially by following the order of
|
yuwzho
approved these changes
Feb 10, 2022
raych1
approved these changes
Feb 11, 2022
This was referenced Feb 11, 2022
openapi-pipeline-app
bot
added
CI-BreakingChange-Go-V2
and removed
CI-BreakingChange-Go-V2
labels
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
* Adding xms-ids for AppPlatform * remove stale changes * remove prettier over fix * fixing semantic val errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.