Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal property under VnetConfiguration for internalOnly environments #17656

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Add internal property under VnetConfiguration for internalOnly environments #17656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcde3bb
Add internal property under VnetConfiguration for internalOnly enviro…
sanchitmehta Feb 3, 2022
b603fe1
Update examples
sanchitmehta Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...on/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,14 @@
"type": "object",
"description": "Configuration properties for apps environment to join a Virtual Network",
"properties": {
"internal": {
"type": "boolean",
"description": "Boolean indicating the environment only has an internal load balancer. These environments do not have a public static IP resource, must provide ControlPlaneSubnetResourceId and AppSubnetResourceId if enabling this property",
"x-ms-mutability": [
"create",
"read"
]
},
"infrastructureSubnetId": {
"type": "string",
"description": "Resource ID of a subnet for infrastructure components. This subnet must be in the same VNET as the subnet defined in runtimeSubnetId. Must not overlap with any other provided IP ranges.",
Expand Down Expand Up @@ -422,14 +430,6 @@
"type": "string",
"readOnly": true
},
"internalLoadBalancerEnabled": {
"description": "Only visible within Vnet/Subnet",
"type": "boolean",
"x-ms-mutability": [
"create",
"read"
]
},
"defaultDomain": {
"description": "Default Domain Name for the cluster",
"type": "string",
Expand Down
2 changes: 0 additions & 2 deletions ...Microsoft.App/preview/2022-01-01-preview/examples/ManagedEnvironments_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"internalLoadBalancerEnabled": false,
"defaultDomain": "testcontainerenv.k4apps.io",
"staticIp": "1.2.3.4",
"appLogsConfiguration": {
Expand All @@ -47,7 +46,6 @@
"properties": {
"provisioningState": "InitializationInProgress",
"deploymentErrors": null,
"internalLoadBalancerEnabled": false,
"defaultDomain": "testcontainerenv.k4apps.io",
"staticIp": "1.2.3.4",
"appLogsConfiguration": {
Expand Down
1 change: 0 additions & 1 deletion ...ce-manager/Microsoft.App/preview/2022-01-01-preview/examples/ManagedEnvironments_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"internalLoadBalancerEnabled": false,
"defaultDomain": "jlaw-demo1.k4apps.io",
"staticIp": "20.42.33.145"
}
Expand Down
2 changes: 0 additions & 2 deletions ...soft.App/preview/2022-01-01-preview/examples/ManagedEnvironments_ListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"internalLoadBalancerEnabled": false,
"defaultDomain": "jlaw-demo1.k4apps.io",
"staticIp": "20.42.33.145",
"appLogsConfiguration": null
Expand All @@ -32,7 +31,6 @@
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"internalLoadBalancerEnabled": false,
"defaultDomain": "demo1.k4apps.io",
"staticIp": "52.142.21.61",
"appLogsConfiguration": null
Expand Down
2 changes: 0 additions & 2 deletions ...osoft.App/preview/2022-01-01-preview/examples/ManagedEnvironments_ListBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"internalLoadBalancerEnabled": false,
"defaultDomain": "jlaw-demo1.k4apps.io",
"staticIp": "20.42.33.145",
"appLogsConfiguration": null
Expand All @@ -31,7 +30,6 @@
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"internalLoadBalancerEnabled": false,
"defaultDomain": "demo1.k4apps.io",
"staticIp": "52.142.21.61",
"appLogsConfiguration": null
Expand Down
1 change: 0 additions & 1 deletion ...-manager/Microsoft.App/preview/2022-01-01-preview/examples/ManagedEnvironments_Patch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"internalLoadBalancerEnabled": false,
"defaultDomain": "testcontainerenv.k4apps.io",
"staticIp": "1.2.3.4",
"appLogsConfiguration": {
Expand Down