Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev desktopvirtualization microsoft.desktop virtualization 2022 02 02 preview #17660

Closed
wants to merge 4 commits into from
Closed

Dev desktopvirtualization microsoft.desktop virtualization 2022 02 02 preview #17660

wants to merge 4 commits into from

Conversation

ryanosh
Copy link
Contributor

@ryanosh ryanosh commented Feb 3, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[X] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@ryanosh ryanosh requested a review from datr93 February 3, 2022 21:17
@openapi-workflow-bot
Copy link

Hi, @ryanosh Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 3, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'MsixImages_Expand' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L2125
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'PrivateEndpointConnections_UpdateByHostPool' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L2606
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'PrivateEndpointConnections_UpdateByWorkspace' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L2841
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3017
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByHostPool' Request Model: 'PrivateEndpointConnection' Response Model: 'PrivateEndpointConnectionWithSystemData'
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L2602
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByWorkspace' Request Model: 'PrivateEndpointConnection' Response Model: 'PrivateEndpointConnectionWithSystemData'
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L2837
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'expandmsiximage' in:'MsixImages_Expand'. Consider updating the operationId
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L2125
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'applications' with immediate parent 'ApplicationGroup', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3969
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'desktops' with immediate parent 'ApplicationGroup', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4202
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'sessionHosts' with immediate parent 'HostPool', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4487
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'msixPackages' with immediate parent 'HostPool', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3763
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'userSessions' with immediate parent 'SessionHost', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4861
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L1431
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L1750
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L1809
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L2252
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3013
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3107
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3269
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validationEnvironment
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3446
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startVMOnConnect
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3506
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3514
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validationEnvironment
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3608
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startVMOnConnect
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3659
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRegularRegistration
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3816
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isActive
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3821
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isActive
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3874
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRegularRegistration
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3878
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: showInPortal
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4069
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: showInPortal
    Location: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4165
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.DesktopVirtualization' for api version '2022-02-02-preview'. The supported api-versions are '2019-01-23-preview,
    2019-09-24-preview,
    2019-12-10-preview,
    2020-09-21-preview,
    2020-10-19-preview,
    2020-11-02-preview,
    2020-11-10-preview,
    2021-01-14-preview,
    2021-02-01-preview,
    2021-03-09-preview,
    2021-04-01-preview,
    2021-05-13-preview,
    2021-08-04-preview,
    2021-09-03-preview,
    2021-09-17-privatepreview,
    2021-07-12'."
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 29 Errors, 61 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L53:11
    ❌ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Personal, BYODesktop' from the old version.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4994:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4392:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5056:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4464:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5086:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4495:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5102:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4512:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5157:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4568:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4323:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3743:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4077:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3503:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4173:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3598:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3422:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2885:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3441:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2903:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3573:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3021:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L3603:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3050:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L4521:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3936:9
    ❌ 1024 - ConstraintIsStronger The new version has a more constraining 'minimum' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5079:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4488:9
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'hostPoolType' renamed or removed?
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5253:7
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4641:7
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'hour' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5182:7
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5182:7
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'hour, minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5056:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4464:9
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'hour, minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5086:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4495:9
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'hour, minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5102:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4512:9
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'hour, minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5157:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4568:9
    ❌ 1036 - ConstraintChanged The new version has a different 'minimum' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5079:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4488:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'maxLength' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L344:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L335:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'minimum' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5079:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4488:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'maxLength' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L384:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L375:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'maxLength' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L439:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L430:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'maxLength' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L479:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L470:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'maxLength' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L5527:5
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4851:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DesktopVirtualization/preview/2022-02-02-preview/desktopvirtualization.json#L49:13
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L49:13
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 3, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @ryanosh your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 3, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go-track2 - armdesktopvirtualization - 0.3.0
    +	Struct `CloudErrorProperties` has been removed
+	Struct `CloudError` has been removed
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-desktopvirtualization - 1.0.0b1
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-09-03-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-04-01-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-03-09-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-02-01-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization - v61.4.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization - v61.4.0
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 9cd1840a1c0903358d1dcffb6a0627dc31dd7433. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.DesktopVirtualizationApi [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 9cd1840a1c0903358d1dcffb6a0627dc31dd7433. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-desktopvirtualization [View full logs]  [Preview SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model SessionHost has a new parameter friendly_name
info	[Changelog]   - Model SessionHostPatch has a new parameter friendly_name
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 9cd1840a1c0903358d1dcffb6a0627dc31dd7433. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-03 21:24:08 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-desktopvirtualization;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2022-02-03 21:24:08 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2022-02-03 21:24:08 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/desktopvirtualization/azure-resourcemanager-desktopvirtualization --java.namespace=com.azure.resourcemanager.desktopvirtualization   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
cmderr	[generate.py] 2022-02-03 21:24:49 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-desktopvirtualization
cmderr	[generate.py] 2022-02-03 21:24:49 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-03 21:24:49 INFO [POM][Skip] pom already has module azure-resourcemanager-desktopvirtualization
cmderr	[generate.py] 2022-02-03 21:24:49 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-03 21:24:49 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-03 21:24:49 INFO [POM][Skip] pom already has module sdk/desktopvirtualization
cmderr	[generate.py] 2022-02-03 21:24:49 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-desktopvirtualization [View full logs]  [Preview SDK Changes] 
      cmderr	[Inst] 2022-02-03 21:26:52 DEBUG Got artifact_id: azure-resourcemanager-desktopvirtualization
cmderr	[Inst] 2022-02-03 21:26:52 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-03 21:26:52 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2022-02-03 21:26:52 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.2.jar
cmderr	[Inst] 2022-02-03 21:26:52 DEBUG Match jar package: azure-resourcemanager-desktopvirtualization-1.0.0-beta.2.jar
cmderr	[Inst] 2022-02-03 21:26:52 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17660/azure-sdk-for-java/azure-resourcemanager-desktopvirtualization/azure-resourcemanager-desktopvirtualization-1.0.0-beta.2.jar\" -o azure-resourcemanager-desktopvirtualization-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-desktopvirtualization -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-desktopvirtualization-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 9cd1840a1c0903358d1dcffb6a0627dc31dd7433. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/desktopvirtualization/mgmt/2021-09-03-preview/desktopvirtualization [View full logs]  [Preview SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/desktopvirtualization/mgmt/2021-04-01-preview/desktopvirtualization [View full logs]  
      info	[Changelog] This is a new package
info	[Changelog]
    • ️✔️preview/desktopvirtualization/mgmt/2021-03-09-preview/desktopvirtualization [View full logs]  
      info	[Changelog] This is a new package
info	[Changelog]
    • ️✔️preview/desktopvirtualization/mgmt/2021-02-01-preview/desktopvirtualization [View full logs]  
      info	[Changelog] This is a new package
info	[Changelog]
    • ️✔️preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization [View full logs]  
      info	[Changelog] This is a new package
info	[Changelog]
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization [View full logs]  
      info	[Changelog] This is a new package
info	[Changelog]
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 9cd1840a1c0903358d1dcffb6a0627dc31dd7433. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armdesktopvirtualization [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `CloudError` has been removed
info	[Changelog] - Struct `CloudErrorProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `FriendlyName` in struct `SessionHostProperties`
info	[Changelog] - New field `FriendlyName` in struct `SessionHostPatchProperties`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 2 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from 9cd1840a1c0903358d1dcffb6a0627dc31dd7433. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-desktopvirtualization [View full logs]  [Preview SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Type Alias SessionHost has a new parameter friendlyName
info	[Changelog]   - Type Alias SessionHostPatch has a new parameter friendlyName
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 9cd1840a1c0903358d1dcffb6a0627dc31dd7433. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️desktopvirtualization [View full logs]  [Preview Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Feb 3, 2022
    Draft
    Draft
    Draft
    Draft
    Draft
    @ryanosh ryanosh removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 4, 2022
    datr93
    datr93 approved these changes Feb 4, 2022
    View reviewed changes
    Copy link
    Contributor

    @datr93 datr93 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm

    @ghost
    Copy link

    ghost commented Feb 20, 2022

    Hi, @ryanosh. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Feb 20, 2022
    @ghost ghost closed this Mar 7, 2022
    @ghost
    Copy link

    ghost commented Mar 7, 2022

    Hi, @ryanosh. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    This pull request was closed.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @datr93 datr93 datr93 approved these changes

    Assignees

    @qiaozha qiaozha

    Labels
    CI-BreakingChange-Go-V2
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @ryanosh @datr93 @qiaozha