Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove x-ms-long-running-operation-options from MFE spec #17823

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Remove x-ms-long-running-operation-options from MFE spec #17823

merged 2 commits into from
Feb 15, 2022

Conversation

erjms
Copy link
Member

@erjms erjms commented Feb 11, 2022 •
edited
Loading

Removed from 2021-03-01-preview api version. Non-breaking change to fix autogenerated REST clients.

Context: AML services follow ARM guidelines when returning payloads after long-running operation polling terminates. They do not return payloads consistent with the x-ms-long-running-operation-options spec. This was not caught as an issue prior to this point because this property was not utilized by REST clients. However, that has changed, and so removing this property from the spec should resolve any issues those clients have with AML long-running operations.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    N/A
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    February 2022
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @erjms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 11, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L5965
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L6002
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L6926
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L7286
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L7667
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L7691
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L7699
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L8290
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L8392
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L9256
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L9349
    ❌ R2008 - MutabilityWithReadOnly When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L9373
    ❌ R4039 - ParametersOrder The parameters:endpointName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L71
    ❌ R4039 - ParametersOrder The parameters:endpointName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L121
    ❌ R4039 - ParametersOrder The parameters:endpointName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L171
    ❌ R4039 - ParametersOrder The parameters:endpointName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L234
    ❌ R4039 - ParametersOrder The parameters:endpointName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L305
    ❌ R4039 - ParametersOrder The parameters:endpointName,deploymentName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L376
    ❌ R4039 - ParametersOrder The parameters:endpointName,deploymentName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L433
    ❌ R4039 - ParametersOrder The parameters:endpointName,deploymentName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L490
    ❌ R4039 - ParametersOrder The parameters:endpointName,deploymentName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L561
    ❌ R4039 - ParametersOrder The parameters:endpointName,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L640
    ❌ R4039 - ParametersOrder The parameters:name,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L743
    ❌ R4039 - ParametersOrder The parameters:name,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L793
    ❌ R4039 - ParametersOrder The parameters:name,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L843
    ❌ R4039 - ParametersOrder The parameters:name,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L914
    ❌ R4039 - ParametersOrder The parameters:name,version,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L985
    ❌ R4039 - ParametersOrder The parameters:name,version,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L1042
    ❌ R4039 - ParametersOrder The parameters:name,version,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L1099
    ❌ R4039 - ParametersOrder The parameters:name,resourceGroupName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#L1228
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 11, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go-track2 - armmachinelearningservices - 0.3.0
    +	Struct `ContainerResourceRequirements` has been removed
+	Struct `ServicePrincipalCredentials` has been removed
+	Type of `DiagnoseRequestProperties.ApplicationInsights` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
+	Type of `DiagnoseRequestProperties.ContainerRegistry` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
+	Type of `DiagnoseRequestProperties.DNSResolution` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
+	Type of `DiagnoseRequestProperties.KeyVault` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
+	Type of `DiagnoseRequestProperties.Nsg` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
+	Type of `DiagnoseRequestProperties.Others` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
+	Type of `DiagnoseRequestProperties.ResourceLock` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
+	Type of `DiagnoseRequestProperties.StorageAccount` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
+	Type of `DiagnoseRequestProperties.Udr` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
+	Type of `ErrorAdditionalInfo.Info` has been changed from `map[string]interface{}` to `interface{}`
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-machinelearningservices - 1.0.0
    ️✔️azure-sdk-for-go - machinelearningservices/mgmt/2021-07-01/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - machinelearningservices/mgmt/2021-04-01/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - machinelearningservices/mgmt/2020-04-01/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - machinelearningservices/mgmt/2020-03-01/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - machinelearningservices/mgmt/2020-01-01/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - machinelearningservices/mgmt/2019-11-01/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - machinelearningservices/mgmt/2019-06-01/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - machinelearningservices/mgmt/2019-05-01/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - machinelearningservices/mgmt/2018-11-19/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - preview/machinelearningservices/mgmt/2022-01-01-preview/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - preview/machinelearningservices/mgmt/2021-03-01-preview/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - preview/machinelearningservices/mgmt/2020-02-18-preview/machinelearningservices - v61.4.0
    ️✔️azure-sdk-for-go - preview/machinelearningservices/mgmt/2018-03-01-preview/machinelearningservices - v61.4.0
    ️❌ azure-sdk-for-net failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 5da6078. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/common-types/resource-management/v2/types.json:316:8 ($.definitions.ErrorDetail.properties.additionalInfo)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/common-types/resource-management/v2/types.json:304:8 ($.definitions.ErrorDetail.properties.details)
cmderr	[Autorest] FATAL: swagger-document/individual/schema-validator - FAILED
cmderr	[Autorest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
cmderr	[Autorest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]  
  
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 5da6078. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️machinelearningservices/mgmt/2021-07-01/machinelearningservices        [View full logs]         [Release SDK Changes]      
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️machinelearningservices/mgmt/2021-04-01/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️machinelearningservices/mgmt/2020-04-01/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️machinelearningservices/mgmt/2020-03-01/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️machinelearningservices/mgmt/2020-01-01/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️machinelearningservices/mgmt/2019-11-01/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️machinelearningservices/mgmt/2019-06-01/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️machinelearningservices/mgmt/2019-05-01/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️machinelearningservices/mgmt/2018-11-19/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/machinelearningservices/mgmt/2022-01-01-preview/machinelearningservices        [View full logs]       
      info	[Changelog] This is a new package
info	[Changelog]
    • ️✔️preview/machinelearningservices/mgmt/2021-03-01-preview/machinelearningservices        [View full logs]       
      info	[Changelog] This is a new package
info	[Changelog]
    • ️✔️preview/machinelearningservices/mgmt/2020-02-18-preview/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/machinelearningservices/mgmt/2018-03-01-preview/machinelearningservices        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 5da6078. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armmachinelearningservices        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `DiagnoseRequestProperties.ContainerRegistry` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `DiagnoseRequestProperties.Nsg` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `DiagnoseRequestProperties.Others` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `DiagnoseRequestProperties.StorageAccount` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `DiagnoseRequestProperties.ApplicationInsights` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `DiagnoseRequestProperties.DNSResolution` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `DiagnoseRequestProperties.Udr` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `DiagnoseRequestProperties.KeyVault` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `DiagnoseRequestProperties.ResourceLock` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `ErrorAdditionalInfo.Info` has been changed from `map[string]interface{}` to `interface{}`
info	[Changelog] - Struct `ContainerResourceRequirements` has been removed
info	[Changelog] - Struct `ServicePrincipalCredentials` has been removed
info	[Changelog]
info	[Changelog] Total 6 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 5da6078. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-machinelearningservices        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.create_or_update
info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.delete
info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.list
info	[Changelog]   - Added operation PrivateLinkResourcesOperations.list
info	[Changelog]   - Added operation WorkspacesOperations.begin_diagnose
info	[Changelog]   - Added operation WorkspacesOperations.begin_prepare_notebook
info	[Changelog]   - Added operation WorkspacesOperations.begin_resync_keys
info	[Changelog]   - Added operation WorkspacesOperations.list_notebook_access_token
info	[Changelog]   - Added operation WorkspacesOperations.list_notebook_keys
info	[Changelog]   - Added operation WorkspacesOperations.list_outbound_network_dependencies_endpoints
info	[Changelog]   - Added operation WorkspacesOperations.list_storage_account_keys
info	[Changelog]   - Added operation group ComputeOperations
info	[Changelog]   - Added operation group WorkspaceSkusOperations
info	[Changelog]   - Model AKS has a new parameter disable_local_auth
info	[Changelog]   - Model AKSProperties has a new parameter cluster_purpose
info	[Changelog]   - Model AKSProperties has a new parameter load_balancer_subnet
info	[Changelog]   - Model AKSProperties has a new parameter load_balancer_type
info	[Changelog]   - Model AmlCompute has a new parameter disable_local_auth
info	[Changelog]   - Model AmlComputeProperties has a new parameter enable_node_public_ip
info	[Changelog]   - Model AmlComputeProperties has a new parameter isolated_network
info	[Changelog]   - Model AmlComputeProperties has a new parameter os_type
info	[Changelog]   - Model AmlComputeProperties has a new parameter virtual_machine_image
info	[Changelog]   - Model ClusterUpdateParameters has a new parameter properties
info	[Changelog]   - Model Compute has a new parameter disable_local_auth
info	[Changelog]   - Model ComputeInstance has a new parameter disable_local_auth
info	[Changelog]   - Model ComputeInstanceProperties has a new parameter compute_instance_authorization_type
info	[Changelog]   - Model ComputeInstanceProperties has a new parameter personal_compute_instance_settings
info	[Changelog]   - Model ComputeInstanceProperties has a new parameter setup_scripts
info	[Changelog]   - Model ComputeResource has a new parameter system_data
info	[Changelog]   - Model DataFactory has a new parameter disable_local_auth
info	[Changelog]   - Model DataLakeAnalytics has a new parameter disable_local_auth
info	[Changelog]   - Model Databricks has a new parameter disable_local_auth
info	[Changelog]   - Model DatabricksProperties has a new parameter workspace_url
info	[Changelog]   - Model EncryptionProperty has a new parameter identity
info	[Changelog]   - Model ErrorDetail has a new parameter additional_info
info	[Changelog]   - Model ErrorDetail has a new parameter details
info	[Changelog]   - Model ErrorDetail has a new parameter target
info	[Changelog]   - Model ErrorResponse has a new parameter error
info	[Changelog]   - Model HDInsight has a new parameter disable_local_auth
info	[Changelog]   - Model PrivateEndpoint has a new parameter subnet_arm_id
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter identity
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter location
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter sku
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter tags
info	[Changelog]   - Model PrivateLinkResource has a new parameter system_data
info	[Changelog]   - Model QuotaUpdateParameters has a new parameter location
info	[Changelog]   - Model ResourceQuota has a new parameter aml_workspace_location
info	[Changelog]   - Model SslConfiguration has a new parameter leaf_domain_label
info	[Changelog]   - Model SslConfiguration has a new parameter overwrite_existing_domain
info	[Changelog]   - Model Usage has a new parameter aml_workspace_location
info	[Changelog]   - Model VirtualMachine has a new parameter disable_local_auth
info	[Changelog]   - Model VirtualMachineProperties has a new parameter is_notebook_instance_compute
info	[Changelog]   - Model VirtualMachineSizeListResult has a new parameter value
info	[Changelog]   - Model Workspace has a new parameter ml_flow_tracking_uri
info	[Changelog]   - Model Workspace has a new parameter primary_user_assigned_identity
info	[Changelog]   - Model Workspace has a new parameter public_network_access
info	[Changelog]   - Model Workspace has a new parameter service_managed_resources_settings
info	[Changelog]   - Model Workspace has a new parameter storage_hns_enabled
info	[Changelog]   - Model Workspace has a new parameter system_data
info	[Changelog]   - Model Workspace has a new parameter tenant_id
info	[Changelog]   - Model WorkspaceConnection has a new parameter value_format
info	[Changelog]   - Model WorkspaceSku has a new parameter capabilities
info	[Changelog]   - Model WorkspaceSku has a new parameter location_info
info	[Changelog]   - Model WorkspaceSku has a new parameter locations
info	[Changelog]   - Model WorkspaceSku has a new parameter name
info	[Changelog]   - Model WorkspaceSku has a new parameter restrictions
info	[Changelog]   - Model WorkspaceSku has a new parameter tier
info	[Changelog]   - Model WorkspaceUpdateParameters has a new parameter identity
info	[Changelog]   - Model WorkspaceUpdateParameters has a new parameter image_build_compute
info	[Changelog]   - Model WorkspaceUpdateParameters has a new parameter primary_user_assigned_identity
info	[Changelog]   - Model WorkspaceUpdateParameters has a new parameter public_network_access
info	[Changelog]   - Model WorkspaceUpdateParameters has a new parameter service_managed_resources_settings
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model AmlComputeNodesInformation no longer has parameter compute_type
info	[Changelog]   - Model ClusterUpdateParameters no longer has parameter scale_settings
info	[Changelog]   - Model ErrorResponse no longer has parameter code
info	[Changelog]   - Model ErrorResponse no longer has parameter details
info	[Changelog]   - Model ErrorResponse no longer has parameter message
info	[Changelog]   - Model Resource no longer has parameter identity
info	[Changelog]   - Model Resource no longer has parameter location
info	[Changelog]   - Model Resource no longer has parameter sku
info	[Changelog]   - Model Resource no longer has parameter tags
info	[Changelog]   - Model VirtualMachineSizeListResult no longer has parameter aml_compute
info	[Changelog]   - Model Workspace no longer has parameter creation_time
info	[Changelog]   - Model WorkspaceSku no longer has parameter skus
info	[Changelog]   - Operation VirtualMachineSizesOperations.list has a new signature
info	[Changelog]   - Operation VirtualMachineSizesOperations.list has a new signature
info	[Changelog]   - Operation WorkspacesOperations.list_by_resource_group has a new signature
info	[Changelog]   - Operation WorkspacesOperations.list_by_subscription has a new signature
info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_delete
info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.put
info	[Changelog]   - Removed operation PrivateLinkResourcesOperations.list_by_workspace
info	[Changelog]   - Removed operation WorkspacesOperations.resync_keys
info	[Changelog]   - Removed operation group AzureMachineLearningWorkspacesOperationsMixin
info	[Changelog]   - Removed operation group MachineLearningComputeOperations
info	[Changelog]   - Removed operation group NotebooksOperations
    ️⚠️ azure-sdk-for-java warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 5da6078. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-15 00:39:32 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-machinelearningservices;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2022-02-15 00:39:32 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2022-02-15 00:39:32 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.50 --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/machinelearningservices/azure-resourcemanager-machinelearningservices --java.namespace=com.azure.resourcemanager.machinelearningservices   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md
cmderr	[generate.py] 2022-02-15 00:40:04 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-machinelearningservices
cmderr	[generate.py] 2022-02-15 00:40:04 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-15 00:40:04 INFO [POM][Skip] pom already has module azure-resourcemanager-machinelearningservices
cmderr	[generate.py] 2022-02-15 00:40:04 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-15 00:40:04 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-15 00:40:04 INFO [POM][Skip] pom already has module sdk/machinelearningservices
cmderr	[generate.py] 2022-02-15 00:40:04 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-machinelearningservices        [View full logs]         [Release SDK Changes]      
      cmderr	[Inst] 2022-02-15 00:41:11 DEBUG Got artifact_id: azure-resourcemanager-machinelearningservices
cmderr	[Inst] 2022-02-15 00:41:11 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-15 00:41:11 DEBUG Got artifact: azure-resourcemanager-machinelearningservices-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2022-02-15 00:41:11 DEBUG Got artifact: azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar
cmderr	[Inst] 2022-02-15 00:41:11 DEBUG Match jar package: azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar
cmderr	[Inst] 2022-02-15 00:41:11 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17823/azure-sdk-for-java/azure-resourcemanager-machinelearningservices/azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar\" -o azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-machinelearningservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-machinelearningservices-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 5da6078. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-machinelearningservices        [View full logs]         [Release SDK Changes]      
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 5da6078. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh]  The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh]  so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh]
cmderr	[initScript.sh]  This is a one-time fix-up, please be patient...
cmderr	[initScript.sh]
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️machinelearningservices        [View full logs]       
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi @erjms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.  
    TaskHow to fixPriority
     
    AvocadoFix-AvocadoHigh
     
    Semantic validationFix-SemanticValidation-ErrorHigh
     
    Model validationFix-ModelValidation-ErrorHigh
     
    LintDiffFix-LintDiffhigh
      If you need further help, please feedback via swagger feedback.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            


  
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Feb 11, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Feb 11, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
  This was referenced Feb 11, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    




    

      
    
  
        
    
    
    
  
  
    
  
              erjms
  

        added 2 commits
        February 11, 2022 16:53
    

      
    
      
    
  
  
    
  
              
    
  
    
    
    
      

    
  
    
      
        @erjms
  
    

    

      
    
        
          Removed x-ms-long-running-operation-options from MFE spec
        

          
                        
      
    

      
    
        

    
    
    

  

      
    

      
    
        
    
          

    
    
    

  

  
    
    
  
    

    
        
    
      
    

      
    
        
          1594412
        
      
    
    
    
  
    
    
    
      
    Removed from 2021-03-01-preview api version for non-POST LRO operations.
Non-breaking change to fix autogenerated REST clients.
    
    
    

    


    

          
    
  
  
    
  
              
    
  
    
    
    
      

    
  
    
      
        @erjms
  
    

    

      
    
        
          Fixed validation errors in examples for MFE 2021-03-01-preview api ve…
        

          
                        
      
    

      
    
        

    
    
    

  

      
    

      
    
        
    
          

    
    
    

  

  
    
    
  
    

    
        
    
      
    

      
    
        
          d90824a
        
      
    
    
    
  
    
    
    
      
    …rsion
    
    
    

    


    

      
    

    



    

      
    
  
          
    
  
  
    
  
          @erjms
  erjms


        force-pushed
    the
        
      
  dev/erjms/fix-mfe-2021-03-01-preview


    
 branch
    from
    6745f10    to
    d90824a      
    Compare
  



    February 11, 2022 22:54    
    

    

    
    


    





    

      
    
  
        



    

      
    
  
            


  
    
  
    
    
  
    
  
    


        @ArcturusZhang
  ArcturusZhang



        merged commit 5da6078
      into

      
  
    Azure:main
  


    Feb 15, 2022

  
    

    


    

  
    
  
    
    
  
    

  
    
      
    
  This was referenced Feb 15, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    




    



        
    
  
          

    
  
    
  
  
    
    
  FredericHeem 

      pushed a commit
        to grucloud/azure-rest-api-specs
      that referenced
      this pull request

    
      Mar 7, 2022
    
    
    
      

    
  
    
    
    
      

    
  
    
      
        @erjms
      
        @FredericHeem
  
    

    


      
    
        
          Remove x-ms-long-running-operation-options from MFE spec (Azure#17823)
        

          
            
          

      
    

      
    
          

    
    
    

  

      
    

      
    
      
    

      
      
    
        
          d0322ae
        
      
    
    
    
  
    
    
    
      
    * Removed x-ms-long-running-operation-options from MFE spec

Removed from 2021-03-01-preview api version for non-POST LRO operations.
Non-breaking change to fix autogenerated REST clients.

* Fixed validation errors in examples for MFE 2021-03-01-preview api version
    
    
    

    

    
    
  
    

    

  
  
  
  



    



  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @ArcturusZhang
  
    ArcturusZhang



          
            
              
            
          
          ArcturusZhang approved these changes

        
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
      @ArcturusZhang
  
    ArcturusZhang
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    Approved-SdkBreakingChange-Go-V2

  

    Approved-SdkBreakingChange-Python

  

    CI-BreakingChange-Go-V2

  

    FixS360



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

          

    

  
      
    
  
    
    
    
      3 participants
    
    
    
    
        
          @erjms 
        
          @ArcturusZhang 
        
          @msyyc