Add xms-ids for monitor #17851
Merged
Add xms-ids for monitor #17851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @LinglingTong Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
This was referenced Feb 14, 2022
|
Hi @LinglingTong, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@LinglingTong I can only approve the added x-ms-identifiers values in scheduledqueryrules, which is my team's service, are good. @arolshan no longer works at MS. I suggest you write to all Insights RP Owners at insightsrp@microsoft.com and ask the RP owner of reach resource type to ack your changes. |
@avjerafi Thanks for looking at the changes also the contact! Just sent an email to insightsrp asking for code reviews. |
|
Signoff from Jorge Herrera on the Monitor team - |
|
Checked failures on Swagger LintDiff and ModelValidation, they are not related to my changes. |
asafst
reviewed
Mar 2, 2022
| @@ -769,6 +775,9 @@ | |||
| "items": { | |||
| "$ref": "#/definitions/MetricCriteria" | |||
| }, | |||
| "x-ms-identifiers": [ | |||
| "operator" | |||
There was a problem hiding this comment.
A more appropriate identifier will probably be the "name" property.
There was a problem hiding this comment.
Thanks for looking at the code change, @asafst! I just pushed the fix regarding to your comments and please take a look when you get a chance.
asafst
approved these changes
Mar 4, 2022
|
@msyyc I checked the failures of LintDiff and ModelValidation, and none of them are related to my change. This PR has been signed off, could you help with merging it? Thanks! |
|
the failure and SDK breaking change is not related with the pr |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 21, 2022
Closed
Closed
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* add xms-ids for monitor * inner properties * change operator to name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
About the Change
APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.
See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.