Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing resourcetype parameter from global prameters as it is not referenced anywhere. #1795

Merged
merged 1 commit into from
Oct 6, 2017
Merged

removing resourcetype parameter from global prameters as it is not referenced anywhere. #1795

merged 1 commit into from
Oct 6, 2017

Conversation

amarzavery
Copy link
Contributor

The changes in this PR were originally made in #1753.
However, that PR had similar changes for ServiceFabric and RecoveryServicesSiteRecovery. Splitting this so that ResourceHealth changes are standalone.

@amarzavery
Copy link
Contributor Author

Assigning Veronica as she reviewed this change in #1753.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/resourcehealth/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

veronicagg
veronicagg suggested changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amarzavery could you please tag the appropriate people from ResourceHealth that you're pending sign-off/review from? thanks!

@amarzavery
Copy link
Contributor Author

@veronicagg - Himanshu Misra from RH team approved this change.

@amarzavery amarzavery merged commit d23c2f0 into Azure:current Oct 6, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veronicagg veronicagg veronicagg requested changes

@HimanshuMisra1 HimanshuMisra1 HimanshuMisra1 approved these changes

Assignees

@veronicagg veronicagg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amarzavery @azuresdkciprbot @AutorestCI @veronicagg @HimanshuMisra1