Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update properties to align with service side #18080

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Update properties to align with service side #18080

merged 2 commits into from
Mar 7, 2022

Conversation

Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Mar 3, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @Juliehzl Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 3, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'name, certificateId' that was not found in the old version.
    New: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L610:11
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L610:11
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'name, certificateId' that was not found in the old version.
    New: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L697:5
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L697:5
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L792
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: internal
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L610
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 3, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armapp - 0.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-app - first release
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 16b967e. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh]  New minor version of npm available! 8.3.1 -> 8.5.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.3` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-app [View full logs]  [Release SDK Changes] 
      info	[Changelog]   - Initial Release
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 16b967e. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-03-07 00:47:36 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-app"
cmderr	[generate.py] 2022-03-07 00:47:36 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2022-03-07 00:47:36 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.50 --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/app/azure-resourcemanager-app --java.namespace=com.azure.resourcemanager.app   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/app/resource-manager/readme.md
cmderr	[generate.py] 2022-03-07 00:48:09 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2022-03-07 00:48:09 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-03-07 00:48:09 INFO [POM][Skip] pom already has module azure-resourcemanager-app
cmderr	[generate.py] 2022-03-07 00:48:09 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-03-07 00:48:09 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-03-07 00:48:09 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-app [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2022-03-07 00:49:45 DEBUG Got artifact_id: azure-resourcemanager-app
cmderr	[Inst] 2022-03-07 00:49:45 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-03-07 00:49:45 DEBUG Got artifact: azure-resourcemanager-app-1.0.0-beta.1.jar
cmderr	[Inst] 2022-03-07 00:49:45 DEBUG Match jar package: azure-resourcemanager-app-1.0.0-beta.1.jar
cmderr	[Inst] 2022-03-07 00:49:45 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/18080/azure-sdk-for-java/azure-resourcemanager-app/azure-resourcemanager-app-1.0.0-beta.1.jar\" -o azure-resourcemanager-app-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-app -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-app-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 16b967e. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armapp [View full logs]  [Release SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New struct `DaprComponentsClientCreateOrUpdateResponse`
info	[Changelog] - New struct `DaprComponentsClientCreateOrUpdateResult`
info	[Changelog] - New struct `DaprComponentsClientDeleteOptions`
info	[Changelog] - New struct `DaprComponentsClientDeleteResponse`
info	[Changelog] - New struct `DaprComponentsClientGetOptions`
info	[Changelog] - New struct `DaprComponentsClientGetResponse`
info	[Changelog] - New struct `DaprComponentsClientGetResult`
info	[Changelog] - New struct `DaprComponentsClientListOptions`
info	[Changelog] - New struct `DaprComponentsClientListPager`
info	[Changelog] - New struct `DaprComponentsClientListResponse`
info	[Changelog] - New struct `DaprComponentsClientListResult`
info	[Changelog] - New struct `DaprComponentsCollection`
info	[Changelog] - New struct `DaprMetadata`
info	[Changelog] - New struct `DefaultErrorResponse`
info	[Changelog] - New struct `DefaultErrorResponseError`
info	[Changelog] - New struct `DefaultErrorResponseErrorDetailsItem`
info	[Changelog] - New struct `EnvironmentVar`
info	[Changelog] - New struct `Facebook`
info	[Changelog] - New struct `GitHub`
info	[Changelog] - New struct `GithubActionConfiguration`
info	[Changelog] - New struct `GlobalValidation`
info	[Changelog] - New struct `Google`
info	[Changelog] - New struct `HTTPScaleRule`
info	[Changelog] - New struct `HTTPSettings`
info	[Changelog] - New struct `HTTPSettingsRoute`
info	[Changelog] - New struct `IdentityProviders`
info	[Changelog] - New struct `Ingress`
info	[Changelog] - New struct `LogAnalyticsConfiguration`
info	[Changelog] - New struct `Login`
info	[Changelog] - New struct `LoginRoute`
info	[Changelog] - New struct `LoginScopes`
info	[Changelog] - New struct `LogsConfiguration`
info	[Changelog] - New struct `ManagedEnvironment`
info	[Changelog] - New struct `ManagedEnvironmentPatch`
info	[Changelog] - New struct `ManagedEnvironmentProperties`
info	[Changelog] - New struct `ManagedEnvironmentStorage`
info	[Changelog] - New struct `ManagedEnvironmentStorageProperties`
info	[Changelog] - New struct `ManagedEnvironmentStoragesCollection`
info	[Changelog] - New struct `ManagedEnvironmentsClient`
info	[Changelog] - New struct `ManagedEnvironmentsClientBeginCreateOrUpdateOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientBeginDeleteOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdatePoller`
info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdatePollerResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdateResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdateResult`
info	[Changelog] - New struct `ManagedEnvironmentsClientDeletePoller`
info	[Changelog] - New struct `ManagedEnvironmentsClientDeletePollerResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientDeleteResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientGetOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientGetResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientGetResult`
info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupPager`
info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupResult`
info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionPager`
info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionResult`
info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateOptions`
info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateResponse`
info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateResult`
info	[Changelog] - New struct `ManagedEnvironmentsCollection`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClient`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateOptions`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateResponse`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateResult`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientDeleteOptions`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientDeleteResponse`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetOptions`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetResponse`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetResult`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListOptions`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListResponse`
info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListResult`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `OpenIDConnectClientCredential`
info	[Changelog] - New struct `OpenIDConnectConfig`
info	[Changelog] - New struct `OpenIDConnectLogin`
info	[Changelog] - New struct `OpenIDConnectRegistration`
info	[Changelog] - New struct `OperationDetail`
info	[Changelog] - New struct `OperationDisplay`
info	[Changelog] - New struct `OperationsClient`
info	[Changelog] - New struct `OperationsClientListOptions`
info	[Changelog] - New struct `OperationsClientListPager`
info	[Changelog] - New struct `OperationsClientListResponse`
info	[Changelog] - New struct `OperationsClientListResult`
info	[Changelog] - New struct `ProxyResource`
info	[Changelog] - New struct `QueueScaleRule`
info	[Changelog] - New struct `Registration`
info	[Changelog] - New struct `RegistryCredentials`
info	[Changelog] - New struct `RegistryInfo`
info	[Changelog] - New struct `Replica`
info	[Changelog] - New struct `ReplicaCollection`
info	[Changelog] - New struct `ReplicaContainer`
info	[Changelog] - New struct `ReplicaProperties`
info	[Changelog] - New struct `Resource`
info	[Changelog] - New struct `Revision`
info	[Changelog] - New struct `RevisionCollection`
info	[Changelog] - New struct `RevisionProperties`
info	[Changelog] - New struct `Scale`
info	[Changelog] - New struct `ScaleRule`
info	[Changelog] - New struct `ScaleRuleAuth`
info	[Changelog] - New struct `Secret`
info	[Changelog] - New struct `SecretsCollection`
info	[Changelog] - New struct `SourceControl`
info	[Changelog] - New struct `SourceControlCollection`
info	[Changelog] - New struct `SourceControlProperties`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `Template`
info	[Changelog] - New struct `TrackedResource`
info	[Changelog] - New struct `TrafficWeight`
info	[Changelog] - New struct `Twitter`
info	[Changelog] - New struct `TwitterRegistration`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New struct `VnetConfiguration`
info	[Changelog] - New struct `Volume`
info	[Changelog] - New struct `VolumeMount`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 801 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 16b967e. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-app [View full logs]  [Release SDK Changes] 
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 16b967e. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @Juliehzl Juliehzl requested a review from ruslany March 3, 2022 06:07
    @openapi-workflow-bot
    Copy link

    Hi @Juliehzl, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 3, 2022
    Draft
    @openapi-workflow-bot
    Copy link

    Hi @Juliehzl, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Mar 3, 2022
    Closed
    Closed
    Closed
    Closed
    @Juliehzl Juliehzl requested a review from vinisoto March 3, 2022 06:37
    @Juliehzl
    Copy link
    Contributor Author

    Juliehzl commented Mar 3, 2022

    @JeffreyRichter Although there is breaking change detected here, but we haven't released any SDKs for our RP and with these changes, SDK behavior will align with server side. So could you help approve the breaking change?

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 3, 2022
    @Juliehzl
    Copy link
    Contributor Author

    Juliehzl commented Mar 4, 2022

    @changlong-liu could you help merge the PR?

    @changlong-liu changlong-liu merged commit 16b967e into Azure:main Mar 7, 2022
    This was referenced Mar 7, 2022
    Merged
    Closed
    Closed
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Mar 7, 2022
    [ReleasePR app] Update properties to align with service side (#2234)
    1fc89ac 
    Create to sync Azure/azure-rest-api-specs#18080
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/app?expand=1)
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022
    @Juliehzl @FredericHeem
    Update properties to align with service side (Azure#18080)
    266a4fd 
    * update

* update
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @changlong-liu changlong-liu changlong-liu approved these changes

    @vinisoto vinisoto vinisoto approved these changes

    @ruslany ruslany Awaiting requested review from ruslany

    Assignees

    @changlong-liu changlong-liu

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @Juliehzl @vinisoto @changlong-liu @JeffreyRichter