[Hub Generated] Public private branch 'dynamic_thresholds/momalka/deprecate_baseline_calculatebaseline' #18109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2022 09:13
… into dynamic_thresholds/momalka/deprecate_baseline_calculatebaseline
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/5984 |
Swagger Generation Artifacts
|
|
Private repo PR: #5984 |
This was referenced Mar 6, 2022
asafst
approved these changes
Mar 6, 2022
|
Hi @weidongxu-microsoft |
weidongxu-microsoft
approved these changes
Mar 8, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@msyyc for failure on azure-sdk-for-python-track2 |
weidongxu-microsoft
added
the
Approved-BreakingChange
|
@msyyc for failure on azure-sdk-for-python-track2 |
|
@weidongxu-microsoft done |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| These settings apply only when `--tag=package-2017-11-01-preview-only --python` is specified on the command line. | ||
| Please also specify `--python-sdks-folder=<path to the root directory of your azure-sdk-for-python clone>`. | ||
|
|
||
| ``` yaml $(tag) == 'package-2017-11-01-preview-only' |
There was a problem hiding this comment.
you still have it package-2017-11-01-preview-only in readme. Just search it.
There was a problem hiding this comment.
@weidongxu-microsoft sorry for missing that. Now all package-2017-11-01-preview-only are removed from that file
moshemal
force-pushed
the
published/moshemal/azure-rest-api-specs-pr/dynamic_thresholds/momalka/deprecate_baseline_calculatebaseline
branch
from
2040d85
to
ee942ca
Compare
This was referenced Mar 23, 2022
Closed
Closed
visingl
pushed a commit
that referenced
this pull request
Mar 30, 2022
…recate_baseline_calculatebaseline' (#18109) * deprecated * cleanup package-2017-11-01-preview-only Co-authored-by: Moshe Malka <momalka@microsoft.com>
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
…recate_baseline_calculatebaseline' (Azure#18109) * deprecated * cleanup package-2017-11-01-preview-only Co-authored-by: Moshe Malka <momalka@microsoft.com>
moshemal
deleted the
published/moshemal/azure-rest-api-specs-pr/dynamic_thresholds/momalka/deprecate_baseline_calculatebaseline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.