Review request for Microsoft.ContainerService to add version 2022-02-02-preview #18150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w/2022-01-02-preview to version 2022-02-02-preview
…022-02-02-preview (#17955) * Add key management service profile of a managed cluster for version 2022-02-02-preview * add kmsProfile * update after api review * add more details in description * update for comments
* add mc snapshot api * fix format * add mc snapshot type * define type for enums * add properties for example
…vice (#17889) * update readme * remove useless -only tags
|
Hi, @FumingZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
FumingZhang
added
the
DoNotMerge
|
Hi @FumingZhang, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 9, 2022
FumingZhang
requested review from
msyyc,
BigCat20196,
ArcturusZhang,
palma21 and
matthchr
as code owners
FumingZhang
removed
the
DoNotMerge
Please fix In reply to: 1065786197 Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/preview/2022-02-02-preview/managedClusters.json:2337 in 38acb70. [](commit_id = 38acb70, deletion_comment = False) |
As chris has pointed out can you please update these values from {resourcename} to an actual value like {managedclustersnapshotname} Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/preview/2022-02-02-preview/managedClusters.json:2319 in 81c594c. [](commit_id = 81c594c, deletion_comment = False) |
As chris has suggested , can you please update this name ? the kms suffix is not descriptive enough and is confusing to read In reply to: 1065786063 Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/preview/2022-02-02-preview/managedClusters.json:5763 in 38acb70. [](commit_id = 38acb70, deletion_comment = False) |
raosuhas
added
ARMSignedOff
Jumping in here (@karataliu feel free to chime in as well). This field is not a reference to a We discussed expanding this fully internally but decided not to because none of the open source projects to which we're referring do so either. We wanted to be consistent with what the projects/solutions are actually called, and in the Kubernetes community they are called |
This was referenced Mar 21, 2022
25 tasks
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
…02-preview (Azure#18150) * Adds base for updating Microsoft.ContainerService from version preview/2022-01-02-preview to version 2022-02-02-preview * Updates readme * Updates API version in new specs and examples * Add key management service profile of a managed cluster for version 2022-02-02-preview (Azure#17955) * Add key management service profile of a managed cluster for version 2022-02-02-preview * add kmsProfile * update after api review * add more details in description * update for comments * add mc snapshot api (Azure#17974) * add mc snapshot api * fix format * add mc snapshot type * define type for enums * add properties for example * Update readmes for the 2022-02-02-preview dev branch of container service (Azure#17889) * update readme * remove useless -only tags * remove nested property in allOf for 2022-02-02-preview managedClusters (Azure#18063) * Fix credential format typo in 0102 preview (Azure#18117) * add missing type object (Azure#18116) * Update several common definitions according to arm feedback for container service 2022-02-02-preview (Azure#18206) * update definition of serveral parameters and system data * update definition of Resource and move property location to sub resources * add missing tags property for prev Resource * fix for compatibility * fix definition name Co-authored-by: Bin Xia <binxi@microsoft.com> Co-authored-by: Qingqing <qizhe@microsoft.com> Co-authored-by: Tongyao Si <tosi@microsoft.com>
FumingZhang
deleted the
dev-containerservice-Microsoft.ContainerService-2022-02-02-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.