Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge updates from main, to feature branch #18239

Closed
wants to merge 9 commits into from

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Mar 14, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changes from:
https://github.com/Azure/azure-rest-api-specs/pull/17853/files -- Done
#18019
#18075 -- Done
I don't think I should include this: #17709

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

rytruong and others added 4 commits March 14, 2022 17:27
* inital commit for diskrp swagger 2021-12-01

* added architecture

* updated api version for example files

* added dataAccessAuthMode

* added architecture and dataAccessAuthMode

* updated description for DataAccessAuthMode

* Addressed comments

* added xms-ids

* Update readme.md

Co-authored-by: REDMOND\rytruong <rytruong@microsoft.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
* save

* save

* add some missing x-ms-identifiers

* add more x-ms-identifiers

* add more x-ms-identifiers

Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
@openapi-workflow-bot
Copy link

Hi, @Sandido Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 14, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Compute/stable/2021-04-01/compute.json#L36
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L36
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L36
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Compute/stable/2021-07-01/compute.json#L36
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L1748
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L1748
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L1929
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L1929
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L2111
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L2111
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L2263
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L2263
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L1754
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L1754
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L1948
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L1948
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L2130
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L2130
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L2282
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L2282
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L1772
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L1772
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L1772
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2069
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2069
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2069
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2251
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2251
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2251
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2418
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2022-01-03
    ️❌ModelValidation: 185 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Compute/stable/2020-09-30/gallery.json#L1678:22
    ExampleUrl: stable/2020-09-30/examples/AddToSharingProfileInAGallery.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Compute/stable/2020-09-30/gallery.json#L1678:22
    ExampleUrl: stable/2020-09-30/examples/ResetSharingProfileInAGallery.json
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Operations_List.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L38:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_Update.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L114:16
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_Delete.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L160:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_Get.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L197:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_List.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L276:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_ListAvailableSizes.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L311:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHostGroups_Update.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L681:16
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHostGroups_Delete.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L727:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHostGroups_ListByResourceGroup.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L823:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHostGroups_ListBySubscription.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L858:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHosts_Update.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L951:16
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHosts_Delete.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1005:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHosts_ListByHostGroup.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1119:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in SshPublicKeys_ListBySubscription.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1161:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in SshPublicKeys_ListByResourceGroup.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1189:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in SshPublicKeys_Update.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1281:16
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in SshPublicKeys_Delete.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1327:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineExtensionImages_Get.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1452:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineExtensionImages_ListTypes.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1502:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineExtensionImages_ListVersions.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1543:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineExtensions_CreateOrUpdate.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1611:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineExtensions_Update.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1671:16
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineExtensions_Delete.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1725:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineExtensions_Get.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1773:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineExtensions_List.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1826:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineImages_Get.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1872:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineImages_List.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L1932:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in VirtualMachineImages_ListOffers.
    Url: Microsoft.Compute/stable/2021-04-01/compute.json#L2008:14
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 14, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-go-track2 - armazurestackhci - 0.3.0
    +	Function `ErrorDetail.MarshalJSON` has been removed
    +	Struct `ErrorAdditionalInfo` has been removed
    +	Struct `ErrorDetail` has been removed
    +	Struct `ErrorResponse` has been removed
    +	Type of `ExtensionParameters.ProtectedSettings` has been changed from `map[string]interface{}` to `interface{}`
    +	Type of `ExtensionParameters.Settings` has been changed from `map[string]interface{}` to `interface{}`
    ⚠️azure-sdk-for-go-track2 - armcompute - 0.6.0
    -	Const `ArchitectureTypesArm64` has been removed
    -	Const `ArchitectureTypesX64` has been removed
    -	Const `DataAccessAuthModeAzureActiveDirectory` has been removed
    -	Const `DataAccessAuthModeNone` has been removed
    -	Field `Architecture` of struct `SupportedCapabilities` has been removed
    -	Field `Architecture` of struct `VirtualMachineImageProperties` has been removed
    -	Field `DataAccessAuthMode` of struct `DiskProperties` has been removed
    -	Field `DataAccessAuthMode` of struct `DiskUpdateProperties` has been removed
    -	Field `DataAccessAuthMode` of struct `SnapshotProperties` has been removed
    -	Field `DataAccessAuthMode` of struct `SnapshotUpdateProperties` has been removed
    -	Function `ArchitectureTypes.ToPtr` has been removed
    -	Function `DataAccessAuthMode.ToPtr` has been removed
    -	Function `PossibleArchitectureTypesValues` has been removed
    -	Function `PossibleDataAccessAuthModeValues` has been removed
    ️✔️azure-sdk-for-go-track2 - armresourcehealth - 0.4.1
    ⚠️azure-sdk-for-js - @azure/arm-compute - 18.0.0
    -	Interface DiskUpdate no longer has parameter dataAccessAuthMode
    -	Interface SnapshotUpdate no longer has parameter dataAccessAuthMode
    -	Interface SupportedCapabilities no longer has parameter architecture
    -	Removed Enum KnownArchitectureTypes
    -	Removed Enum KnownDataAccessAuthMode
    -	Type Alias Disk no longer has parameter dataAccessAuthMode
    -	Type Alias Snapshot no longer has parameter dataAccessAuthMode
    -	Type Alias VirtualMachineImage no longer has parameter architecture
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-azurestackhci - 6.1.0b1
    ⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 26.1.0
    -	Model VirtualMachineImage no longer has parameter architecture
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-resourcehealth - 1.0.0b1
    ️✔️azure-sdk-for-go - azurestackhci/mgmt/2022-01-01/azurestackhci - v62.2.0
    ️✔️azure-sdk-for-go - azurestackhci/mgmt/2020-10-01/azurestackhci - v62.2.0
    ️✔️azure-sdk-for-go - preview/azurestackhci/mgmt/2021-01-01-preview/azurestackhci - v62.2.0
    ️✔️azure-sdk-for-go - preview/azurestackhci/mgmt/2020-03-01-preview/azurestackhci - v62.2.0
    ️✔️azure-sdk-for-go - profiles/2020-09-01/compute/mgmt/compute - v62.2.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2017-01-31/containerservice - v62.2.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-09-30/containerservice - v62.2.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-03-30/containerservice - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2021-12-01/compute - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2021-11-01/compute - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2021-08-01/compute - v62.2.0
    ⚠️azure-sdk-for-go - compute/mgmt/2021-07-01/compute - v62.2.0
    +	Field `ProvisioningDetails` of struct `RestorePointProperties` has been removed
    +	Struct `RestorePointProvisioningDetails` has been removed
    ⚠️azure-sdk-for-go - compute/mgmt/2021-04-01/compute - v62.2.0
    +	Field `ProvisioningDetails` of struct `RestorePointProperties` has been removed
    +	Struct `RestorePointProvisioningDetails` has been removed
    +	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
    ⚠️azure-sdk-for-go - compute/mgmt/2021-03-01/compute - v62.2.0
    +	Field `ConsistencyMode` of struct `RestorePoint` has been removed
    +	Field `ExcludeDisks` of struct `RestorePoint` has been removed
    +	Field `ProvisioningDetails` of struct `RestorePoint` has been removed
    +	Field `ProvisioningState` of struct `RestorePoint` has been removed
    +	Field `PublicIPAddressSkuName` of struct `PublicIPAddressSku` has been removed
    +	Field `PublicIPAddressSkuTier` of struct `PublicIPAddressSku` has been removed
    +	Field `SourceMetadata` of struct `RestorePoint` has been removed
    +	Struct `RestorePointProvisioningDetails` has been removed
    +	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
    ️✔️azure-sdk-for-go - compute/mgmt/2020-12-01/compute - v62.2.0
    ⚠️azure-sdk-for-go - compute/mgmt/2020-06-30/compute - v62.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ⚠️azure-sdk-for-go - compute/mgmt/2020-06-01/compute - v62.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ⚠️azure-sdk-for-go - compute/mgmt/2019-12-01/compute - v62.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ⚠️azure-sdk-for-go - compute/mgmt/2019-07-01/compute - v62.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ⚠️azure-sdk-for-go - compute/mgmt/2019-03-01/compute - v62.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ️✔️azure-sdk-for-go - compute/mgmt/2018-10-01/compute - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-06-01/compute - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-04-01/compute - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-12-01/compute - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-09-01/skus - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-03-30/compute - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2016-03-30/compute - v62.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2015-06-15/compute - v62.2.0
    ️✔️azure-sdk-for-go - preview/containerservice/mgmt/2015-11-01-preview/containerservice - v62.2.0
    ️✔️azure-sdk-for-go - preview/compute/mgmt/2020-10-01-preview/compute - v62.2.0
    ️✔️azure-sdk-for-go - preview/compute/mgmt/2016-04-30-preview/compute - v62.2.0
    ️✔️azure-sdk-for-go - resourcehealth/mgmt/2020-05-01/resourcehealth - v62.2.0
    ️✔️azure-sdk-for-go - resourcehealth/mgmt/2017-07-01/resourcehealth - v62.2.0
    ️✔️azure-sdk-for-go - resourcehealth/mgmt/2015-01-01/resourcehealth - v62.2.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 23a63f7421c875e1bef906cf91909b3b950aa1f1. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.4>
      cmderr	[automation_generate.sh] npm Run `npm install -g npm@8.5.4` to update!
      cmderr	[automation_generate.sh]
    • ️✔️track2_azure-mgmt-azurestackhci [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model Cluster has a new parameter desired_properties
      info	[Changelog]   - Model ClusterNode has a new parameter windows_server_subscription
      info	[Changelog]   - Model ClusterPatch has a new parameter aad_client_id
      info	[Changelog]   - Model ClusterPatch has a new parameter aad_tenant_id
      info	[Changelog]   - Model ClusterPatch has a new parameter desired_properties
      info	[Changelog]   - Model ClusterReportedProperties has a new parameter diagnostic_level
      info	[Changelog]   - Model ClusterReportedProperties has a new parameter imds_attestation
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation CommunityGalleryImageVersionsOperations.list
      info	[Changelog]   - Added operation CommunityGalleryImagesOperations.list
      info	[Changelog]   - Model CommunityGalleryImage has a new parameter architecture
      info	[Changelog]   - Model CommunityGalleryImageVersion has a new parameter exclude_from_latest
      info	[Changelog]   - Model CommunityGalleryImageVersion has a new parameter storage_profile
      info	[Changelog]   - Model SharedGalleryImage has a new parameter architecture
      info	[Changelog]   - Model SharedGalleryImageVersion has a new parameter exclude_from_latest
      info	[Changelog]   - Model SharedGalleryImageVersion has a new parameter storage_profile
    • ️✔️track2_azure-mgmt-resourcehealth [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs] Generate from 23a63f7421c875e1bef906cf91909b3b950aa1f1. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️azurestackhci/mgmt/2022-01-01/azurestackhci [View full logs
      Only show 4 items here, please refer to log for details.
      error		preview/compute/mgmt/2016-04-30-preview/compute
      error		resourcehealth/mgmt/2020-05-01/resourcehealth
      error		resourcehealth/mgmt/2017-07-01/resourcehealth
      error		resourcehealth/mgmt/2015-01-01/resourcehealth
    • ️✔️azurestackhci/mgmt/2020-10-01/azurestackhci
    • ️✔️preview/azurestackhci/mgmt/2021-01-01-preview/azurestackhci
    • ️✔️preview/azurestackhci/mgmt/2020-03-01-preview/azurestackhci
    • ️✔️profiles/2020-09-01/compute/mgmt/compute
    • ️✔️containerservice/mgmt/2017-01-31/containerservice
    • ️✔️containerservice/mgmt/2016-09-30/containerservice
    • ️✔️containerservice/mgmt/2016-03-30/containerservice
    • ️✔️compute/mgmt/2021-12-01/compute
    • ️✔️compute/mgmt/2021-11-01/compute
    • ️✔️compute/mgmt/2021-08-01/compute
    • ️✔️compute/mgmt/2021-07-01/compute
    • ️✔️compute/mgmt/2021-04-01/compute
    • ️✔️compute/mgmt/2021-03-01/compute
    • ️✔️compute/mgmt/2020-12-01/compute
    • ️✔️compute/mgmt/2020-06-30/compute
    • ️✔️compute/mgmt/2020-06-01/compute
    • ️✔️compute/mgmt/2019-12-01/compute
    • ️✔️compute/mgmt/2019-07-01/compute
    • ️✔️compute/mgmt/2019-03-01/compute
    • ️✔️compute/mgmt/2018-10-01/compute
    • ️✔️compute/mgmt/2018-06-01/compute
    • ️✔️compute/mgmt/2018-04-01/compute
    • ️✔️compute/mgmt/2017-12-01/compute
    • ️✔️compute/mgmt/2017-09-01/skus
    • ️✔️compute/mgmt/2017-03-30/compute
    • ️✔️compute/mgmt/2016-03-30/compute
    • ️✔️compute/mgmt/2015-06-15/compute
    • ️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice
    • ️✔️preview/compute/mgmt/2020-10-01-preview/compute
    • ️✔️preview/compute/mgmt/2016-04-30-preview/compute
    • ️✔️resourcehealth/mgmt/2020-05-01/resourcehealth
    • ️✔️resourcehealth/mgmt/2017-07-01/resourcehealth
    • ️✔️resourcehealth/mgmt/2015-01-01/resourcehealth
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 23a63f7421c875e1bef906cf91909b3b950aa1f1. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armazurestackhci [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `ExtensionParameters.Settings` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Type of `ExtensionParameters.ProtectedSettings` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Function `ErrorDetail.MarshalJSON` has been removed
      info	[Changelog] - Struct `ErrorAdditionalInfo` has been removed
      info	[Changelog] - Struct `ErrorDetail` has been removed
      info	[Changelog] - Struct `ErrorResponse` has been removed
      info	[Changelog]
      info	[Changelog] Total 8 breaking change(s), 0 additive change(s).
    • ️✔️armcompute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 40 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] - New const `GallerySharingPermissionTypesCommunity`
      info	[Changelog] - New const `SharedGalleryHostCachingNone`
      info	[Changelog] - New const `SharedGalleryHostCachingReadOnly`
      info	[Changelog] - New const `SharedGalleryHostCachingReadWrite`
      info	[Changelog] - New function `*CommunityGalleryImagesClientListPager.NextPage(context.Context) bool`
      info	[Changelog] - New function `*CommunityGalleryImageVersionsClientListPager.PageResponse() CommunityGalleryImageVersionsClientListResponse`
      info	[Changelog] - New function `CommunityGalleryImageList.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `SharedGalleryImageVersionStorageProfile.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*CommunityGalleryImagesClientListPager.PageResponse() CommunityGalleryImagesClientListResponse`
      info	[Changelog] - New function `CommunityGalleryImageVersionList.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `SharedGalleryHostCaching.ToPtr() *SharedGalleryHostCaching`
      info	[Changelog] - New function `*CommunityGalleryImageVersionsClientListPager.Err() error`
      info	[Changelog] - New function `*CommunityGalleryImagesClientListPager.Err() error`
      info	[Changelog] - New function `*CommunityGalleryImageVersionsClientListPager.NextPage(context.Context) bool`
      info	[Changelog] - New function `*CommunityGalleryImageVersionsClient.List(string, string, string, *CommunityGalleryImageVersionsClientListOptions) *CommunityGalleryImageVersionsClientListPager`
      info	[Changelog] - New function `*CommunityGalleryImagesClient.List(string, string, *CommunityGalleryImagesClientListOptions) *CommunityGalleryImagesClientListPager`
      info	[Changelog] - New function `PossibleSharedGalleryHostCachingValues() []SharedGalleryHostCaching`
      info	[Changelog] - New struct `CommunityGalleryImageList`
      info	[Changelog] - New struct `CommunityGalleryImageVersionList`
      info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListOptions`
      info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListPager`
      info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListResponse`
      info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListResult`
      info	[Changelog] - New struct `CommunityGalleryImagesClientListOptions`
      info	[Changelog] - New struct `CommunityGalleryImagesClientListPager`
      info	[Changelog] - New struct `CommunityGalleryImagesClientListResponse`
      info	[Changelog] - New struct `CommunityGalleryImagesClientListResult`
      info	[Changelog] - New struct `SharedGalleryDataDiskImage`
      info	[Changelog] - New struct `SharedGalleryDiskImage`
      info	[Changelog] - New struct `SharedGalleryImageVersionStorageProfile`
      info	[Changelog] - New struct `SharedGalleryOSDiskImage`
      info	[Changelog] - New field `Architecture` in struct `CommunityGalleryImageProperties`
      info	[Changelog] - New field `Architecture` in struct `SharedGalleryImageProperties`
      info	[Changelog] - New field `ExcludeFromLatest` in struct `SharedGalleryImageVersionProperties`
      info	[Changelog] - New field `StorageProfile` in struct `SharedGalleryImageVersionProperties`
      info	[Changelog] - New field `ExcludeFromLatest` in struct `CommunityGalleryImageVersionProperties`
      info	[Changelog] - New field `StorageProfile` in struct `CommunityGalleryImageVersionProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 49 additive change(s).
    • ️✔️armresourcehealth [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from 23a63f7421c875e1bef906cf91909b3b950aa1f1. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-azurestackhci [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    • ️✔️@azure/arm-compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation CommunityGalleryImages.list
      info	[Changelog]   - Added operation CommunityGalleryImageVersions.list
      info	[Changelog]   - Added Interface CommunityGalleryImageList
      info	[Changelog]   - Added Interface CommunityGalleryImagesListNextOptionalParams
      info	[Changelog]   - Added Interface CommunityGalleryImagesListOptionalParams
      info	[Changelog]   - Added Interface CommunityGalleryImageVersionList
      info	[Changelog]   - Added Interface CommunityGalleryImageVersionsListNextOptionalParams
      info	[Changelog]   - Added Interface CommunityGalleryImageVersionsListOptionalParams
      info	[Changelog]   - Added Interface SharedGalleryDiskImage
      info	[Changelog]   - Added Interface SharedGalleryImageVersionStorageProfile
      info	[Changelog]   - Added Type Alias CommunityGalleryImagesListNextResponse
      info	[Changelog]   - Added Type Alias CommunityGalleryImagesListResponse
      info	[Changelog]   - Added Type Alias CommunityGalleryImageVersionsListNextResponse
      info	[Changelog]   - Added Type Alias CommunityGalleryImageVersionsListResponse
      info	[Changelog]   - Added Type Alias SharedGalleryDataDiskImage
      info	[Changelog]   - Added Type Alias SharedGalleryHostCaching
      info	[Changelog]   - Added Type Alias SharedGalleryOSDiskImage
      info	[Changelog]   - Type Alias CommunityGalleryImage has a new parameter architecture
      info	[Changelog]   - Type Alias CommunityGalleryImageVersion has a new parameter excludeFromLatest
      info	[Changelog]   - Type Alias CommunityGalleryImageVersion has a new parameter storageProfile
      info	[Changelog]   - Type Alias SharedGalleryImage has a new parameter architecture
      info	[Changelog]   - Type Alias SharedGalleryImageVersion has a new parameter excludeFromLatest
      info	[Changelog]   - Type Alias SharedGalleryImageVersion has a new parameter storageProfile
      info	[Changelog]   - Added Enum KnownSharedGalleryHostCaching
      info	[Changelog]   - Enum KnownGallerySharingPermissionTypes has a new value Community
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Enum KnownSharingProfileGroupTypes no longer has value Community
    • ️✔️@azure/arm-resourcehealth [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 23a63f7421c875e1bef906cf91909b3b950aa1f1. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️azurestackhci [View full logs
    • ️✔️compute [View full logs]  [Preview Schema Changes]
    • ️✔️resourcehealth [View full logs
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 23a63f7421c875e1bef906cf91909b3b950aa1f1. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      warn		specification/azurestackhci/resource-manager/readme.md skipped due to azure-sdk-for-net not found in swagger-to-sdk
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/resourcehealth/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Compute [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @Sandido, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    readme updates for disk version and 01-03 only tag
    remove to get validation to run again
    @Sandido Sandido marked this pull request as ready for review March 15, 2022 19:50
    @Sandido
    Copy link
    Member Author

    Sandido commented Mar 15, 2022

    /azp run

    @azure-pipelines
    Copy link

    Pull request contains merge conflicts.

    @Sandido
    Copy link
    Member Author

    Sandido commented Mar 15, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @Sandido Sandido closed this Mar 15, 2022
    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @Sandido. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    2 similar comments
    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @Sandido. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @Sandido. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    @JackTn JackTn deleted the adsandor/merge1 branch July 5, 2022 01:19
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants