Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GrafanaResource as ManagedGrfana #18270

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

jinghzhu-msft
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@jinghzhu-msft
Copy link
Member Author

This PR is to address the review comments from .NET SDK team:

  1. Rename resource name GrafanaResource as ManagedGrafana.
  2. Make all parameters in body as reuqired.
  3. Update some desc for better user experience.

Please note that we are still in Private Preview and there should be no breaking change for it.

@ruowan
Copy link
Member

ruowan commented Mar 17, 2022

/azp run

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 17, 2022

Swagger Validation Report

️❌BreakingChange: 7 Errors, 0 Warnings failed [Detail]
Rule Message
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'GrafanaResource' removed or renamed?
New: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L349:3
Old: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L347:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'GrafanaResourceProperties' removed or renamed?
New: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L349:3
Old: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L347:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'GrafanaResourceUpdateParameters' removed or renamed?
New: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L349:3
Old: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L347:3
1010 - AddingRequiredParameter The required parameter 'requestBodyParameters' was added in the new version.
New: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L204:11
1010 - AddingRequiredParameter The required parameter 'requestBodyParameters' was added in the new version.
New: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L268:11
1046 - RemovedOptionalParameter The optional parameter 'body' was removed in the new version.
Old: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L204:11
1046 - RemovedOptionalParameter The optional parameter 'body' was removed in the new version.
Old: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L267:11
️⚠️LintDiff: 6 Warnings warning [Detail]
The following errors/warnings are introduced by current PR:
Rule Message
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L400
⚠️ R4000 - ParameterDescriptionRequired 'requestBodyParameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L204
⚠️ R4000 - ParameterDescriptionRequired 'requestBodyParameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L268
⚠️ R4021 - DescriptionAndTitleMissing 'ManagedGrafanaListResponse' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L434
⚠️ R4021 - DescriptionAndTitleMissing 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L437
⚠️ R4021 - DescriptionAndTitleMissing 'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L443


The following errors/warnings exist before current PR submission:

Rule Message
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L594
⚠️ R4021 - DescriptionAndTitleMissing 'LastModifiedByType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L488
⚠️ R4021 - DescriptionAndTitleMissing 'ProvisioningState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L624
⚠️ R4021 - DescriptionAndTitleMissing 'ResourceSku' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L642
⚠️ R4021 - DescriptionAndTitleMissing 'name' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L648
⚠️ R4021 - DescriptionAndTitleMissing 'SystemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L653
⚠️ R4021 - DescriptionAndTitleMissing 'createdBy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L657
⚠️ R4021 - DescriptionAndTitleMissing 'createdAt' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L663
⚠️ R4021 - DescriptionAndTitleMissing 'lastModifiedBy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L667
⚠️ R4021 - DescriptionAndTitleMissing 'lastModifiedAt' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L673
⚠️ R4021 - DescriptionAndTitleMissing 'ZoneRedundancy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L679
⚠️ R4021 - DescriptionAndTitleMissing 'UserAssignedIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L691
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 17, 2022

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armdashboard - 0.1.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-dashboard - first release
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 0a52f4d. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-6.0
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/dashboard/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Dashboard [View full logs]  [Release SDK Changes]
    warn	Skip artifact folder because it doesn't exist: artifacts/packages
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 0a52f4d. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.4
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.4>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.4` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-dashboard [View full logs]  [Release SDK Changes]
    info	[Changelog]   - Initial Release
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 0a52f4d. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️armdashboard [View full logs]  [Release SDK Changes]
    Only show 120 items here, please refer to log for details.
    info	[Changelog] - New const `ZoneRedundancyEnabled`
    info	[Changelog] - New const `ProvisioningStateNotSpecified`
    info	[Changelog] - New const `LastModifiedByTypeApplication`
    info	[Changelog] - New const `ProvisioningStateCanceled`
    info	[Changelog] - New const `ProvisioningStateSucceeded`
    info	[Changelog] - New const `ActionTypeInternal`
    info	[Changelog] - New const `IdentityTypeNone`
    info	[Changelog] - New const `CreatedByTypeUser`
    info	[Changelog] - New const `ZoneRedundancyDisabled`
    info	[Changelog] - New const `IdentityTypeSystemAssigned`
    info	[Changelog] - New const `ProvisioningStateAccepted`
    info	[Changelog] - New const `ProvisioningStateDeleted`
    info	[Changelog] - New const `ProvisioningStateUpdating`
    info	[Changelog] - New const `LastModifiedByTypeKey`
    info	[Changelog] - New const `CreatedByTypeKey`
    info	[Changelog] - New const `CreatedByTypeManagedIdentity`
    info	[Changelog] - New const `ProvisioningStateDeleting`
    info	[Changelog] - New const `OriginUser`
    info	[Changelog] - New const `OriginUserSystem`
    info	[Changelog] - New const `ProvisioningStateFailed`
    info	[Changelog] - New const `LastModifiedByTypeManagedIdentity`
    info	[Changelog] - New const `CreatedByTypeApplication`
    info	[Changelog] - New function `*GrafanaClient.BeginCreate(context.Context, string, string, ManagedGrafana, *GrafanaClientBeginCreateOptions) (GrafanaClientCreatePollerResponse, error)`
    info	[Changelog] - New function `*GrafanaClientCreatePoller.Poll(context.Context) (*http.Response, error)`
    info	[Changelog] - New function `*GrafanaClientCreatePoller.Done() bool`
    info	[Changelog] - New function `OperationListResult.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `*GrafanaClientCreatePoller.FinalResponse(context.Context) (GrafanaClientCreateResponse, error)`
    info	[Changelog] - New function `*GrafanaClientDeletePoller.Done() bool`
    info	[Changelog] - New function `PossibleProvisioningStateValues() []ProvisioningState`
    info	[Changelog] - New function `*GrafanaClientCreatePoller.ResumeToken() (string, error)`
    info	[Changelog] - New function `PossibleLastModifiedByTypeValues() []LastModifiedByType`
    info	[Changelog] - New function `*GrafanaClient.List(*GrafanaClientListOptions) *GrafanaClientListPager`
    info	[Changelog] - New function `*GrafanaClientListByResourceGroupPager.NextPage(context.Context) bool`
    info	[Changelog] - New function `ActionType.ToPtr() *ActionType`
    info	[Changelog] - New function `*GrafanaClient.ListByResourceGroup(string, *GrafanaClientListByResourceGroupOptions) *GrafanaClientListByResourceGroupPager`
    info	[Changelog] - New function `*GrafanaClient.BeginDelete(context.Context, string, string, *GrafanaClientBeginDeleteOptions) (GrafanaClientDeletePollerResponse, error)`
    info	[Changelog] - New function `*OperationsClientListPager.Err() error`
    info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
    info	[Changelog] - New function `*OperationsClient.List(*OperationsClientListOptions) *OperationsClientListPager`
    info	[Changelog] - New function `ManagedIdentity.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `ManagedGrafana.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `IdentityType.ToPtr() *IdentityType`
    info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
    info	[Changelog] - New function `CreatedByType.ToPtr() *CreatedByType`
    info	[Changelog] - New function `SystemData.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `*timeRFC3339.UnmarshalJSON([]byte) error`
    info	[Changelog] - New function `ManagedGrafanaUpdateParameters.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `*GrafanaClientDeletePoller.Poll(context.Context) (*http.Response, error)`
    info	[Changelog] - New function `PossibleZoneRedundancyValues() []ZoneRedundancy`
    info	[Changelog] - New function `*OperationsClientListPager.PageResponse() OperationsClientListResponse`
    info	[Changelog] - New function `LastModifiedByType.ToPtr() *LastModifiedByType`
    info	[Changelog] - New function `*GrafanaClientListByResourceGroupPager.PageResponse() GrafanaClientListByResourceGroupResponse`
    info	[Changelog] - New function `ManagedGrafanaListResponse.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `*GrafanaClient.Update(context.Context, string, string, ManagedGrafanaUpdateParameters, *GrafanaClientUpdateOptions) (GrafanaClientUpdateResponse, error)`
    info	[Changelog] - New function `*SystemData.UnmarshalJSON([]byte) error`
    info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
    info	[Changelog] - New function `*GrafanaClientListPager.Err() error`
    info	[Changelog] - New function `*GrafanaClientListPager.PageResponse() GrafanaClientListResponse`
    info	[Changelog] - New function `PossibleOriginValues() []Origin`
    info	[Changelog] - New function `*GrafanaClient.Get(context.Context, string, string, *GrafanaClientGetOptions) (GrafanaClientGetResponse, error)`
    info	[Changelog] - New function `timeRFC3339.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `GrafanaClientCreatePollerResponse.PollUntilDone(context.Context, time.Duration) (GrafanaClientCreateResponse, error)`
    info	[Changelog] - New function `ProvisioningState.ToPtr() *ProvisioningState`
    info	[Changelog] - New function `PossibleIdentityTypeValues() []IdentityType`
    info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
    info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
    info	[Changelog] - New function `NewGrafanaClient(string, azcore.TokenCredential, *arm.ClientOptions) *GrafanaClient`
    info	[Changelog] - New function `GrafanaClientDeletePollerResponse.PollUntilDone(context.Context, time.Duration) (GrafanaClientDeleteResponse, error)`
    info	[Changelog] - New function `ZoneRedundancy.ToPtr() *ZoneRedundancy`
    info	[Changelog] - New function `*GrafanaClientDeletePoller.FinalResponse(context.Context) (GrafanaClientDeleteResponse, error)`
    info	[Changelog] - New function `*GrafanaClientListByResourceGroupPager.Err() error`
    info	[Changelog] - New function `Origin.ToPtr() *Origin`
    info	[Changelog] - New function `NewOperationsClient(azcore.TokenCredential, *arm.ClientOptions) *OperationsClient`
    info	[Changelog] - New function `*GrafanaClientDeletePollerResponse.Resume(context.Context, *GrafanaClient, string) error`
    info	[Changelog] - New function `*GrafanaClientCreatePollerResponse.Resume(context.Context, *GrafanaClient, string) error`
    info	[Changelog] - New function `*OperationsClientListPager.NextPage(context.Context) bool`
    info	[Changelog] - New function `*GrafanaClientDeletePoller.ResumeToken() (string, error)`
    info	[Changelog] - New function `*GrafanaClientListPager.NextPage(context.Context) bool`
    info	[Changelog] - New struct `GrafanaClient`
    info	[Changelog] - New struct `GrafanaClientBeginCreateOptions`
    info	[Changelog] - New struct `GrafanaClientBeginDeleteOptions`
    info	[Changelog] - New struct `GrafanaClientCreatePoller`
    info	[Changelog] - New struct `GrafanaClientCreatePollerResponse`
    info	[Changelog] - New struct `GrafanaClientCreateResponse`
    info	[Changelog] - New struct `GrafanaClientCreateResult`
    info	[Changelog] - New struct `GrafanaClientDeletePoller`
    info	[Changelog] - New struct `GrafanaClientDeletePollerResponse`
    info	[Changelog] - New struct `GrafanaClientDeleteResponse`
    info	[Changelog] - New struct `GrafanaClientGetOptions`
    info	[Changelog] - New struct `GrafanaClientGetResponse`
    info	[Changelog] - New struct `GrafanaClientGetResult`
    info	[Changelog] - New struct `GrafanaClientListByResourceGroupOptions`
    info	[Changelog] - New struct `GrafanaClientListByResourceGroupPager`
    info	[Changelog] - New struct `GrafanaClientListByResourceGroupResponse`
    info	[Changelog] - New struct `GrafanaClientListByResourceGroupResult`
    info	[Changelog] - New struct `GrafanaClientListOptions`
    info	[Changelog] - New struct `GrafanaClientListPager`
    info	[Changelog] - New struct `GrafanaClientListResponse`
    info	[Changelog] - New struct `GrafanaClientListResult`
    info	[Changelog] - New struct `GrafanaClientUpdateOptions`
    info	[Changelog] - New struct `GrafanaClientUpdateResponse`
    info	[Changelog] - New struct `GrafanaClientUpdateResult`
    info	[Changelog] - New struct `ManagedGrafana`
    info	[Changelog] - New struct `ManagedGrafanaListResponse`
    info	[Changelog] - New struct `ManagedGrafanaProperties`
    info	[Changelog] - New struct `ManagedGrafanaUpdateParameters`
    info	[Changelog] - New struct `ManagedIdentity`
    info	[Changelog] - New struct `OperationDisplay`
    info	[Changelog] - New struct `OperationListResult`
    info	[Changelog] - New struct `OperationResult`
    info	[Changelog] - New struct `OperationsClient`
    info	[Changelog] - New struct `OperationsClientListOptions`
    info	[Changelog] - New struct `OperationsClientListPager`
    info	[Changelog] - New struct `OperationsClientListResponse`
    info	[Changelog] - New struct `OperationsClientListResult`
    info	[Changelog] - New struct `ResourceSKU`
    info	[Changelog] - New struct `SystemData`
    info	[Changelog] - New struct `UserAssignedIdentity`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 161 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 0a52f4d. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] WARN old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
    cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
    cmderr	[initScript.sh] npm WARN old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
    cmderr	[initScript.sh] npm WARN old lockfile
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️dashboard [View full logs]  [Release Schema Changes]
️⚠️ azure-sdk-for-js warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 0a52f4d. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    cmderr	[automation_init.sh] WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
    cmderr	[automation_init.sh] npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
    cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
    cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-dashboard [View full logs]  [Release SDK Changes]
    info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-workflow-bot
Copy link

Hi @jinghzhu-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

@ruowan ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 17, 2022
@ruowan
Copy link
Member

ruowan commented Mar 17, 2022

No customer impact. Confirm with PR author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants