Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making primary domain controller optional #18278

Merged
merged 1 commit into from
Mar 22, 2022
Merged

making primary domain controller optional #18278

merged 1 commit into from
Mar 22, 2022

Conversation

sasank-chaganty
Copy link
Contributor

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@sasank-chaganty
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akning-ms
Copy link
Contributor

/azp run

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 17, 2022 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]
The following errors/warnings exist before current PR submission:
Rule Message
⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'activeDirectoryConnectors' with immediate parent 'DataControllerResource', must have a list by immediate parent operation.
Location: Microsoft.AzureArcData/preview/2022-03-01-preview/activeDirectoryConnectors.json#L29
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: preferK8sDnsForPtrLookups
Location: Microsoft.AzureArcData/preview/2022-03-01-preview/activeDirectoryConnectors.json#L137
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 17, 2022 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go - azurearcdata/mgmt/2021-11-01/azurearcdata - v62.2.0
❌azure-sdk-for-go-track2 - armazurearcdata - 0.3.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-azurearcdata - 1.0.0
️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
  • ⚠️Warning [Logs]Release - Generate from 05dd534. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.5` to update!
cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-azurearcdata        [View full logs]         [Release SDK Changes]      
    info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ActiveDirectoryConnectorsOperations
info	[Changelog]   - Added operation group PostgresInstancesOperations
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model SqlManagedInstanceProperties has a new parameter keytab
info	[Changelog]   - Model SqlServerInstanceProperties has a new parameter esu_expiration_date
info	[Changelog]   - Model SqlServerInstanceProperties has a new parameter host_type
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]  
  
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
  • ️✔️Succeeded [Logs]Release - Generate from 05dd534. SDK Automation 14.0.0 
    command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️azurearcdata/mgmt/2021-11-01/azurearcdata        [View full logs]         [Release SDK Changes]      
    info	[Changelog] This is a new package
info	[Changelog]
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]  
  
  • ️✔️Succeeded [Logs]Release - Generate from 05dd534. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️armazurearcdata        [View full logs]         [Release SDK Changes]        Breaking Change Detected
          Only show 120 items here, please refer to log for details.
    info	[Changelog] - New const `SQLVersionSQLServer2022`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientListPager.NextPage(context.Context) bool`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePollerResponse.Resume(context.Context, *ActiveDirectoryConnectorsClient, string) error`
info	[Changelog] - New function `ActiveDirectoryConnectorListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ActiveDirectoryConnectorStatus.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*PostgresInstancesClientListByResourceGroupPager.Err() error`
info	[Changelog] - New function `*PostgresInstancesClientCreatePoller.FinalResponse(context.Context) (PostgresInstancesClientCreateResponse, error)`
info	[Changelog] - New function `PostgresInstanceListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PostgresInstancesClientCreatePollerResponse.PollUntilDone(context.Context, time.Duration) (PostgresInstancesClientCreateResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClient.Get(context.Context, string, string, *PostgresInstancesClientGetOptions) (PostgresInstancesClientGetResponse, error)`
info	[Changelog] - New function `PostgresInstance.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ActiveDirectoryDomainControllers.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientListPager.Err() error`
info	[Changelog] - New function `*ActiveDirectoryConnectorStatus.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePoller.Done() bool`
info	[Changelog] - New function `ActiveDirectoryConnectorsClientDeletePollerResponse.PollUntilDone(context.Context, time.Duration) (ActiveDirectoryConnectorsClientDeleteResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClient.List(*PostgresInstancesClientListOptions) *PostgresInstancesClientListPager`
info	[Changelog] - New function `*PostgresInstancesClientListPager.Err() error`
info	[Changelog] - New function `*PostgresInstancesClientListByResourceGroupPager.NextPage(context.Context) bool`
info	[Changelog] - New function `NewActiveDirectoryConnectorsClient(string, azcore.TokenCredential, *arm.ClientOptions) *ActiveDirectoryConnectorsClient`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePoller.Done() bool`
info	[Changelog] - New function `*PostgresInstancesClientCreatePoller.Done() bool`
info	[Changelog] - New function `*PostgresInstancesClientCreatePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `*PostgresInstanceProperties.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PostgresInstanceUpdate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*PostgresInstancesClientCreatePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `NewPostgresInstancesClient(string, azcore.TokenCredential, *arm.ClientOptions) *PostgresInstancesClient`
info	[Changelog] - New function `ActiveDirectoryConnectorDNSDetails.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientListPager.PageResponse() ActiveDirectoryConnectorsClientListResponse`
info	[Changelog] - New function `*PostgresInstancesClientDeletePoller.FinalResponse(context.Context) (PostgresInstancesClientDeleteResponse, error)`
info	[Changelog] - New function `ActiveDirectoryConnectorsClientCreatePollerResponse.PollUntilDone(context.Context, time.Duration) (ActiveDirectoryConnectorsClientCreateResponse, error)`
info	[Changelog] - New function `HostType.ToPtr() *HostType`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClient.Get(context.Context, string, string, string, *ActiveDirectoryConnectorsClientGetOptions) (ActiveDirectoryConnectorsClientGetResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClient.BeginDelete(context.Context, string, string, *PostgresInstancesClientBeginDeleteOptions) (PostgresInstancesClientDeletePollerResponse, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `*PostgresInstancesClient.BeginCreate(context.Context, string, string, PostgresInstance, *PostgresInstancesClientBeginCreateOptions) (PostgresInstancesClientCreatePollerResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClientDeletePollerResponse.Resume(context.Context, *PostgresInstancesClient, string) error`
info	[Changelog] - New function `*PostgresInstancesClientListPager.NextPage(context.Context) bool`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePoller.FinalResponse(context.Context) (ActiveDirectoryConnectorsClientDeleteResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClientCreatePollerResponse.Resume(context.Context, *PostgresInstancesClient, string) error`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `*PostgresInstancesClient.ListByResourceGroup(string, *PostgresInstancesClientListByResourceGroupOptions) *PostgresInstancesClientListByResourceGroupPager`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClient.BeginDelete(context.Context, string, string, string, *ActiveDirectoryConnectorsClientBeginDeleteOptions) (ActiveDirectoryConnectorsClientDeletePollerResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClient.Update(context.Context, string, string, PostgresInstanceUpdate, *PostgresInstancesClientUpdateOptions) (PostgresInstancesClientUpdateResponse, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePollerResponse.Resume(context.Context, *ActiveDirectoryConnectorsClient, string) error`
info	[Changelog] - New function `PostgresInstancesClientDeletePollerResponse.PollUntilDone(context.Context, time.Duration) (PostgresInstancesClientDeleteResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClientDeletePoller.Done() bool`
info	[Changelog] - New function `*PostgresInstancesClientListByResourceGroupPager.PageResponse() PostgresInstancesClientListByResourceGroupResponse`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClient.BeginCreate(context.Context, string, string, string, ActiveDirectoryConnectorResource, *ActiveDirectoryConnectorsClientBeginCreateOptions) (ActiveDirectoryConnectorsClientCreatePollerResponse, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePoller.FinalResponse(context.Context) (ActiveDirectoryConnectorsClientCreateResponse, error)`
info	[Changelog] - New function `PossibleHostTypeValues() []HostType`
info	[Changelog] - New function `*PostgresInstancesClientListPager.PageResponse() PostgresInstancesClientListResponse`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClient.List(string, string, *ActiveDirectoryConnectorsClientListOptions) *ActiveDirectoryConnectorsClientListPager`
info	[Changelog] - New function `*PostgresInstancesClientDeletePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `PostgresInstanceProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `*PostgresInstancesClientDeletePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New struct `ActiveDirectoryConnectorDNSDetails`
info	[Changelog] - New struct `ActiveDirectoryConnectorDomainDetails`
info	[Changelog] - New struct `ActiveDirectoryConnectorListResult`
info	[Changelog] - New struct `ActiveDirectoryConnectorProperties`
info	[Changelog] - New struct `ActiveDirectoryConnectorResource`
info	[Changelog] - New struct `ActiveDirectoryConnectorSpec`
info	[Changelog] - New struct `ActiveDirectoryConnectorStatus`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClient`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientBeginCreateOptions`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientBeginDeleteOptions`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientCreatePoller`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientCreatePollerResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientCreateResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientCreateResult`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientDeletePoller`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientDeletePollerResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientDeleteResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientGetOptions`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientGetResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientGetResult`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientListOptions`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientListPager`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientListResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientListResult`
info	[Changelog] - New struct `ActiveDirectoryDomainController`
info	[Changelog] - New struct `ActiveDirectoryDomainControllers`
info	[Changelog] - New struct `CommonSKU`
info	[Changelog] - New struct `PostgresInstance`
info	[Changelog] - New struct `PostgresInstanceListResult`
info	[Changelog] - New struct `PostgresInstanceProperties`
info	[Changelog] - New struct `PostgresInstanceSKU`
info	[Changelog] - New struct `PostgresInstanceUpdate`
info	[Changelog] - New struct `PostgresInstancesClient`
info	[Changelog] - New struct `PostgresInstancesClientBeginCreateOptions`
info	[Changelog] - New struct `PostgresInstancesClientBeginDeleteOptions`
info	[Changelog] - New struct `PostgresInstancesClientCreatePoller`
info	[Changelog] - New struct `PostgresInstancesClientCreatePollerResponse`
info	[Changelog] - New struct `PostgresInstancesClientCreateResponse`
info	[Changelog] - New struct `PostgresInstancesClientCreateResult`
info	[Changelog] - New struct `PostgresInstancesClientDeletePoller`
info	[Changelog] - New struct `PostgresInstancesClientDeletePollerResponse`
info	[Changelog] - New struct `PostgresInstancesClientDeleteResponse`
info	[Changelog] - New struct `PostgresInstancesClientGetOptions`
info	[Changelog] - New struct `PostgresInstancesClientGetResponse`
info	[Changelog] - New struct `PostgresInstancesClientGetResult`
info	[Changelog] - New struct `PostgresInstancesClientListByResourceGroupOptions`
info	[Changelog] - New struct `PostgresInstancesClientListByResourceGroupPager`
info	[Changelog] - New struct `PostgresInstancesClientListByResourceGroupResponse`
info	[Changelog] - New struct `PostgresInstancesClientListByResourceGroupResult`
info	[Changelog] - New struct `PostgresInstancesClientListOptions`
info	[Changelog] - New struct `PostgresInstancesClientListPager`
info	[Changelog] - New struct `PostgresInstancesClientListResponse`
info	[Changelog] - New struct `PostgresInstancesClientListResult`
info	[Changelog] - New struct `PostgresInstancesClientUpdateOptions`
info	[Changelog] - New struct `PostgresInstancesClientUpdateResponse`
info	[Changelog] - New struct `PostgresInstancesClientUpdateResult`
info	[Changelog] - New struct `ProxyResource`
info	[Changelog] - New field `Keytab` in struct `SQLManagedInstanceProperties`
info	[Changelog] - New field `EsuExpirationDate` in struct `SQLServerInstanceProperties`
info	[Changelog] - New field `HostType` in struct `SQLServerInstanceProperties`
info	[Changelog]
info	[Changelog] Total 16 breaking change(s), 183 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]   
  
  • ⚠️Warning [Logs]Release - Generate from 05dd534. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-azurearcdata        [View full logs]         [Release SDK Changes]      
    info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]  
  
  • ️✔️Succeeded [Logs]Release - Generate from 05dd534. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/azurearcdata/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.AzureArcData        [View full logs]         [Release SDK Changes]      
    warn	Skip artifact folder because it doesn't exist: artifacts/packages
️⚠️ azure-resource-manager-schemas warning [Detail]   
  
  • ⚠️Warning [Logs]Release - Generate from 05dd534. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️azurearcdata        [View full logs]         [Release Schema Changes]      
Posted by Swagger Pipeline | How to fix these errors?
      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @azure-pipelines





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
Azure Pipelines successfully started running 1 pipeline(s).


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Mar 17, 2022
    





  


  

      
   Closed

  







  




    


  

  

    
  


  

      

  This was referenced Mar 17, 2022





  


  

      
   Closed

  






      






  


  

      
   Closed

  






      






  


  

      
   Closed

  






      






  


  

      
   Closed

  






  




  

  
  

  
      @sasank-chaganty
  sasank-chaganty


        marked this pull request as ready for review

    
      March 17, 2022 17:14
    
    




    







      

  
        





      

  
          

  

    
  

  



        @ruowan
  ruowan



        merged commit 05dd534
      into

      
  
    Azure:main
  


    Mar 22, 2022

  







  

  

    
  


  

      

  This was referenced Mar 22, 2022





  


  

      
   Closed

  






      






  


  

      
   Closed

  






      






  


  

      
   Closed

  






      






  


  

      
   Closed

  






      






  


  

      
   Closed

  






      






  


  

      
   Closed

  






      






  


  

      
   Closed

  






  




  


  
    
  
  

    
  FredericHeem 

      pushed a commit
        to grucloud/azure-rest-api-specs
      that referenced
      this pull request

    
      May 16, 2022
    
    

      


  

    

      


  

      
        @sasank-chaganty
      
        @FredericHeem
  





      

        
          making primary domain controller optional (Azure#18278)
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          70edfa0
        
      

    

  




    

  




  
  
  









  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    


        

          

  
      @ruowan
  
    ruowan



          
            
              
            
          
          ruowan approved these changes

        


      






    

  


      
  

    Assignees
  



        

      

        

  
      @ruowan
  
    ruowan
    

      








      


  


  

    Labels
  



    

      

    CI-BreakingChange-Go-V2









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




        
      

    

  
      

  

    

      3 participants
    

    

        
          @sasank-chaganty 
        
          @akning-ms 
        
          @ruowan